Re: Deprecated Classes

[Andrey Pokhilko]

Hi,

If JMeter will break plugins massively, the biggest problem are rarely
changing/abandoned plugins. There's simply nobody to release fixed
versions of them. So please consider a pain that this will cause to
community.

Andrey Pokhilko

22.11.2017 00:44, Philippe Mouawad пишет:
> Hi Graham,
> As we'll be releasing a 4.0, we might drop them.
> This can possibly break plugins but we have warned about this for 2
> releases.
>
> Regards
>
> On Mon, Nov 20, 2017 at 2:54 AM, Graham Russell  wrote:
>
>> I came across the following classes, in org.apache.log, which are
>> deprecated and the comment says will be removed in 3.3, but they still
>> seem to be here:
>> LogEvent
>> ContextMap
>> LogTarget
>> Logger
>> Priority
>>
>> Was this an oversight or should these have been removed?
>>
>> Thanks
>>
>> Graham
>>
>
>

Re: svn commit: r1815838 - in /jmeter/trunk: src/functions/org/apache/jmeter/functions/ChangeCase.java test/src/org/apache/jmeter/functions/TestChangeCase.java xdocs/changes.xml xdocs/usermanual/funct

[Philippe Mouawad]

Hi Felix,
I've taken into account your first remarks.
I let you fix the remaining ones.

Thanks for your feedback!
Regards

On Wed, Nov 22, 2017 at 7:36 AM, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

>
>
> Am 20. November 2017 20:50:51 MEZ schrieb pmoua...@apache.org:
> >Author: pmouawad
> >Date: Mon Nov 20 19:50:51 2017
> >New Revision: 1815838
> >
> >URL: http://svn.apache.org/viewvc?rev=1815838=rev
> >Log:
> >Bug 61759 - New __changeCase function
> >Contributed by Orimarko
> >Bugzilla Id: 61759
> >
> >Added:
> >jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
> > (with props)
> >jmeter/trunk/test/src/org/apache/jmeter/functions/TestChangeCase.java
> >(with props)
> >Modified:
> >jmeter/trunk/xdocs/changes.xml
>


> >jmeter/trunk/xdocs/usermanual/functions.xml
> >
> >Added:
> >jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/src/functions/
> org/apache/jmeter/functions/ChangeCase.java?rev=1815838=auto
> >===
> ===
> >---
> >jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
> >(added)
> >+++
> >jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
> >Mon Nov 20 19:50:51 2017
> >@@ -0,0 +1,175 @@
> >+/*
> >+ * Licensed to the Apache Software Foundation (ASF) under one or more
> >+ * contributor license agreements.  See the NOTICE file distributed
> >with
> >+ * this work for additional information regarding copyright ownership.
> >+ * The ASF licenses this file to You under the Apache License, Version
> >2.0
> >+ * (the "License"); you may not use this file except in compliance
> >with
> >+ * the License.  You may obtain a copy of the License at
> >+ *
> >+ *   http://www.apache.org/licenses/LICENSE-2.0
> >+ *
> >+ * Unless required by applicable law or agreed to in writing, software
> >+ * distributed under the License is distributed on an "AS IS" BASIS,
> >+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >implied.
> >+ * See the License for the specific language governing permissions and
> >+ * limitations under the License.
> >+ *
> >+ */
> >+
> >+package org.apache.jmeter.functions;
> >+
> >+import java.util.Collection;
> >+import java.util.EnumSet;
> >+import java.util.LinkedList;
> >+import java.util.List;
> >+import java.util.regex.Pattern;
> >+
> >+import org.apache.commons.lang3.StringUtils;
> >+import org.apache.jmeter.engine.util.CompoundVariable;
> >+import org.apache.jmeter.samplers.SampleResult;
> >+import org.apache.jmeter.samplers.Sampler;
> >+import org.apache.jmeter.util.JMeterUtils;
> >+import org.slf4j.Logger;
> >+import org.slf4j.LoggerFactory;
> >+
> >+/**
> >+ * Change Case Function
> >+ *
> >+ * Support String manipulations of:
> >+ * 
> >+ * upper case
> >+ * lower case
> >+ * capitalize
> >+ * camel cases
> >+ * 
> >+ *
> >+ *
> >+ * @since 4.0
> >+ *
> >+ */
> >+public class ChangeCase extends AbstractFunction {
> >+
> >+private static final Pattern NOT_ALPHANUMERIC_REGEX =
> >+Pattern.compile("[^a-zA-Z]");
>
> The regex doesn't include numeric, so it probably should be called not
> alpha.
>
yes

>
> Would not it be better to allow groups of non wanted characters by adding
> a +?
>
Yes

>
> But it might be nicer to split on non word chars. That would be \W+.
>
> >+private static final Logger LOGGER =
> >LoggerFactory.getLogger(ChangeCase.class);
> >+private static final List DESC = new LinkedList<>();
> >+private static final String KEY = "__changeCase";
> >+
> >+private static final int MIN_PARAMETER_COUNT = 1;
> >+private static final int MAX_PARAMETER_COUNT = 3;
> >+
> >+static {
> >+DESC.add(JMeterUtils.getResString("change_case_string"));
> >+DESC.add(JMeterUtils.getResString("change_case_mode"));
> >+DESC.add(JMeterUtils.getResString("function_name_paropt"));
> >+}
> >+
> >+private CompoundVariable[] values;
> >+
> >+@Override
> >+public String execute(SampleResult previousResult, Sampler
> >currentSampler) throws InvalidVariableException {
> >+String originalString = values[0].execute();
> >+String mode = ChangeCaseMode.UPPER.getName(); // default
> >+if (values.length > 1) {
> >+mode = values[1].execute();
> >+}
> >+String targetString = changeCase(originalString, mode);
> >+addVariableValue(targetString, values, 2);
> >+return targetString;
> >+}
> >+
> >+protected String changeCase(String originalString, String mode) {
> >+String targetString = originalString;
> >+// mode is case insensitive, allow upper for example
> >+ChangeCaseMode changeCaseMode =
> >ChangeCaseMode.typeOf(mode.toUpperCase());
> >+if (changeCaseMode != null) {
> >+switch (changeCaseMode) {
> >+case UPPER:
> >+targetString = 

Re: svn commit: r1815838 - in /jmeter/trunk: src/functions/org/apache/jmeter/functions/ChangeCase.java test/src/org/apache/jmeter/functions/TestChangeCase.java xdocs/changes.xml xdocs/usermanual/funct

[Felix Schumacher]

Am 20. November 2017 20:50:51 MEZ schrieb pmoua...@apache.org:
>Author: pmouawad
>Date: Mon Nov 20 19:50:51 2017
>New Revision: 1815838
>
>URL: http://svn.apache.org/viewvc?rev=1815838=rev
>Log:
>Bug 61759 - New __changeCase function
>Contributed by Orimarko
>Bugzilla Id: 61759
>
>Added:
>jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java 
> (with props)
>jmeter/trunk/test/src/org/apache/jmeter/functions/TestChangeCase.java  
>(with props)
>Modified:
>jmeter/trunk/xdocs/changes.xml
>jmeter/trunk/xdocs/usermanual/functions.xml
>
>Added:
>jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java?rev=1815838=auto
>==
>---
>jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>(added)
>+++
>jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>Mon Nov 20 19:50:51 2017
>@@ -0,0 +1,175 @@
>+/*
>+ * Licensed to the Apache Software Foundation (ASF) under one or more
>+ * contributor license agreements.  See the NOTICE file distributed
>with
>+ * this work for additional information regarding copyright ownership.
>+ * The ASF licenses this file to You under the Apache License, Version
>2.0
>+ * (the "License"); you may not use this file except in compliance
>with
>+ * the License.  You may obtain a copy of the License at
>+ *
>+ *   http://www.apache.org/licenses/LICENSE-2.0
>+ *
>+ * Unless required by applicable law or agreed to in writing, software
>+ * distributed under the License is distributed on an "AS IS" BASIS,
>+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>implied.
>+ * See the License for the specific language governing permissions and
>+ * limitations under the License.
>+ *
>+ */
>+
>+package org.apache.jmeter.functions;
>+
>+import java.util.Collection;
>+import java.util.EnumSet;
>+import java.util.LinkedList;
>+import java.util.List;
>+import java.util.regex.Pattern;
>+
>+import org.apache.commons.lang3.StringUtils;
>+import org.apache.jmeter.engine.util.CompoundVariable;
>+import org.apache.jmeter.samplers.SampleResult;
>+import org.apache.jmeter.samplers.Sampler;
>+import org.apache.jmeter.util.JMeterUtils;
>+import org.slf4j.Logger;
>+import org.slf4j.LoggerFactory;
>+
>+/**
>+ * Change Case Function
>+ * 
>+ * Support String manipulations of:
>+ * 
>+ * upper case
>+ * lower case
>+ * capitalize
>+ * camel cases
>+ * 
>+ * 
>+ * 
>+ * @since 4.0
>+ *
>+ */
>+public class ChangeCase extends AbstractFunction {
>+
>+private static final Pattern NOT_ALPHANUMERIC_REGEX = 
>+Pattern.compile("[^a-zA-Z]");

The regex doesn't include numeric, so it probably should be called not alpha.

Would not it be better to allow groups of non wanted characters by adding a +? 

But it might be nicer to split on non word chars. That would be \W+. 

>+private static final Logger LOGGER =
>LoggerFactory.getLogger(ChangeCase.class);
>+private static final List DESC = new LinkedList<>();
>+private static final String KEY = "__changeCase";
>+
>+private static final int MIN_PARAMETER_COUNT = 1;
>+private static final int MAX_PARAMETER_COUNT = 3;
>+
>+static {
>+DESC.add(JMeterUtils.getResString("change_case_string"));
>+DESC.add(JMeterUtils.getResString("change_case_mode"));
>+DESC.add(JMeterUtils.getResString("function_name_paropt"));
>+}
>+
>+private CompoundVariable[] values;
>+
>+@Override
>+public String execute(SampleResult previousResult, Sampler
>currentSampler) throws InvalidVariableException {
>+String originalString = values[0].execute();
>+String mode = ChangeCaseMode.UPPER.getName(); // default
>+if (values.length > 1) {
>+mode = values[1].execute();
>+}
>+String targetString = changeCase(originalString, mode);
>+addVariableValue(targetString, values, 2);
>+return targetString;
>+}
>+
>+protected String changeCase(String originalString, String mode) {
>+String targetString = originalString;
>+// mode is case insensitive, allow upper for example
>+ChangeCaseMode changeCaseMode =
>ChangeCaseMode.typeOf(mode.toUpperCase());
>+if (changeCaseMode != null) {
>+switch (changeCaseMode) {
>+case UPPER:
>+targetString = StringUtils.upperCase(originalString);
>+break;
>+case LOWER:
>+targetString = StringUtils.lowerCase(originalString);
>+break;
>+case CAPITALIZE:
>+targetString = StringUtils.capitalize(originalString);
>+break;
>+case CAMEL_CASE:
>+targetString = camel(originalString, false);
>+break;
>+case CAMEL_CASE_FIRST_LOWER:
>+

Re: svn commit: r1815838 - in /jmeter/trunk: src/functions/org/apache/jmeter/functions/ChangeCase.java test/src/org/apache/jmeter/functions/TestChangeCase.java xdocs/changes.xml xdocs/usermanual/funct

[Felix Schumacher]

Am 21. November 2017 22:23:32 MEZ schrieb Philippe Mouawad 
:
>Hi Felix,
>In this case CAMEL_CASE implementations are wrong.
>Your conception look indeed closer to what I was usually seeing.
>Shall I fix it ?

I have a few more questions ;) 

What shall we do with umlauts?

If we handle umlauts, how do we specify the encoding? 

Should we support snake case, as well? 

>
>Do you think CAMEL_CASE and CAMEL_CASE_FIRST_LOWER are clear enough ?
>Or should we name them:
>
>   - UPPER_CAMEL_CASE
>   - LOWER_CAMEL_CASE
>
>As per:
>https://en.wikipedia.org/wiki/Camel_case

I think it is a good idea to follow the wording used in Wikipedia. 

>Thanks
>
>
>
>On Tue, Nov 21, 2017 at 9:59 PM, Felix Schumacher internetallee.de> wrote:
>
>> Am 20.11.2017 um 20:50 schrieb pmoua...@apache.org:
>>
>>> Author: pmouawad
>>> Date: Mon Nov 20 19:50:51 2017
>>> New Revision: 1815838
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1815838=rev
>>> Log:
>>> Bug 61759 - New __changeCase function
>>> Contributed by Orimarko
>>> Bugzilla Id: 61759
>>>
>>> Added:
>>> 
>jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>>>  (with props)
>>> 
>jmeter/trunk/test/src/org/apache/jmeter/functions/TestChangeCase.java
>>>  (with props)
>>> Modified:
>>>  jmeter/trunk/xdocs/changes.xml
>>>  jmeter/trunk/xdocs/usermanual/functions.xml
>>>
>>> Added: jmeter/trunk/src/functions/org/apache/jmeter/functions/Chang
>>> eCase.java
>>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/functions/org/
>>> apache/jmeter/functions/ChangeCase.java?rev=1815838=auto
>>> 
>>> ==
>>> ---
>jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>>> (added)
>>> +++
>jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>>> Mon Nov 20 19:50:51 2017
>>> @@ -0,0 +1,175 @@
>>> +/*
>>> + * Licensed to the Apache Software Foundation (ASF) under one or
>more
>>> + * contributor license agreements.  See the NOTICE file distributed
>with
>>> + * this work for additional information regarding copyright
>ownership.
>>> + * The ASF licenses this file to You under the Apache License,
>Version
>>> 2.0
>>> + * (the "License"); you may not use this file except in compliance
>with
>>> + * the License.  You may obtain a copy of the License at
>>> + *
>>> + *   http://www.apache.org/licenses/LICENSE-2.0
>>> + *
>>> + * Unless required by applicable law or agreed to in writing,
>software
>>> + * distributed under the License is distributed on an "AS IS"
>BASIS,
>>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>>> implied.
>>> + * See the License for the specific language governing permissions
>and
>>> + * limitations under the License.
>>> + *
>>> + */
>>> +
>>> +package org.apache.jmeter.functions;
>>> +
>>> +import java.util.Collection;
>>> +import java.util.EnumSet;
>>> +import java.util.LinkedList;
>>> +import java.util.List;
>>> +import java.util.regex.Pattern;
>>> +
>>> +import org.apache.commons.lang3.StringUtils;
>>> +import org.apache.jmeter.engine.util.CompoundVariable;
>>> +import org.apache.jmeter.samplers.SampleResult;
>>> +import org.apache.jmeter.samplers.Sampler;
>>> +import org.apache.jmeter.util.JMeterUtils;
>>> +import org.slf4j.Logger;
>>> +import org.slf4j.LoggerFactory;
>>> +
>>> +/**
>>> + * Change Case Function
>>> + *
>>> + * Support String manipulations of:
>>> + * 
>>> + * upper case
>>> + * lower case
>>> + * capitalize
>>> + * camel cases
>>> + * 
>>> + *
>>> + *
>>> + * @since 4.0
>>> + *
>>> + */
>>> +public class ChangeCase extends AbstractFunction {
>>> +
>>> +private static final Pattern NOT_ALPHANUMERIC_REGEX =
>>> +Pattern.compile("[^a-zA-Z]");
>>> +private static final Logger LOGGER =
>LoggerFactory.getLogger(Change
>>> Case.class);
>>> +private static final List DESC = new LinkedList<>();
>>> +private static final String KEY = "__changeCase";
>>> +
>>> +private static final int MIN_PARAMETER_COUNT = 1;
>>> +private static final int MAX_PARAMETER_COUNT = 3;
>>> +
>>> +static {
>>> +DESC.add(JMeterUtils.getResString("change_case_string"));
>>> +DESC.add(JMeterUtils.getResString("change_case_mode"));
>>> +DESC.add(JMeterUtils.getResString("function_name_paropt"));
>>> +}
>>> +
>>> +private CompoundVariable[] values;
>>> +
>>> +@Override
>>> +public String execute(SampleResult previousResult, Sampler
>>> currentSampler) throws InvalidVariableException {
>>> +String originalString = values[0].execute();
>>> +String mode = ChangeCaseMode.UPPER.getName(); // default
>>> +if (values.length > 1) {
>>> +mode = values[1].execute();
>>> +}
>>> +String targetString = changeCase(originalString, mode);
>>> +addVariableValue(targetString, values, 2);
>>> +return targetString;
>>> +}
>>> +
>>> +

[GitHub] jmeter pull request #336: Fixed some docs regarding removal of WorkBench

[ham1]

GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/336

Fixed some docs regarding removal of WorkBench

Removed some references to WorkBench from docs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter workbench-tidy

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #336


commit 3f0ecbf5d1c1f49d17b7a9bcf6729b2e62cd5d3e
Author: Graham Russell 
Date:   2017-11-22T00:57:28Z

Fixed some docs regarding removal of WorkBench




---

Re: BUG 61567

[Philippe Mouawad]

Hello,
There is clearly a bug. You can try the attached project.

The fix would be just to rename our jars by suffixing them with version

Regards

On Sun, Nov 19, 2017 at 12:22 AM, sebb  wrote:

> The code is quite complicated, so I would be very wary of changing it.
> And it's important not to include jars in the classpath that don't belong.
>
> JMeter runs quite happily if the jars are named anything you like so
> long as they are in the lib/ext directory or they are added to the
> appropriate path.
>
> So I'm not sure that the Bug is valid.
>
> On 18 November 2017 at 22:42, Philippe Mouawad
>  wrote:
> > Hello,
> > Any thoughts on this ?
> > Thanks
> >
> > On Sat, Nov 11, 2017 at 10:41 PM, Philippe Mouawad <
> > p.moua...@ubik-ingenierie.com> wrote:
> >
> >> Hello,
> >> Analyzing bug 61567 , I end up thinking that what we're doing in the
> below
> >> method is not correct:
> >>
> >>- ClassFinder#getClasspathMatches
> >>
> >> This method does the following:
> >>
> >>- It takes a list of jars in search_path
> >>- It takes the classpath
> >>- For each entry in classpath , it tests if it ends with one of the
> >>jar of the first list
> >>- If one match is found, the entry will be returned , otherwise it
> >>will be ignored
> >>
> >> So what is triggering the bug is the following, as search_path is empty,
> >> only content of lib/ext is used.
> >>
> >> So first list consist of :
> >>
> >>- ApacheJMeter_jms.jar
> >>ApacheJMeter_junit.jar
> >>ApacheJMeter_native.jar
> >>ApacheJMeter_ftp.jar
> >>ApacheJMeter_components.jar
> >>/data/jmeter/jmeters/apache-jmeter-3.3/lib/ext
> >>ApacheJMeter_ldap.jar
> >>ApacheJMeter_mail.jar
> >>ApacheJMeter_tcp.jar
> >>ApacheJMeter_http.jar
> >>ApacheJMeter_java.jar
> >>ApacheJMeter_core.jar
> >>ApacheJMeter_functions.jar
> >>ApacheJMeter_jdbc.jar
> >>ApacheJMeter_mongodb.jar
> >>
> >> Classpath consists of many entries and specifically , JMeter artifacts
> end
> >> with -3.3.jar
> >>
> >> None of the entries are added due to endsWith test failing, example:
> >>
> >> Testing if /MAVEN .m2/repository/org/apache/
> jmeter/ApacheJMeter_functions/
> >> 3.3/ApacheJMeter_functions-3.3.jar ends with ApacheJMeter_jms.jar *will
> >> return false*
> >>
> >> As a consequence, no function is found
> >>
> >>
> >> *One fix would be in JMeter to suffix artifacts in bin and lib/ext with
> >> the version number.*
> >>
> >> *But is this behaviour correct ?*
> >>
> >> --
> >> Regards.
> >> Philippe M.
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> > Ubik-Ingénierie
> >
> > UBIK LOAD PACK Web Site 
> >
> > UBIK LOAD PACK on TWITTER 
>



-- 
Cordialement.
Philippe Mouawad.

[GitHub] jmeter issue #335: Removed functions.util.* as they don't seem to be used (f...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/335
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/335?src=pr=h1) 
Report
> Merging 
[#335](https://codecov.io/gh/apache/jmeter/pull/335?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/5fc60e78ea8e49764096f8a75a16637a9e5b0682?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/335/graphs/tree.svg?src=pr=650=6Q7CI1wFSh=150)](https://codecov.io/gh/apache/jmeter/pull/335?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #335  +/-   ##

+ Coverage 57.91%   57.91%   +<.01% 
+ Complexity1002510024   -1 

  Files  1148 1146   -2 
  Lines 7378973781   -8 
  Branches   7328 7328  

- Hits  4273442733   -1 
+ Misses2857728570   -7 
  Partials   2478 2478
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/335?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/335?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==)
 | `85.38% <0%> (-0.77%)` | `18% <0%> (-1%)` | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/335?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/335?src=pr=footer). Last 
update 
[5fc60e7...38a6e30](https://codecov.io/gh/apache/jmeter/pull/335?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

Re: Static Analysis Issues

[Philippe Mouawad]

Hi Graham,
My answers below.
Regards

On Sun, Nov 19, 2017 at 3:09 PM, Graham Russell  wrote:

> It looks to me like the quality gate is already failing?
> https://builds.apache.org/analysis/overview?id=org.apache.jmeter%3AJMeter
>
> How do we normally know if we are passing or failing, could it be made part
> of the build?
>
We can tune quality gate:

   - https://docs.sonarqube.org/display/SONAR/Quality+Gates


> How do we open a request to infra about notifications?
>

Open a JIRA request:
See similar issue:

   - https://issues.apache.org/jira/browse/INFRA-15506


> Thanks
>
> Graham
>
> On Sun, 19 Nov 2017, 11:11 Philippe Mouawad, 
> wrote:
>
> > Hello,
> > It should be possible by configuring Quality Gate to fail .
> > Regarding notifications, I think we must open a request towards Infra
> team.
> >
> > Regards
> >
> > On Sun, Nov 19, 2017 at 11:56 AM, Graham Russell 
> > wrote:
> >
> > > All
> > >
> > > Do we get notifications of sonar issues? I've just noticed that 8
> > > "bugs" were introduced yesterday:
> > > https://builds.apache.org/analysis/component_issues?id=
> > > org.apache.jmeter%3AJMeter#resolved=false|types=BUG
> > >
> > > Is it also possible to get it to check PRs as we do with codecov, is
> > > this one for ifra?
> > >
> > > Thanks
> > >
> > > Graham
> > >
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>



-- 
Cordialement.
Philippe Mouawad.

[GitHub] jmeter pull request #335: Removed functions.util.* as they don't seem to be ...

[ham1]

GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/335

Removed functions.util.* as they don't seem to be used (for many years).

## Description
Remove files which don't seem to be used, they have a TODO comment from 
2008 and hasn't been meaningfully changed since 2003.

## How Has This Been Tested?
Ran unit tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter remove_unused_functions.util

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #335


commit 38a6e30435d8e56b1a51cb9c7637a90ab843d581
Author: Graham Russell 
Date:   2017-11-21T21:05:04Z

Removed functions.util.* as they don't seem to be used (for many years).




---

Re: svn commit: r1815838 - in /jmeter/trunk: src/functions/org/apache/jmeter/functions/ChangeCase.java test/src/org/apache/jmeter/functions/TestChangeCase.java xdocs/changes.xml xdocs/usermanual/funct

[Philippe Mouawad]

Hi Felix,
In this case CAMEL_CASE implementations are wrong.
Your conception look indeed closer to what I was usually seeing.
Shall I fix it ?

Do you think CAMEL_CASE and CAMEL_CASE_FIRST_LOWER are clear enough ?
Or should we name them:

   - UPPER_CAMEL_CASE
   - LOWER_CAMEL_CASE

As per:
https://en.wikipedia.org/wiki/Camel_case
Thanks



On Tue, Nov 21, 2017 at 9:59 PM, Felix Schumacher  wrote:

> Am 20.11.2017 um 20:50 schrieb pmoua...@apache.org:
>
>> Author: pmouawad
>> Date: Mon Nov 20 19:50:51 2017
>> New Revision: 1815838
>>
>> URL: http://svn.apache.org/viewvc?rev=1815838=rev
>> Log:
>> Bug 61759 - New __changeCase function
>> Contributed by Orimarko
>> Bugzilla Id: 61759
>>
>> Added:
>>  jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>>  (with props)
>>  jmeter/trunk/test/src/org/apache/jmeter/functions/TestChangeCase.java
>>  (with props)
>> Modified:
>>  jmeter/trunk/xdocs/changes.xml
>>  jmeter/trunk/xdocs/usermanual/functions.xml
>>
>> Added: jmeter/trunk/src/functions/org/apache/jmeter/functions/Chang
>> eCase.java
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/functions/org/
>> apache/jmeter/functions/ChangeCase.java?rev=1815838=auto
>> 
>> ==
>> --- jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>> (added)
>> +++ jmeter/trunk/src/functions/org/apache/jmeter/functions/ChangeCase.java
>> Mon Nov 20 19:50:51 2017
>> @@ -0,0 +1,175 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements.  See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License, Version
>> 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License.  You may obtain a copy of the License at
>> + *
>> + *   http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + *
>> + */
>> +
>> +package org.apache.jmeter.functions;
>> +
>> +import java.util.Collection;
>> +import java.util.EnumSet;
>> +import java.util.LinkedList;
>> +import java.util.List;
>> +import java.util.regex.Pattern;
>> +
>> +import org.apache.commons.lang3.StringUtils;
>> +import org.apache.jmeter.engine.util.CompoundVariable;
>> +import org.apache.jmeter.samplers.SampleResult;
>> +import org.apache.jmeter.samplers.Sampler;
>> +import org.apache.jmeter.util.JMeterUtils;
>> +import org.slf4j.Logger;
>> +import org.slf4j.LoggerFactory;
>> +
>> +/**
>> + * Change Case Function
>> + *
>> + * Support String manipulations of:
>> + * 
>> + * upper case
>> + * lower case
>> + * capitalize
>> + * camel cases
>> + * 
>> + *
>> + *
>> + * @since 4.0
>> + *
>> + */
>> +public class ChangeCase extends AbstractFunction {
>> +
>> +private static final Pattern NOT_ALPHANUMERIC_REGEX =
>> +Pattern.compile("[^a-zA-Z]");
>> +private static final Logger LOGGER = LoggerFactory.getLogger(Change
>> Case.class);
>> +private static final List DESC = new LinkedList<>();
>> +private static final String KEY = "__changeCase";
>> +
>> +private static final int MIN_PARAMETER_COUNT = 1;
>> +private static final int MAX_PARAMETER_COUNT = 3;
>> +
>> +static {
>> +DESC.add(JMeterUtils.getResString("change_case_string"));
>> +DESC.add(JMeterUtils.getResString("change_case_mode"));
>> +DESC.add(JMeterUtils.getResString("function_name_paropt"));
>> +}
>> +
>> +private CompoundVariable[] values;
>> +
>> +@Override
>> +public String execute(SampleResult previousResult, Sampler
>> currentSampler) throws InvalidVariableException {
>> +String originalString = values[0].execute();
>> +String mode = ChangeCaseMode.UPPER.getName(); // default
>> +if (values.length > 1) {
>> +mode = values[1].execute();
>> +}
>> +String targetString = changeCase(originalString, mode);
>> +addVariableValue(targetString, values, 2);
>> +return targetString;
>> +}
>> +
>> +protected String changeCase(String originalString, String mode) {
>> +String targetString = originalString;
>> +// mode is case insensitive, allow upper for example
>> +ChangeCaseMode changeCaseMode = ChangeCaseMode.typeOf(mode.toU
>> pperCase());
>> +if (changeCaseMode != null) {
>> +switch (changeCaseMode) {
>> +case UPPER:
>> +targetString = StringUtils.upperCase(originalString);
>> +   

Re: Release a 4.0 ?

[Antonio Gomes Rodrigues]

Work fine in my Linux

Antonio

2017-11-21 20:28 GMT+01:00 Milamber :

>
>
> On 21/11/2017 12:36, Philippe Mouawad wrote:
>
>> Hello,
>> Thanks Antonio for your tests, I indeed was using laf name instead of
>> class
>> name.
>> It is working now in my tests, but Milamber, Antonio or any subscriber,
>> your tests are welcome.
>>
>
> That's works for default LAF after remove theses lines into this file
> ~/.java/.userPrefs/org/apache/jmeter/gui/action/prefs.xml
>
> (removed)
> 
> 
>
>
> Thanks
>
> Jenkins build is in progress, a new nightly build should be available in
>> few minutes.
>> Regards
>>
>> On Tue, Nov 21, 2017 at 10:17 AM, Philippe Mouawad <
>> philippe.moua...@gmail.com> wrote:
>>
>> Hi Antonio,
>>> I fixed this bug on sunday.
>>> Are you using last revision ?
>>>
>>> Thanks
>>>
>>> On Tue, Nov 21, 2017 at 10:14 AM, Antonio Gomes Rodrigues <
>>> ra0...@gmail.com> wrote:
>>>
>>> Hi Philippe,

 About Darcula, in Windows 10 (I will test it in Linux later but I think
 it's the same) we have in the first launch

 2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand: Installing
 Darcula LAF
 2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using look
 and
 feel: Darcula []
 2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula
 2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to: Darcula
 java.lang.ClassNotFoundException: Darcula
 at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_144]
 at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
 at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
 at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144]
 at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144]
 at javax.swing.SwingUtilities.loadSystemClass(Unknown Source)
 ~[?:1.8.0_144]
 at javax.swing.UIManager.setLookAndFeel(Unknown Source) ~[?:1.8.0_144]
 at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
 [ApacheJMeter_core.jar:r1815865]
 at org.apache.jmeter.JMeter.start(JMeter.java:520)
 [ApacheJMeter_core.jar:r1815865]
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 ~[?:1.8.0_144]
 at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
 ~[?:1.8.0_144]
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
 ~[?:1.8.0_144]
 at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144]
 at org.apache.jmeter.NewDriver.main(NewDriver.java:248)
 [ApacheJMeter.jar:r1815865]


 In the second launch, all is ok

 017-11-21 10:11:37,394 INFO o.a.j.g.a.LookAndFeelCommand: Installing
 Darcula LAF
 2017-11-21 10:11:37,409 INFO o.a.j.g.a.LookAndFeelCommand: Using look
 and
 feel: com.bulenkov.darcula.DarculaLaf [Darcula]
 2017-11-21 10:11:37,409 INFO o.a.j.JMeter: Setting LAF to:
 com.bulenkov.darcula.DarculaLaf
 2017-11-21 10:11:37,455 INFO o.a.j.JMeter: Loaded icon properties from
 org/apache/jmeter/images/icon.properties

 Antonio


 2017-11-21 9:52 GMT+01:00 Philippe Mouawad :

 Hi Milamber,
> One note below regarding LAF.
>
> Thanks
>
> On Tue, Nov 21, 2017 at 9:50 AM, Milamber  wrote:
>
>
>> On 20/11/2017 21:06, Philippe Mouawad wrote:
>>
>> Hello,
>>> We now have a version that contains:
>>> - 49 enhancements
>>> - 13 bug fixes
>>> - 6 PR
>>>
>>> Version looks mature to me currently and brings interesting new
>>>
>> features

> and a nice new look.
>>>
>>> +1 for nice new look. (perhaps Dracula can be the default look)
>>
>> It is already.
> If it's not then it would be an issue, I intentionally changed the
> preference name for the laf so that all users have a chance to see it.
> Can you double check and confirm please ?
>
>
>> What do you think of releasing ?
>>>
>>> Yes before end of the year that's will a good idea.
>>
>>
>> There are remaining PRs that could be merged but could introduce more
>>> delay
>>> :
>>>
>>>  - https://github.com/apache/jmeter/pull/320 => Migration to
>>> last
>>>
>> HC4
>
>>  APIs but it would need important tesint
>>>  - https://github.com/apache/jmeter/pull/313 => I asked a
>>>
>> question

> about
>>>  it. I think we should adapt it to add a Metadata property
>>>
>> instead of

> Comment
>>>
>>>
>>> Regards
>>> Philippe M.
>>>
>>>
>>>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>>>
>>> --
>>> Cordialement.
>>> Philippe Mouawad.
>>>
>>>
>>>
>>>
>>
>

buildbot success in on jmeter-trunk

[buildbot]

The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3244

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815979
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

buildbot failure in on jmeter-trunk

[buildbot]

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3242

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815976
Blamelist: pmouawad

BUILD FAILED: failed shell_2 shell_3

Sincerely,
 -The Buildbot

Re: Release a 4.0 ?

[Milamber]

On 21/11/2017 12:36, Philippe Mouawad wrote:

Hello,
Thanks Antonio for your tests, I indeed was using laf name instead of class
name.
It is working now in my tests, but Milamber, Antonio or any subscriber,
your tests are welcome.


That's works for default LAF after remove theses lines into this file
~/.java/.userPrefs/org/apache/jmeter/gui/action/prefs.xml

(removed)




Thanks

Jenkins build is in progress, a new nightly build should be available in
few minutes.
Regards

On Tue, Nov 21, 2017 at 10:17 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:


Hi Antonio,
I fixed this bug on sunday.
Are you using last revision ?

Thanks

On Tue, Nov 21, 2017 at 10:14 AM, Antonio Gomes Rodrigues <
ra0...@gmail.com> wrote:


Hi Philippe,

About Darcula, in Windows 10 (I will test it in Linux later but I think
it's the same) we have in the first launch

2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand: Installing
Darcula LAF
2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
feel: Darcula []
2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula
2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to: Darcula
java.lang.ClassNotFoundException: Darcula
at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_144]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144]
at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144]
at javax.swing.SwingUtilities.loadSystemClass(Unknown Source)
~[?:1.8.0_144]
at javax.swing.UIManager.setLookAndFeel(Unknown Source) ~[?:1.8.0_144]
at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
[ApacheJMeter_core.jar:r1815865]
at org.apache.jmeter.JMeter.start(JMeter.java:520)
[ApacheJMeter_core.jar:r1815865]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_144]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
~[?:1.8.0_144]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
~[?:1.8.0_144]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144]
at org.apache.jmeter.NewDriver.main(NewDriver.java:248)
[ApacheJMeter.jar:r1815865]


In the second launch, all is ok

017-11-21 10:11:37,394 INFO o.a.j.g.a.LookAndFeelCommand: Installing
Darcula LAF
2017-11-21 10:11:37,409 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
feel: com.bulenkov.darcula.DarculaLaf [Darcula]
2017-11-21 10:11:37,409 INFO o.a.j.JMeter: Setting LAF to:
com.bulenkov.darcula.DarculaLaf
2017-11-21 10:11:37,455 INFO o.a.j.JMeter: Loaded icon properties from
org/apache/jmeter/images/icon.properties

Antonio


2017-11-21 9:52 GMT+01:00 Philippe Mouawad :


Hi Milamber,
One note below regarding LAF.

Thanks

On Tue, Nov 21, 2017 at 9:50 AM, Milamber  wrote:



On 20/11/2017 21:06, Philippe Mouawad wrote:


Hello,
We now have a version that contains:
- 49 enhancements
- 13 bug fixes
- 6 PR

Version looks mature to me currently and brings interesting new

features

and a nice new look.


+1 for nice new look. (perhaps Dracula can be the default look)


It is already.
If it's not then it would be an issue, I intentionally changed the
preference name for the laf so that all users have a chance to see it.
Can you double check and confirm please ?




What do you think of releasing ?


Yes before end of the year that's will a good idea.



There are remaining PRs that could be merged but could introduce more
delay
:

 - https://github.com/apache/jmeter/pull/320 => Migration to last

HC4

 APIs but it would need important tesint
 - https://github.com/apache/jmeter/pull/313 => I asked a

question

about
 it. I think we should adapt it to add a Metadata property

instead of

Comment


Regards
Philippe M.




--
Cordialement.
Philippe Mouawad.




--
Cordialement.
Philippe Mouawad.

Build failed in Jenkins: JMeter Windows #892

[Apache Jenkins Server]

See 


Changes:

[pmouawad] Fix SONAR warnings

[pmouawad] Fix SONAR warnings

[pmouawad] Fix order

[pmouawad] Bug 61794 - [Influxdb] Allow users to add theirs owns tags 
Fix SONAR warnings
Bugzilla Id: 61794

--
[...truncated 176.78 KB...]
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/log4j-slf4j-impl-2.8.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: Found binding in 
[jar:file:/F:/jenkins/jenkins-slave/workspace/JMeter%20Windows/trunk/lib/opt/activemq-all-5.15.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/FTP_TESTS.jmx
   [jmeter] Starting the test @ Tue Nov 21 14:20:03 UTC 2017 (1511274003220)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary =  6 in 00:00:03 =2.0/s Avg:   296 Min:14 Max:  
1494 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Tue Nov 21 14:20:07 UTC 2017 (1511274007970)
   [jmeter] ... end of run
   [concat] 2017-11-21 14:20:07,881 WARN o.a.f.l.n.FtpLoggingFilter: EXCEPTION :
   [concat] java.io.IOException: An established connection was aborted by the 
software in your host machine
   [concat] at sun.nio.ch.SocketDispatcher.read0(Native Method) 
~[?:1.8.0_152]
   [concat] at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:43) 
~[?:1.8.0_152]
   [concat] at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223) 
~[?:1.8.0_152]
   [concat] at sun.nio.ch.IOUtil.read(IOUtil.java:197) ~[?:1.8.0_152]
   [concat] at 
sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380) ~[?:1.8.0_152]
   [concat] at 
org.apache.mina.transport.socket.nio.NioProcessor.read(NioProcessor.java:317) 
~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.transport.socket.nio.NioProcessor.read(NioProcessor.java:45) 
~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.read(AbstractPollingIoProcessor.java:683)
 ~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.process(AbstractPollingIoProcessor.java:659)
 ~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.process(AbstractPollingIoProcessor.java:648)
 ~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.access$600(AbstractPollingIoProcessor.java:68)
 ~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:1120)
 ~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64) 
~[mina-core-2.0.16.jar:?]
   [concat] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
~[?:1.8.0_152]
   [concat] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
~[?:1.8.0_152]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]
   [concat] 2017-11-21 14:20:07,901 ERROR o.a.f.i.DefaultFtpHandler: Exception 
caught, closing session
   [concat] java.io.IOException: An established connection was aborted by the 
software in your host machine
   [concat] at sun.nio.ch.SocketDispatcher.read0(Native Method) 
~[?:1.8.0_152]
   [concat] at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:43) 
~[?:1.8.0_152]
   [concat] at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223) 
~[?:1.8.0_152]
   [concat] at sun.nio.ch.IOUtil.read(IOUtil.java:197) ~[?:1.8.0_152]
   [concat] at 
sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380) ~[?:1.8.0_152]
   [concat] at 
org.apache.mina.transport.socket.nio.NioProcessor.read(NioProcessor.java:317) 
~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.transport.socket.nio.NioProcessor.read(NioProcessor.java:45) 
~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.read(AbstractPollingIoProcessor.java:683)
 ~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.process(AbstractPollingIoProcessor.java:659)
 ~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.process(AbstractPollingIoProcessor.java:648)
 ~[mina-core-2.0.16.jar:?]
   [concat] at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.access$600(AbstractPollingIoProcessor.java:68)
 ~[mina-core-2.0.16.jar:?]
  

buildbot success in on jmeter-trunk

[buildbot]

The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3240

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815920
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

buildbot failure in on jmeter-trunk

[buildbot]

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3239

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815917
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

Re: Bug 61763

[Philippe Mouawad]

Hello,
It has been implemented within Bug 61724
Regards

On Tue, Nov 21, 2017 at 1:55 PM, jmeter tea  wrote:

> Bug #61763 marked as fixed,
> But it has no files attached and I don't find __encode function,
> Should it change to Status NEW?
> https://bz.apache.org/bugzilla/show_activity.cgi?id=61763
>



-- 
Cordialement.
Philippe Mouawad.

Bug 61763

[jmeter tea]

Bug #61763 marked as fixed,
But it has no files attached and I don't find __encode function,
Should it change to Status NEW?
https://bz.apache.org/bugzilla/show_activity.cgi?id=61763

Re: Release a 4.0 ?

[Philippe Mouawad]

Hello,
Thanks Antonio for your tests, I indeed was using laf name instead of class
name.
It is working now in my tests, but Milamber, Antonio or any subscriber,
your tests are welcome.
Jenkins build is in progress, a new nightly build should be available in
few minutes.
Regards

On Tue, Nov 21, 2017 at 10:17 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hi Antonio,
> I fixed this bug on sunday.
> Are you using last revision ?
>
> Thanks
>
> On Tue, Nov 21, 2017 at 10:14 AM, Antonio Gomes Rodrigues <
> ra0...@gmail.com> wrote:
>
>> Hi Philippe,
>>
>> About Darcula, in Windows 10 (I will test it in Linux later but I think
>> it's the same) we have in the first launch
>>
>> 2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand: Installing
>> Darcula LAF
>> 2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
>> feel: Darcula []
>> 2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula
>> 2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to: Darcula
>> java.lang.ClassNotFoundException: Darcula
>> at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_144]
>> at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
>> at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
>> at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144]
>> at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144]
>> at javax.swing.SwingUtilities.loadSystemClass(Unknown Source)
>> ~[?:1.8.0_144]
>> at javax.swing.UIManager.setLookAndFeel(Unknown Source) ~[?:1.8.0_144]
>> at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
>> [ApacheJMeter_core.jar:r1815865]
>> at org.apache.jmeter.JMeter.start(JMeter.java:520)
>> [ApacheJMeter_core.jar:r1815865]
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> ~[?:1.8.0_144]
>> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>> ~[?:1.8.0_144]
>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>> ~[?:1.8.0_144]
>> at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144]
>> at org.apache.jmeter.NewDriver.main(NewDriver.java:248)
>> [ApacheJMeter.jar:r1815865]
>>
>>
>> In the second launch, all is ok
>>
>> 017-11-21 10:11:37,394 INFO o.a.j.g.a.LookAndFeelCommand: Installing
>> Darcula LAF
>> 2017-11-21 10:11:37,409 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
>> feel: com.bulenkov.darcula.DarculaLaf [Darcula]
>> 2017-11-21 10:11:37,409 INFO o.a.j.JMeter: Setting LAF to:
>> com.bulenkov.darcula.DarculaLaf
>> 2017-11-21 10:11:37,455 INFO o.a.j.JMeter: Loaded icon properties from
>> org/apache/jmeter/images/icon.properties
>>
>> Antonio
>>
>>
>> 2017-11-21 9:52 GMT+01:00 Philippe Mouawad :
>>
>> > Hi Milamber,
>> > One note below regarding LAF.
>> >
>> > Thanks
>> >
>> > On Tue, Nov 21, 2017 at 9:50 AM, Milamber  wrote:
>> >
>> > >
>> > >
>> > > On 20/11/2017 21:06, Philippe Mouawad wrote:
>> > >
>> > >> Hello,
>> > >> We now have a version that contains:
>> > >> - 49 enhancements
>> > >> - 13 bug fixes
>> > >> - 6 PR
>> > >>
>> > >> Version looks mature to me currently and brings interesting new
>> features
>> > >> and a nice new look.
>> > >>
>> > >
>> > > +1 for nice new look. (perhaps Dracula can be the default look)
>> > >
>> > It is already.
>> > If it's not then it would be an issue, I intentionally changed the
>> > preference name for the laf so that all users have a chance to see it.
>> > Can you double check and confirm please ?
>> >
>> > >
>> > >
>> > >> What do you think of releasing ?
>> > >>
>> > >
>> > > Yes before end of the year that's will a good idea.
>> > >
>> > >
>> > >> There are remaining PRs that could be merged but could introduce more
>> > >> delay
>> > >> :
>> > >>
>> > >> - https://github.com/apache/jmeter/pull/320 => Migration to last
>> > HC4
>> > >> APIs but it would need important tesint
>> > >> - https://github.com/apache/jmeter/pull/313 => I asked a
>> question
>> > >> about
>> > >> it. I think we should adapt it to add a Metadata property
>> instead of
>> > >> Comment
>> > >>
>> > >>
>> > >> Regards
>> > >> Philippe M.
>> > >>
>> > >>
>> > >
>> >
>> >
>> > --
>> > Cordialement.
>> > Philippe Mouawad.
>> >
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>


-- 
Cordialement.
Philippe Mouawad.

[Jmeter Wiki] Update of "CommittingChanges" by ham1

[Apache Wiki]

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Jmeter Wiki" for change 
notification.

The "CommittingChanges" page has been changed by ham1:
https://wiki.apache.org/jmeter/CommittingChanges?action=diff=4=5

   * the xdocs/changes.xml file should be updated (except for trivial updates, 
e.g. correcting spelling in documentation)
  
  = Ant targets to run before committing =
+  * `ant checkstyle`
   * `ant package`
   * `ant test`
   * `ant test-headless` or `ant test-headed` (whichever was not run by the ant 
test)

Jenkins build is back to normal : JMeter-trunk #6481

[Apache Jenkins Server]

See 

Re: Release a 4.0 ?

[Antonio Gomes Rodrigues]

Hi,

I have tested with the last release : apache-jmeter-r1815865

It's appear only in the first launch of JMeter.

In the second launch, all is ok



2017-11-21 10:17 GMT+01:00 Philippe Mouawad :

> Hi Antonio,
> I fixed this bug on sunday.
> Are you using last revision ?
>
> Thanks
>
> On Tue, Nov 21, 2017 at 10:14 AM, Antonio Gomes Rodrigues <
> ra0...@gmail.com>
> wrote:
>
> > Hi Philippe,
> >
> > About Darcula, in Windows 10 (I will test it in Linux later but I think
> > it's the same) we have in the first launch
> >
> > 2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand: Installing
> > Darcula LAF
> > 2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
> > feel: Darcula []
> > 2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula
> > 2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to: Darcula
> > java.lang.ClassNotFoundException: Darcula
> > at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_144]
> > at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
> > at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
> > at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144]
> > at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144]
> > at javax.swing.SwingUtilities.loadSystemClass(Unknown Source)
> > ~[?:1.8.0_144]
> > at javax.swing.UIManager.setLookAndFeel(Unknown Source) ~[?:1.8.0_144]
> > at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
> > [ApacheJMeter_core.jar:r1815865]
> > at org.apache.jmeter.JMeter.start(JMeter.java:520)
> > [ApacheJMeter_core.jar:r1815865]
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > ~[?:1.8.0_144]
> > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> > ~[?:1.8.0_144]
> > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> > ~[?:1.8.0_144]
> > at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144]
> > at org.apache.jmeter.NewDriver.main(NewDriver.java:248)
> > [ApacheJMeter.jar:r1815865]
> >
> >
> > In the second launch, all is ok
> >
> > 017-11-21 10:11:37,394 INFO o.a.j.g.a.LookAndFeelCommand: Installing
> > Darcula LAF
> > 2017-11-21 10:11:37,409 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
> > feel: com.bulenkov.darcula.DarculaLaf [Darcula]
> > 2017-11-21 10:11:37,409 INFO o.a.j.JMeter: Setting LAF to:
> > com.bulenkov.darcula.DarculaLaf
> > 2017-11-21 10:11:37,455 INFO o.a.j.JMeter: Loaded icon properties from
> > org/apache/jmeter/images/icon.properties
> >
> > Antonio
> >
> >
> > 2017-11-21 9:52 GMT+01:00 Philippe Mouawad :
> >
> > > Hi Milamber,
> > > One note below regarding LAF.
> > >
> > > Thanks
> > >
> > > On Tue, Nov 21, 2017 at 9:50 AM, Milamber  wrote:
> > >
> > > >
> > > >
> > > > On 20/11/2017 21:06, Philippe Mouawad wrote:
> > > >
> > > >> Hello,
> > > >> We now have a version that contains:
> > > >> - 49 enhancements
> > > >> - 13 bug fixes
> > > >> - 6 PR
> > > >>
> > > >> Version looks mature to me currently and brings interesting new
> > features
> > > >> and a nice new look.
> > > >>
> > > >
> > > > +1 for nice new look. (perhaps Dracula can be the default look)
> > > >
> > > It is already.
> > > If it's not then it would be an issue, I intentionally changed the
> > > preference name for the laf so that all users have a chance to see it.
> > > Can you double check and confirm please ?
> > >
> > > >
> > > >
> > > >> What do you think of releasing ?
> > > >>
> > > >
> > > > Yes before end of the year that's will a good idea.
> > > >
> > > >
> > > >> There are remaining PRs that could be merged but could introduce
> more
> > > >> delay
> > > >> :
> > > >>
> > > >> - https://github.com/apache/jmeter/pull/320 => Migration to
> last
> > > HC4
> > > >> APIs but it would need important tesint
> > > >> - https://github.com/apache/jmeter/pull/313 => I asked a
> question
> > > >> about
> > > >> it. I think we should adapt it to add a Metadata property
> instead
> > of
> > > >> Comment
> > > >>
> > > >>
> > > >> Regards
> > > >> Philippe M.
> > > >>
> > > >>
> > > >
> > >
> > >
> > > --
> > > Cordialement.
> > > Philippe Mouawad.
> > >
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

buildbot success in on jmeter-trunk

[buildbot]

The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3235

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815890
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

Build failed in Jenkins: JMeter-trunk #6480

[Apache Jenkins Server]

See 


Changes:

[pmouawad] Add test of callable statement in read mode

--
[...truncated 182.61 KB...]
   [concat] at java.net.Socket.connect(Socket.java:589) ~[?:1.8.0_152]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.getSocket(TCPSampler.java:168)
 [ApacheJMeter_tcp.jar:r1815887]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.sample(TCPSampler.java:384) 
[ApacheJMeter_tcp.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:490)
 [ApacheJMeter_core.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:416) 
[ApacheJMeter_core.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:250) 
[ApacheJMeter_core.jar:r1815887]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]
   [concat] 2017-11-21 09:20:57,457 WARN o.a.j.p.t.s.TCPSampler: Unknown host 
for tcp://localhost:2223
   [concat] java.net.UnknownHostException: localhost
   [concat] at 
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184) 
~[?:1.8.0_152]
   [concat] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) 
~[?:1.8.0_152]
   [concat] at java.net.Socket.connect(Socket.java:589) ~[?:1.8.0_152]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.getSocket(TCPSampler.java:168)
 [ApacheJMeter_tcp.jar:r1815887]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.sample(TCPSampler.java:384) 
[ApacheJMeter_tcp.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:490)
 [ApacheJMeter_core.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:416) 
[ApacheJMeter_core.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:250) 
[ApacheJMeter_core.jar:r1815887]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]
   [concat] 2017-11-21 09:20:57,460 ERROR o.a.j.p.t.s.TCPSampler: Could not 
find protocol class 'org.foo.xxx'
 [echo] TCP_TESTS output files compared OK

batchtest:
 [echo] Starting JDBC_TESTS with file JDBC_TESTS.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/JDBC_TESTS.jmx
   [jmeter] Starting the test @ Tue Nov 21 09:21:00 UTC 2017 (1511256060617)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary +  1 in 00:00:00 =2.3/s Avg:   389 Min:   389 Max:  
 389 Err: 0 (0.00%) Active: 1 Started: 1 Finished: 0
   [jmeter] summary + 20 in 00:00:01 =   26.3/s Avg: 2 Min: 0 Max:  
  21 Err: 0 (0.00%) Active: 0 Started: 2 Finished: 2
   [jmeter] summary = 21 in 00:00:01 =   17.6/s Avg:20 Min: 0 Max:  
 389 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Tue Nov 21 09:21:02 UTC 2017 (1511256062762)
   [jmeter] ... end of run
   [concat] 2017-11-21 09:21:02,742 ERROR o.a.j.t.JMeterThread: Error while 
processing sampler: 'JDBC_With_Failing_PreProcessor'.
   [concat] java.lang.IllegalArgumentException: Variable Name must not be null 
in JDBC PreProcessor
   [concat] at 
org.apache.jmeter.protocol.jdbc.processor.AbstractJDBCProcessor.process(AbstractJDBCProcessor.java:45)
 ~[ApacheJMeter_jdbc.jar:r1815887]
   [concat] at 
org.apache.jmeter.protocol.jdbc.processor.JDBCPreProcessor.process(JDBCPreProcessor.java:33)
 ~[ApacheJMeter_jdbc.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.runPreProcessors(JMeterThread.java:844) 
~[ApacheJMeter_core.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:467)
 ~[ApacheJMeter_core.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:416) 
[ApacheJMeter_core.jar:r1815887]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:250) 
[ApacheJMeter_core.jar:r1815887]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]
   [concat] 2017-11-21 09:21:02,749 ERROR o.a.j.t.JMeterThread: Error while 

Re: Release a 4.0 ?

[Philippe Mouawad]

Hi Antonio,
I fixed this bug on sunday.
Are you using last revision ?

Thanks

On Tue, Nov 21, 2017 at 10:14 AM, Antonio Gomes Rodrigues 
wrote:

> Hi Philippe,
>
> About Darcula, in Windows 10 (I will test it in Linux later but I think
> it's the same) we have in the first launch
>
> 2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand: Installing
> Darcula LAF
> 2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
> feel: Darcula []
> 2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula
> 2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to: Darcula
> java.lang.ClassNotFoundException: Darcula
> at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_144]
> at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
> at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
> at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144]
> at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144]
> at javax.swing.SwingUtilities.loadSystemClass(Unknown Source)
> ~[?:1.8.0_144]
> at javax.swing.UIManager.setLookAndFeel(Unknown Source) ~[?:1.8.0_144]
> at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
> [ApacheJMeter_core.jar:r1815865]
> at org.apache.jmeter.JMeter.start(JMeter.java:520)
> [ApacheJMeter_core.jar:r1815865]
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> ~[?:1.8.0_144]
> at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
> ~[?:1.8.0_144]
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
> ~[?:1.8.0_144]
> at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144]
> at org.apache.jmeter.NewDriver.main(NewDriver.java:248)
> [ApacheJMeter.jar:r1815865]
>
>
> In the second launch, all is ok
>
> 017-11-21 10:11:37,394 INFO o.a.j.g.a.LookAndFeelCommand: Installing
> Darcula LAF
> 2017-11-21 10:11:37,409 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
> feel: com.bulenkov.darcula.DarculaLaf [Darcula]
> 2017-11-21 10:11:37,409 INFO o.a.j.JMeter: Setting LAF to:
> com.bulenkov.darcula.DarculaLaf
> 2017-11-21 10:11:37,455 INFO o.a.j.JMeter: Loaded icon properties from
> org/apache/jmeter/images/icon.properties
>
> Antonio
>
>
> 2017-11-21 9:52 GMT+01:00 Philippe Mouawad :
>
> > Hi Milamber,
> > One note below regarding LAF.
> >
> > Thanks
> >
> > On Tue, Nov 21, 2017 at 9:50 AM, Milamber  wrote:
> >
> > >
> > >
> > > On 20/11/2017 21:06, Philippe Mouawad wrote:
> > >
> > >> Hello,
> > >> We now have a version that contains:
> > >> - 49 enhancements
> > >> - 13 bug fixes
> > >> - 6 PR
> > >>
> > >> Version looks mature to me currently and brings interesting new
> features
> > >> and a nice new look.
> > >>
> > >
> > > +1 for nice new look. (perhaps Dracula can be the default look)
> > >
> > It is already.
> > If it's not then it would be an issue, I intentionally changed the
> > preference name for the laf so that all users have a chance to see it.
> > Can you double check and confirm please ?
> >
> > >
> > >
> > >> What do you think of releasing ?
> > >>
> > >
> > > Yes before end of the year that's will a good idea.
> > >
> > >
> > >> There are remaining PRs that could be merged but could introduce more
> > >> delay
> > >> :
> > >>
> > >> - https://github.com/apache/jmeter/pull/320 => Migration to last
> > HC4
> > >> APIs but it would need important tesint
> > >> - https://github.com/apache/jmeter/pull/313 => I asked a question
> > >> about
> > >> it. I think we should adapt it to add a Metadata property instead
> of
> > >> Comment
> > >>
> > >>
> > >> Regards
> > >> Philippe M.
> > >>
> > >>
> > >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
> >
>



-- 
Cordialement.
Philippe Mouawad.

buildbot failure in on jmeter-trunk

[buildbot]

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3234

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1815887
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

Re: Release a 4.0 ?

[Antonio Gomes Rodrigues]

Hi Philippe,

About Darcula, in Windows 10 (I will test it in Linux later but I think
it's the same) we have in the first launch

2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand: Installing
Darcula LAF
2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
feel: Darcula []
2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula
2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to: Darcula
java.lang.ClassNotFoundException: Darcula
at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_144]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144]
at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144]
at javax.swing.SwingUtilities.loadSystemClass(Unknown Source) ~[?:1.8.0_144]
at javax.swing.UIManager.setLookAndFeel(Unknown Source) ~[?:1.8.0_144]
at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
[ApacheJMeter_core.jar:r1815865]
at org.apache.jmeter.JMeter.start(JMeter.java:520)
[ApacheJMeter_core.jar:r1815865]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_144]
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
~[?:1.8.0_144]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
~[?:1.8.0_144]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144]
at org.apache.jmeter.NewDriver.main(NewDriver.java:248)
[ApacheJMeter.jar:r1815865]


In the second launch, all is ok

017-11-21 10:11:37,394 INFO o.a.j.g.a.LookAndFeelCommand: Installing
Darcula LAF
2017-11-21 10:11:37,409 INFO o.a.j.g.a.LookAndFeelCommand: Using look and
feel: com.bulenkov.darcula.DarculaLaf [Darcula]
2017-11-21 10:11:37,409 INFO o.a.j.JMeter: Setting LAF to:
com.bulenkov.darcula.DarculaLaf
2017-11-21 10:11:37,455 INFO o.a.j.JMeter: Loaded icon properties from
org/apache/jmeter/images/icon.properties

Antonio


2017-11-21 9:52 GMT+01:00 Philippe Mouawad :

> Hi Milamber,
> One note below regarding LAF.
>
> Thanks
>
> On Tue, Nov 21, 2017 at 9:50 AM, Milamber  wrote:
>
> >
> >
> > On 20/11/2017 21:06, Philippe Mouawad wrote:
> >
> >> Hello,
> >> We now have a version that contains:
> >> - 49 enhancements
> >> - 13 bug fixes
> >> - 6 PR
> >>
> >> Version looks mature to me currently and brings interesting new features
> >> and a nice new look.
> >>
> >
> > +1 for nice new look. (perhaps Dracula can be the default look)
> >
> It is already.
> If it's not then it would be an issue, I intentionally changed the
> preference name for the laf so that all users have a chance to see it.
> Can you double check and confirm please ?
>
> >
> >
> >> What do you think of releasing ?
> >>
> >
> > Yes before end of the year that's will a good idea.
> >
> >
> >> There are remaining PRs that could be merged but could introduce more
> >> delay
> >> :
> >>
> >> - https://github.com/apache/jmeter/pull/320 => Migration to last
> HC4
> >> APIs but it would need important tesint
> >> - https://github.com/apache/jmeter/pull/313 => I asked a question
> >> about
> >> it. I think we should adapt it to add a Metadata property instead of
> >> Comment
> >>
> >>
> >> Regards
> >> Philippe M.
> >>
> >>
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

Build failed in Jenkins: JMeter-trunk #6479

[Apache Jenkins Server]

See 


Changes:

[pmouawad] Enable running of JUnit tests from within IntelliJ with default 
config
Contributed by Graham Russell
This closes #334

--
[...truncated 181.52 KB...]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]
   [concat] Caused by: java.net.SocketTimeoutException: Read timed out
   [concat] at java.net.SocketInputStream.socketRead0(Native Method) 
~[?:1.8.0_152]
   [concat] at 
java.net.SocketInputStream.socketRead(SocketInputStream.java:116) ~[?:1.8.0_152]
   [concat] at java.net.SocketInputStream.read(SocketInputStream.java:171) 
~[?:1.8.0_152]
   [concat] at java.net.SocketInputStream.read(SocketInputStream.java:141) 
~[?:1.8.0_152]
   [concat] at java.net.SocketInputStream.read(SocketInputStream.java:127) 
~[?:1.8.0_152]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.BinaryTCPClientImpl.read(BinaryTCPClientImpl.java:134)
 ~[ApacheJMeter_tcp.jar:r1815881]
   [concat] ... 5 more
   [concat] 2017-11-21 09:03:48,765 WARN o.a.j.p.t.s.TCPSampler: Could not 
create socket for tcp://localhost:2223
   [concat] java.net.ConnectException: Connection refused (Connection refused)
   [concat] at java.net.PlainSocketImpl.socketConnect(Native Method) 
~[?:1.8.0_152]
   [concat] at 
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350) 
~[?:1.8.0_152]
   [concat] at 
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
 ~[?:1.8.0_152]
   [concat] at 
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) 
~[?:1.8.0_152]
   [concat] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) 
~[?:1.8.0_152]
   [concat] at java.net.Socket.connect(Socket.java:589) ~[?:1.8.0_152]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.getSocket(TCPSampler.java:168)
 [ApacheJMeter_tcp.jar:r1815881]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.sample(TCPSampler.java:384) 
[ApacheJMeter_tcp.jar:r1815881]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:490)
 [ApacheJMeter_core.jar:r1815881]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:416) 
[ApacheJMeter_core.jar:r1815881]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:250) 
[ApacheJMeter_core.jar:r1815881]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]
   [concat] 2017-11-21 09:03:48,854 WARN o.a.j.p.t.s.TCPSampler: Unknown host 
for tcp://localhost:2223
   [concat] java.net.UnknownHostException: localhost
   [concat] at 
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184) 
~[?:1.8.0_152]
   [concat] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) 
~[?:1.8.0_152]
   [concat] at java.net.Socket.connect(Socket.java:589) ~[?:1.8.0_152]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.getSocket(TCPSampler.java:168)
 [ApacheJMeter_tcp.jar:r1815881]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.sample(TCPSampler.java:384) 
[ApacheJMeter_tcp.jar:r1815881]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:490)
 [ApacheJMeter_core.jar:r1815881]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:416) 
[ApacheJMeter_core.jar:r1815881]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:250) 
[ApacheJMeter_core.jar:r1815881]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]
   [concat] 2017-11-21 09:03:48,858 ERROR o.a.j.p.t.s.TCPSampler: Could not 
find protocol class 'org.foo.xxx'
 [echo] TCP_TESTS output files compared OK

batchtest:
 [echo] Starting JDBC_TESTS with file JDBC_TESTS.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/JDBC_TESTS.jmx
   [jmeter] Starting the test @ Tue Nov 21 09:03:52 UTC 2017 (1511255032707)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary = 18 in 00:00:01 =   13.5/s Avg:26 Min: 0 Max:  
 418 Err: 0 (0.00%)
   

Re: Use of https://github.com/HdrHistogram/HdrHistogram

[Isuru Perera]

+1 for using HdrHistogram. We found out that the percentiles values shown
in "Aggregate Report" and the web dashboard are different for the same JTL
file. It will be good if we can use the same logic to calculate percentile
values in JMeter listeners and the web dashboard.

On Sat, May 20, 2017 at 7:58 PM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hello,
> Any other thoughts ?
>
> Thanks
>
> On Saturday, May 6, 2017, Antonio Gomes Rodrigues 
> wrote:
>
> > +1
> >
> > 2017-05-06 15:57 GMT+02:00 Maxime Chassagneux <
> > maxime.chassagn...@gmail.com >
> > :
> >
> > > +1 : lgtm
> > >
> > > 2017-05-06 15:41 GMT+02:00 Philippe Mouawad <
> > p.moua...@ubik-ingenierie.com 
> > > >:
> > >
> > > > Hello,
> > > > A user recently reported a bug on StatCalculator class:
> > > >
> > > >- https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
> > > >
> > > > It appears issue is not restrained to Median but concerns  percentile
> > > > computing.
> > > >
> > > > Besides, this class has many drawbacks:
> > > >
> > > >- It is not tested as much as it should be
> > > >- It relies on an algorithm that consumes memory
> > > >
> > > > We use another class in Web/Dashboard report and BackendListener
> client
> > > > implementations that relies on commons-math
> > > > org.apache.commons.math3.stat.descriptive.DescriptiveStatistics.
> > > >
> > > > My proposal is the following:
> > > >
> > > >- First step : Introduce in StatCalculator, HdrHistogram
> > > >- Second step : Replace DescriptiveStatistics by HdrHistogram
> > > >
> > > >
> > > > Benefits:
> > > >
> > > >- Uniform computing accross JMeter
> > > >- Better performances
> > > >
> > > > Are you ok with this approach ?
> > > >
> > > > Thanks
> > > > --
> > > > Regards.
> > > > Philippe Mouawad.
> > > > Ubik-Ingénierie
> > > >
> > >
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>



-- 
Isuru Perera
about.me/chrishantha

Re: Release a 4.0 ?

[Philippe Mouawad]

Hi Milamber,
One note below regarding LAF.

Thanks

On Tue, Nov 21, 2017 at 9:50 AM, Milamber  wrote:

>
>
> On 20/11/2017 21:06, Philippe Mouawad wrote:
>
>> Hello,
>> We now have a version that contains:
>> - 49 enhancements
>> - 13 bug fixes
>> - 6 PR
>>
>> Version looks mature to me currently and brings interesting new features
>> and a nice new look.
>>
>
> +1 for nice new look. (perhaps Dracula can be the default look)
>
It is already.
If it's not then it would be an issue, I intentionally changed the
preference name for the laf so that all users have a chance to see it.
Can you double check and confirm please ?

>
>
>> What do you think of releasing ?
>>
>
> Yes before end of the year that's will a good idea.
>
>
>> There are remaining PRs that could be merged but could introduce more
>> delay
>> :
>>
>> - https://github.com/apache/jmeter/pull/320 => Migration to last HC4
>> APIs but it would need important tesint
>> - https://github.com/apache/jmeter/pull/313 => I asked a question
>> about
>> it. I think we should adapt it to add a Metadata property instead of
>> Comment
>>
>>
>> Regards
>> Philippe M.
>>
>>
>


-- 
Cordialement.
Philippe Mouawad.

Re: Release a 4.0 ?

[Milamber]

On 20/11/2017 21:06, Philippe Mouawad wrote:

Hello,
We now have a version that contains:
- 49 enhancements
- 13 bug fixes
- 6 PR

Version looks mature to me currently and brings interesting new features
and a nice new look.


+1 for nice new look. (perhaps Dracula can be the default look)



What do you think of releasing ?


Yes before end of the year that's will a good idea.



There are remaining PRs that could be merged but could introduce more delay
:

- https://github.com/apache/jmeter/pull/320 => Migration to last HC4
APIs but it would need important tesint
- https://github.com/apache/jmeter/pull/313 => I asked a question about
it. I think we should adapt it to add a Metadata property instead of Comment


Regards
Philippe M.

Re: Release a 4.0 ?

[jmeter tea]

I found it, sorry for the confusion.

On Tue, Nov 21, 2017 at 9:55 AM, Philippe Mouawad <
philippe.moua...@gmail.com> wrote:

> Hello,
> Function is there , it is called __digest
>
> Please confirm you find it.
> Regards
>
> On Tue, Nov 21, 2017 at 7:58 AM, jmeter tea  wrote:
>
> > I think it's a good idea,
> > Just a small issue, I didn't find DigestEncodeFunction.java which is
> called
> > from TestDigestFunction (it was called DigestEncode)
> > It's related to bug 61724
> >
> > Thank you
> >
> >
> > On Mon, Nov 20, 2017 at 11:06 PM, Philippe Mouawad <
> > philippe.moua...@gmail.com> wrote:
> >
> > > Hello,
> > > We now have a version that contains:
> > > - 49 enhancements
> > > - 13 bug fixes
> > > - 6 PR
> > >
> > > Version looks mature to me currently and brings interesting new
> features
> > > and a nice new look.
> > >
> > > What do you think of releasing ?
> > >
> > > There are remaining PRs that could be merged but could introduce more
> > delay
> > > :
> > >
> > >- https://github.com/apache/jmeter/pull/320 => Migration to last
> HC4
> > >APIs but it would need important tesint
> > >- https://github.com/apache/jmeter/pull/313 => I asked a question
> > about
> > >it. I think we should adapt it to add a Metadata property instead of
> > > Comment
> > >
> > >
> > > Regards
> > > Philippe M.
> > >
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>

[GitHub] jmeter issue #332: Added Spock framework and some tests, both old and new

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/332
  
Hi @ham1 ,
Thanks for this interesting PR.
There is a conflict in it, could you rebase it as you proposed.
Also, there is something I don't understand, I see coverage has decreased 
while you modified some existing tests and added new ones.
Maybe as a first step, you could only add new tests and not impact existing 
ones ?

Thank you
Regards


---

[GitHub] jmeter pull request #334: Enable running of JUnit tests from within IntelliJ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/334


---