Re: Improve build stability

[sebb]

On 24 November 2017 at 19:15, Philippe Mouawad
 wrote:
> Hello,
> Today checkstyle which controls tabs and other things that can make build
> fail is ran after tests.
>
> Wouldn’t we gain some cpu, time and avoid useless power consumption if we
> added this check before even compiling classes  ?

Disagree; if the build is failed just for tabs than you may fix a tab
issue only to find that there is a compilation issue or a unit test
failure.

Maybe it's possible to configure the tabs as a warning rather than a
failure (in which case it does not matter when they are checked)

> I also have the feeling the jenkins nodes are not very stable:
> - localhost not configured
> - disk space issues
>
> Any ideas to improve ?

Report the problems to the build list.

> Regards
>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie
>
> UBIK LOAD PACK Web Site 
>
> UBIK LOAD PACK on TWITTER 

Re: Improve build stability

[Felix Schumacher]

Am 24. November 2017 20:15:09 MEZ schrieb Philippe Mouawad 
:
>Hello,
>Today checkstyle which controls tabs and other things that can make
>build
>fail is ran after tests.
>
>Wouldn’t we gain some cpu, time and avoid useless power consumption if
>we
>added this check before even compiling classes  ?

+1

>
>I also have the feeling the jenkins nodes are not very stable:
>- localhost not configured
>- disk space issues
>
>Any ideas to improve ?

Not really. 

Felix 

>
>Regards

Assertions execution should follow the same order as Pre/Post Processor

[Philippe Mouawad]

Hello,
When you have elements at different scopes:
- Pre and Post Processors are processed from OUTER to INNER scope
- while assertions are processed from INNER to OUTER scope

I don't see any regression risk

I propose we align it.
See:
https://bz.apache.org/bugzilla/show_bug.cgi?id=61815

-- 
Cordialement.
Philippe

Add a way to execute a step when error occurs and configuration is startNextLoop

[Philippe Mouawad]

Hello,
When load testing, I frequently have the following use case when analyzing
a problem or for some particular applications that require explicit logout :

   - Thread Group is set to restart next loop on error
   - But I'd like to execute the equivalent of a finally block or goto


Do you think this is a use case worth supporting ?

-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER 

Improve build stability

[Philippe Mouawad]

Hello,
Today checkstyle which controls tabs and other things that can make build
fail is ran after tests.

Wouldn’t we gain some cpu, time and avoid useless power consumption if we
added this check before even compiling classes  ?

I also have the feeling the jenkins nodes are not very stable:
- localhost not configured
- disk space issues

Any ideas to improve ?

Regards




-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER 

Re: svn commit: r1816234 - in /jmeter/trunk/bin: jmeter jmeter.bat

[Felix Schumacher]

Am 24. November 2017 14:31:41 MEZ schrieb pmoua...@apache.org:
>Author: pmouawad
>Date: Fri Nov 24 13:31:41 2017
>New Revision: 1816234
>
>URL: http://svn.apache.org/viewvc?rev=1816234=rev
>Log:
>Add -XX:+PrintAdaptiveSizePolicy
>
>Modified:
>jmeter/trunk/bin/jmeter
>jmeter/trunk/bin/jmeter.bat
>
>Modified: jmeter/trunk/bin/jmeter
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter?rev=1816234=1816233=1816234=diff
>==
>--- jmeter/trunk/bin/jmeter (original)
>+++ jmeter/trunk/bin/jmeter Fri Nov 24 13:31:41 2017
>@@ -123,7 +123,7 @@ esac
> HEAP="-Xms512m -Xmx512m -XX:MaxMetaspaceSize=256m"
> 
> # Uncomment this to generate GC verbose file with Java prior to 9
>-# VERBOSE_GC="-verbose:gc -Xloggc:gc_jmeter_%p.log -XX:+PrintGCDetails
>-XX:+PrintGCCause -XX:+PrintTenuringDistribution -XX:+PrintHeapAtGC
>-XX:+PrintGCApplicationConcurrentTime
>-XX:+PrintGCApplicationStoppedTime -XX:+PrintGCDateStamps"
>+# VERBOSE_GC="-verbose:gc -Xloggc:gc_jmeter_%p.log -XX:+PrintGCDetails
>-XX:+PrintGCCause -XX:+PrintTenuringDistribution -XX:+PrintHeapAtGC
>-XX:+PrintGCApplicationConcurrentTime -XX:+PrintAdaptiveSizePolicy
>-XX:+PrintGCApplicationStoppedTime -XX:+PrintGCDateStamps"
> 
> # Uncomment this to generate GC verbose file with Java 9 and above
>#
>VERBOSE_GC="-Xlog:gc*,gc+age=trace,gc+heap=debug:file=gc_jmeter_%p.log"
>
>Modified: jmeter/trunk/bin/jmeter.bat
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.bat?rev=1816234=1816233=1816234=diff
>==
>--- jmeter/trunk/bin/jmeter.bat (original)
>+++ jmeter/trunk/bin/jmeter.bat Fri Nov 24 13:31:41 2017
>@@ -27,7 +27,7 @@ rem
> rem   =
> 
> setlocal
>-
>+set JVM_ARGS=-Duser.language="en" -Duser.region="EN"

Is this intentional? 

Felix

> rem Minimal version to run JMeter
> set MINIMAL_VERSION=1.8.0
> 
>@@ -94,7 +94,7 @@ rem including some tuning recommendation
> set HEAP=-Xms512m -Xmx512m -XX:MaxMetaspaceSize=256m
> 
> rem Uncomment this to generate GC verbose file with Java prior to 9 
>-rem set VERBOSE_GC=-verbose:gc -Xloggc:gc_jmeter_%%p.log
>-XX:+PrintGCDetails -XX:+PrintGCCause -XX:+PrintTenuringDistribution
>-XX:+PrintHeapAtGC -XX:+PrintGCApplicationConcurrentTime
>-XX:+PrintGCApplicationStoppedTime -XX:+PrintGCDateStamps
>+rem set VERBOSE_GC=-verbose:gc -Xloggc:gc_jmeter_%%p.log
>-XX:+PrintGCDetails -XX:+PrintGCCause -XX:+PrintTenuringDistribution
>-XX:+PrintHeapAtGC -XX:+PrintGCApplicationConcurrentTime
>-XX:+PrintGCApplicationStoppedTime -XX:+PrintGCDateStamps
>-XX:+PrintAdaptiveSizePolicy
> 
> rem Uncomment this to generate GC verbose file with Java 9 and above
>rem set
>VERBOSE_GC=-Xlog:gc*,gc+age=trace,gc+heap=debug:file=gc_jmeter_%%p.log

Re: Hanging test due to no timeout set / hanging sampler and Test duration

[Andrey Pokhilko]

Hi,

First of all, I agree that this is very confusing for users. We need to
not fall into this trap by default.

Wouldn't changing default timeout for HTTP sampler help in this case?
Just default how we set it for newly added samplers. This way it won't
affect existing test plans, but will make users by default to have
limited socket waiting time. Something like 30-60 seconds is a good
default from my practice.

Andrey Pokhilko

24.11.2017 15:15, Philippe Mouawad пишет:
> Hello,
> Currently when you check Schedule in Thread group and:
>
>- fix a duration for your test
>- Don't set any timeout on HTTP requests or use a non interruptible
>sampler
>
> Your test can hang infinitely as JMeter will not interrupt the Hanging
> samplers even after duration of Thread Group has been reached.
>
> This is a frequent problem faced by JMeter users (I remember that I have
> answered this SO question at least 10 times). Even non newbie can get
> trapped.
>
> Shouldn't we introduce this to avoid hanging test that give a feeling of
> broken JMeter while the problem is in the hanging targetted server ?:
>
>- Option 1: Add an option in Scheduler part called "Interrupt pending
>Threads after duration + security margin (1m) that could be a field or
>property" on Thread Group (checked by default)
>- Option 2 : Add it at test plan level to avoid repeating the
>configuration
>- On start of Thread Group, an additional TimerTask would be triggered
>after duration + security margin and would do the following:
>   - run equivalent (refactor) of code at:
>  -
>  
> https://github.com/apache/jmeter/blob/trunk/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java#L326
>
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie
>
> UBIK LOAD PACK Web Site 
>
> UBIK LOAD PACK on TWITTER 
>

buildbot success in on jmeter-trunk

[buildbot]

The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3266

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1816234
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

Re: svn commit: r1816193 - in /jmeter/trunk: src/core/org/apache/jmeter/JMeter.java src/jorphan/org/apache/jorphan/gui/ComponentUtil.java xdocs/changes.xml

[Antonio Gomes Rodrigues]

+1

2017-11-24 12:37 GMT+01:00 Philippe Mouawad :

> +1
>
> On Friday, November 24, 2017, Felix Schumacher <
> felix.schumac...@internetallee.de> wrote:
>
> >
> >
> > Am 23. November 2017 23:21:45 MEZ schrieb pmoua...@apache.org
> > :
> > >Author: pmouawad
> > >Date: Thu Nov 23 22:21:45 2017
> > >New Revision: 1816193
> > >
> > >URL: http://svn.apache.org/viewvc?rev=1816193=rev
> > >Log:
> > >Bug 61808 - Fix main frame position
> > >Contributed by by Artem Fedorov
> > >This closes #338
> > >
> > >Bugzilla Id: 61808
> > >
> > >Modified:
> > >jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
> > >jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
> > >jmeter/trunk/xdocs/changes.xml
> > >
> > >Modified: jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
> > >URL:
> > >http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> > apache/jmeter/JMeter.java?rev=1816193=1816192=1816193=diff
> > >===
> > ===
> > >--- jmeter/trunk/src/core/org/apache/jmeter/JMeter.java (original)
> > >+++ jmeter/trunk/src/core/org/apache/jmeter/JMeter.java Thu Nov 23
> > >22:21:45 2017
> > >@@ -376,7 +376,9 @@ public class JMeter implements JMeterPlu
> > > MainFrame main = new MainFrame(treeModel, treeLis);
> > > splash.setProgress(100);
> > > ComponentUtil.centerComponentInWindow(main, 80);
> > >+main.setLocationRelativeTo(splash);
> > > main.setVisible(true);
> > >+main.toFront();
> > >instance.actionPerformed(new ActionEvent(main, 1,
> > >ActionNames.ADD_ALL));
> > > if (testFile != null) {
> > > try {
> > >
> > >Modified:
> > >jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
> > >URL:
> > >http://svn.apache.org/viewvc/jmeter/trunk/src/jorphan/org/
> > apache/jorphan/gui/ComponentUtil.java?rev=1816193=1816192=1816193&
> > view=diff
> > >===
> > ===
> > >--- jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
> > >(original)
> > >+++ jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
> > >Thu Nov 23 22:21:45 2017
> > >@@ -18,8 +18,7 @@
> > >
> > > package org.apache.jorphan.gui;
> > >
> > >-import java.awt.Component;
> > >-import java.awt.Dimension;
> > >+import java.awt.*;
> >
> > I would like to disallow star imports.
> >
> > This is the only place in our code base, where they are (now) used.
> >
> > If no one disagrees, I will add a Checkstyle rule AvoidStarImport.
> >
> > Felix
> >
> > >
> > > /**
> > >* This class is a Util for awt Component and could be used to place
> > >them in
> > >@@ -49,8 +48,8 @@ public final class ComponentUtil {
> > > return;
> > > }
> > > double percent = percentOfScreen / 100.d;
> > >-Dimension dimension = component.getToolkit().getScreenSize();
> > >-component.setSize((int) (dimension.getWidth() * percent),
> > >(int) (dimension.getHeight() * percent));
> > >+Rectangle bounds =
> > >GraphicsEnvironment.getLocalGraphicsEnvironment().
> > getDefaultScreenDevice().getDefaultConfiguration().getBounds();
> > >+component.setSize((int) (bounds.getWidth() * percent), (int)
> > >(bounds.getHeight() * percent));
> > > centerComponentInWindow(component);
> > > }
> > >
> > >@@ -61,10 +60,9 @@ public final class ComponentUtil {
> > >  *the component you want to center in window
> > >  */
> > > public static void centerComponentInWindow(Component component) {
> > >-Dimension dimension = component.getToolkit().getScreenSize();
> > >-
> > >-component.setLocation((int) ((dimension.getWidth() -
> > >component.getWidth()) / 2),
> > >-(int) ((dimension.getHeight() - component.getHeight())
> > >/ 2));
> > >+Rectangle bounds =
> > >GraphicsEnvironment.getLocalGraphicsEnvironment().
> > getDefaultScreenDevice().getDefaultConfiguration().getBounds();
> > >+component.setLocation((int) ((bounds.getWidth() -
> > >component.getWidth()) / 2),
> > >+(int) ((bounds.getHeight() - component.getHeight()) /
> > >2));
> > > component.validate();
> > > component.repaint();
> > > }
> > >
> > >Modified: jmeter/trunk/xdocs/changes.xml
> > >URL:
> > >http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> > xml?rev=1816193=1816192=1816193=diff
> > >===
> > ===
> > >--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> > >+++ jmeter/trunk/xdocs/changes.xml [utf-8] Thu Nov 23 22:21:45 2017
> > >@@ -171,6 +171,7 @@ Summary
> > >61731Enhance Test plan Backup with option to save before
> > >run. Based on a contribution by orimarko at gmail.com
> > >61640JSR223 Test Elements : Enable by default caching.
> > >Contributed by Ubik Load Pack (support at 

Jenkins build is back to normal : JMeter Ubuntu #301

[Apache Jenkins Server]

See 

buildbot failure in on jmeter-trunk

[buildbot]

The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3265

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1816233
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/341
  
Hi @max3163 ,
0/ In order to justify the user case, can you illustrate your use case ?
1/ I think we should add a log in debug level when we ignore a SampleResult
2/ Could you also add either a JUnit or an integration test (jmx test) that 
tests different cases:
- ignore only in JSR223Sampler
- ignore only in Assertion
- ignore only in PostProcessor
3/ Can you add a comment on the reason for the multiple test ? when reading 
the code, I forgot for few minutes the initial intent ,and it was not clear for 
me. 
Comment like:
"setIgnore can be called in Assertion or PostProcessors so test again"


Thanks


---

Hanging test due to no timeout set / hanging sampler and Test duration

[Philippe Mouawad]

Hello,
Currently when you check Schedule in Thread group and:

   - fix a duration for your test
   - Don't set any timeout on HTTP requests or use a non interruptible
   sampler

Your test can hang infinitely as JMeter will not interrupt the Hanging
samplers even after duration of Thread Group has been reached.

This is a frequent problem faced by JMeter users (I remember that I have
answered this SO question at least 10 times). Even non newbie can get
trapped.

Shouldn't we introduce this to avoid hanging test that give a feeling of
broken JMeter while the problem is in the hanging targetted server ?:

   - Option 1: Add an option in Scheduler part called "Interrupt pending
   Threads after duration + security margin (1m) that could be a field or
   property" on Thread Group (checked by default)
   - Option 2 : Add it at test plan level to avoid repeating the
   configuration
   - On start of Thread Group, an additional TimerTask would be triggered
   after duration + security margin and would do the following:
  - run equivalent (refactor) of code at:
 -
 
https://github.com/apache/jmeter/blob/trunk/src/core/org/apache/jmeter/engine/StandardJMeterEngine.java#L326

Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER 

Build failed in Jenkins: JMeter Ubuntu #300

[Apache Jenkins Server]

See 


Changes:

[pmouawad] Bug 61697 Introduce Darcula Look And Feel to make JMeter UI more 
attractive
Forgot to commit the xml addition to jar
Bugzilla Id: 61697

--
[...truncated 161.30 KB...]
   [concat] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) 
~[?:1.8.0_144]
   [concat] at java.net.Socket.connect(Socket.java:589) ~[?:1.8.0_144]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.getSocket(TCPSampler.java:168)
 [ApacheJMeter_tcp.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.sample(TCPSampler.java:384) 
[ApacheJMeter_tcp.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:490)
 [ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:416) 
[ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:250) 
[ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
   [concat] 2017-11-24 11:36:20,173 WARN o.a.j.p.t.s.TCPSampler: Unknown host 
for tcp://localhost:2223
   [concat] java.net.UnknownHostException: localhost
   [concat] at 
java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184) 
~[?:1.8.0_144]
   [concat] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) 
~[?:1.8.0_144]
   [concat] at java.net.Socket.connect(Socket.java:589) ~[?:1.8.0_144]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.getSocket(TCPSampler.java:168)
 [ApacheJMeter_tcp.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.protocol.tcp.sampler.TCPSampler.sample(TCPSampler.java:384) 
[ApacheJMeter_tcp.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:490)
 [ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:416) 
[ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:250) 
[ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]
   [concat] 2017-11-24 11:36:20,178 ERROR o.a.j.p.t.s.TCPSampler: Could not 
find protocol class 'org.foo.xxx'
 [echo] TCP_TESTS output files compared OK

batchtest:
 [echo] Starting JDBC_TESTS with file JDBC_TESTS.jmx using -X -Jdummy=dummy
   [jmeter] SLF4J: Class path contains multiple SLF4J bindings.
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: Found binding in 
[jar:
   [jmeter] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
   [jmeter] SLF4J: Actual binding is of type 
[org.apache.logging.slf4j.Log4jLoggerFactory]
   [jmeter] Creating summariser 
   [jmeter] Created the tree successfully using testfiles/JDBC_TESTS.jmx
   [jmeter] Starting the test @ Fri Nov 24 11:36:23 UTC 2017 (1511523383900)
   [jmeter] Waiting for possible Shutdown/StopTestNow/Heapdump message on port 
4445
   [jmeter] summary = 21 in 00:00:02 =   12.9/s Avg:31 Min: 0 Max:  
 598 Err: 0 (0.00%)
   [jmeter] Tidying up ...@ Fri Nov 24 11:36:26 UTC 2017 (1511523386809)
   [jmeter] ... end of run
   [concat] 2017-11-24 11:36:26,773 ERROR o.a.j.t.JMeterThread: Error while 
processing sampler: 'JDBC_With_Failing_PreProcessor'.
   [concat] java.lang.IllegalArgumentException: Variable Name must not be null 
in JDBC PreProcessor
   [concat] at 
org.apache.jmeter.protocol.jdbc.processor.AbstractJDBCProcessor.process(AbstractJDBCProcessor.java:45)
 ~[ApacheJMeter_jdbc.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.protocol.jdbc.processor.JDBCPreProcessor.process(JDBCPreProcessor.java:33)
 ~[ApacheJMeter_jdbc.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.runPreProcessors(JMeterThread.java:844) 
~[ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:467)
 ~[ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:416) 
[ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at 
org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:250) 
[ApacheJMeter_core.jar:4.0-SNAPSHOT r1816230]
   [concat] at 

Re: svn commit: r1816193 - in /jmeter/trunk: src/core/org/apache/jmeter/JMeter.java src/jorphan/org/apache/jorphan/gui/ComponentUtil.java xdocs/changes.xml

[Philippe Mouawad]

+1

On Friday, November 24, 2017, Felix Schumacher <
felix.schumac...@internetallee.de> wrote:

>
>
> Am 23. November 2017 23:21:45 MEZ schrieb pmoua...@apache.org
> :
> >Author: pmouawad
> >Date: Thu Nov 23 22:21:45 2017
> >New Revision: 1816193
> >
> >URL: http://svn.apache.org/viewvc?rev=1816193=rev
> >Log:
> >Bug 61808 - Fix main frame position
> >Contributed by by Artem Fedorov
> >This closes #338
> >
> >Bugzilla Id: 61808
> >
> >Modified:
> >jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
> >jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
> >jmeter/trunk/xdocs/changes.xml
> >
> >Modified: jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> apache/jmeter/JMeter.java?rev=1816193=1816192=1816193=diff
> >===
> ===
> >--- jmeter/trunk/src/core/org/apache/jmeter/JMeter.java (original)
> >+++ jmeter/trunk/src/core/org/apache/jmeter/JMeter.java Thu Nov 23
> >22:21:45 2017
> >@@ -376,7 +376,9 @@ public class JMeter implements JMeterPlu
> > MainFrame main = new MainFrame(treeModel, treeLis);
> > splash.setProgress(100);
> > ComponentUtil.centerComponentInWindow(main, 80);
> >+main.setLocationRelativeTo(splash);
> > main.setVisible(true);
> >+main.toFront();
> >instance.actionPerformed(new ActionEvent(main, 1,
> >ActionNames.ADD_ALL));
> > if (testFile != null) {
> > try {
> >
> >Modified:
> >jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/src/jorphan/org/
> apache/jorphan/gui/ComponentUtil.java?rev=1816193=1816192=1816193&
> view=diff
> >===
> ===
> >--- jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
> >(original)
> >+++ jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
> >Thu Nov 23 22:21:45 2017
> >@@ -18,8 +18,7 @@
> >
> > package org.apache.jorphan.gui;
> >
> >-import java.awt.Component;
> >-import java.awt.Dimension;
> >+import java.awt.*;
>
> I would like to disallow star imports.
>
> This is the only place in our code base, where they are (now) used.
>
> If no one disagrees, I will add a Checkstyle rule AvoidStarImport.
>
> Felix
>
> >
> > /**
> >* This class is a Util for awt Component and could be used to place
> >them in
> >@@ -49,8 +48,8 @@ public final class ComponentUtil {
> > return;
> > }
> > double percent = percentOfScreen / 100.d;
> >-Dimension dimension = component.getToolkit().getScreenSize();
> >-component.setSize((int) (dimension.getWidth() * percent),
> >(int) (dimension.getHeight() * percent));
> >+Rectangle bounds =
> >GraphicsEnvironment.getLocalGraphicsEnvironment().
> getDefaultScreenDevice().getDefaultConfiguration().getBounds();
> >+component.setSize((int) (bounds.getWidth() * percent), (int)
> >(bounds.getHeight() * percent));
> > centerComponentInWindow(component);
> > }
> >
> >@@ -61,10 +60,9 @@ public final class ComponentUtil {
> >  *the component you want to center in window
> >  */
> > public static void centerComponentInWindow(Component component) {
> >-Dimension dimension = component.getToolkit().getScreenSize();
> >-
> >-component.setLocation((int) ((dimension.getWidth() -
> >component.getWidth()) / 2),
> >-(int) ((dimension.getHeight() - component.getHeight())
> >/ 2));
> >+Rectangle bounds =
> >GraphicsEnvironment.getLocalGraphicsEnvironment().
> getDefaultScreenDevice().getDefaultConfiguration().getBounds();
> >+component.setLocation((int) ((bounds.getWidth() -
> >component.getWidth()) / 2),
> >+(int) ((bounds.getHeight() - component.getHeight()) /
> >2));
> > component.validate();
> > component.repaint();
> > }
> >
> >Modified: jmeter/trunk/xdocs/changes.xml
> >URL:
> >http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.
> xml?rev=1816193=1816192=1816193=diff
> >===
> ===
> >--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
> >+++ jmeter/trunk/xdocs/changes.xml [utf-8] Thu Nov 23 22:21:45 2017
> >@@ -171,6 +171,7 @@ Summary
> >61731Enhance Test plan Backup with option to save before
> >run. Based on a contribution by orimarko at gmail.com
> >61640JSR223 Test Elements : Enable by default caching.
> >Contributed by Ubik Load Pack (support at ubikloadpack.com)
> >61785Add
> >HelpUseful
> >links to create issues and download nightly
> >build
> >+61808Fix main frame position. Implemented by Artem
> >Fedorov (artem at blazemeter.com) and contributed by BlazeMeter
> >Ltd.
> > 
> >
> > Non-functional changes
>


-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1816193 - in /jmeter/trunk: src/core/org/apache/jmeter/JMeter.java src/jorphan/org/apache/jorphan/gui/ComponentUtil.java xdocs/changes.xml

[Felix Schumacher]

Am 23. November 2017 23:21:45 MEZ schrieb pmoua...@apache.org:
>Author: pmouawad
>Date: Thu Nov 23 22:21:45 2017
>New Revision: 1816193
>
>URL: http://svn.apache.org/viewvc?rev=1816193=rev
>Log:
>Bug 61808 - Fix main frame position
>Contributed by by Artem Fedorov
>This closes #338
>
>Bugzilla Id: 61808
>
>Modified:
>jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
>jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
>jmeter/trunk/xdocs/changes.xml
>
>Modified: jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/JMeter.java?rev=1816193=1816192=1816193=diff
>==
>--- jmeter/trunk/src/core/org/apache/jmeter/JMeter.java (original)
>+++ jmeter/trunk/src/core/org/apache/jmeter/JMeter.java Thu Nov 23
>22:21:45 2017
>@@ -376,7 +376,9 @@ public class JMeter implements JMeterPlu
> MainFrame main = new MainFrame(treeModel, treeLis);
> splash.setProgress(100);
> ComponentUtil.centerComponentInWindow(main, 80);
>+main.setLocationRelativeTo(splash);
> main.setVisible(true);
>+main.toFront();
>instance.actionPerformed(new ActionEvent(main, 1,
>ActionNames.ADD_ALL));
> if (testFile != null) {
> try {
>
>Modified:
>jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java?rev=1816193=1816192=1816193=diff
>==
>--- jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
>(original)
>+++ jmeter/trunk/src/jorphan/org/apache/jorphan/gui/ComponentUtil.java
>Thu Nov 23 22:21:45 2017
>@@ -18,8 +18,7 @@
> 
> package org.apache.jorphan.gui;
> 
>-import java.awt.Component;
>-import java.awt.Dimension;
>+import java.awt.*;

I would like to disallow star imports. 

This is the only place in our code base, where they are (now) used. 

If no one disagrees, I will add a Checkstyle rule AvoidStarImport. 

Felix 

> 
> /**
>* This class is a Util for awt Component and could be used to place
>them in
>@@ -49,8 +48,8 @@ public final class ComponentUtil {
> return;
> }
> double percent = percentOfScreen / 100.d;
>-Dimension dimension = component.getToolkit().getScreenSize();
>-component.setSize((int) (dimension.getWidth() * percent),
>(int) (dimension.getHeight() * percent));
>+Rectangle bounds =
>GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice().getDefaultConfiguration().getBounds();
>+component.setSize((int) (bounds.getWidth() * percent), (int)
>(bounds.getHeight() * percent));
> centerComponentInWindow(component);
> }
> 
>@@ -61,10 +60,9 @@ public final class ComponentUtil {
>  *the component you want to center in window
>  */
> public static void centerComponentInWindow(Component component) {
>-Dimension dimension = component.getToolkit().getScreenSize();
>-
>-component.setLocation((int) ((dimension.getWidth() -
>component.getWidth()) / 2),
>-(int) ((dimension.getHeight() - component.getHeight())
>/ 2));
>+Rectangle bounds =
>GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice().getDefaultConfiguration().getBounds();
>+component.setLocation((int) ((bounds.getWidth() -
>component.getWidth()) / 2),
>+(int) ((bounds.getHeight() - component.getHeight()) /
>2));
> component.validate();
> component.repaint();
> }
>
>Modified: jmeter/trunk/xdocs/changes.xml
>URL:
>http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1816193=1816192=1816193=diff
>==
>--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
>+++ jmeter/trunk/xdocs/changes.xml [utf-8] Thu Nov 23 22:21:45 2017
>@@ -171,6 +171,7 @@ Summary
>61731Enhance Test plan Backup with option to save before
>run. Based on a contribution by orimarko at gmail.com
>61640JSR223 Test Elements : Enable by default caching.
>Contributed by Ubik Load Pack (support at ubikloadpack.com)
>61785Add
>HelpUseful
>links to create issues and download nightly
>build
>+61808Fix main frame position. Implemented by Artem
>Fedorov (artem at blazemeter.com) and contributed by BlazeMeter
>Ltd.
> 
> 
> Non-functional changes

[GitHub] jmeter pull request #341: Test isIgnore after post processor and assertions

[max3163]

GitHub user max3163 opened a pull request:

https://github.com/apache/jmeter/pull/341

Test isIgnore after post processor and assertions

Actually, the new setIgnore() method allow to not send the sampleResut to 
all listeners. 
But you have to set the property in the sampler, you can't change it on a 
post-processor or in a assertion script.

This PR allow it

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/max3163/jmeter BZ60829_SetIgnore

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #341


commit 1cbc3c10a957f378e41048c60e49620a312daba0
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-11-24T10:58:31Z

Test isIgnore after post processor and assertions




---

[GitHub] jmeter pull request #340: Bz61806 set ignore

[max3163]

Github user max3163 closed the pull request at:

https://github.com/apache/jmeter/pull/340


---

[GitHub] jmeter pull request #340: Bz61806 set ignore

[max3163]

GitHub user max3163 opened a pull request:

https://github.com/apache/jmeter/pull/340

Bz61806 set ignore

Actually, the new setIgnore() method allow to not send the sampleResut to 
all listeners. 
But you have to set the property in the sampler, you can't change it on a 
post-processor or in a assertion script.

This PR allow to do it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/max3163/jmeter BZ61806_SetIgnore

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #340


commit 5ca11d5b592fa68e4456358f93a78771fc62bc92
Author: Maxime Chassagneux <4163...@airfrance.fr>
Date:   2017-02-16T10:32:53Z

Add pom.xml for bamboo build (3.2 SNAPSHOT)

commit d03c1772a6cf9c9272ae70cc8442b8869b1023b5
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-02-16T11:42:35Z

skip some test

commit b7f3cdc3c23282dd84d61e9142dda9c043839aed
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-02-16T11:52:32Z

Delete ApacheJMeter_monitors

commit fd943737519ecc5b5b36d4c593930702581db67f
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-02-28T10:09:26Z

Merge remote-tracking branch 'origin/trunk' into trunk_stash

Conflicts:
build.xml

commit 2ac2fd3176233b78e994a6d313c2ab006afab3ef
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-02-28T10:18:27Z

Fix build file

commit f44408e1153ebb8d7b924ce77d87fc992d581231
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-02-28T11:42:18Z

skip.batchtest

commit 8b0e7a4f36002acc9b0feabda2dcee935c62d052
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-02T14:21:44Z

Merge remote-tracking branch 'origin/trunk' into trunk_stash

commit 7dbbb601a0719713924ed55bc2176c809fdcb970
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-02T14:38:14Z

Delete _allbatchtests test

commit eca74a8d8738411b71f1d465c2b40f8f2215013f
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-09T09:30:27Z

Merge remote-tracking branch 'origin/trunk' into trunk_stash

commit 6205ea0b5c9cef96f93f6b97363567010fa56f4a
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-09T09:32:05Z

Fix bamboo url

commit 35e0e0d1d02e2692a31651aabfcdb28c7065bd4c
Author: Maxime Chassagneux 
Date:   2017-03-10T14:32:31Z

Allow on JMeter client to use variables and functions for Listener

This patch allow to use in all ResultCollector and Backend sampler (
which are executed in the client side for a distributed test ) to have
access on test plan and user defined variables.

commit 7145ea94318bc9c9d3da4845e577d7e995adbd31
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-15T10:42:09Z

Merge remote-tracking branch 'origin/trunk' into trunk_stash

commit 15fbb86954dc951eca1f7a79667bc30bf3bacf28
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-15T10:42:36Z

Merge remote-tracking branch 'github/ClientVariable' into trunk_stash

commit 9ec3feb31ffab50b946ff6a6b12c9c240d0d116f
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-16T09:46:08Z

Change order of PreCompiler

commit e8c3b73200fc7990a2a5084d2368f94b22e85696
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-28T08:02:26Z

Merge remote-tracking branch 'origin/trunk' into trunk_stash

commit b809ff25fbe36b7ce9318abfcc2a344631bc6499
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-29T14:29:22Z

Wait for end of Thread create on the fly

commit b920f7f6cd0c7b4870d5285e3df7eeec9f0d79c3
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-29T14:31:03Z

Merge remote-tracking branch 'origin/trunk' into trunk_stash

commit f0b0be406afc30c18349df160d24f6b22efb1a45
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-29T16:25:12Z

Wait until allThreads is empty ( and revert last comit )

commit f0c37f6154849a9c6795c30a11dc799ea852
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-03-29T16:26:46Z

Skip all test

commit 5846d6854f3e22eaf7c7972380a4435d49f9b2c4
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-04-10T13:24:24Z

Merge remote-tracking branch 'origin/trunk' into trunk_stash

commit de02cbd8ea5d9878ad9f6b9c437b5636dcab5622
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-04-10T13:39:42Z

Don't cumul initial delay + rampup delay

commit 16e9db26c3fb7c82c957934db01b732eba9a367b
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   2017-04-25T13:07:18Z

Add time shifting function

commit 4bf532bc1a45ec2dca9d37cde855428ffd811475
Author: Chassagneux Maxime <4163...@airfrance.fr>
Date:   

[GitHub] jmeter pull request #321: [Influxdb] Allow users to add theirs owns tags

[max3163]

Github user max3163 closed the pull request at:

https://github.com/apache/jmeter/pull/321


---