Re: Hanging test due to no timeout set / hanging sampler and Test duration

[Antonio Gomes Rodrigues]

Hi,

I have had this problem not long ago and I confirm it's very confusing

I don't think add a default timeout for HTTP sampler is a good idea,
because the value will depend a lot of the tested application. And sometime
60 secondes is not enough

I prefer option 1

Antonio


2017-11-24 14:44 GMT+01:00 Andrey Pokhilko :

> Hi,
>
> First of all, I agree that this is very confusing for users. We need to
> not fall into this trap by default.
>
> Wouldn't changing default timeout for HTTP sampler help in this case?
> Just default how we set it for newly added samplers. This way it won't
> affect existing test plans, but will make users by default to have
> limited socket waiting time. Something like 30-60 seconds is a good
> default from my practice.
>
> Andrey Pokhilko
>
> 24.11.2017 15:15, Philippe Mouawad пишет:
> > Hello,
> > Currently when you check Schedule in Thread group and:
> >
> >- fix a duration for your test
> >- Don't set any timeout on HTTP requests or use a non interruptible
> >sampler
> >
> > Your test can hang infinitely as JMeter will not interrupt the Hanging
> > samplers even after duration of Thread Group has been reached.
> >
> > This is a frequent problem faced by JMeter users (I remember that I have
> > answered this SO question at least 10 times). Even non newbie can get
> > trapped.
> >
> > Shouldn't we introduce this to avoid hanging test that give a feeling of
> > broken JMeter while the problem is in the hanging targetted server ?:
> >
> >- Option 1: Add an option in Scheduler part called "Interrupt pending
> >Threads after duration + security margin (1m) that could be a field or
> >property" on Thread Group (checked by default)
> >- Option 2 : Add it at test plan level to avoid repeating the
> >configuration
> >- On start of Thread Group, an additional TimerTask would be triggered
> >after duration + security margin and would do the following:
> >   - run equivalent (refactor) of code at:
> >  -
> >  https://github.com/apache/jmeter/blob/trunk/src/core/org/
> apache/jmeter/engine/StandardJMeterEngine.java#L326
> >
> > Cordialement.
> > Philippe Mouawad.
> > Ubik-Ingénierie
> >
> > UBIK LOAD PACK Web Site 
> >
> > UBIK LOAD PACK on TWITTER 
> >
>
>

Re: Remove comments about object ages in bin/jmeter

[Graham Russell]

+1 to remove the link (or replace with a modern alternative?)
+0 to remove the text

On Sun, 26 Nov 2017 at 21:35 Antonio Gomes Rodrigues 
wrote:

> Hi,
>
> In bin/jmeter we have
>
> #
> # Original page has disappeared, it is now only available at:
> #
>
> https://web.archive.org/web/20060614151434/http://www.atg.com/portal/myatg/developer?paf_dm=full_gear_id=1100010=true=9606
> #
> # JMeter objects can generally be grouped into three life-length groups:
> #
> # - Per-sample objects (results, DOMs,...). An awful lot of those.
> #   Life length of milliseconds to a few seconds.
> #
> # - Per-run objects (threads, listener data structures,...). Not that many
> #   of those unless we use the table or tree listeners on heavy runs.
> #   Life length of minutes to several hours, from creation to start of next
> run.
> #
> # - Per-work-session objects (test plans, GUIs,...).
> #   Life length: for the life of the JVM.
>
> The link is very old 2003 and not updated to G1 GC
>
> Moreover I find that the information given is useless
>
> O propose to remove these lines
>
> Antonio
>

Remove comments about object ages in bin/jmeter

[Antonio Gomes Rodrigues]

Hi,

In bin/jmeter we have

#
# Original page has disappeared, it is now only available at:
#
https://web.archive.org/web/20060614151434/http://www.atg.com/portal/myatg/developer?paf_dm=full_gear_id=1100010=true=9606
#
# JMeter objects can generally be grouped into three life-length groups:
#
# - Per-sample objects (results, DOMs,...). An awful lot of those.
#   Life length of milliseconds to a few seconds.
#
# - Per-run objects (threads, listener data structures,...). Not that many
#   of those unless we use the table or tree listeners on heavy runs.
#   Life length of minutes to several hours, from creation to start of next
run.
#
# - Per-work-session objects (test plans, GUIs,...).
#   Life length: for the life of the JVM.

The link is very old 2003 and not updated to G1 GC

Moreover I find that the information given is useless

O propose to remove these lines

Antonio

[GitHub] jmeter issue #343: Reduced the size of all screenshots.

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/343
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/343?src=pr=h1) 
Report
> Merging 
[#343](https://codecov.io/gh/apache/jmeter/pull/343?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/ffb434e7df9fa56358c99dbb8cda9119f63daf89?src=pr=desc)
 will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/343/graphs/tree.svg?height=150=pr=6Q7CI1wFSh=650)](https://codecov.io/gh/apache/jmeter/pull/343?src=pr=tree)

```diff
@@Coverage Diff@@
##  trunk #343   +/-   ##
=
  Coverage 58.06%   58.06%   
  Complexity1010010100   
=
  Files  1153 1153   
  Lines 7386873868   
  Branches   7337 7337   
=
  Hits  4289342893   
  Misses2849628496   
  Partials   2479 2479
```



--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/343?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/343?src=pr=footer). Last 
update 
[ffb434e...43e81ea](https://codecov.io/gh/apache/jmeter/pull/343?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #343: Reduced the size of all screenshots.

[ham1]

GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/343

Reduced the size of all screenshots.

## Description
Reduced size of all png screenshots using: `pngquant -f --ext .png 
--quality 70-95 *.png`.
Most were only reduced marginally but some were reduced a lot. This should 
probably be done for each new screenshot to ensure source control and the doc 
website loads as fast as possible.
Also: 
Removed workbench from a few screenshots.
Removed unused screenshots.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter doc_screenshots

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #343


commit 43e81eab0c44f82efd106b3ef2a3650d5429e0c9
Author: Graham Russell 
Date:   2017-11-26T17:48:59Z

Reduced the size of all screenshots.
Removed workbench from a few screenshots.
Removed unused screenshots.




---

[GitHub] jmeter issue #342: More edge cases for changeCase function and slight behavi...

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/342
  
+1 for trim
Ok for me to merge. 


---