[GitHub] jmeter issue #359: Added finals to fields where possible

2017-12-13 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/359
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/359?src=pr=h1) 
Report
> Merging 
[#359](https://codecov.io/gh/apache/jmeter/pull/359?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/427907f9d2ca45f8077acf9398a140834d75e3bd?src=pr=desc)
 will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/359/graphs/tree.svg?width=650=150=6Q7CI1wFSh=pr)](https://codecov.io/gh/apache/jmeter/pull/359?src=pr=tree)

```diff
@@Coverage Diff@@
##  trunk #359   +/-   ##
=
  Coverage 58.19%   58.19%   
  Complexity1021010210   
=
  Files  1161 1161   
  Lines 7418974189   
  Branches   7322 7322   
=
  Hits  4317443174   
  Misses2851728517   
  Partials   2498 2498
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/359?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...rotocol/jdbc/config/DataSourceElementBeanInfo.java](https://codecov.io/gh/apache/jmeter/pull/359/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2pkYmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvamRiYy9jb25maWcvRGF0YVNvdXJjZUVsZW1lbnRCZWFuSW5mby5qYXZh)
 | `90.14% <100%> (ø)` | `5 <0> (ø)` | :arrow_down: |
| 
[...jmeter/protocol/http/control/HC4CookieHandler.java](https://codecov.io/gh/apache/jmeter/pull/359/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL0hDNENvb2tpZUhhbmRsZXIuamF2YQ==)
 | `86.44% <100%> (ø)` | `21 <0> (ø)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/359?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/359?src=pr=footer). Last 
update 
[427907f...cc5154f](https://codecov.io/gh/apache/jmeter/pull/359?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #360: Reordered menus.

2017-12-13 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/360
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/360?src=pr=h1) 
Report
> Merging 
[#360](https://codecov.io/gh/apache/jmeter/pull/360?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/427907f9d2ca45f8077acf9398a140834d75e3bd?src=pr=desc)
 will **increase** coverage by `0.01%`.
> The diff coverage is `12.4%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/360/graphs/tree.svg?height=150=650=6Q7CI1wFSh=pr)](https://codecov.io/gh/apache/jmeter/pull/360?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #360  +/-   ##

+ Coverage 58.19%   58.21%   +0.01% 
  Complexity1021010210  

  Files  1161 1162   +1 
  Lines 7418974160  -29 
  Branches   7322 7302  -20 

- Hits  4317443169   -5 
+ Misses2851728492  -25 
- Partials   2498 2499   +1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/360?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...apache/jmeter/extractor/gui/RegexExtractorGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL2d1aS9SZWdleEV4dHJhY3Rvckd1aS5qYXZh)
 | `89.79% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| 
[.../apache/jmeter/extractor/gui/HtmlExtractorGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL2d1aS9IdG1sRXh0cmFjdG9yR3VpLmphdmE=)
 | `85.59% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| 
[...rg/apache/jmeter/assertions/ResponseAssertion.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9SZXNwb25zZUFzc2VydGlvbi5qYXZh)
 | `78.22% <ø> (ø)` | `83 <0> (ø)` | :arrow_down: |
| 
[...r/protocol/http/control/gui/HttpTestSampleGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL2d1aS9IdHRwVGVzdFNhbXBsZUd1aS5qYXZh)
 | `85.71% <ø> (ø)` | `24 <0> (ø)` | :arrow_down: |
| 
[.../org/apache/jmeter/assertions/JSR223Assertion.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9KU1IyMjNBc3NlcnRpb24uamF2YQ==)
 | `65% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| 
[...pache/jmeter/timers/gui/UniformRandomTimerGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL2d1aS9Vbmlmb3JtUmFuZG9tVGltZXJHdWkuamF2YQ==)
 | `100% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| 
[...nts/org/apache/jmeter/extractor/JoddExtractor.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL0pvZGRFeHRyYWN0b3IuamF2YQ==)
 | `80.76% <ø> (ø)` | `8 <0> (ø)` | :arrow_down: |
| 
[...eter/protocol/http/config/gui/HttpDefaultsGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb25maWcvZ3VpL0h0dHBEZWZhdWx0c0d1aS5qYXZh)
 | `80.78% <ø> (ø)` | `21 <0> (ø)` | :arrow_down: |
| 
[...s/org/apache/jmeter/visualizers/SummaryReport.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvU3VtbWFyeVJlcG9ydC5qYXZh)
 | `72.16% <ø> (ø)` | `10 <0> (ø)` | :arrow_down: |
| 
[...ts/org/apache/jmeter/extractor/JSoupExtractor.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL0pTb3VwRXh0cmFjdG9yLmphdmE=)
 | `84.21% <ø> (ø)` | `8 <0> (ø)` | :arrow_down: |
| ... and [26 
more](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/360?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/360?src=pr=footer). Last 
update 
[427907f...fc7e50f](https://codecov.io/gh/apache/jmeter/pull/360?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #360: Reordered menus. With some drive-by tidying up.

2017-12-13 Thread ham1 
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/360

Reordered menus. With some drive-by tidying up.

## Description

Added ability for MenuFactory to add separators to menus.
Some TestBeanGUI refactoring for reformatting.
New Spock test.
Refactored AbstractThreadGroupGui menu creation.
Cleaned up horrible if sequence and unneeded variables

## How Has This Been Tested?
`ant test` and manually

## Screenshots (if appropriate):


![test-plan_menu](https://user-images.githubusercontent.com/3393038/33964457-6dbbb87c-e050-11e7-816c-c409da44fcc5.png)

![thread](https://user-images.githubusercontent.com/3393038/33964458-6ddc6f4a-e050-11e7-9f49-06168c5ba20b.png)

![sampler](https://user-images.githubusercontent.com/3393038/33964456-6d943dce-e050-11e7-9e10-6b6cfe200fbc.png)

## Types of changes
- Bug fix (non-breaking change which fixes an issue)

## Checklist:


- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter menu_sort_order

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #360


commit fc7e50fd28cde7760d0bc581f3513823abb0b2f3
Author: Graham Russell 
Date:   2017-12-13T21:43:51Z

Reordered menus. With some drive-by tidying up.
Added ability for MenuFactory to add separators to menus.
Some TestBeanGUI refactoring for reformatting.
New Spock test.
Refactored AbstractThreadGroupGui menu creation.
Cleaned up horrible if sequence and unneeded variables




---

[GitHub] jmeter pull request #359: Added finals to fields where possible

2017-12-13 Thread ham1 
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/359

Added finals to fields where possible



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter final

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/359.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #359


commit f46d1c4d57d67a9fb137ba981fe9ef6e73d5ecaa
Author: Graham Russell 
Date:   2017-12-13T20:31:34Z

added final




---