buildbot success in on jmeter-nightly

2017-12-23 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-nightly while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-nightly/builds/881

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_1604_test_ubuntu

Build Reason: The Nightly scheduler named 'jmeterNightly' triggered this build
Build Source Stamp: [branch jmeter/trunk] HEAD
Blamelist: 

Build succeeded!

Sincerely,
 -The Buildbot

[GitHub] jmeter pull request #368: Csv sample reader fix

2017-12-23 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/368


---

[GitHub] jmeter issue #368: Csv sample reader fix

2017-12-23 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/368
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr=h1) 
Report
> Merging 
[#368](https://codecov.io/gh/apache/jmeter/pull/368?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/998b3302a10ad8f298c12e67e08369f5a205018d?src=pr=desc)
 will **increase** coverage by `0.01%`.
> The diff coverage is `81.25%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/368/graphs/tree.svg?width=650=150=pr=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/368?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #368  +/-   ##

+ Coverage 58.35%   58.36%   +0.01% 
- Complexity1028810290   +2 

  Files  1164 1164  
  Lines 7412774126   -1 
  Branches   7298 7298  

+ Hits  4325443266  +12 
+ Misses2835928349  -10 
+ Partials   2514 2511   -3
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/368?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...apache/jmeter/report/core/CsvSampleReaderTest.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvQ3N2U2FtcGxlUmVhZGVyVGVzdC5qYXZh)
 | `78.18% <100%> (+4.49%)` | `11 <1> (-1)` | :arrow_down: |
| 
[...org/apache/jmeter/report/core/CsvSampleReader.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvQ3N2U2FtcGxlUmVhZGVyLmphdmE=)
 | `57.57% <50%> (+0.65%)` | `12 <0> (ø)` | :arrow_down: |
| 
[src/core/org/apache/jmeter/report/core/Sample.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvU2FtcGxlLmphdmE=)
 | `41.02% <0%> (+2.56%)` | `11% <0%> (+1%)` | :arrow_up: |
| 
[...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh)
 | `30.95% <0%> (+3.17%)` | `11% <0%> (+1%)` | :arrow_up: |
| 
[...re/org/apache/jmeter/engine/DistributedRunner.java](https://codecov.io/gh/apache/jmeter/pull/368/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZW5naW5lL0Rpc3RyaWJ1dGVkUnVubmVyLmphdmE=)
 | `85.95% <0%> (+4.13%)` | `32% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/368?src=pr=footer). Last 
update 
[998b330...083b1ae](https://codecov.io/gh/apache/jmeter/pull/368?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

2017-12-23 Thread vlsi 
Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/231
  
> Philippe: It is just that as per your confirmation, one of the aims of 
this new component was:
> Vladimir: "The very basic requirement is to ensure you end up exactly 50 
iterations **per hour**.
> Philippe: That's why I tested such things, so I think it needs to be 
mitigated a bit.

Please, be careful: I suggested 50 per **hour**, and you are testing 50 per 
**second**. That is 3600 times higher rate than I suggested. I don't mean the 
timer works for 50/hour rate only, but 50/second is a bit different thing.

>Now regarding "Repeatable test profile", for 2 runs, I don't see "similar 
test profile"

Let us consider "10 second test with 1 per second on average".
Current implementation writes "o.a.j.t.ConstantPoissonProcessGenerator: 
Generated ..." log record with expected timestamps of the samples.
```
2017-12-23 21:39:01,449 INFO o.a.j.t.ConstantPoissonProcessGenerator: 
Generated 11 timings (ExponentialTimer 10 required, rate 1.0, duration 10, 
exact lim 2, i11) in 0 ms, restar
t was issued 12 times. First 15 events will be fired at: 
0.11401676510964737 (+0.11401676510964737), 0.6130748250774025 
(+0.49905805996775515), 3.342639426533685 (+2.7295646014562824
), 3.377172823174598 (+0.03453339664091315), 5.112423358789579 
(+1.735250535614981), 5.1755972505795125 (+0.06317389178993338), 
5.514713410628992 (+0.3391161600494792), 7.94457420086467 
(+2.4298607902356784), 8.509235493336268 (+0.5646612924715981), 8.5888989163364 
(+0.07966342300013096), 10.107204382018718 (+1.5183054656823192)
```

A bit more readable: 0.1, 0.6, 3.3, 3.4, 5.1, 5.2, 5.5, 7.9, 8.5, 8.6, 10.1 
seconds. Note: there's exactly 10 samples in between 0..10 sec.

Let me restart the test:
```
2017-12-23 21:40:19,752 INFO o.a.j.t.ConstantPoissonProcessGenerator: 
Generated 11 timings (ExponentialTimer 10 required, rate 1.0, duration 10, 
exact lim 2, i11) in 0 ms, restart was issued 12 times. First 15 events 
will be fired at: 0.11401676510964737 (+0.11401676510964737), 
0.6130748250774025 (+0.49905805996775515), 3.342639426533685 
(+2.7295646014562824
), 3.377172823174598 (+0.03453339664091315), 5.112423358789579 
(+1.735250535614981), 5.1755972505795125 (+0.06317389178993338), 
5.514713410628992 (+0.3391161600494792), 7.94457420086467 
(+2.4298607902356784), 8.509235493336268 (+0.5646612924715981), 8.5888989163364 
(+0.07966342300013096), 10.107204382018718 (+1.5183054656823192)
```

Note: the timestamps are exactly the same (the log timestamp is different, 
so it is a different execution).

This is super-useful when testing low-rate things (e.g. 100 per hour) as it 
enables to have the same load profile, thus there's less moving parts when 
comparing different runs. Otherwise it is hard to tell if the difference in 
"CPU usage" profile is caused by different sample sequence or different system 
under test behavior.

Note: in order for "repeatable test profile" to work, you need to set 
non-zero "randomSeed" (see 
https://github.com/apache/jmeter/pull/231/files#diff-76a5e8f118fb5e533f52ea80fd10dd0bR58
 )
Unfortunately, JMeter is unable to initialize "test element property with a 
random-generated value". Test elements are created with constant values only, 
so I had to resort to a 0 being "random". I agree this is more like "easier for 
developer" rather than "easier for JMeter user", however I'm not sure what is 
JMeter way of doing that config.



>Finally regarding Batched Departures, I am not sure to understand how it 
is supposed to influence load and if it is supposed to work correctly with 
First part in GUI.

The idea is "batched departures" keep the load level (total number of 
samples per hour), however the samples are scheduled to come in pairs, triples, 
etc.
For instance, with "batch size=2, throughput=10, duration=10" it produces 
samples as follows: 0.52, 0.52, 0.67, 0.67, 3.4, 3.4, 9.37, 9.37, 9.43, 9.43.

Does the above make sense?

PS. That is why I was saying [the documentation is 
missing](https://github.com/apache/jmeter/pull/231#issuecomment-342008122)




---

[GitHub] jmeter pull request #368: Csv sample reader fix

2017-12-23 Thread ham1 
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/368

Csv sample reader fix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter CsvSampleReader_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/368.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #368


commit f4e310901f8e108736ae0b27cfaebbc987761549
Author: Graham Russell 
Date:   2017-12-23T18:09:37Z

Added extra test and fixed failure

commit 083b1ae4ccbc9382ee09b77d69a4fb50b70ea2c0
Author: Graham Russell 
Date:   2017-12-23T18:37:43Z

Formatting and tidy




---

[GitHub] jmeter issue #365: Expanded Checkstyle to files in src and test; fixed newly...

2017-12-23 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/365
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=h1) 
Report
> Merging 
[#365](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/998b3302a10ad8f298c12e67e08369f5a205018d?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `60.71%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/365/graphs/tree.svg?width=650=150=6Q7CI1wFSh=pr)](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #365  +/-   ##

+ Coverage 58.35%   58.35%   +<.01% 
- Complexity1028810290   +2 

  Files  1164 1164  
  Lines 7412774135   +8 
  Branches   7298 7298  

+ Hits  4325443263   +9 
  Misses2835928359  
+ Partials   2514 2513   -1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...mpler/TestHTTPSamplersAgainstHttpMirrorServer.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL1Rlc3RIVFRQU2FtcGxlcnNBZ2FpbnN0SHR0cE1pcnJvclNlcnZlci5qYXZh)
 | `89.75% <ø> (ø)` | `80 <0> (ø)` | :arrow_down: |
| 
[...g/apache/jmeter/assertions/SMIMEAssertionTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9TTUlNRUFzc2VydGlvblRlc3QuamF2YQ==)
 | `100% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| 
[...er/protocol/http/control/TestHTTPMirrorThread.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL1Rlc3RIVFRQTWlycm9yVGhyZWFkLmphdmE=)
 | `90% <ø> (ø)` | `26 <0> (ø)` | :arrow_down: |
| 
[...apache/jmeter/functions/TestTimeShiftFunction.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1Rlc3RUaW1lU2hpZnRGdW5jdGlvbi5qYXZh)
 | `89.32% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| 
[...pache/jmeter/assertions/ResponseAssertionTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9SZXNwb25zZUFzc2VydGlvblRlc3QuamF2YQ==)
 | `99.03% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| 
[...t/src/org/apache/jmeter/functions/PackageTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1BhY2thZ2VUZXN0LmphdmE=)
 | `91.63% <ø> (ø)` | `25 <0> (ø)` | :arrow_down: |
| 
[...rg/apache/jmeter/visualizers/TestRenderAsJson.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvVGVzdFJlbmRlckFzSnNvbi5qYXZh)
 | `100% <ø> (ø)` | `10 <0> (ø)` | :arrow_down: |
| 
[.../org/apache/jmeter/functions/ChangeCaseSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL0NoYW5nZUNhc2VTcGVjLmdyb292eQ==)
 | `100% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| 
[...che/jmeter/protocol/http/config/UrlConfigTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb25maWcvVXJsQ29uZmlnVGVzdC5qYXZh)
 | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| 
[...est/src/org/apache/jorphan/util/TestConverter.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qb3JwaGFuL3V0aWwvVGVzdENvbnZlcnRlci5qYXZh)
 | `100% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| ... and [29 
more](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=footer). Last 
update 
[998b330...08615ed](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #366: Set max line length to 160 (eventual target 120).

2017-12-23 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/366
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/366?src=pr=h1) 
Report
> Merging 
[#366](https://codecov.io/gh/apache/jmeter/pull/366?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/998b3302a10ad8f298c12e67e08369f5a205018d?src=pr=desc)
 will **increase** coverage by `0.01%`.
> The diff coverage is `47.81%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/366/graphs/tree.svg?width=650=150=pr=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/366?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #366  +/-   ##

+ Coverage 58.35%   58.36%   +0.01% 
- Complexity1028810289   +1 

  Files  1164 1164  
  Lines 7412774225  +98 
  Branches   7298 7305   +7 

+ Hits  4325443323  +69 
- Misses2835928389  +30 
+ Partials   2514 2513   -1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/366?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...apache/jmeter/control/gui/ModuleControllerGui.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvY29udHJvbC9ndWkvTW9kdWxlQ29udHJvbGxlckd1aS5qYXZh)
 | `30.76% <ø> (ø)` | `8 <0> (ø)` | :arrow_down: |
| 
[...jmeter/protocol/http/util/accesslog/LogFilter.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC91dGlsL2FjY2Vzc2xvZy9Mb2dGaWx0ZXIuamF2YQ==)
 | `81.3% <ø> (ø)` | `35 <0> (ø)` | :arrow_down: |
| 
[...rg/apache/jmeter/util/keystore/JmeterKeyStore.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9rZXlzdG9yZS9KbWV0ZXJLZXlTdG9yZS5qYXZh)
 | `19.54% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| 
[...ts/org/apache/jmeter/visualizers/RenderAsJSON.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvUmVuZGVyQXNKU09OLmphdmE=)
 | `60% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| 
[...g/apache/jmeter/samplers/AbstractSampleSender.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvc2FtcGxlcnMvQWJzdHJhY3RTYW1wbGVTZW5kZXIuamF2YQ==)
 | `80% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| 
[...protocol/http/sampler/LazySchemeSocketFactory.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL0xhenlTY2hlbWVTb2NrZXRGYWN0b3J5LmphdmE=)
 | `66.66% <ø> (ø)` | `5 <0> (ø)` | :arrow_down: |
| 
[.../org/apache/jmeter/report/core/SampleMetadata.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvU2FtcGxlTWV0YWRhdGEuamF2YQ==)
 | `26.08% <ø> (ø)` | `8 <0> (ø)` | :arrow_down: |
| 
[.../backend/graphite/PickleGraphiteMetricsSender.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9ncmFwaGl0ZS9QaWNrbGVHcmFwaGl0ZU1ldHJpY3NTZW5kZXIuamF2YQ==)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...er/protocol/http/proxy/AbstractSamplerCreator.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9wcm94eS9BYnN0cmFjdFNhbXBsZXJDcmVhdG9yLmphdmE=)
 | `59.37% <ø> (ø)` | `6 <0> (ø)` | :arrow_down: |
| 
[...er/protocol/http/modifier/RegExUserParameters.java](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9tb2RpZmllci9SZWdFeFVzZXJQYXJhbWV0ZXJzLmphdmE=)
 | `27.08% <0%> (-0.58%)` | `9 <0> (ø)` | |
| ... and [32 
more](https://codecov.io/gh/apache/jmeter/pull/366/diff?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/366?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/366?src=pr=footer). Last 
update 
[998b330...408b0ad](https://codecov.io/gh/apache/jmeter/pull/366?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

2017-12-23 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/231
  
Hi @vlsi ,
Thanks for your clarifications.
It is just that as per your confirmation, one of the aims of this new 
component was:
**"The very basic requirement is to ensure you end up exactly 50
iterations per hour.
Business customers would not understand if you report load test
results with 47 executions "just because the random was random"."**

That's why I tested such things, so I think it needs to be mitigated a bit.
I tested with 1000 hits for 2 minutes and I get 1002 hits so ok.

Now regarding "Repeatable test profile", for 2 runs, I don't see "similar 
test profile", but it is maybe just a matter of interpretation, what is exactly 
expected in your aim for "Repeatable test profile" 


Finally regarding Batched Departures, I am not sure to understand how it is 
supposed to influence load and if it is supposed to work correctly with First 
part in GUI.

Thanks for clarifications.
Regards


---

[GitHub] jmeter pull request #367: Improved SampleMetadataParserSpec

2017-12-23 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/367


---

[GitHub] jmeter issue #367: Improved SampleMetadataParserSpec

2017-12-23 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/367
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/367?src=pr=h1) 
Report
> Merging 
[#367](https://codecov.io/gh/apache/jmeter/pull/367?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/ad3e1fb31a447d84a72f8b353c0a59dbf0728b6a?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/367/graphs/tree.svg?width=650=150=6Q7CI1wFSh=pr)](https://codecov.io/gh/apache/jmeter/pull/367?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #367  +/-   ##

+ Coverage 58.35%   58.36%   +<.01% 
- Complexity1028910291   +2 

  Files  1164 1164  
  Lines 7412774127  
  Branches   7298 7298  

+ Hits  4325843264   +6 
+ Misses2835528350   -5 
+ Partials   2514 2513   -1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/367?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...jmeter/report/core/SampleMetadataParserSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/367/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvU2FtcGxlTWV0YWRhdGFQYXJzZXJTcGVjLmdyb292eQ==)
 | `100% <100%> (ø)` | `1 <1> (ø)` | :arrow_down: |
| 
[...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/367/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh)
 | `30.95% <0%> (+3.17%)` | `11% <0%> (+1%)` | :arrow_up: |
| 
[...s/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/367/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL1BvaXNzb25SYW5kb21UaW1lci5qYXZh)
 | `78.37% <0%> (+5.4%)` | `10% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/367?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/367?src=pr=footer). Last 
update 
[ad3e1fb...f8603b5](https://codecov.io/gh/apache/jmeter/pull/367?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

2017-12-23 Thread vlsi 
Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/231
  
>Is it really supposed to be exact ?

Let me ask another question: "is thread scheduler=120sec supposed to make 
the test to last exactly 120 seconds"?

Note: **timers do not limit the number of samples** in JMeter. If you want 
to limit the number of iterations (e.g. to make exactly 1 samples), you'd 
use additional counter or something like that.

1) When I try "startupdelay=0, duration=120sec, threads=10, 
throughput=1", I get 10011 samples in the aggregate report. I think it good 
enough to be considered exact.

Note: target throughput is 1/120=83.3 samples/sec.  
11samples/(1/120)=0.13 sec. That is those 11 "extra" samples can be due to 
130ms spent on initialization/finalization of the test (e.g. in between "test 
started" and "threads started")

2) "exact number of samples" makes sense for cases like 10-100-1000 per 
HOUR, not 5000 per minute.  I don't think there are requirements to aim for 
"exactly 1 per minute". In case there are that requirements, I would still 
discuss that in a separate PR as it would be tightly related with thread 
startup time, etc.
Have you tried to test rates like 0.5...1 per second?



---

Jenkins build is back to normal : JMeter Windows #951

2017-12-23 Thread Apache Jenkins Server 
See

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

2017-12-23 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/231
  
Hi @vlsi ,
Thanks for your feedback.
I tried many configurations including thread delay to 0, and I never really 
reach exact sampling on duration.
Is it really supposed to be exact ?

https://user-images.githubusercontent.com/3127467/34321041-0999c088-e806-11e7-9409-657186ef92ba.png;>
https://user-images.githubusercontent.com/3127467/34321042-09b21da4-e806-11e7-980f-0d8f0f9c15fc.png;>
https://user-images.githubusercontent.com/3127467/34321043-09ca845c-e806-11e7-81c1-e92f53677bf5.png;>



---

Jenkins build is back to normal : JMeter-trunk #6560

2017-12-23 Thread Apache Jenkins Server 
See

buildbot success in on jmeter-trunk

2017-12-23 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3384

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1819164
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

Build failed in Jenkins: JMeter-trunk #6559

2017-12-23 Thread Apache Jenkins Server 
See 


Changes:

[pmouawad] Bug 61900 - Report Generator : Report generation fails if separator 
is a regex reserved char like '|'
Bugzilla Id: 61900

[pmouawad] Add files being compiled

[pmouawad] Ignore failing test for now

[pmouawad] Fix typo

--
[...truncated 446.85 KB...]
  [javadoc] Loading source files for package org.apache.jmeter.sampler.gui...
  [javadoc] Loading source files for package org.apache.jmeter.thinktime...
  [javadoc] Loading source files for package org.apache.jmeter.validation...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.graphite...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.influxdb...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.utils...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.parser...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.sampler.hc...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.util...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.util.accesslog...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.sampler...
  [javadoc] Loading source files for package org.apache.jmeter.protocol.jdbc...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.test...
  [javadoc] Loading source files for package org.apache.jorphan.collections...
  [javadoc] Loading source files for package org.apache.jorphan.exec...
  [javadoc] Loading source files for package org.apache.jorphan.gui...
  [javadoc] Loading source files for package org.apache.jorphan.gui.layout...
  [javadoc] Loading source files for package org.apache.jorphan.io...
  [javadoc] Loading source files for package org.apache.jorphan.logging...
  [javadoc] Loading source files for package org.apache.jorphan.math...
  [javadoc] Loading source files for package org.apache.jorphan.reflect...
  [javadoc] Loading source files for package org.apache.jorphan.test...
  [javadoc] Loading source files for package org.apache.jorphan.util...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.sampler.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.testbeans.example1...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.testbeans.example2...
  [javadoc] Loading source

buildbot failure in on jmeter-trunk

2017-12-23 Thread buildbot 
The Buildbot has detected a new failure on builder jmeter-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3383

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1819161
Blamelist: pmouawad

BUILD FAILED: failed shell_3

Sincerely,
 -The Buildbot

buildbot success in on jmeter-trunk

2017-12-23 Thread buildbot 
The Buildbot has detected a restored build on builder jmeter-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-trunk/builds/3382

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave1_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-jmeter-commit' 
triggered this build
Build Source Stamp: [branch jmeter/trunk] 1819159
Blamelist: pmouawad

Build succeeded!

Sincerely,
 -The Buildbot

Build failed in Jenkins: JMeter-trunk #6558

2017-12-23 Thread Apache Jenkins Server 
See 


Changes:

[pmouawad] Bug 61759 - New __changeCase function
Remove useless message labels as per orimarko patch
Bugzilla Id: 61759

--
[...truncated 142.60 KB...]
  [javadoc] Loading source files for package org.apache.jmeter.thinktime...
  [javadoc] Loading source files for package org.apache.jmeter.validation...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.graphite...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.backend.influxdb...
  [javadoc] Loading source files for package 
org.apache.jmeter.visualizers.utils...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.modifier.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.parser...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.proxy.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.sampler.hc...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.util...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.util.accesslog...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.http.visualizers...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ftp.sampler...
  [javadoc] Loading source files for package org.apache.jmeter.protocol.jdbc...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.processor...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.jdbc.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.config...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.java.test...
  [javadoc] Loading source files for package org.apache.jorphan.collections...
  [javadoc] Loading source files for package org.apache.jorphan.exec...
  [javadoc] Loading source files for package org.apache.jorphan.gui...
  [javadoc] Loading source files for package org.apache.jorphan.gui.layout...
  [javadoc] Loading source files for package org.apache.jorphan.io...
  [javadoc] Loading source files for package org.apache.jorphan.logging...
  [javadoc] Loading source files for package org.apache.jorphan.math...
  [javadoc] Loading source files for package org.apache.jorphan.reflect...
  [javadoc] Loading source files for package org.apache.jorphan.test...
  [javadoc] Loading source files for package org.apache.jorphan.util...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.ldap.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.config.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.control.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.tcp.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.sampler...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.sampler.gui...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.testbeans.example1...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.testbeans.example2...
  [javadoc] Loading source files for package 
org.apache.jmeter.examples.testbeans.example3...
  [javadoc] Loading source files for package 
org.apache.jmeter.protocol.mail.sampler...
  [javadoc] Loading source files

[GitHub] jmeter pull request #366: Set max line length to 160 (eventual target 120).

2017-12-23 Thread ham1 
GitHub user ham1 opened a pull request:

https://github.com/apache/jmeter/pull/366

 Set max line length to 160 (eventual target 120). 

## Description
Added new checkstyle rule for max line length of 160; with the view to, 
eventually, make it around 120. I will create another PR with the rest of the 
changes from #358 once this is merged as it should make merging slightly easier.

Hopefully reducing the scope and splitting this into commits that each 
change a separate thing will help merging - let me know if it's too much and I 
could split further if required.

## Motivation and Context
This PR will prevent any extra long lines and extra long anonymous inner 
classes being accidentally added.

## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.

[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ham1/jmeter max_line_length

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #366


commit c02a4e7529cea8ea043fd918073f0b60774d1729
Author: Graham Russell 
Date:   2017-12-23T13:59:56Z

Set max line length to 160 (eventual target 120).

commit 00ab78f50374027f7506a8143fdbbfc07dbdc21c
Author: Graham Russell 
Date:   2017-12-23T14:02:05Z

removed blank lines and superfluous comments

commit 6dd2f65d48957adc81373919fcba77c0c6355c5b
Author: Graham Russell 
Date:   2017-12-23T14:02:24Z

formatting and spelling




---