Re: [VOTE] Release JMeter 5.0 RC2

2018-09-16 Thread Jmeter Tea
Thanks for adding init script support
[+1] I support this release

On Mon, Sep 17, 2018 at 12:23 AM, Philippe Mouawad <
p.moua...@ubik-ingenierie.com> wrote:

> Hello,
> Thanks for preparing the release.
>
> My vote:
>
> [+1] I support this release
>
> Regards
> Philippe M.
>
> On Friday, September 14, 2018, Milamber  wrote:
>
> > Hello,
> >
> > The second release candidate for JMeter 5.0 (r1840935) has been prepared,
> > and your votes are solicited.
> >
> > This release brings a lot of new features and improvements, and also
> fixes
> > bugs.
> >
> > Please, test this release candidate (with load tests and/or functional
> > tests) using Java 8+ on Linux/Windows/Mac OS, especially on the changes.
> > Feedback is very welcome within the next 72 hours.
> >
> > You can read the New and Noteworthy section with some screenshots to
> > illustrate improvements and full list of changes at:
> > http://home.apache.org/~milamber/jmeter-5.0RC2/docs/changes.html
> >
> > JMeter is a Java desktop application designed to load test functional
> > behavior and measure performance. The current version targets Java 8+.
> >
> > Download - Archives/hashes/sigs:
> >
> > https://dist.apache.org/repos/dist/dev/jmeter/v5.0_RC2/
> > (dist revision r29390)
> >
> > RAT report:
> >
> > http://home.apache.org/~milamber/jmeter-5.0RC2/dist/rat-
> > report-jmeter-5.0RC2.txt
> >
> > SHA512 hashes of archives for this vote: see footnote [1]
> >
> > Site Docs are here:
> > http://home.apache.org/~milamber/jmeter-5.0RC2/docs/
> >
> > Maven staging repository is accessible here:
> > https://repository.apache.org/content/repositories/orgapache
> > jmeter-1033/org/apache/jmeter/
> >
> > Tag:
> > https://svn.apache.org/repos/asf/jmeter/tags/v5_0_RC2/
> >
> > Keys are here:
> > https://www.apache.org/dist/jmeter/KEYS
> >
> > N.B.
> > To download the dependencies: "ant download_jars"
> >
> > To create the jars and test JMeter: "ant package test".
> >
> > JMeter 5.0 requires Java 8 or later to run.
> >
> > Some known issues and incompatible changes are listed on changes page.
> > http://home.apache.org/~milamber/jmeter-5.0RC2/docs/changes.
> > html#Known%20problems%20and%20workarounds
> >
> >
> > All feedback and vote are welcome.
> >
> > [  ] +1  I support this release
> > [  ] +0  I am OK with this release
> > [  ] -0   OK, but
> > [  ] -1   I do not support this release (please indicate why)
> >
> > The vote will remain open for at least 72 hours.
> >
> > The PMC members please indicate the mention "(binding)" with your vote.
> >
> >
> > Note: If the vote passes, the intention is to release the archive files
> > and rename the RC tag as the release tag.
> >
> > Thanks in advance!
> >
> > Milamber
> >
> >
> > ===
> > [1] SHA512 hashes of archives for this vote:
> >
> > a5a3bdd84ec8f78b67cee1b12bd9f2f578f3e9334ef2dc85cebd37878e0c
> > f69ea3385a9c4f531dae094c0a4df93f262f43c2d9a9dfb10d38565d17eec3f907f1
> > *apache-jmeter-5.0.tgz
> > 26d4cf65cce0ef008f8ef5955ef0d28e0bef310f2a75a36fe78fcc5f4ff9
> > a6853071be0dd5140815834ca533e88224d766917b7ed2eb5168dc859b35eda5d2dc
> > *apache-jmeter-5.0_src.tgz
> > c0b65879db8cbc7ed25de96b869ed3b703ceecad3acbf7fe726f101bd5d6
> > 5f22443168eac4676c98d8cb55719de453efcb3bf699d02ca4ce4137ef0c594505fa
> > *apache-jmeter-5.0.zip
> > f3a4400cea7431b6c1e59cf2498bf70c526eb06f5016dbdf5423d153
> > 0549b4555d3eedafe305c51c996adb0543c186d54c0c4979bbac9b8f5269630a1df1
> > *apache-jmeter-5.0_src.zip
> >
> >
> >
> >
> >
>
> --
> Cordialement.
> Philippe Mouawad.
> Ubik-Ingénierie
>
> UBIK LOAD PACK Web Site 
>
> UBIK LOAD PACK on TWITTER 
>


buildbot failure in on jmeter-nightly

2018-09-16 Thread buildbot
The Buildbot has detected a new failure on builder jmeter-nightly while 
building . Full details are available at:
https://ci.apache.org/builders/jmeter-nightly/builds/1158

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: bb_slave7_ubuntu

Build Reason: The Nightly scheduler named 'jmeterNightly' triggered this build
Build Source Stamp: [branch jmeter/trunk] HEAD
Blamelist: 

BUILD FAILED: failed shell_5

Sincerely,
 -The Buildbot





Re: [VOTE] Release JMeter 5.0 RC2

2018-09-16 Thread Philippe Mouawad
Hello,
Thanks for preparing the release.

My vote:

[+1] I support this release

Regards
Philippe M.

On Friday, September 14, 2018, Milamber  wrote:

> Hello,
>
> The second release candidate for JMeter 5.0 (r1840935) has been prepared,
> and your votes are solicited.
>
> This release brings a lot of new features and improvements, and also fixes
> bugs.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 8+ on Linux/Windows/Mac OS, especially on the changes.
> Feedback is very welcome within the next 72 hours.
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> http://home.apache.org/~milamber/jmeter-5.0RC2/docs/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version targets Java 8+.
>
> Download - Archives/hashes/sigs:
>
> https://dist.apache.org/repos/dist/dev/jmeter/v5.0_RC2/
> (dist revision r29390)
>
> RAT report:
>
> http://home.apache.org/~milamber/jmeter-5.0RC2/dist/rat-
> report-jmeter-5.0RC2.txt
>
> SHA512 hashes of archives for this vote: see footnote [1]
>
> Site Docs are here:
> http://home.apache.org/~milamber/jmeter-5.0RC2/docs/
>
> Maven staging repository is accessible here:
> https://repository.apache.org/content/repositories/orgapache
> jmeter-1033/org/apache/jmeter/
>
> Tag:
> https://svn.apache.org/repos/asf/jmeter/tags/v5_0_RC2/
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To download the dependencies: "ant download_jars"
>
> To create the jars and test JMeter: "ant package test".
>
> JMeter 5.0 requires Java 8 or later to run.
>
> Some known issues and incompatible changes are listed on changes page.
> http://home.apache.org/~milamber/jmeter-5.0RC2/docs/changes.
> html#Known%20problems%20and%20workarounds
>
>
> All feedback and vote are welcome.
>
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0   OK, but
> [  ] -1   I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
>
> ===
> [1] SHA512 hashes of archives for this vote:
>
> a5a3bdd84ec8f78b67cee1b12bd9f2f578f3e9334ef2dc85cebd37878e0c
> f69ea3385a9c4f531dae094c0a4df93f262f43c2d9a9dfb10d38565d17eec3f907f1
> *apache-jmeter-5.0.tgz
> 26d4cf65cce0ef008f8ef5955ef0d28e0bef310f2a75a36fe78fcc5f4ff9
> a6853071be0dd5140815834ca533e88224d766917b7ed2eb5168dc859b35eda5d2dc
> *apache-jmeter-5.0_src.tgz
> c0b65879db8cbc7ed25de96b869ed3b703ceecad3acbf7fe726f101bd5d6
> 5f22443168eac4676c98d8cb55719de453efcb3bf699d02ca4ce4137ef0c594505fa
> *apache-jmeter-5.0.zip
> f3a4400cea7431b6c1e59cf2498bf70c526eb06f5016dbdf5423d153
> 0549b4555d3eedafe305c51c996adb0543c186d54c0c4979bbac9b8f5269630a1df1
> *apache-jmeter-5.0_src.zip
>
>
>
>
>

-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site 

UBIK LOAD PACK on TWITTER 


Re: JMeter send double requests when configure proxy with authentication

2018-09-16 Thread Philippe Mouawad
Thanks for last PR update.
We'll merge it once 5.0 is released;

But before, could you describe the use case met that made you see this
issue ?
Is the a possibility to provide  a JMX Test plan that could be used as
integration test ? and if possible a JUnit test ?

Thanks

On Sat, Sep 1, 2018 at 4:02 PM Philippe Mouawad 
wrote:

> Hello,
> Thanks for latest updates of PR.
> 1/ I would not use Object but AuthState instead.
>
> 2/ Shouldn't we use HTTPCLIENTS_CACHE_PER_THREAD_AND_HTTPCLIENTKEY and
> store AuthState there (transforming Pair to Triple)?
>
> This would be the case for a Thread representing a Virtual User.
> But it would not be correct if a thread is not a Virtual User
>
>
> Regards
>
> On Wed, Aug 29, 2018 at 11:14 AM Artem Fedorov <
> artem.fedo...@blazemeter.com> wrote:
>
>> Fixed.
>>
>> Regarding (HttpClientContext.PROXY_AUTH_STATE + this) I also have doubts:
>>
>> - minimal number of authstate, that we should store = Number of Requests
>> in
>> Test Plan. (each request can use own proxy). Does the AuthState is Thread
>> Safe and we can share it between threads? I think no and it'll better to
>> store Number of Requests in Plan * Number of Threads AuthStates.
>>
>> - Also in case if we use dynamic proxy we can not reuse saved AuthState:
>>
>> >  if (!isDynamicProxy(getProxyHost(), getProxyPortInt())) {
>> >localContext.setAttribute(HttpClientContext.PROXY_AUTH_STATE, proxy);
>> >  }
>>
>> Artem
>>
>> On Tue, Aug 28, 2018 at 11:46 PM, Philippe Mouawad <
>> philippe.moua...@gmail.com> wrote:
>>
>> > Thank you Artem,
>> >
>> > I made a little comment on PR.
>> >
>> > Just to be sure I understand the PR:
>> >
>> >- You set HttpClientContext.PROXY_AUTH_STATE so that it is used if
>> >updated
>> >
>> > But is it correct to store it as:
>> >
>> >- "http.auth.proxy-scope" + this
>> >
>> > Because we'll end per Thread with :
>> >
>> >- Number of Requests in Plan * Number of Threads AuthStates
>> >
>> > Regards
>> >
>> >
>> > On Mon, Aug 27, 2018 at 3:43 PM Artem Fedorov <
>> > artem.fedo...@blazemeter.com>
>> > wrote:
>> >
>> > > Hi Philippe
>> > >
>> > > https://github.com/apache/jmeter/pull/397
>> > >
>> > > Let's discuss the details in the PR
>> > >
>> > > Thanks,
>> > > Artem
>> > >
>> > > On Sun, Aug 26, 2018 at 12:04 AM, Philippe Mouawad <
>> > > philippe.moua...@gmail.com> wrote:
>> > >
>> > > > Hello Artem,
>> > > > Go ahead and propose a patch or PR.
>> > > > It will be a clearer base to discuss.
>> > > >
>> > > > Thank you
>> > > >
>> > > > On Wed, Aug 22, 2018 at 10:56 AM Artem Fedorov <
>> > > > artem.fedo...@blazemeter.com>
>> > > > wrote:
>> > > >
>> > > > > I work with the latest JMeter version from github
>> > > > > (revision f27c31590cf07bc8427663b62fc22d6d650b95af)
>> > > > >
>> > > > > I create a Thread Group with 1 loop and 1 user. This Thread Group
>> > > > contains
>> > > > > View Results Tree (Listener) and HTTP Resuest (Sampler)
>> > > > >
>> > > > > Configuration of HTTP Sampler:
>> > > > >
>> > > > > > > > > > > testclass="HTTPSamplerProxy" testname="HTTP Request"
>> > enabled="true">
>> > > > > >   > > > > > > elementType="Arguments" guiclass="HTTPArgumentsPanel"
>> > > > > testclass="Arguments"
>> > > > > > testname="User Defined Variables" enabled="true">
>> > > > > > 
>> > > > > >   
>> > > > > >   
>> > > > > >   
>> > > > > >   
>> > > > > >   > > > name="HTTPSampler.contentEncoding">
>> > > > > >   
>> http://blazedemo.com
>> > > > > > 
>> > > > > >   GET
>> > > > > >   true
>> > > > > >   > > > name="HTTPSampler.auto_redirects">false
>> > > > > >   true
>> > > > > >   false> > > > boolProp>
>> > > > > >   > > > name="HTTPSampler.embedded_url_re">
>> > > > > >   
>> > > > localhost
>> > > > > >   
>> > 3321
>> > > > > >   
>> > artem
>> > > > > >   
>> > artem
>> > > > > >   > > > name="HTTPSampler.connect_timeout">
>> > > > > >   
>> > > > > > 
>> > > > >
>> > > > >
>> > > > > When I run this Test Plan I see 1 sample in the View Results Tree,
>> > but
>> > > in
>> > > > > the access.log of squid I see 2 request from JMeter.
>> > > > >
>> > > > > 1534844834.248  0 127.0.0.1 TCP_DENIED/407 4056 GET
>> > > > > > http://blazedemo.com/ - HIER_NONE/- text/html
>> > > > > > 1534844834.320 52 127.0.0.1 TCP_MISS/200 8077 GET
>> > > > > > http://blazedemo.com/ artem HIER_DIRECT/54.93.131.97 text/html
>> > > > >
>> > > > >
>> > > > > So, in real test each Sampler will send 2 requests:
>> > > > > - 1st without authentication data (and will receive 407 http
>> response
>> > > > code)
>> > > > >  - TCP_DENIED/407
>> > > > > - 2nd with authentication data(username/password/type) - will be a
>> > > > success
>> > > > > - TCP_MISS/200
>> > > > >
>> > > > > JMeter (httpclient) send 1st request for detect authentication
>> type
>> > > > > (Basic/Digest/NTLM/SPNEGO/Kerberos) which 

[GitHub] jmeter issue #399: Fix undefined disabled icon

2018-09-16 Thread pmouawad
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/399
  
Thanks for PR.
We'll merge it once version 5.0 is released.

Regards


---


[GitHub] jmeter pull request #399: Fix undefined disabled icon

2018-09-16 Thread tilln
GitHub user tilln opened a pull request:

https://github.com/apache/jmeter/pull/399

Fix undefined disabled icon

## Description
When a TestElement does not define a disabled icon, 
`JMeterTreeNode.getIcon(false)` returns null (via `GUIFactory.getIcon`).
This situation is incorrectly handled in 
`JMeterCellRenderer.getTreeCellRendererComponent`, though comments acknowledge 
the condition:
```
if (!enabled)// i.e. no disabled icon found
{
// Must therefore set the enabled icon so there is at least 
some
// icon
ic = node.getIcon();
if (ic != null) {
setIcon(ic);
}
```

## Motivation and Context
The above issue causes the wrong disabled icon to be displayed, e.g. when a 
TestElement defines its own icon via `BeanInfoSupport.setIcon`.

## How Has This Been Tested?
Tested with a locally patched class for JMeter v4.0 (Java 8, Windows 10), 
via manually disabling test plan elements.

## Screenshots (if appropriate):
![Wrong 
Icon](https://raw.githubusercontent.com/tilln/jmeter-wssecurity/issue/icon/docs/wrongicon.png)

## Types of changes
- Bug fix (non-breaking change which fixes an issue)

## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tilln/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #399


commit f6f2e563d53bc602e8c203030a4ff43ff0253ce8
Author: Till Neunast 
Date:   2018-09-16T06:09:07Z

Fix undefined disabled icon




---