[GitHub] jmeter issue #401: Bug 62257 - Expand/Collapse short key doesn't work with n...

[FSchumacher]

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/401
  
Do you think, we should support both key combinations, or should we rather 
fix the documentation to use the working combinations?


---

Jenkins build is back to normal : JMeter-trunk #6949

[Apache Jenkins Server]

See 

Build failed in Jenkins: JMeter-trunk #6948

[Apache Jenkins Server]

See 


Changes:

[fschumacher] Some shortcuts are not working correctly on windows

Contributed by Michael Pavlov (michael.paulau at gmail.com)

Bugzilla Id: 62336
Closes #396 on github

--
[...truncated 607.87 KB...]
[junit] Running org.apache.jmeter.functions.TestMachineIPName
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.004 sec
[junit] Running org.apache.jmeter.functions.TestRandomFromMultipleVars
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.004 sec
[junit] Running org.apache.jmeter.functions.TestRegexFunction
[junit] Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.048 sec
[junit] Running org.apache.jmeter.functions.TestSamplerNameFunction
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.003 sec
[junit] Running org.apache.jmeter.functions.TestSetProperty
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.006 sec
[junit] Running org.apache.jmeter.functions.TestSimpleFunctions
[junit] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.03 sec
[junit] Running org.apache.jmeter.functions.TestTimeFunction
[junit] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.009 sec
[junit] Running org.apache.jmeter.functions.TestTimeRandomDateFunction
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.078 sec
[junit] Running org.apache.jmeter.functions.TestTimeShiftFunction
[junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.054 sec
[junit] Running org.apache.jmeter.functions.TestUrlEncodeDecode
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.006 sec
[junit] Running org.apache.jmeter.functions.VariableTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.003 sec
[junit] Running org.apache.jmeter.gui.action.TestLoad
[junit] Tests run: 84, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.032 sec
[junit] Running org.apache.jmeter.gui.action.TestSave
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.009 sec
[junit] Running org.apache.jmeter.gui.logging.TestGuiLogEventAppender
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.035 sec
[junit] Running org.apache.jmeter.gui.util.JSyntaxTextAreaTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.006 sec
[junit] Running org.apache.jmeter.junit.JMeterTest
[junit] Tests run: 715, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.933 sec
[junit] Running org.apache.jmeter.listeners.TestResultAction
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.004 sec
[junit] Running 
org.apache.jmeter.protocol.http.config.MultipartUrlConfigTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.006 sec
[junit] Running org.apache.jmeter.protocol.http.config.UrlConfigTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.01 sec
[junit] Running org.apache.jmeter.protocol.http.control.TestAuthManager
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.009 sec
[junit] Running org.apache.jmeter.protocol.http.control.TestAuthorization
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.003 sec
[junit] Running org.apache.jmeter.protocol.http.control.TestCacheManagerHC4
[junit] Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.771 sec
[junit] Running 
org.apache.jmeter.protocol.http.control.TestCacheManagerUrlConnection
[junit] Tests run: 23, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.76 sec
[junit] Running org.apache.jmeter.protocol.http.control.TestDNSCacheManager
[junit] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.303 sec
[junit] Running org.apache.jmeter.protocol.http.control.TestHC4CookieManager
[junit] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.108 sec
[junit] Running org.apache.jmeter.protocol.http.control.TestHTTPMirrorThread
[junit] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.963 sec
[junit] Running 
org.apache.jmeter.protocol.http.control.gui.TestHttpTestSampleGui
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.026 sec
[junit] Running org.apache.jmeter.protocol.http.modifier.TestAnchorModifier
[junit] Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.157 sec
[junit] Running 
org.apache.jmeter.protocol.http.modifier.TestURLRewritingModifier
[junit] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.019 sec
[junit] Running 

[GitHub] jmeter issue #396: Fix to 62336

[FSchumacher]

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/396
  
Thanks for your contribution.

I still don't know, why we get `null` for `CTRL`+`6` on windows, but the 
workaround seems to work, so I have included it and hope somebody can explain 
the real bug to me.


---

[GitHub] jmeter pull request #396: Fix to 62336

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/396


---

[GitHub] jmeter pull request #413: Enhancement 62829 - Allow specifying proxy scheme ...

[pmouawad]

Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/413#discussion_r228741947
  
--- Diff: 
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -1037,7 +1044,7 @@ private CloseableHttpClient 
setupClient(JMeterVariables jMeterVariables, URL url
 
 // Set up proxy details
 if(useProxy) {
-HttpHost proxy = new HttpHost(proxyHost, proxyPort);
+HttpHost proxy = new HttpHost(proxyHost, proxyPort, 
proxyScheme);
--- End diff --

If proxyScheme is empty, then it should be passed as null so that default 
(HTTP) is used.


---