[GitHub] jmeter pull request #434: Truncate response message to avoid too large udp p...

2018-11-23 Thread mybreeze77 
Github user mybreeze77 commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/434#discussion_r235965931
  
--- Diff: 
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
 ---
@@ -196,12 +196,18 @@ private void addMetrics(String transaction, 
SamplerMetric metric) {
 }
 
 private void addErrorMetric(String transaction, String responseCode, 
String responseMessage, long count) {
+final int MAX_RES_CODE_LENGTH_FOR_UDP = 50;
--- End diff --







Yes, I agree it is a property which is better to be decided by users. 
Actually 50 is a kind of empirical value. 

More details said, as we can see below example, "count", "countError", 
"hit", etc. are integers with 4 bytes. "pct95.0", "pct99.0", etc. are doubles 
with 8 bytes. But as they will be converted to String in influx line protocal, 
they actually take about 10 bytes and 20 bytes respectively. Without response 
message, the data sent to influxdb as udp will be about 1350 bytes at most. 

```
jmeter,application=application,transaction=all,statut=all 
count=304,countError=304,hit=304,sb=39216,rb=106688,pct95.0=13.0,pct99.0=16.9699985,pct90.0=12.906
 154295971070800 -- 300 bytes at most

jmeter,application=application,statut=all,transaction=HTTP\ Request 
count=304,avg=8.8,min=6.0,max=17.0,sb=39216,rb=106688,pct95.0=13.0,pct99.0=16.9699985,pct90.0=12.906
 154295971070900 -- 300 bytes at most

jmeter,application=application,statut=ko,transaction=HTTP\ Request 
count=304,avg=8.8,min=6.0,max=17.0,pct95.0=13.0,pct99.0=16.9699985,pct90.0=12.906
 154295971071000 -- 300 bytes at most

jmeter,application=application,transaction=HTTP\ 
Request,responseCode=404,responseMessage=Very 
llong mmessage count=304 
154295971071000 -- 300 bytes at most without response message

jmeter,application=application,transaction=internal 
minAT=1,maxAT=1,meanAT=1,startedT=1,endedT=0 154295971071000 -- 150 bytes 
at most
```

So for the size of response message, any value lower than 1500 - 1350 = 150 
will be safe. That's the reason we set it 50. Hope it clear.


---

[GitHub] jmeter pull request #433: Bug 62935. Pass custom 'mail.*' properties to Mail...

2018-11-23 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/433


---

[GitHub] jmeter issue #432: Bug 62870 / Templates : Add ability to provide parameters

2018-11-23 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/432
  
Hello Felix, 
I have committed the fixes following your review.
Let me know if you will commit the PR (which I would prefer), otherwise 
I'll do it.

Thanks
Regards


---

[GitHub] jmeter issue #429: Fix 62887. Customized SampleLabel is ignored and overwrit...

2018-11-23 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/429
  
@artem-fedorov ,
Yes if the are in the test plan.
No guarantee if they are automatically handled by resources download and it 
is done in parallel, but since 5.0, we add the URL in the CSV to disambiguate



---

[GitHub] jmeter issue #429: Fix 62887. Customized SampleLabel is ignored and overwrit...

2018-11-23 Thread artem-fedorov 
Github user artem-fedorov commented on the issue:

https://github.com/apache/jmeter/pull/429
  
@pmouawad 
In case when I have 3 resources for request url.com
- url.com/res.css
- url.com/res.html
- url.com/res.xml
Does current behaviour guaranteed that `url.com/res.css` always will have 
label `url-0`, `url.com/res.html` -> `url.com-1` and `url.com/res.xml` -> 
`url.com-2` ? and Labels will not be confused?


---

[GitHub] jmeter issue #433: Bug 62935. Pass custom 'mail.*' properties to Mail Reader...

2018-11-23 Thread artem-fedorov 
Github user artem-fedorov commented on the issue:

https://github.com/apache/jmeter/pull/433
  
Awesome! thanks!


---

[GitHub] jmeter pull request #434: Truncate response message to avoid too large udp p...

2018-11-23 Thread pmouawad 
Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/434#discussion_r235892281
  
--- Diff: 
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
 ---
@@ -196,12 +196,18 @@ private void addMetrics(String transaction, 
SamplerMetric metric) {
 }
 
 private void addErrorMetric(String transaction, String responseCode, 
String responseMessage, long count) {
+final int MAX_RES_CODE_LENGTH_FOR_UDP = 50;
--- End diff --

I think this should be a property.
Can you point me to the reference that mentions 50 ?

Thank you


---

[GitHub] jmeter issue #434: Truncate response message to avoid too large udp package ...

2018-11-23 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/434
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/434?src=pr&el=h1) 
Report
> Merging 
[#434](https://codecov.io/gh/apache/jmeter/pull/434?src=pr&el=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/c9defe696e3bf0214e058fd2f2775f7c6823ee50?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/434/graphs/tree.svg?width=650&token=6Q7CI1wFSh&height=150&src=pr)](https://codecov.io/gh/apache/jmeter/pull/434?src=pr&el=tree)

```diff
@@ Coverage Diff @@
##  trunk#434  +/-   ##
===
- Coverage 58.61%   58.6%   -0.01% 
+ Complexity10640   10639   -1 
===
  Files  11961196  
  Lines 76092   76097   +5 
  Branches   73627364   +2 
===
- Hits  44600   44597   -3 
- Misses28984   28992   +8 
  Partials   25082508
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/434?src=pr&el=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...ackend/influxdb/InfluxdbBackendListenerClient.java](https://codecov.io/gh/apache/jmeter/pull/434/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvYmFja2VuZC9pbmZsdXhkYi9JbmZsdXhkYkJhY2tlbmRMaXN0ZW5lckNsaWVudC5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/434/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==)
 | `54.83% <0%> (-2.16%)` | `15% <0%> (ø)` | |
| 
[...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/434/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==)
 | `85.49% <0%> (-0.77%)` | `18% <0%> (-1%)` | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/434?src=pr&el=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/434?src=pr&el=footer). Last 
update 
[c9defe6...dbe7683](https://codecov.io/gh/apache/jmeter/pull/434?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter pull request #434: Truncate response message to avoid too large udp p...

2018-11-23 Thread mybreeze77 
GitHub user mybreeze77 opened a pull request:

https://github.com/apache/jmeter/pull/434

Truncate response message to avoid too large udp package using 
UdpMetricsSender

In JMeter, we can use "BackendListener - InfluxdbBackendListenerClient - 
UdpMetricsSender" to send data as udp to InfluxDB. As we know, UDP package max 
size is limited to the MTU (about 1500 bytes). So if is possible to exceed it, 
for below example.

`
jmeter,application=application,transaction=all,statut=all 
count=304,countError=304,hit=304,sb=39216,rb=106688,pct95.0=13.0,pct99.0=16.9699985,pct90.0=12.906
 154295971070800
jmeter,application=application,statut=all,transaction=HTTP\ Request 
count=304,avg=8.8,min=6.0,max=17.0,sb=39216,rb=106688,pct95.0=13.0,pct99.0=16.9699985,pct90.0=12.906
 154295971070900
jmeter,application=application,statut=ko,transaction=HTTP\ Request 
count=304,avg=8.8,min=6.0,max=17.0,pct95.0=13.0,pct99.0=16.9699985,pct90.0=12.906
 154295971071000
jmeter,application=application,transaction=HTTP\ 
Request,responseCode=404,responseMessage=Very 
llong mmessage count=304 
154295971071000
jmeter,application=application,transaction=internal 
minAT=1,maxAT=1,meanAT=1,startedT=1,endedT=0 154295971071000
`

We will get below error and data are not sent to InfluxDB.

> 2018-09-28 23:53:29,743 ERROR o.a.j.v.b.i.UdpMetricsSender: Error in 
transferring udp package
> java.io.IOException: Message too long

Considering the size of other fields/tags are under control, it will be 
better if we truncate the response message to about 50 bytes when it is too 
large (Only for udp sender). 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mybreeze77/jmeter fixudp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #434


commit 1ba4b514714c3466fd90c435bf8bec922494a27e
Author: Junlong Wu 
Date:   2018-11-23T09:24:35Z

Truncate response message to avoid too large udp package using 
UdpMetricsSender




---