[GitHub] [jmeter] FSchumacher commented on pull request #595: Add freestyle naming scheme to proxy samples
FSchumacher commented on pull request #595: URL: https://github.com/apache/jmeter/pull/595#issuecomment-684837107 Can you try again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on pull request #595: Add freestyle naming scheme to proxy samples
FSchumacher commented on pull request #595: URL: https://github.com/apache/jmeter/pull/595#issuecomment-683890998 I have added a JMeter property (`proxy.sampler_format` in `bin/jmeter.properties`), that can be used to choose a default value. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on pull request #595: Add freestyle naming scheme to proxy samples
FSchumacher commented on pull request #595:
URL: https://github.com/apache/jmeter/pull/595#issuecomment-683698110
In the string format, you can use `#{counter,number,000}` directly. So, if
you want to use the counter with three digits then a dash, the path and the
transaction name in parenthesis, you would write `#{counter,number,000} -
#{path} (#{name})` in the text field next to the select field `Naming scheme`
where you selected `Use format string`.
You don't set any property.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on pull request #595: Add freestyle naming scheme to proxy samples
FSchumacher commented on pull request #595: URL: https://github.com/apache/jmeter/pull/595#issuecomment-680240138 Despite of my initial comment, I have implemented the counter feature from #571 in this PR. Apart from the documentation (which is still missing), it looks complete now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on pull request #595: Add freestyle naming scheme to proxy samples
FSchumacher commented on pull request #595:
URL: https://github.com/apache/jmeter/pull/595#issuecomment-637596512
...
> I'm not sure MessageFormat is a proper templating framework though: there
are no named parameters, so the template string would be awkward and it would
be hard to reason about :-/
Yes, I agree. MessageFormat might be hard to read, but
* it is better then my first implementation, which used `String#format`
which sucked even more ;)
* it can use formatting options for numbers, which is handy, as it allows
something like `{1,number,000}`
* other template languages might look like the JMeter built-in variable
replacement syntax or would have to be included (for the former I thought about
StringSubstitutor from commons-text)
Do you have a special templating system in mind, that we can/should use?
One idea would be to parse the format string and generate the three
placeholders à la `#{prefix} #{path} #{count,number,000}` -> `{0} {1}
{2,number,000}` via `s/#{count\b/{2/`, etc.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
