Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/283
Hello Maxime,
Thanks for patch.
My remarks:
- I think we need here JUnit tests to check no regression will occur. This
part of the code is complex and critical and needs 100% coverage ideally
through JUnit otherwise with a test plan running with Jacoco
- I would prefer to delay it after 3.2 release to avoid introducing another
delay in release.
I'll review code more thoroughly in near future.
Regards
Philippe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
