[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[FSchumacher]

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/341
  
Yes, but also to enable us to filter in view results tree on those meta 
information. It could be something like a comment, a thread name or anything 
else.


---

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/341
  
Hi @FSchumacher ,
Good idea.
Is this in relation with https://github.com/apache/jmeter/pull/313 ?
Thanks


---

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[FSchumacher]

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/341
  
I wonder, whether instead of or additionally to the new `setIgnore` method, 
we should add and expose a `setMetadata(type, content)` method.
I believe it would be useful for example to:
* mark samples to be ignored by listeners and such
* use the information later on to group by (a use case would be to group by 
some user given metadata in the view results tree)


---

[GitHub] jmeter issue #341: Test isIgnore after post processor and assertions

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/341
  
Hi @max3163 ,
0/ In order to justify the user case, can you illustrate your use case ?
1/ I think we should add a log in debug level when we ignore a SampleResult
2/ Could you also add either a JUnit or an integration test (jmx test) that 
tests different cases:
- ignore only in JSR223Sampler
- ignore only in Assertion
- ignore only in PostProcessor
3/ Can you add a comment on the reason for the multiple test ? when reading 
the code, I forgot for few minutes the initial intent ,and it was not clear for 
me. 
Comment like:
"setIgnore can be called in Assertion or PostProcessors so test again"


Thanks


---