[GitHub] jmeter issue #345: Checkstyle

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/345
  
Hi team, anybody wants to merge this one ? if not I’ll do it this 
week-end. Thanks


---

[GitHub] jmeter issue #345: Checkstyle

[romani]

Github user romani commented on the issue:

https://github.com/apache/jmeter/pull/345
  
if master branch of this project (jmeter) start to use about 80 Checks in 
its config with ERROR severity and no violations reported, we can start to use 
jmeter in out CI for regression testing. 

just keep enforcing more and more rules, and pin me then you are done.


---

[GitHub] jmeter issue #345: Checkstyle

[ham1]

Github user ham1 commented on the issue:

https://github.com/apache/jmeter/pull/345
  
@romani, sorry I'm not clear on what, if anything, you'd want me to 
do/change?


---

[GitHub] jmeter issue #345: Checkstyle

[romani]

Github user romani commented on the issue:

https://github.com/apache/jmeter/pull/345
  
@ham1 , if you enforce(ERROR level) more than half of Checks on this 
project, we can use jmeter project in each commit (in checkstyle) regression 
testing.


---

[GitHub] jmeter issue #345: Checkstyle

[ham1]

Github user ham1 commented on the issue:

https://github.com/apache/jmeter/pull/345
  
Yes, that's correct, I some how missed it in the docs.

I've suggested on https://github.com/checkstyle/checkstyle/issues/5305 that 
the error message is changed to something like:
`"Return count is 2 (maxForVoid allowed is 1). [ReturnCount10]"`
or
`"Void return count is 2 (max allowed is 1). [ReturnCount10]"`
to perhaps help prevent the confusion.


---

[GitHub] jmeter issue #345: Checkstyle

[romani]

Github user romani commented on the issue:

https://github.com/apache/jmeter/pull/345
  
Looks like a reason was in `maxForVoid` with default value., Right ?


---

[GitHub] jmeter issue #345: Checkstyle

[ham1]

Github user ham1 commented on the issue:

https://github.com/apache/jmeter/pull/345
  
@romani it's commented out to stop this PR failing but where you see it 
commented out was where I had:
```

  

```


---

[GitHub] jmeter issue #345: Checkstyle

[romani]

Github user romani commented on the issue:

https://github.com/apache/jmeter/pull/345
  
@ham1 , ReturnCount check is commented out.  Please point me to place where 
you configure it.


---

[GitHub] jmeter issue #345: Checkstyle

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/345
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=h1) 
Report
> Merging 
[#345](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/4d8facc557fda5986837c3da3b2364350f08b368?src=pr=desc)
 will **decrease** coverage by `0.01%`.
> The diff coverage is `66.66%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/345/graphs/tree.svg?token=6Q7CI1wFSh=650=pr=150)](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree)

```diff
@@ Coverage Diff @@
## trunk #345  +/-   ##
===
- Coverage 58.1%   58.08%   -0.02% 
- Complexity   1011110121  +10 
===
  Files 1154 1154  
  Lines7396173952   -9 
  Branches  7342 7337   -5 
===
- Hits 4297242955  -17 
- Misses   2850928515   +6 
- Partials  2480 2482   +2
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...e/org/apache/jmeter/report/core/SampleBuilder.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L2NvcmUvU2FtcGxlQnVpbGRlci5qYXZh)
 | `77.77% <ø> (ø)` | `6 <0> (ø)` | :arrow_down: |
| 
[...ache/jmeter/control/TestTransactionController.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvY29udHJvbC9UZXN0VHJhbnNhY3Rpb25Db250cm9sbGVyLmphdmE=)
 | `90% <ø> (ø)` | `2 <0> (ø)` | :arrow_down: |
| 
[.../apache/jmeter/testelement/TestNumberProperty.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvdGVzdGVsZW1lbnQvVGVzdE51bWJlclByb3BlcnR5LmphdmE=)
 | `76.19% <ø> (ø)` | `6 <0> (ø)` | :arrow_down: |
| 
[...apache/jmeter/reporters/ResultCollectorHelper.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1Jlc3VsdENvbGxlY3RvckhlbHBlci5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...jmeter/protocol/jms/control/gui/JMSSamplerGui.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvY29udHJvbC9ndWkvSk1TU2FtcGxlckd1aS5qYXZh)
 | `84.37% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| 
[.../org/apache/jmeter/functions/TestFileToString.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1Rlc3RGaWxlVG9TdHJpbmcuamF2YQ==)
 | `90% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| 
[.../apache/jmeter/extractor/gui/HtmlExtractorGui.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL2d1aS9IdG1sRXh0cmFjdG9yR3VpLmphdmE=)
 | `85.59% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| 
[...rc/core/org/apache/jmeter/util/HostNameSetter.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9Ib3N0TmFtZVNldHRlci5qYXZh)
 | `75% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| 
[...apache/jmeter/report/processor/TaggerConsumer.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0L3Byb2Nlc3Nvci9UYWdnZXJDb25zdW1lci5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...nents/org/apache/jmeter/reporters/MailerModel.java](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL01haWxlck1vZGVsLmphdmE=)
 | `35% <ø> (ø)` | `28 <0> (ø)` | :arrow_down: |
| ... and [59 
more](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=footer). Last 
update 
[4d8facc...44fc9d3](https://codecov.io/gh/apache/jmeter/pull/345?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---