[GitHub] jmeter issue #365: Expanded Checkstyle to files in src and test; fixed newly...

[ham1]

Github user ham1 commented on the issue:

https://github.com/apache/jmeter/pull/365
  
Thanks for committing!


---

[GitHub] jmeter issue #365: Expanded Checkstyle to files in src and test; fixed newly...

[FSchumacher]

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/365
  
Thanks for your contribution.


---

[GitHub] jmeter issue #365: Expanded Checkstyle to files in src and test; fixed newly...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/365
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=h1) 
Report
> Merging 
[#365](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/998b3302a10ad8f298c12e67e08369f5a205018d?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `60.71%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/365/graphs/tree.svg?width=650=150=6Q7CI1wFSh=pr)](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #365  +/-   ##

+ Coverage 58.35%   58.35%   +<.01% 
- Complexity1028810290   +2 

  Files  1164 1164  
  Lines 7412774135   +8 
  Branches   7298 7298  

+ Hits  4325443263   +9 
  Misses2835928359  
+ Partials   2514 2513   -1
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...mpler/TestHTTPSamplersAgainstHttpMirrorServer.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL1Rlc3RIVFRQU2FtcGxlcnNBZ2FpbnN0SHR0cE1pcnJvclNlcnZlci5qYXZh)
 | `89.75% <ø> (ø)` | `80 <0> (ø)` | :arrow_down: |
| 
[...g/apache/jmeter/assertions/SMIMEAssertionTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9TTUlNRUFzc2VydGlvblRlc3QuamF2YQ==)
 | `100% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| 
[...er/protocol/http/control/TestHTTPMirrorThread.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL1Rlc3RIVFRQTWlycm9yVGhyZWFkLmphdmE=)
 | `90% <ø> (ø)` | `26 <0> (ø)` | :arrow_down: |
| 
[...apache/jmeter/functions/TestTimeShiftFunction.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1Rlc3RUaW1lU2hpZnRGdW5jdGlvbi5qYXZh)
 | `89.32% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| 
[...pache/jmeter/assertions/ResponseAssertionTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9SZXNwb25zZUFzc2VydGlvblRlc3QuamF2YQ==)
 | `99.03% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| 
[...t/src/org/apache/jmeter/functions/PackageTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1BhY2thZ2VUZXN0LmphdmE=)
 | `91.63% <ø> (ø)` | `25 <0> (ø)` | :arrow_down: |
| 
[...rg/apache/jmeter/visualizers/TestRenderAsJson.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvVGVzdFJlbmRlckFzSnNvbi5qYXZh)
 | `100% <ø> (ø)` | `10 <0> (ø)` | :arrow_down: |
| 
[.../org/apache/jmeter/functions/ChangeCaseSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL0NoYW5nZUNhc2VTcGVjLmdyb292eQ==)
 | `100% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| 
[...che/jmeter/protocol/http/config/UrlConfigTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb25maWcvVXJsQ29uZmlnVGVzdC5qYXZh)
 | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| 
[...est/src/org/apache/jorphan/util/TestConverter.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qb3JwaGFuL3V0aWwvVGVzdENvbnZlcnRlci5qYXZh)
 | `100% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| ... and [29 
more](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=footer). Last 
update 
[998b330...08615ed](https://codecov.io/gh/apache/jmeter/pull/365?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---