[GitHub] jmeter issue #374: Add a 'go to top' button that gets shown, when page is sc...

2018-02-11 Thread FSchumacher 
Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/374
  
I didn't want to introduce a possible breakage into the RC and it will 
affect the web page, only. So we can "release" these kind of changes at a later 
point.


---

[GitHub] jmeter issue #374: Add a 'go to top' button that gets shown, when page is sc...

2018-02-06 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/374
  
Hi Felix,
Why not commit this before release ?
Do you have a doubt about it ?
Thanks



---

[GitHub] jmeter issue #374: Add a 'go to top' button that gets shown, when page is sc...

2018-02-01 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/374
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/374?src=pr=h1) 
Report
> Merging 
[#374](https://codecov.io/gh/apache/jmeter/pull/374?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/f43ad48079caf19359e74ab929fce6483389c616?src=pr=desc)
 will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/374/graphs/tree.svg?width=650=150=pr=6Q7CI1wFSh)](https://codecov.io/gh/apache/jmeter/pull/374?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #374  +/-   ##

- Coverage 58.56%   58.56%   -0.01% 
+ Complexity1036310362   -1 

  Files  1174 1174  
  Lines 7441674416  
  Branches   7266 7266  

- Hits  4358043579   -1 
- Misses2834028341   +1 
  Partials   2496 2496
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/374?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/374/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh)
 | `27.41% <0%> (-2.42%)` | `10% <0%> (-1%)` | |
| 
[...ocol/jms/org/apache/jmeter/protocol/jms/Utils.java](https://codecov.io/gh/apache/jmeter/pull/374/diff?src=pr=tree#diff-c3JjL3Byb3RvY29sL2ptcy9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9qbXMvVXRpbHMuamF2YQ==)
 | `56.98% <0%> (+2.15%)` | `15% <0%> (ø)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/374?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/374?src=pr=footer). Last 
update 
[f43ad48...8fe98f3](https://codecov.io/gh/apache/jmeter/pull/374?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

[GitHub] jmeter issue #374: Add a 'go to top' button that gets shown, when page is sc...

2018-02-01 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/374
  
Very good idea


---