[GitHub] jmeter issue #408: Display an info message, when no JavaFX is found and Rend...

[FSchumacher]

Github user FSchumacher commented on the issue:

https://github.com/apache/jmeter/pull/408
  
The message from a `ClassNotFoundException` is checked for `javafx`. I 
think it is safe to assume that any message on that kind of error hints to a 
missing JavaFX installation, when it contains the string `javafx`.


---

[GitHub] jmeter issue #408: Display an info message, when no JavaFX is found and Rend...

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/408
  
+1

Should you test «.javafx. » instead of only javafx?

Thanks 


---

[GitHub] jmeter issue #408: Display an info message, when no JavaFX is found and Rend...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/408
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/408?src=pr=h1) 
Report
> Merging 
[#408](https://codecov.io/gh/apache/jmeter/pull/408?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/b15fab078a0055442df3c4dec4cb9260e93319a1?src=pr=desc)
 will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/408/graphs/tree.svg?width=650=6Q7CI1wFSh=150=pr)](https://codecov.io/gh/apache/jmeter/pull/408?src=pr=tree)

```diff
@@ Coverage Diff  @@
##  trunk #408  +/-   ##

+ Coverage 58.58%   58.58%   +<.01% 
- Complexity1061610618   +2 

  Files  1193 1193  
  Lines 7595775961   +4 
  Branches   7343 7344   +1 

+ Hits  4449944505   +6 
  Misses2895328953  
+ Partials   2505 2503   -2
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/408?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[.../jmeter/visualizers/ViewResultsFullVisualizer.java](https://codecov.io/gh/apache/jmeter/pull/408/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvVmlld1Jlc3VsdHNGdWxsVmlzdWFsaXplci5qYXZh)
 | `38% <0%> (-0.57%)` | `15 <0> (ø)` | |
| 
[...re/org/apache/jmeter/engine/DistributedRunner.java](https://codecov.io/gh/apache/jmeter/pull/408/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZW5naW5lL0Rpc3RyaWJ1dGVkUnVubmVyLmphdmE=)
 | `85.71% <0%> (+3.36%)` | `32% <0%> (+1%)` | :arrow_up: |
| 
[...s/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/408/diff?src=pr=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL1BvaXNzb25SYW5kb21UaW1lci5qYXZh)
 | `78.37% <0%> (+5.4%)` | `10% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/408?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/408?src=pr=footer). Last 
update 
[b15fab0...002d427](https://codecov.io/gh/apache/jmeter/pull/408?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---