[GitHub] jmeter issue #432: Bug 62870 / Templates : Add ability to provide parameters

2018-11-27 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/432
  
Hello,
I'll be merging it today.

Regards


---

[GitHub] jmeter issue #432: Bug 62870 / Templates : Add ability to provide parameters

2018-11-23 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/432
  
Hello Felix, 
I have committed the fixes following your review.
Let me know if you will commit the PR (which I would prefer), otherwise 
I'll do it.

Thanks
Regards


---

[GitHub] jmeter issue #432: Bug 62870 / Templates : Add ability to provide parameters

2018-11-20 Thread pmouawad 
Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/432
  
Hi Felix,
You’re right.

Take your time 

Sorry, I am always impatient guy :)

Regards 


---

[GitHub] jmeter issue #432: Bug 62870 / Templates : Add ability to provide parameters

2018-11-19 Thread codecov-io 
Github user codecov-io commented on the issue:

https://github.com/apache/jmeter/pull/432
  
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/432?src=pr=h1) 
Report
> Merging 
[#432](https://codecov.io/gh/apache/jmeter/pull/432?src=pr=desc) into 
[trunk](https://codecov.io/gh/apache/jmeter/commit/cc55d68116667087e75b88a270c66cecb4d7e916?src=pr=desc)
 will **decrease** coverage by `0.03%`.
> The diff coverage is `28.43%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/jmeter/pull/432/graphs/tree.svg?width=650=6Q7CI1wFSh=150=pr)](https://codecov.io/gh/apache/jmeter/pull/432?src=pr=tree)

```diff
@@ Coverage Diff @@
## trunk #432  +/-   ##
===
- Coverage 58.6%   58.57%   -0.04% 
- Complexity   1063810667  +29 
===
  Files 1196 1198   +2 
  Lines7608776331 +244 
  Branches  7361 7399  +38 
===
+ Hits 4459444712 +118 
- Misses   2898629106 +120 
- Partials  2507 2513   +6
```


| [Impacted 
Files](https://codecov.io/gh/apache/jmeter/pull/432?src=pr=tree) | Coverage 
Δ | Complexity Δ | |
|---|---|---|---|
| 
[...pache/jmeter/gui/action/SelectTemplatesDialog.java](https://codecov.io/gh/apache/jmeter/pull/432/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL2FjdGlvbi9TZWxlY3RUZW1wbGF0ZXNEaWFsb2cuamF2YQ==)
 | `1.58% <0%> (-1.42%)` | `1 <0> (ø)` | |
| 
[src/core/org/apache/jmeter/util/TemplateUtil.java](https://codecov.io/gh/apache/jmeter/pull/432/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdXRpbC9UZW1wbGF0ZVV0aWwuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
| 
[...rg/apache/jmeter/gui/action/template/Template.java](https://codecov.io/gh/apache/jmeter/pull/432/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL2FjdGlvbi90ZW1wbGF0ZS9UZW1wbGF0ZS5qYXZh)
 | `20.93% <4.28%> (+20.93%)` | `12 <2> (+12)` | :arrow_up: |
| 
[...he/jmeter/gui/action/template/TemplateManager.java](https://codecov.io/gh/apache/jmeter/pull/432/diff?src=pr=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL2FjdGlvbi90ZW1wbGF0ZS9UZW1wbGF0ZU1hbmFnZXIuamF2YQ==)
 | `74.41% <84.21%> (+74.41%)` | `13 <10> (+13)` | :arrow_up: |
| 
[...meter/gui/action/template/TestTemplateManager.java](https://codecov.io/gh/apache/jmeter/pull/432/diff?src=pr=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL2FjdGlvbi90ZW1wbGF0ZS9UZXN0VGVtcGxhdGVNYW5hZ2VyLmphdmE=)
 | `87.8% <87.8%> (ø)` | `4 <4> (?)` | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/jmeter/pull/432?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/jmeter/pull/432?src=pr=footer). Last 
update 
[cc55d68...db95633](https://codecov.io/gh/apache/jmeter/pull/432?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---