Re: Release 5.6.3

2023-12-29 Thread Milamber

Hi Vladimir,

Thanks for your works. I will prepare the first RC tomorrow.

Milamber

On 29/12/2023 16:46, Vladimir Sitnikov wrote:

Hi,

I think we should be good to go.
I've merged the fix for test element properties, and I've refactored the
existing JUnit3/4 and Spock tests to JUnit 5.

Milamber, do you think you could prepare a release candidate?

Vladimir





Re: Release 5.6.3

2023-12-29 Thread Vladimir Sitnikov
Hi,

I think we should be good to go.
I've merged the fix for test element properties, and I've refactored the
existing JUnit3/4 and Spock tests to JUnit 5.

Milamber, do you think you could prepare a release candidate?

Vladimir


Re: Release 5.6.3

2023-12-25 Thread NaveenKumar Namachivayam
Hi Vladimir,

I tested https://github.com/apache/jmeter/issues/6076 in macOS from your branch.

It works fine when download embed resources enabled from the HTTP request 
defaults.

Thanks!
On Dec 25, 2023 at 12:15 PM -0500, Vladimir Sitnikov 
, wrote:
> > There are missing bits like adding javadocs, and selecting the class and
> method names, however, it would be great if somebody could test if the PR
> fixes their workflows/scripts.
>
> Ok, I polished the docs and naming. I am going to merge the PR soon.
>
> Vladimir


Re: Release 5.6.3

2023-12-25 Thread Vladimir Sitnikov
>There are missing bits like adding javadocs, and selecting the class and
method names, however, it would be great if somebody could test if the PR
fixes their workflows/scripts.

Ok, I polished the docs and naming. I am going to merge the PR soon.

Vladimir


Re: Release 5.6.3

2023-12-24 Thread Vladimir Sitnikov
I think I figured out the solution for properties, and I like the way it
works now.
I put the description in https://github.com/apache/jmeter/pull/6199, and I
think the solution is more-or-less ready to go.

For instance, BeanShellSamplerGui, OpenModelThreadGroupGui become much
simpler as they no longer need to implement
configure, modifyTestElement, and clearGui methods (see the PR).

There are missing bits like adding javadocs, and selecting the class and
method names, however, it would be great if somebody could test if the PR
fixes their workflows/scripts.

Vladimir


Re: Release 5.6.3

2023-12-20 Thread Vladimir Sitnikov
I am analyzing the issue "Downloading of embedded resources via HTTP
Request Default not working on v5.6.2" (
https://github.com/apache/jmeter/issues/6076 ),
and it requires fixing the implementation of properties. I think we should
fix it in 5.6.3

I hope to sort it out by Friday.

Vladimir


Re: Release 5.6.3

2023-12-20 Thread Milamber

Hi,

Will be in holidays next weeks, I can release 5.63 at this moment (as RM)

Are you OK?

Milamber

On 18/12/2023 16:18, Vladimir Sitnikov wrote:

I've prepared the changelog for 5.6.3:
https://github.com/apache/jmeter/pull/6190

I suggest releasing 5.6.3 and moving to 6.0 development.

Any thoughts?

Vladimir





Re: Release 5.6.3

2023-12-18 Thread Antonio Gomes Rodrigues
Thanks to your work
Still ok for me

Le lun. 18 déc. 2023 à 16:19, Vladimir Sitnikov 
a écrit :

> I've prepared the changelog for 5.6.3:
> https://github.com/apache/jmeter/pull/6190
>
> I suggest releasing 5.6.3 and moving to 6.0 development.
>
> Any thoughts?
>
> Vladimir
>


Re: Release 5.6.3

2023-12-18 Thread Vladimir Sitnikov
I've prepared the changelog for 5.6.3:
https://github.com/apache/jmeter/pull/6190

I suggest releasing 5.6.3 and moving to 6.0 development.

Any thoughts?

Vladimir


Re: Release 5.6.3

2023-12-07 Thread Antonio Gomes Rodrigues
Hi
No objection for me


Le jeu. 7 déc. 2023, 12:14, Vladimir Sitnikov 
a écrit :

> Hi,
>
> I think 5.6.3 is long overdue, and I would like to cut a release soon.
>
> Does anybody have any objections?
> Does anybody know the pressing issues we should fix before releasing 5.6.3?
>
> I will update the changelog to include the relevant changes, known bugs,
> and issues fixed in 5.6.3.
>
> Vladimir
>


Release 5.6.3

2023-12-07 Thread Vladimir Sitnikov
Hi,

I think 5.6.3 is long overdue, and I would like to cut a release soon.

Does anybody have any objections?
Does anybody know the pressing issues we should fix before releasing 5.6.3?

I will update the changelog to include the relevant changes, known bugs,
and issues fixed in 5.6.3.

Vladimir