[GitHub] [joshua] tteofili commented on issue #88: Update path to env, remove git command

[GitBox]

tteofili commented on issue #88: Update path to env, remove git command
URL: https://github.com/apache/joshua/pull/88#issuecomment-501750271
 
 
   thx James for your PR, did you also try running the script with a "usual" 
$JOSHUA dir being a git repo?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] jamesewoo commented on issue #88: Update path to env, remove git command

[GitBox]

jamesewoo commented on issue #88: Update path to env, remove git command
URL: https://github.com/apache/joshua/pull/88#issuecomment-501808560
 
 
   Running it like that would work fine, but my use case is running inside a
   container where just the Joshua runtime binaries have been copied over.
   
   On Thu, Jun 13, 2019, 11:22 AM Tommaso Teofili 
   wrote:
   
   > thx James for your PR, did you also try running the script with a "usual"
   > $JOSHUA dir being a git repo?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] jamesewoo opened a new pull request #88: Update path to env, remove git command

[GitBox]

jamesewoo opened a new pull request #88: Update path to env, remove git command
URL: https://github.com/apache/joshua/pull/88
 
 
   Fixes for running in an Ubuntu Docker container where $JOSHUA is not a git 
repo


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] tteofili merged pull request #87: Using replace() instead of replaceAll() for non-regex patterns

[GitBox]

tteofili merged pull request #87: Using replace() instead of replaceAll() for 
non-regex patterns
URL: https://github.com/apache/joshua/pull/87
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] bd2019us opened a new pull request #87: Using replace() instead of replaceAll() for non-regex patterns

[GitBox]

bd2019us opened a new pull request #87: Using replace() instead of replaceAll() 
for non-regex patterns
URL: https://github.com/apache/joshua/pull/87
 
 
   [JOSHUA-342](https://issues.apache.org/jira/browse/JOSHUA-342) Using 
replace() instead replaceAll() when no regex is used removes the overhead 
associated with replaceAll()


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] tteofili merged pull request #89: Add OpenJDK dependency required for "jni.h"

[GitBox]

tteofili merged pull request #89: Add OpenJDK dependency required for "jni.h"
URL: https://github.com/apache/joshua/pull/89
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] magali-joine opened a new pull request #89: Add OpenJDK dependency required for "jni.h"

[GitBox]

magali-joine opened a new pull request #89: Add OpenJDK dependency required for 
"jni.h"
URL: https://github.com/apache/joshua/pull/89
 
 
   Fixes docker build: Solves
   
   ```
   100%] Linking CXX executable ../tests/model_test
   [100%] Built target model_test
   /code/jni/kenlm_wrap.cc:28:17: fatal error: jni.h: No such file or directory
#include 
^
   compilation terminated.
   Removing intermediate container 0c2cb0c17a12
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] tteofili merged pull request #88: Update path to env, remove git command

[GitBox]

tteofili merged pull request #88: Update path to env, remove git command
URL: https://github.com/apache/joshua/pull/88
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] tteofili merged pull request #90: Remove bashism

[GitBox]

tteofili merged pull request #90: Remove bashism
URL: https://github.com/apache/joshua/pull/90
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] iadbbwarln opened a new pull request #90: Remove bashism

[GitBox]

iadbbwarln opened a new pull request #90: Remove bashism
URL: https://github.com/apache/joshua/pull/90
 
 
   Remove bashism and requirement for system to have /bin/sh == bash.
   
   This is required to run on Debian10 amd64.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [joshua] tteofili commented on pull request #91: Update Dockerfile

[GitBox]

tteofili commented on pull request #91:
URL: https://github.com/apache/joshua/pull/91#issuecomment-619388075


   thanks @arfunk , and +1 if you have time to write a full fledged tutorial 
that'd be great!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [joshua] lewismc commented on pull request #91: Update Dockerfile

[GitBox]

lewismc commented on pull request #91:
URL: https://github.com/apache/joshua/pull/91#issuecomment-619091267


   +1 @arfunk 
   I wonder if you could insert some content to the README to detail usage with 
Docker?
   @tteofili wdyt?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [joshua] arfunk commented on pull request #91: Update Dockerfile

[GitBox]

arfunk commented on pull request #91:
URL: https://github.com/apache/joshua/pull/91#issuecomment-619102134


   > +1 @arfunk
   > I wonder if you could insert some content to the README to detail usage 
with Docker?
   > @tteofili wdyt?
   
   So what kind of details? 
   Documentation about running Apache Joshua with Docker is 
[here](https://cwiki.apache.org/confluence/display/JOSHUA/Docker)
   If you need more information I can write a detailed tutorial how to build a 
working environment with docker and downloaded language pack. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org