[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase
[ https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398365#comment-15398365 ] Hudson commented on JOSHUA-286: --- SUCCESS: Integrated in joshua_master #83 (See [https://builds.apache.org/job/joshua_master/83/]) JOSHUA-286 - Update replacement of old joshua-decoder.org links (johnhew: rev 903770f0fd5a97979512ca40b422f0ee7a494fda) * src/main/java/org/apache/joshua/decoder/Decoder.java * CHANGELOG * .gitignore * scripts/support/make-release.sh > Remove presence of all joshua-decoder.org links in codebase > --- > > Key: JOSHUA-286 > URL: https://issues.apache.org/jira/browse/JOSHUA-286 > Project: Joshua > Issue Type: Improvement > Components: documentation >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > Right now, joshua-decoder.org exists in the following files, we should remove > it and replace it with joshua.apache.org > {code} > lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr > "joshua-decoder.org" . > ./.gitignore > ./CHANGELOG > ./doc/mainpage.md > ./scripts/support/make-release.sh > ./src/main/java/org/apache/joshua/decoder/Decoder.java > ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase
[ https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398275#comment-15398275 ] ASF GitHub Bot commented on JOSHUA-286: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/32 > Remove presence of all joshua-decoder.org links in codebase > --- > > Key: JOSHUA-286 > URL: https://issues.apache.org/jira/browse/JOSHUA-286 > Project: Joshua > Issue Type: Improvement > Components: documentation >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > Right now, joshua-decoder.org exists in the following files, we should remove > it and replace it with joshua.apache.org > {code} > lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr > "joshua-decoder.org" . > ./.gitignore > ./CHANGELOG > ./doc/mainpage.md > ./scripts/support/make-release.sh > ./src/main/java/org/apache/joshua/decoder/Decoder.java > ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] incubator-joshua issue #32: JOSHUA-286 - Replace old joshua-decoder.org link...
Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/32 Can someone please merge in to master? Thanks @john-hewitt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase
[ https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398254#comment-15398254 ] ASF GitHub Bot commented on JOSHUA-286: --- Github user lewismc commented on the issue: https://github.com/apache/incubator-joshua/pull/32 Can someone please merge in to master? Thanks @john-hewitt > Remove presence of all joshua-decoder.org links in codebase > --- > > Key: JOSHUA-286 > URL: https://issues.apache.org/jira/browse/JOSHUA-286 > Project: Joshua > Issue Type: Improvement > Components: documentation >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > Right now, joshua-decoder.org exists in the following files, we should remove > it and replace it with joshua.apache.org > {code} > lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr > "joshua-decoder.org" . > ./.gitignore > ./CHANGELOG > ./doc/mainpage.md > ./scripts/support/make-release.sh > ./src/main/java/org/apache/joshua/decoder/Decoder.java > ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: master pushes
Great, thanks, Kellen. It's nice how it shows with a check on github! matt > On Jul 28, 2016, at 11:32 AM, kellen sunderland > wrote: > > Ahh, I see we don't yet have a travis.yml. Let me try and create one ... > Pull request should be coming soon. > > -Kellen > > On Thu, Jul 28, 2016 at 5:30 PM, kellen sunderland < > kellen.sunderl...@gmail.com> wrote: > >> Hey Matt, what still needs to be setup? I can try and help out. >> >> On Thu, Jul 28, 2016 at 4:49 PM, Matt Post wrote: >> >>> Hi folks, >>> >>> Sorry for the continued pushes to master. We have had Travis-CI enabled, >>> but I haven't taken the time to get it setup. Someone else should feel free >>> to take charge, here; otherwise, I hope to have time to do this after my >>> workshop is done, at the end of next week. >>> >>> matt >> >> >>
[GitHub] incubator-joshua issue #33: Refactored unit tests to all use TestNG, removed...
Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/33 Does this pass your tests? When I run it, I get errors related to maven-surefire-plugin. I thought I'd check if you know what this is about before I dig into it. Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project joshua: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called? [ERROR] Command was /bin/sh -c cd /Users/post/code/joshua && /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre/bin/java -Djava.library.path=/Users/post/code/joshua/lib -jar /Users/post/code/joshua/target/surefire/surefirebooter3138892612018380852.jar /Users/post/code/joshua/target/surefire/surefire2495440792813112582tmp /Users/post/code/joshua/target/surefire/surefire_03287663746024243525tmp --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-joshua pull request #34: Enable basic travis build
Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (JOSHUA-285) Not all RuntimeExceptions are caught
[ https://issues.apache.org/jira/browse/JOSHUA-285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kellen Sunderland reassigned JOSHUA-285: Assignee: Kellen Sunderland > Not all RuntimeExceptions are caught > > > Key: JOSHUA-285 > URL: https://issues.apache.org/jira/browse/JOSHUA-285 > Project: Joshua > Issue Type: Bug >Reporter: Matt Post >Assignee: Kellen Sunderland > Fix For: 6.1 > > > In many instances Joshua threads will throw a RuntimeException that is not > caught, causing the decoder to hang indefinitely. These should be caught and, > if serious enough, cause the decoder to die. An example of an error that is > caught is running out of memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] incubator-joshua pull request #34: Enable basic travis build
GitHub user KellenSunderland opened a pull request: https://github.com/apache/incubator-joshua/pull/34 Enable basic travis build This should get us started with Travis. I'll open a PR to see if we're at least passing with a basic config, then add some more build steps later. You can merge this pull request into a Git repository by running: $ git pull https://github.com/KellenSunderland/incubator-joshua travis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit b9b43531e84a7922b3a3126754d32a46fae3b9eb Author: Kellen Sunderland Date: 2016-07-28T15:45:30Z Enable basic travis build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: master pushes
Ahh, I see we don't yet have a travis.yml. Let me try and create one ... Pull request should be coming soon. -Kellen On Thu, Jul 28, 2016 at 5:30 PM, kellen sunderland < kellen.sunderl...@gmail.com> wrote: > Hey Matt, what still needs to be setup? I can try and help out. > > On Thu, Jul 28, 2016 at 4:49 PM, Matt Post wrote: > >> Hi folks, >> >> Sorry for the continued pushes to master. We have had Travis-CI enabled, >> but I haven't taken the time to get it setup. Someone else should feel free >> to take charge, here; otherwise, I hope to have time to do this after my >> workshop is done, at the end of next week. >> >> matt > > >
[jira] [Comment Edited] (JOSHUA-287) KenLM.java catches UnsatisfiedLinkError when attempting to load libken.so (libken.dylib on OSX)
[ https://issues.apache.org/jira/browse/JOSHUA-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397701#comment-15397701 ] Kellen Sunderland edited comment on JOSHUA-287 at 7/28/16 3:42 PM: --- I should have addressed this in my latest PR. https://github.com/apache/incubator-joshua/pull/33 I think the correct behaviour is to throw a RuntimeException here. There are two environments to consider, testing, and the general case. At test time my feeling is that if a user doesn't have libkenlm we should simply skip any tests that rely on KenLM. We shouldn't force users to download/compile KenLM just to run unit tests. In general if we make a call into the KenLM class and the library is not on our java.library.path it's a serious error. We should throw a descriptive exception (now a KenLMLoadException which extends Runtime) and let the caller deal with it. Can you provide some details on how this breaks Sonar? Is it still broken after the PR? was (Author: kellen.sunderland): I should have addressed this in my latest PR. https://github.com/apache/incubator-joshua/pull/33 I think the correct behaviour is to throw a RuntimeException here. There are two environments to consider, testing, and the general case. At test time my feeling is that we should simply skip any tests that rely on KenLM. We shouldn't force users to download/compile KenLM just to run unit tests. In general if we make a call into the KenLM class and the library is not on our java.library.path it's a serious error. We should throw a descriptive exception (now a KenLMLoadException which extends Runtime) and let the caller deal with it. Can you provide some details on how this breaks Sonar? Is it still broken after the PR? > KenLM.java catches UnsatisfiedLinkError when attempting to load libken.so > (libken.dylib on OSX) > --- > > Key: JOSHUA-287 > URL: https://issues.apache.org/jira/browse/JOSHUA-287 > Project: Joshua > Issue Type: Bug > Components: core, kenlm >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As explained in > http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg01189.html > currently we have an issue, where, when checked out from master the following > RuntimeException is thrown. > {code} > --- > T E S T S > --- > Running TestSuite > WARN - sentence 0 too long 401, truncating to length 200 > WARN - sentence 0 too long 401, truncating to length 200 > WARN - sentence 0 too long 401, truncating to length 200 > WARN - sentence 0 too long 401, truncating to length 200 > tm_pt_0=-2.000 tm_glue_0=3.000 lm_0=-206.718 lm_0_oov=2.000 > OOVPenalty=-200.000 | -198.000 > ERROR - * FATAL: Can't find libken.so (libken.dylib on OS X) in $JOSHUA/lib > ERROR - *This probably means that the KenLM library didn't compile. > ERROR - *Make sure that BOOST_ROOT is set to the root of your boost > ERROR - *installation (it's not /opt/local/, the default), change to > ERROR - *$JOSHUA, and type 'ant kenlm'. If problems persist, see the > ERROR - *website (joshua-decoder.org). > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > {code} > We need to fix this such that we can run static source code analysis via > sonar and have our results available on analysis.apache.org. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-287) KenLM.java catches UnsatisfiedLinkError when attempting to load libken.so (libken.dylib on OSX)
[ https://issues.apache.org/jira/browse/JOSHUA-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397701#comment-15397701 ] Kellen Sunderland commented on JOSHUA-287: -- I should have addressed this in my latest PR. https://github.com/apache/incubator-joshua/pull/33 I think the correct behaviour is to throw a RuntimeException here. There are two environments to consider, testing, and the general case. At test time my feeling is that we should simply skip any tests that rely on KenLM. We shouldn't force users to download/compile KenLM just to run unit tests. In general if we make a call into the KenLM class and the library is not on our java.library.path it's a serious error. We should throw a descriptive exception (now a KenLMLoadException which extends Runtime) and let the caller deal with it. Can you provide some details on how this breaks Sonar? Is it still broken after the PR? > KenLM.java catches UnsatisfiedLinkError when attempting to load libken.so > (libken.dylib on OSX) > --- > > Key: JOSHUA-287 > URL: https://issues.apache.org/jira/browse/JOSHUA-287 > Project: Joshua > Issue Type: Bug > Components: core, kenlm >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > As explained in > http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg01189.html > currently we have an issue, where, when checked out from master the following > RuntimeException is thrown. > {code} > --- > T E S T S > --- > Running TestSuite > WARN - sentence 0 too long 401, truncating to length 200 > WARN - sentence 0 too long 401, truncating to length 200 > WARN - sentence 0 too long 401, truncating to length 200 > WARN - sentence 0 too long 401, truncating to length 200 > tm_pt_0=-2.000 tm_glue_0=3.000 lm_0=-206.718 lm_0_oov=2.000 > OOVPenalty=-200.000 | -198.000 > ERROR - * FATAL: Can't find libken.so (libken.dylib on OS X) in $JOSHUA/lib > ERROR - *This probably means that the KenLM library didn't compile. > ERROR - *Make sure that BOOST_ROOT is set to the root of your boost > ERROR - *installation (it's not /opt/local/, the default), change to > ERROR - *$JOSHUA, and type 'ant kenlm'. If problems persist, see the > ERROR - *website (joshua-decoder.org). > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > WARN - no grammars supplied! Supplying dummy glue grammar. > {code} > We need to fix this such that we can run static source code analysis via > sonar and have our results available on analysis.apache.org. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: master pushes
Hey Matt, what still needs to be setup? I can try and help out. On Thu, Jul 28, 2016 at 4:49 PM, Matt Post wrote: > Hi folks, > > Sorry for the continued pushes to master. We have had Travis-CI enabled, > but I haven't taken the time to get it setup. Someone else should feel free > to take charge, here; otherwise, I hope to have time to do this after my > workshop is done, at the end of next week. > > matt
[GitHub] incubator-joshua pull request #33: Refactored unit tests to all use TestNG, ...
GitHub user KellenSunderland opened a pull request: https://github.com/apache/incubator-joshua/pull/33 Refactored unit tests to all use TestNG, removed no longer applicable⦠⦠tests, refactored KenLM in order to make handling upstream errors easier You can merge this pull request into a Git repository by running: $ git pull https://github.com/KellenSunderland/incubator-joshua master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 701d746d9670964b77b7f8fd26b030deccf25f0c Author: Kellen Sunderland Date: 2016-07-12T17:34:52Z Refactored unit tests to all use TestNG, removed no longer applicable tests, refactored KenLM in order to make handling upstream errors easier --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase
[ https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397668#comment-15397668 ] ASF GitHub Bot commented on JOSHUA-286: --- Github user john-hewitt commented on the issue: https://github.com/apache/incubator-joshua/pull/32 @lewismc Improvements addressed. Happy to help. > Remove presence of all joshua-decoder.org links in codebase > --- > > Key: JOSHUA-286 > URL: https://issues.apache.org/jira/browse/JOSHUA-286 > Project: Joshua > Issue Type: Improvement > Components: documentation >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > Right now, joshua-decoder.org exists in the following files, we should remove > it and replace it with joshua.apache.org > {code} > lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr > "joshua-decoder.org" . > ./.gitignore > ./CHANGELOG > ./doc/mainpage.md > ./scripts/support/make-release.sh > ./src/main/java/org/apache/joshua/decoder/Decoder.java > ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] incubator-joshua issue #32: JOSHUA-286 - Replace old joshua-decoder.org link...
Github user john-hewitt commented on the issue: https://github.com/apache/incubator-joshua/pull/32 @lewismc Improvements addressed. Happy to help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
master pushes
Hi folks, Sorry for the continued pushes to master. We have had Travis-CI enabled, but I haven't taken the time to get it setup. Someone else should feel free to take charge, here; otherwise, I hope to have time to do this after my workshop is done, at the end of next week. matt
[jira] [Created] (JOSHUA-288) Port fast_align to java
Matt Post created JOSHUA-288: Summary: Port fast_align to java Key: JOSHUA-288 URL: https://issues.apache.org/jira/browse/JOSHUA-288 Project: Joshua Issue Type: New Feature Reporter: Matt Post Priority: Minor It would be great to have a Java port of fast_align, so that we don't have to worry about compiling it, and could distribute it via Maven. https://github.com/clab/fast_align -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase
[ https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397497#comment-15397497 ] ASF GitHub Bot commented on JOSHUA-286: --- Github user mjpost commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72616102 --- Diff: scripts/support/make-release.sh --- @@ -40,7 +40,7 @@ echo "Bundling up joshua-$version" [[ ! -d release ]] && mkdir release rm -f joshua-$version && ln -s $JOSHUA joshua-$version -wget -r http://joshua-decoder.org/ +wget -r http://joshua.apache.org/6.0/ --- End diff -- This was intended to bundle a crawl of the website with the release. It should be removed. Joshua is now hosted on Confluence, so the directory paths now longer work. Also, Confluence has better tools for documentation export if we should decide to use them in the future. > Remove presence of all joshua-decoder.org links in codebase > --- > > Key: JOSHUA-286 > URL: https://issues.apache.org/jira/browse/JOSHUA-286 > Project: Joshua > Issue Type: Improvement > Components: documentation >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > Right now, joshua-decoder.org exists in the following files, we should remove > it and replace it with joshua.apache.org > {code} > lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr > "joshua-decoder.org" . > ./.gitignore > ./CHANGELOG > ./doc/mainpage.md > ./scripts/support/make-release.sh > ./src/main/java/org/apache/joshua/decoder/Decoder.java > ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user mjpost commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72616102 --- Diff: scripts/support/make-release.sh --- @@ -40,7 +40,7 @@ echo "Bundling up joshua-$version" [[ ! -d release ]] && mkdir release rm -f joshua-$version && ln -s $JOSHUA joshua-$version -wget -r http://joshua-decoder.org/ +wget -r http://joshua.apache.org/6.0/ --- End diff -- This was intended to bundle a crawl of the website with the release. It should be removed. Joshua is now hosted on Confluence, so the directory paths now longer work. Also, Confluence has better tools for documentation export if we should decide to use them in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JOSHUA-286) Remove presence of all joshua-decoder.org links in codebase
[ https://issues.apache.org/jira/browse/JOSHUA-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397495#comment-15397495 ] ASF GitHub Bot commented on JOSHUA-286: --- Github user mjpost commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72615877 --- Diff: .gitignore --- @@ -42,6 +42,7 @@ doxygen_*.tmp .cachepipe joshua-decoder.org +joshua.apache.org --- End diff -- Yeah, agreed. I used to bundle a crawl of the website with the repo, but am no longer going to do so. > Remove presence of all joshua-decoder.org links in codebase > --- > > Key: JOSHUA-286 > URL: https://issues.apache.org/jira/browse/JOSHUA-286 > Project: Joshua > Issue Type: Improvement > Components: documentation >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney > Fix For: 6.1 > > > Right now, joshua-decoder.org exists in the following files, we should remove > it and replace it with joshua.apache.org > {code} > lmcgibbn@LMC-032857 /usr/local/incubator-joshua(JOSHUA-283) $ grep -lr > "joshua-decoder.org" . > ./.gitignore > ./CHANGELOG > ./doc/mainpage.md > ./scripts/support/make-release.sh > ./src/main/java/org/apache/joshua/decoder/Decoder.java > ./src/main/java/org/apache/joshua/decoder/ff/lm/KenLM.java > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] incubator-joshua pull request #32: JOSHUA-286 - Replace old joshua-decoder.o...
Github user mjpost commented on a diff in the pull request: https://github.com/apache/incubator-joshua/pull/32#discussion_r72615877 --- Diff: .gitignore --- @@ -42,6 +42,7 @@ doxygen_*.tmp .cachepipe joshua-decoder.org +joshua.apache.org --- End diff -- Yeah, agreed. I used to bundle a crawl of the website with the repo, but am no longer going to do so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---