[GitHub] incubator-joshua pull request #69: JOSHUA-290 - provide Joshua as a bundle

[hsaputra]

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r81881247
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

This should go to `maven-multi-module` branch I suppose?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request #36: Demo

[hsaputra]

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/36#discussion_r73449163
  
--- Diff: src/main/java/org/apache/joshua/server/ServerThread.java ---
@@ -225,15 +225,18 @@ private void handleMetadata(String meta, JSONMessage 
message) {
   String source = argTokens[1];
   String target = argTokens[2];
   String featureStr = "";
+  String alignmentStr = "";
   if (argTokens.length > 3) 
 featureStr = argTokens[3];
-  
+  if (argTokens.length > 4)
+alignmentStr = " ||| " + argTokens[4];
--- End diff --

What is this `alignmentStr` argument for ? Wonder if we could add test for 
this new argument


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

[hsaputra]

Github user hsaputra commented on the issue:

https://github.com/apache/incubator-joshua/pull/24
  
Just to clarify, so the idea is to move components into separate modules 
that could be compile and included by parent module?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: Joshua-262: Slf4j - Log4j bridge

[hsaputra]

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/15#discussion_r64159711
  
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaConfiguration.java 
---
@@ -587,7 +588,7 @@ else if (fds[1].toLowerCase().equals("http"))
   } else if (parameter
   
.equals(normalize_key(SOFT_SYNTACTIC_CONSTRAINT_DECODING_PROPERTY_NAME))) {
 fuzzy_matching = Boolean.parseBoolean(fds[1]);
-logger.finest(String.format(fuzzy_matching + ": %s", 
fuzzy_matching));
+LOG.debug("fuzzy_matching: {}", fuzzy_matching);
--- End diff --

Thx for the reply, @thammegowda.
I don't have strong preference on this, so +1 for keeping as DEBUG level.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request: Joshua-262: Slf4j - Log4j bridge

[hsaputra]

Github user hsaputra commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/15#discussion_r64144497
  
--- Diff: src/main/java/org/apache/joshua/decoder/JoshuaConfiguration.java 
---
@@ -587,7 +588,7 @@ else if (fds[1].toLowerCase().equals("http"))
   } else if (parameter
   
.equals(normalize_key(SOFT_SYNTACTIC_CONSTRAINT_DECODING_PROPERTY_NAME))) {
 fuzzy_matching = Boolean.parseBoolean(fds[1]);
-logger.finest(String.format(fuzzy_matching + ": %s", 
fuzzy_matching));
+LOG.debug("fuzzy_matching: {}", fuzzy_matching);
--- End diff --

Should this match to TRACE instead of DEBUG?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---