[GitHub] incubator-joshua pull request #25: ClassLMs: fixed a bug with class-based lm...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request #25: ClassLMs: fixed a bug with class-based lm...

[fhieber]

GitHub user fhieber opened a pull request:

https://github.com/apache/incubator-joshua/pull/25

ClassLMs: fixed a bug with class-based lms not mapping to class ids for 
estimateCost()

Also refactored the code a little bit to have StateMinimizingLanguageModels 
support classes as well. Added some unit tests. The existing regression test 
output was changed to the new output.

@mjpost It is hard to see whether the new regression output for 
test-classlm.sh is 'more' correct than before. If you could test this change 
with some of your models that use class-based lms, that'd be great.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fhieber/incubator-joshua master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #25


commit 8fc7544eaaf35f71367b48778eaa1f22772ca390
Author: Felix Hieber 
Date:   2016-06-20T09:21:03Z

ClassLMs: fixed a bug with class-based lms not mapping to class ids when 
estimateCost(). Also refactored the code a little bit to have 
StateMinimizingLanguageModels support classes as well. Added some unit tests. 
The existing regression test output was changed to the new output.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---