[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313110#comment-15313110 ] Thamme Gowda commented on JOSHUA-262: - Yes, I think we can close this [~post] > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313106#comment-15313106 ] Matt Post commented on JOSHUA-262: -- This is done, right? Can we close out this request, [~tgow...@gmail.com]? > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301637#comment-15301637 ] ASF GitHub Bot commented on JOSHUA-262: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/17 > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294664#comment-15294664 ] Thamme Gowda commented on JOSHUA-262: - that means: - 0 for DEBUG. When we set level to INFO, these messages don't show up. - 1 for INFO. No ambiguities here - 2+ It seems like DEBUG, although I am not sure Since log4j allows us to set different levels to specific classes and packages, we can tune them. I will send any System.err.print*s to ERROR and System.out.print*s to INFO. Please correct me if this is wrong. > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294656#comment-15294656 ] Lewis John McGibbney commented on JOSHUA-262: - I honestly have no idea. > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-262) Implement all logging as Slf4j over Log4j
[ https://issues.apache.org/jira/browse/JOSHUA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294655#comment-15294655 ] Matt Post commented on JOSHUA-262: -- It's not very systematic. - 0: print nothing. This mostly works, except the flag is not passed to KenLM, which sometimes prints something - 1: print "basic" information, like progress loading models, information about each sentence, and so on - 2+: extended debugging and detail I think it's useful to have a "silent" model (-v 0), and 1 should probably be for INFO. I'm not sure what the standard practice is when you want extra debugging output? > Implement all logging as Slf4j over Log4j > - > > Key: JOSHUA-262 > URL: https://issues.apache.org/jira/browse/JOSHUA-262 > Project: Joshua > Issue Type: Improvement > Components: core >Affects Versions: 6.0.5 >Reporter: Lewis John McGibbney >Assignee: Thamme Gowda N > Fix For: 6.1 > > > [~hsaputra] suggested that we implement all logging as Slf4j over Log4j. If > we use [parameterized logging > notation|http://www.slf4j.org/faq.html#logging_performance] we can have good > logging in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
