[jira] [Commented] (JOSHUA-273) Joshua API
[ https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346780#comment-15346780 ] Matt Post commented on JOSHUA-273: -- Okay, so in the near future, I plan to make some small changes here in the direction of having a better API. My plan is to - Extract the output writer code from KBestExtractor, moving it all to StructuredTranslationFactory - Turn KBestExtractor into an iterator There will likely be other changes that will get triggered with this, but I thought I would let you know these plans in case it triggers any comments. > Joshua API > -- > > Key: JOSHUA-273 > URL: https://issues.apache.org/jira/browse/JOSHUA-273 > Project: Joshua > Issue Type: Improvement >Reporter: Matt Post > Fix For: 7 > > > We have a lot of work to do to clean up the decoder's internal object > pipeline in order to create a nice, clean API. > (This is just a stub for this issue; I will return soon with a better > description and roadmap. Others feel free to edit, as well). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-273) Joshua API
[ https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339419#comment-15339419 ] ASF GitHub Bot commented on JOSHUA-273: --- Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/commit/6d2213a20b74432fc7cb131c732f7507b74053e9#commitcomment-17933088 In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java: In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java on line 57: Hi Felix — I guess I probably don't. I put this in so as to have the convenience functions of querying the maps (that are in FeatureVector), and didn't realize why you guys had stuck with just a HashMap. I'll revert it. In general, this relates to JOSHUA-273: I want to remove all the output code from KBestExtractor and place it in StructuredTranslation (and then, in turn, to collapse Translation and StructuredTranslation). There are at least two ways to do this; do you have a preference? - StructuredTranslationFactory could be called to create the necessary entries in StructuredTranslation, which would then just be stored as strings. This approach makes StructuredTranslation basically just a container that is operated on. - StructuredTranslation can do its own computation, formatting the "outputFormat" line from the config file. This view makes StructuredTranslation itself a bit smarter. matt > Joshua API > -- > > Key: JOSHUA-273 > URL: https://issues.apache.org/jira/browse/JOSHUA-273 > Project: Joshua > Issue Type: Improvement >Reporter: Matt Post > Fix For: 7 > > > We have a lot of work to do to clean up the decoder's internal object > pipeline in order to create a nice, clean API. > (This is just a stub for this issue; I will return soon with a better > description and roadmap. Others feel free to edit, as well). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-273) Joshua API
[ https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307694#comment-15307694 ] ASF GitHub Bot commented on JOSHUA-273: --- Github user fhieber commented on the pull request: https://github.com/apache/incubator-joshua/pull/20 You are right, the structural changes in this PR are subsumed by JOSHUA-273 mostly. However, the changes to the alignment code would still be beneficial. > Joshua API > -- > > Key: JOSHUA-273 > URL: https://issues.apache.org/jira/browse/JOSHUA-273 > Project: Joshua > Issue Type: Improvement >Reporter: Matt Post > Fix For: 7 > > > We have a lot of work to do to clean up the decoder's internal object > pipeline in order to create a nice, clean API. > (This is just a stub for this issue; I will return soon with a better > description and roadmap. Others feel free to edit, as well). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-273) Joshua API
[ https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307688#comment-15307688 ] ASF GitHub Bot commented on JOSHUA-273: --- Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/20 So it seems this isn't compatible with JOSHUA-273 (which is fine), but provides some of its functionality. One concern I have is the complexity of juggling the master branch, JOSHUA-252, JOSHUA-273, and these changes in my head right now. I'd really like to get JOSHUA-252 merged in to help simplify things. We would then want to merge either (a) JOSHUA-273, after having Decoder.decodeAll() return Translations, (b) merge this PR, or both. The reason I'm pushing a bit for JOSHUA-273 is because I also removed a lot of the redundancies in k-best extraction and so on, collapsed Translation and StructuredTranslation, and did some other things. It seems that it subsumes this PR? In which case, it might be less complex to go that route. But correct me if I'm wrong, or if JOSHUA-273 is headed in the wrong direction, or if this PR has some short-term advantage that can help us out in the meantime. > Joshua API > -- > > Key: JOSHUA-273 > URL: https://issues.apache.org/jira/browse/JOSHUA-273 > Project: Joshua > Issue Type: Improvement >Reporter: Matt Post > Fix For: 7 > > > We have a lot of work to do to clean up the decoder's internal object > pipeline in order to create a nice, clean API. > (This is just a stub for this issue; I will return soon with a better > description and roadmap. Others feel free to edit, as well). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-273) Joshua API
[ https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307682#comment-15307682 ] ASF GitHub Bot commented on JOSHUA-273: --- Github user fhieber commented on the pull request: https://github.com/apache/incubator-joshua/pull/20 These changes would not be immediately compatible with JOSHUA-273. The latter is unlikely to be immediately merged, right? Basically, the KBestExtractor now may return StructuredTranslations so that you can return them if Joshua is used as a library. > Joshua API > -- > > Key: JOSHUA-273 > URL: https://issues.apache.org/jira/browse/JOSHUA-273 > Project: Joshua > Issue Type: Improvement >Reporter: Matt Post > Fix For: 7 > > > We have a lot of work to do to clean up the decoder's internal object > pipeline in order to create a nice, clean API. > (This is just a stub for this issue; I will return soon with a better > description and roadmap. Others feel free to edit, as well). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-273) Joshua API
[ https://issues.apache.org/jira/browse/JOSHUA-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307640#comment-15307640 ] ASF GitHub Bot commented on JOSHUA-273: --- Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/20 I plan to look at this this morning. One question: how does this relate to the changes in JOSHUA-273? Are they more or less along the same lines, or do they do different things? If I changed JOSHUA-273 so that Decoder.decodeAll() returns a Translation object, would that accomplish what you've done here? If you have any notes on this (or even an I don't know) that will inform my review. > Joshua API > -- > > Key: JOSHUA-273 > URL: https://issues.apache.org/jira/browse/JOSHUA-273 > Project: Joshua > Issue Type: Improvement >Reporter: Matt Post > Fix For: 7 > > > We have a lot of work to do to clean up the decoder's internal object > pipeline in order to create a nice, clean API. > (This is just a stub for this issue; I will return soon with a better > description and roadmap. Others feel free to edit, as well). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
