Re: [apache/jspwiki] Clickable buttons (#1)

[Harry Metske]

I had seen it before on the dev list.
But since it was mostly frontend, I did not comment.

cheers,
Harry


On Tue, 29 May 2018 at 00:40, Juan Pablo Santos Rodríguez <
juanpablo.san...@gmail.com> wrote:

> Hi,
>
> I was looking for the below mail at [user|dev|commits]@jspwiki.a.o. As I
> can't see it through Pony Mail, I'm resending over
> dev. Would anyone mind confirming if this is the first time receiving the
> e-mail? (if not, apologies for the noise).
>
> And regarding the PR itself, any thoughts on it? I find it useful, esp. for
> mobile devices, and would be +1 for merging it,
> but I don't have a strong opinion on it, frontend isn't one of my key
> points..
>
>
> thanks in advance,
> juan pablo
>
>
> -- Forwarded message --
> From: jonasmue 
> Date: Fri, May 25, 2018 at 1:35 PM
> Subject: [apache/jspwiki] Clickable buttons (#1)
> To: apache/jspwiki 
> Cc: Subscribed 
>
>
> Made header buttons clickable instead of hoverable. This change should
> result in increased usability since the opening boxes frequently would have
> been closed involuntarily if user's mouse movement was not precise enough
> after hovering over the buttons. Removed the carets for consistency reasons
> as they indicate a hoverable target.
> --
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/apache/jspwiki/pull/1
> Commit Summary
>
>- Clickable header buttons
>- Updated to current state and removed other changes
>- Changed indentation to original form
>
> File Changes
>
>- *M* jspwiki-war/src/main/scripts/wiki/Wiki.js
> (35)
>- *M* jspwiki-war/src/main/webapp/templates/haddock/SearchBox.jsp
> (4)
>- *M* jspwiki-war/src/main/webapp/templates/haddock/UserBox.jsp
> (4)
>
> Patch Links:
>
>- https://github.com/apache/jspwiki/pull/1.patch
>- https://github.com/apache/jspwiki/pull/1.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> , or mute the thread
> <
> https://github.com/notifications/unsubscribe-auth/ABKX4v23eYQ0kCinSJj1cWhts1HVqYbUks5t1-yBgaJpZM4UN0uj
> >
> .
>

Re: NPE while building (was: Re: [VOTE] Release JSPWiki version 2.10.4)

[Brian Burch]

On 29/05/18 08:13, Juan Pablo Santos Rodríguez wrote:

Hi Brian,

the jdk.version property is used indeed to set the source and target
arguments of the compiler plugin, and also to
set the minimum JDK required to compile the project (see the configuration
of the enforcer plugin on the base pom).
Forcing it to 1.6 won't solve the problem of compiling with a JDK 10, as
the problem is with that JDK + the version
of the surefire plugin.

Upgrading surefire to 2.21.0 should be enough; I recall reading somewhere
that the compiler's plugin version needed
for using JDK9+ must be 3.7.0 or greater, which it already is, but it needs
some tweaking too. 2.10.5-git-01 should
be ok to be compiled with JDK10, if you won't mind testing with current
master.. O:-) In any case, I've also opened
JSPWIKI-1070 (and solved for 2.10.5-git-01) to track this issue; if
anything else arises, we'll reopen it.


Given that I missed the vote, I didn't want to "drop the ball". I 
started from scratch and you definitely got me past the surefire problem.


I ran "mvn -x clean install" while cooking steaks on the BBQ and now (in 
QLD) its time to sip a glass of wine before going to bed (we all go to 
bed early here!). The tests seemed to run ok, but there was a new crash 
further down the track...


Forgive me for being lazy, but I felt it was better to let you have the 
console log while your day was starting and mine ending - if I don't 
hear back, that's OK, I will do some digging tomorrow.


Here's the last bit of the console log:-

[INFO]
[INFO] --- jslint-maven-plugin:1.0.1:jslint (checkThirdParty) @ 
jspwiki-war ---

[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process 
(process-resource-bundles) @ jspwiki-war ---

[INFO]
[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ 
jspwiki-war ---

[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 37 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @ 
jspwiki-war ---

[INFO] Changes detected - recompiling the module!
[INFO] Compiling 356 source files to 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/target/classes
[INFO] 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/src/main/java/org/apache/wiki/render/CleanTextRenderer.java: 
Some input files use or override a deprecated API.
[INFO] 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/src/main/java/org/apache/wiki/render/CleanTextRenderer.java: 
Recompile with -Xlint:deprecation for details.
[INFO] 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/src/main/java/org/apache/wiki/WikiEngine.java: 
Some input files use unchecked or unsafe operations.
[INFO] 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/src/main/java/org/apache/wiki/WikiEngine.java: 
Recompile with -Xlint:unchecked for details.

[INFO]
[INFO] --- maven-resources-plugin:3.0.2:testResources 
(default-testResources) @ jspwiki-war ---

[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 13 resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.7.0:testCompile (default-testCompile) 
@ jspwiki-war ---

[INFO] Changes detected - recompiling the module!
[INFO] Compiling 139 source files to 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/target/test-classes
[INFO] 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/src/test/java/org/apache/wiki/TestJDBCDataSource.java: 
Some input files use or override a deprecated API.
[INFO] 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/src/test/java/org/apache/wiki/TestJDBCDataSource.java: 
Recompile with -Xlint:deprecation for details.
[INFO] 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/src/test/java/org/apache/wiki/auth/permissions/GroupPermissionTest.java: 
Some input files use unchecked or unsafe operations.
[INFO] 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/src/test/java/org/apache/wiki/auth/permissions/GroupPermissionTest.java: 
Recompile with -Xlint:unchecked for details.

[INFO]
[INFO] --- maven-surefire-plugin:2.21.0:test (default-test) @ 
jspwiki-war ---
[INFO] Surefire report directory: 
/home/brian/sandboxApache/jspwiki-2.10.5/jspwiki-war/target/surefire-reports

[INFO]
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running org.apache.wiki.PropertyReaderTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.187 s - in org.apache.wiki.PropertyReaderTest

[INFO] Running org.apache.wiki.search.SearchManagerTest
log4j:WARN No appenders could be found for logger 
(net.sf.ehcache.config.ConfigurationFactory).

log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
39.389 s - in org.apache.wiki.search.SearchManagerTest

[INFO] Running 

Re: Blog post for review: JSPWiki 2.10.4

[Dave Koelmeyer]

bump

On 28/05/18 21:27, Dave Koelmeyer wrote:
> Hi folks,
>
> For review, please let me know if okay to publish.
>
> **
>
> => Announcing Apache JSPWiki 2.10.4
>
> We're pleased to announce the availability of Apache JSPWiki version
> 2.10.4. Following are the notable changes included in this release.
>
> => Improvements to the Haddock template
>
> Haddock is JSPWiki's next generation template. Building on the huge
> number of new features shipped in 2.10.3, changes in 2.10.4 include a
> floating editing toolbar (JSPWIKI-1058). This is especially useful when
> editing long pages, as the toolbar is always visible without having to
> scroll to the top of the page:
>
> 
>
> Work is also continuing to improve support for mobile devices
> (JSPWIKI-835), and a new favicon has been added.
>
> => Fixes for ACLs
>
> * JSPWIKI-1039 – ACLs are not taken into account when cache is disabled
> * JSPWIKI-1047 – Access Control Lists do not work if page cache is
> deactivated
> * JSPWIKI-1067 – View-only ACLs are not enforced
>
> => Other fixes
>
> JSPWiki 2.10.4 corrects German language translation errors, and a
> rendering cache fix.
>
> => For more information
>
> For a full list of changes see the ChangeLog file or our issue tracker.
>
> The release is available for download at:
>
> * http://www.apache.org/dyn/closer.cgi/jspwiki/
>
> JSPWiki Maven artifacts are available under org.apache.jspwiki groupId,
> version 2.10.4
>
> All JSPWiki site administrators are encouraged to update. To get
> involved, visit the project website at http://jspwiki.apache.org. For
> feedback, help, and developer queries please visit us on the mailing lists.
>
> **
>
>

-- 
Dave Koelmeyer
http://blog.davekoelmeyer.co.nz
GPG Key ID: 0x238BFF87
The Document Foundation (TDF) member