Re: [VOTE] Release JSPWiki version 2.11.0.M1
The discussion below is useful warning for me because I am (very slowly!) setting up a test tomcat to validate the new version of jspwiki, but then I have my own plugins to migrate. I had intended to also migrate from the old default template to haddock, but it seems that step will be automatic in my case. Because I can't currently install and properly validate RC3, I've only built and tested on two different systems, both running ubuntu with 4.18.0-13 (generic and low-latency) x86_64 kernels and OpenJDK 64-Bit Server VM (build 11.0.1+13-Ubuntu-2ubuntu1, mixed mode, sharing). mvn install/test runs on both systems were 100% successful, so... +1 Well done and thanks! Brian On 28/1/19 8:11 am, Juan Pablo Santos Rodríguez wrote: Hi Murray, I think it's a valid point, we discussed it on the dev list but people migrating don't have to have readed it.. I've added a prominent section noting this at https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 Also, the relevant key at jspwiki.properties is already stating the allowed values, see: https://github.com/apache/jspwiki/blob/master/jspwiki-main/src/main/resources/ini/jspwiki.properties#L292-L297 Originally, the default template folder was to be called haddock, to ease transitioning from 2.10. One of the advantages of having the haddock template as default is that you can create your template with only the files you want to modify. Those files will "override" the default template ones, whereas the rest will be readed from the default one. So you can create new templates by modifying a few files. Also, because of this, some files are expected to be on the default folder (they're hardcoded values on 210, and on java code), so keeping the haddock folder would mean having part of the template on one folder and the rest on another, plus we'd lose the ability of overwritting templates.. TLDR; given that we could break backwards compatibility, it was easier to have the haddock template folder renamed to default, as we thought it was prone to less errors than the alternatives. Hope is enough to make you reconsider the vote. best regards, juan pablo On Sun, Jan 27, 2019 at 9:27 PM Murray Altheim wrote: Hi all. This is a release vote for Apache JSPWiki, version 2.11.0.M1. The vote will be open for at least 72 hours from now. -1. I've successfully built, installed and fired up a wiki based on 2.11.0.M1. Everything works as it should. I was even able to do a one-liner change to common-headers.jsp and get my own supplemental stylesheet to work nicely. I'm downvoting for one reason: any users (such as myself) who (mistakenly) re-use their existing jspwiki-custom.properties file, or as I did, copy my "custom" properties across to the new file, will get a template-less result (a white page with the LeftMenu at the bottom of the screen and the page-content even further down) if they neglect to set the template name from 'haddock' to 'default' or leave the property commented-out. This might flummox some admins and isn't a friendly behaviour. Perhaps when the template name in the property file fails JSPWiki should fall back to the default template rather than fail outright? At very least there should be a note in the change log indicating that 'haddock' no longer works as a template name. This is kinda an edge case; I don't really want to downvote and delay things but this does seem like a minor bug. I'm open to changing my vote, BTW, i.e., I'm easily convinced that a note in the change log would suffice, more wanting to see how you folks feel about this. Cheers, Murray ... Murray Altheim= = === http://www.altheim.com/murray/ === === = = === In the evening The rice leaves in the garden Rustle in the autumn wind That blows through my reed hut. -- Minamoto no Tsunenobu
Re: [VOTE] Release JSPWiki version 2.11.0.M1
1) During this transition moving the haddock template folder, it would be wise to still keep an empty template/haddock folder. JSPWiki will automatically fall back to the default template when it doesn't find the requested JSP; so migrating would become more easy. 2) As an improvement on the longer run, JSPWiki should also automatically fall back to the default template when the requested template *folder* is not found. Br, dirk On Sun, Jan 27, 2019 at 11:12 PM Juan Pablo Santos Rodríguez < juanpablo.san...@gmail.com> wrote: > Hi Murray, > > I think it's a valid point, we discussed it on the dev list but people > migrating don't have to have readed it.. > I've added a prominent section noting this at > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 > > Also, the relevant key at jspwiki.properties is already stating the allowed > values, see: > > https://github.com/apache/jspwiki/blob/master/jspwiki-main/src/main/resources/ini/jspwiki.properties#L292-L297 > > Originally, the default template folder was to be called haddock, to ease > transitioning from 2.10. One of the advantages > of having the haddock template as default is that you can create your > template with only the files you want to modify. > Those files will "override" the default template ones, whereas the rest > will be readed from the default one. So you can > create new templates by modifying a few files. > > Also, because of this, some files are expected to be on the default folder > (they're hardcoded values on 210, and on java > code), so keeping the haddock folder would mean having part of the template > on one folder and the rest on another, plus > we'd lose the ability of overwritting templates.. > > TLDR; given that we could break backwards compatibility, it was easier to > have the haddock template folder renamed to > default, as we thought it was prone to less errors than the alternatives. > > Hope is enough to make you reconsider the vote. > > > best regards, > juan pablo > > On Sun, Jan 27, 2019 at 9:27 PM Murray Altheim > wrote: > > > Hi all. > > > > > This is a release vote for Apache JSPWiki, version 2.11.0.M1. The vote > > > will be open for at least 72 hours from now. > > > > -1. > > > > I've successfully built, installed and fired up a wiki based on > 2.11.0.M1. > > Everything works as it should. I was even able to do a one-liner change > to > > common-headers.jsp and get my own supplemental stylesheet to work nicely. > > > > I'm downvoting for one reason: any users (such as myself) who > (mistakenly) > > re-use their existing jspwiki-custom.properties file, or as I did, copy > > my "custom" properties across to the new file, will get a template-less > > result (a white page with the LeftMenu at the bottom of the screen and > the > > page-content even further down) if they neglect to set the template name > > from 'haddock' to 'default' or leave the property commented-out. This > might > > flummox some admins and isn't a friendly behaviour. > > > > Perhaps when the template name in the property file fails JSPWiki should > > fall back to the default template rather than fail outright? At very > least > > there should be a note in the change log indicating that 'haddock' no > > longer works as a template name. > > > > This is kinda an edge case; I don't really want to downvote and delay > > things > > but this does seem like a minor bug. I'm open to changing my vote, BTW, > > i.e., I'm easily convinced that a note in the change log would suffice, > > more wanting to see how you folks feel about this. > > > > Cheers, > > > > Murray > > > > > ... > > Murray Altheim= = > === > > http://www.altheim.com/murray/ === > > === > >= = > === > > In the evening > > The rice leaves in the garden > > Rustle in the autumn wind > > That blows through my reed hut. > > -- Minamoto no Tsunenobu > > > > > > > > >
Re: [VOTE] Release JSPWiki version 2.11.0.M1
Hi Murray, I think it's a valid point, we discussed it on the dev list but people migrating don't have to have readed it.. I've added a prominent section noting this at https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 Also, the relevant key at jspwiki.properties is already stating the allowed values, see: https://github.com/apache/jspwiki/blob/master/jspwiki-main/src/main/resources/ini/jspwiki.properties#L292-L297 Originally, the default template folder was to be called haddock, to ease transitioning from 2.10. One of the advantages of having the haddock template as default is that you can create your template with only the files you want to modify. Those files will "override" the default template ones, whereas the rest will be readed from the default one. So you can create new templates by modifying a few files. Also, because of this, some files are expected to be on the default folder (they're hardcoded values on 210, and on java code), so keeping the haddock folder would mean having part of the template on one folder and the rest on another, plus we'd lose the ability of overwritting templates.. TLDR; given that we could break backwards compatibility, it was easier to have the haddock template folder renamed to default, as we thought it was prone to less errors than the alternatives. Hope is enough to make you reconsider the vote. best regards, juan pablo On Sun, Jan 27, 2019 at 9:27 PM Murray Altheim wrote: > Hi all. > > > This is a release vote for Apache JSPWiki, version 2.11.0.M1. The vote > > will be open for at least 72 hours from now. > > -1. > > I've successfully built, installed and fired up a wiki based on 2.11.0.M1. > Everything works as it should. I was even able to do a one-liner change to > common-headers.jsp and get my own supplemental stylesheet to work nicely. > > I'm downvoting for one reason: any users (such as myself) who (mistakenly) > re-use their existing jspwiki-custom.properties file, or as I did, copy > my "custom" properties across to the new file, will get a template-less > result (a white page with the LeftMenu at the bottom of the screen and the > page-content even further down) if they neglect to set the template name > from 'haddock' to 'default' or leave the property commented-out. This might > flummox some admins and isn't a friendly behaviour. > > Perhaps when the template name in the property file fails JSPWiki should > fall back to the default template rather than fail outright? At very least > there should be a note in the change log indicating that 'haddock' no > longer works as a template name. > > This is kinda an edge case; I don't really want to downvote and delay > things > but this does seem like a minor bug. I'm open to changing my vote, BTW, > i.e., I'm easily convinced that a note in the change log would suffice, > more wanting to see how you folks feel about this. > > Cheers, > > Murray > > ... > Murray Altheim= = === > http://www.altheim.com/murray/ === > === >= = === > In the evening > The rice leaves in the garden > Rustle in the autumn wind > That blows through my reed hut. > -- Minamoto no Tsunenobu > > > >
Re: [VOTE] Release JSPWiki version 2.11.0.M1
Hi all. > This is a release vote for Apache JSPWiki, version 2.11.0.M1. The vote > will be open for at least 72 hours from now. -1. I've successfully built, installed and fired up a wiki based on 2.11.0.M1. Everything works as it should. I was even able to do a one-liner change to common-headers.jsp and get my own supplemental stylesheet to work nicely. I'm downvoting for one reason: any users (such as myself) who (mistakenly) re-use their existing jspwiki-custom.properties file, or as I did, copy my "custom" properties across to the new file, will get a template-less result (a white page with the LeftMenu at the bottom of the screen and the page-content even further down) if they neglect to set the template name from 'haddock' to 'default' or leave the property commented-out. This might flummox some admins and isn't a friendly behaviour. Perhaps when the template name in the property file fails JSPWiki should fall back to the default template rather than fail outright? At very least there should be a note in the change log indicating that 'haddock' no longer works as a template name. This is kinda an edge case; I don't really want to downvote and delay things but this does seem like a minor bug. I'm open to changing my vote, BTW, i.e., I'm easily convinced that a note in the change log would suffice, more wanting to see how you folks feel about this. Cheers, Murray ... Murray Altheim= = === http://www.altheim.com/murray/ === === = = === In the evening The rice leaves in the garden Rustle in the autumn wind That blows through my reed hut. -- Minamoto no Tsunenobu
Re: [VOTE] Release JSPWiki version 2.11.0.M1
One more +1. dirk On Sun, Jan 27, 2019 at 1:28 PM Harry Metske wrote: > +1 > > thanks, > Harry > > > On Sat, 26 Jan 2019 at 18:39, Juan Pablo Santos Rodríguez < > juanpablo.san...@gmail.com> wrote: > > > This is a release vote for Apache JSPWiki, version 2.11.0.M1. The vote > will > > be open for at least 72 hours from now. > > > > It fixes the following issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=12343348 > > > > You can see a curated changelog at > > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Everybody is encouraged to vote. > > > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/jspwiki/2.11.0.M1-rc3 > > > > Nexus staging repo: > > https://repository.apache.org/content/repositories/orgapachejspwiki-1008 > > > > The tag to be voted upon: > > https://github.com/apache/jspwiki/tree/2.11.0.M1.RC3 > > > > JSPWiki's KEYS file containing PGP keys we use to sign the release: > > https://www.apache.org/dist/jspwiki/KEYS > > > > *** Please download, test and vote: > > > > [ ] +1 Approve the release > > [ ] 0 Don't mind > > [ ] -1 Disapprove the release (please provide specific comments) > > >
Re: [VOTE] Release JSPWiki version 2.11.0.M1
+1 thanks, Harry On Sat, 26 Jan 2019 at 18:39, Juan Pablo Santos Rodríguez < juanpablo.san...@gmail.com> wrote: > This is a release vote for Apache JSPWiki, version 2.11.0.M1. The vote will > be open for at least 72 hours from now. > > It fixes the following issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732&version=12343348 > > You can see a curated changelog at > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Everybody is encouraged to vote. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/jspwiki/2.11.0.M1-rc3 > > Nexus staging repo: > https://repository.apache.org/content/repositories/orgapachejspwiki-1008 > > The tag to be voted upon: > https://github.com/apache/jspwiki/tree/2.11.0.M1.RC3 > > JSPWiki's KEYS file containing PGP keys we use to sign the release: > https://www.apache.org/dist/jspwiki/KEYS > > *** Please download, test and vote: > > [ ] +1 Approve the release > [ ] 0 Don't mind > [ ] -1 Disapprove the release (please provide specific comments) >
