[CANCEL][VOTE] Release JSPWiki version 2.11.0.M5
Hi, Cleared browser cache and was able to reproduce the issue, hence canceling the vote.. I'll add a funcional test so we can prevent / detect this issue. Also, I've noticed that the portable build is bundling an older version of tomcat. Nothing blocker, but we can fix this issue too for RC3. As for the version, 2.11.0-M5-git-19 should be ok, was the next one before RC2 (pom versions should be reverted to 2.11.0.M5-SNAPSHOT too). Best regards, juan pablo El mié., 11 sept. 2019 21:26, Dirk Frederickx escribió: > Juan > > Sorry, -1. > Need to fix build error on javascript. => which version should I use > : 2.11.0-M5-git-19?? > > dirk > > On Wed, Sep 11, 2019 at 8:57 PM Dirk Frederickx > > wrote: > > > Harry, > > > > Txs. Let me check this. Seems like some js is missing. > > > > dirk > > > > On Wed, Sep 11, 2019 at 8:28 PM Harry Metske > > wrote: > > > >> I downloaded the source, did a successful maven clean package, deployed > to > >> a server and clicked around in an incognito Chrome tab. Looks fine, > >> however > >> when trying to edit a page, I get this javascript error: > >> > >> haddock-edit.js:1 Uncaught TypeError: $.toFunction is not a function > >> at Object.initialize (haddock-edit.js:1) > >> at Object. (haddock.js:1) > >> at Object.r.extend.$owner (haddock.js:1) > >> at new (haddock.js:1) > >> at Object.initialize (haddock-edit.js:1) > >> at Object. (haddock.js:1) > >> at Object.r.extend.$owner (haddock.js:1) > >> at new (haddock.js:1) > >> at HTMLTextAreaElement. (haddock-edit.js:1) > >> at Object.update (haddock.js:1) > >> > >> The edit window is empty, also creating new pages does not work (page > >> cannot be saved). > >> > >> I must be doing something wrong? > >> > >> cheers, > >> Harry > >> > >> > >> > >> On Tue, 10 Sep 2019 at 22:11, Juan Pablo Santos Rodríguez < > >> juanpa...@apache.org> wrote: > >> > >> > This is a release vote for Apache JSPWiki, version 2.11.0.M5. The vote > >> will > >> > be open for at least 72 hours from now. > >> > > >> > It fixes the following issues: > >> > > >> > > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732=12345540 > >> > > >> > You can see a curated changelog at > >> > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 > >> > > >> > Note that we are voting upon the source (tag), binaries are provided > for > >> > convenience. > >> > > >> > Everybody is encouraged to vote. > >> > > >> > Source and binary files: > >> > https://dist.apache.org/repos/dist/dev/jspwiki/2.11.0.M5-rc2 > >> > > >> > Nexus staging repo: > >> > > >> > https://repository.apache.org/content/repositories/orgapachejspwiki-1014 > >> > > >> > The tag to be voted upon: > >> > https://github.com/apache/jspwiki/tree/2.11.0.M5-RC2 > >> > > >> > JSPWiki's KEYS file containing PGP keys we use to sign the release: > >> > https://www.apache.org/dist/jspwiki/KEYS > >> > > >> > *** Please download, test and vote: > >> > > >> > [ ] +1 Approve the release > >> > [ ] 0 Don't mind > >> > [ ] -1 Disapprove the release (please provide specific comments) > >> > > >> > > >
Re: [VOTE] Release JSPWiki version 2.11.0.M5
Juan Sorry, -1. Need to fix build error on javascript. => which version should I use : 2.11.0-M5-git-19?? dirk On Wed, Sep 11, 2019 at 8:57 PM Dirk Frederickx wrote: > Harry, > > Txs. Let me check this. Seems like some js is missing. > > dirk > > On Wed, Sep 11, 2019 at 8:28 PM Harry Metske > wrote: > >> I downloaded the source, did a successful maven clean package, deployed to >> a server and clicked around in an incognito Chrome tab. Looks fine, >> however >> when trying to edit a page, I get this javascript error: >> >> haddock-edit.js:1 Uncaught TypeError: $.toFunction is not a function >> at Object.initialize (haddock-edit.js:1) >> at Object. (haddock.js:1) >> at Object.r.extend.$owner (haddock.js:1) >> at new (haddock.js:1) >> at Object.initialize (haddock-edit.js:1) >> at Object. (haddock.js:1) >> at Object.r.extend.$owner (haddock.js:1) >> at new (haddock.js:1) >> at HTMLTextAreaElement. (haddock-edit.js:1) >> at Object.update (haddock.js:1) >> >> The edit window is empty, also creating new pages does not work (page >> cannot be saved). >> >> I must be doing something wrong? >> >> cheers, >> Harry >> >> >> >> On Tue, 10 Sep 2019 at 22:11, Juan Pablo Santos Rodríguez < >> juanpa...@apache.org> wrote: >> >> > This is a release vote for Apache JSPWiki, version 2.11.0.M5. The vote >> will >> > be open for at least 72 hours from now. >> > >> > It fixes the following issues: >> > >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732=12345540 >> > >> > You can see a curated changelog at >> > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 >> > >> > Note that we are voting upon the source (tag), binaries are provided for >> > convenience. >> > >> > Everybody is encouraged to vote. >> > >> > Source and binary files: >> > https://dist.apache.org/repos/dist/dev/jspwiki/2.11.0.M5-rc2 >> > >> > Nexus staging repo: >> > >> https://repository.apache.org/content/repositories/orgapachejspwiki-1014 >> > >> > The tag to be voted upon: >> > https://github.com/apache/jspwiki/tree/2.11.0.M5-RC2 >> > >> > JSPWiki's KEYS file containing PGP keys we use to sign the release: >> > https://www.apache.org/dist/jspwiki/KEYS >> > >> > *** Please download, test and vote: >> > >> > [ ] +1 Approve the release >> > [ ] 0 Don't mind >> > [ ] -1 Disapprove the release (please provide specific comments) >> > >> >
Re: [VOTE] Release JSPWiki version 2.11.0.M5
Harry, Txs. Let me check this. Seems like some js is missing. dirk On Wed, Sep 11, 2019 at 8:28 PM Harry Metske wrote: > I downloaded the source, did a successful maven clean package, deployed to > a server and clicked around in an incognito Chrome tab. Looks fine, however > when trying to edit a page, I get this javascript error: > > haddock-edit.js:1 Uncaught TypeError: $.toFunction is not a function > at Object.initialize (haddock-edit.js:1) > at Object. (haddock.js:1) > at Object.r.extend.$owner (haddock.js:1) > at new (haddock.js:1) > at Object.initialize (haddock-edit.js:1) > at Object. (haddock.js:1) > at Object.r.extend.$owner (haddock.js:1) > at new (haddock.js:1) > at HTMLTextAreaElement. (haddock-edit.js:1) > at Object.update (haddock.js:1) > > The edit window is empty, also creating new pages does not work (page > cannot be saved). > > I must be doing something wrong? > > cheers, > Harry > > > > On Tue, 10 Sep 2019 at 22:11, Juan Pablo Santos Rodríguez < > juanpa...@apache.org> wrote: > > > This is a release vote for Apache JSPWiki, version 2.11.0.M5. The vote > will > > be open for at least 72 hours from now. > > > > It fixes the following issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732=12345540 > > > > You can see a curated changelog at > > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 > > > > Note that we are voting upon the source (tag), binaries are provided for > > convenience. > > > > Everybody is encouraged to vote. > > > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/jspwiki/2.11.0.M5-rc2 > > > > Nexus staging repo: > > https://repository.apache.org/content/repositories/orgapachejspwiki-1014 > > > > The tag to be voted upon: > > https://github.com/apache/jspwiki/tree/2.11.0.M5-RC2 > > > > JSPWiki's KEYS file containing PGP keys we use to sign the release: > > https://www.apache.org/dist/jspwiki/KEYS > > > > *** Please download, test and vote: > > > > [ ] +1 Approve the release > > [ ] 0 Don't mind > > [ ] -1 Disapprove the release (please provide specific comments) > > >
Re: [VOTE] Release JSPWiki version 2.11.0.M5
I downloaded the source, did a successful maven clean package, deployed to a server and clicked around in an incognito Chrome tab. Looks fine, however when trying to edit a page, I get this javascript error: haddock-edit.js:1 Uncaught TypeError: $.toFunction is not a function at Object.initialize (haddock-edit.js:1) at Object. (haddock.js:1) at Object.r.extend.$owner (haddock.js:1) at new (haddock.js:1) at Object.initialize (haddock-edit.js:1) at Object. (haddock.js:1) at Object.r.extend.$owner (haddock.js:1) at new (haddock.js:1) at HTMLTextAreaElement. (haddock-edit.js:1) at Object.update (haddock.js:1) The edit window is empty, also creating new pages does not work (page cannot be saved). I must be doing something wrong? cheers, Harry On Tue, 10 Sep 2019 at 22:11, Juan Pablo Santos Rodríguez < juanpa...@apache.org> wrote: > This is a release vote for Apache JSPWiki, version 2.11.0.M5. The vote will > be open for at least 72 hours from now. > > It fixes the following issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310732=12345540 > > You can see a curated changelog at > https://jspwiki-wiki.apache.org/Wiki.jsp?page=NewIn2.11 > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Everybody is encouraged to vote. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/jspwiki/2.11.0.M5-rc2 > > Nexus staging repo: > https://repository.apache.org/content/repositories/orgapachejspwiki-1014 > > The tag to be voted upon: > https://github.com/apache/jspwiki/tree/2.11.0.M5-RC2 > > JSPWiki's KEYS file containing PGP keys we use to sign the release: > https://www.apache.org/dist/jspwiki/KEYS > > *** Please download, test and vote: > > [ ] +1 Approve the release > [ ] 0 Don't mind > [ ] -1 Disapprove the release (please provide specific comments) >
