[jira] [Updated] (JSPWIKI-1167) prettify: line numbering is wrong with longer lines

2023-10-01 Thread Arturo Bernal (Jira) 


 [ 
https://issues.apache.org/jira/browse/JSPWIKI-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arturo Bernal updated JSPWIKI-1167:
---
Fix Version/s: 2.12.2

> prettify: line numbering is wrong with longer lines
> ---
>
> Key: JSPWIKI-1167
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1167
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.11.0
>Reporter: Dietrich Schmidt
>Assignee: Dirk Frederickx
>Priority: Major
> Fix For: 2.12.2
>
> Attachments: jspwiki-Zeilennummern-im-Editor.png, 
> jspwiki-Zeilennummern.png
>
>
> with %%prettify, line numbering is shown. With a line longer than textsize, 
> the line is split in two lines and the line numbering becomes wrong.
> See Attachment. !langezeile.png!
> It looks like attaching an image does not work.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (JSPWIKI-1167) prettify: line numbering is wrong with longer lines

2023-10-01 Thread Arturo Bernal (Jira) 


 [ 
https://issues.apache.org/jira/browse/JSPWIKI-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arturo Bernal resolved JSPWIKI-1167.

Resolution: Fixed

> prettify: line numbering is wrong with longer lines
> ---
>
> Key: JSPWIKI-1167
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1167
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.11.0
>Reporter: Dietrich Schmidt
>Assignee: Dirk Frederickx
>Priority: Major
> Fix For: 2.12.2
>
> Attachments: jspwiki-Zeilennummern-im-Editor.png, 
> jspwiki-Zeilennummern.png
>
>
> with %%prettify, line numbering is shown. With a line longer than textsize, 
> the line is split in two lines and the line numbering becomes wrong.
> See Attachment. !langezeile.png!
> It looks like attaching an image does not work.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (jspwiki)

2023-10-01 Thread via GitHub 


arturobernalg commented on PR #310:
URL: https://github.com/apache/jspwiki/pull/310#issuecomment-1742174282

   You're absolutely correct, JP. The version has been updated to
   2.12.2-git-03.
   
   
   Arturo
   
   
   On Sun, Oct 1, 2023 at 8:09 PM Brushed ***@***.***> wrote:
   
   > Txs. Looks ok to me.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (jspwiki)

2023-10-01 Thread via GitHub 


brushed commented on PR #310:
URL: https://github.com/apache/jspwiki/pull/310#issuecomment-1742156411

   Txs. Looks ok to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [apache/jspwiki] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (PR #310)

2023-10-01 Thread Juan Pablo Santos Rodríguez 
Typo, meant 2.12.2-git-03 (although nothing especially important, if it
stays on git-02 is ok too)

Br,
juan pablo

El dom, 1 oct 2023, 19:01, Juan Pablo Santos Rodríguez <
juanpablo.san...@gmail.com> escribió:

> Hi! Shouldn't this be part of 2.12.1-git-03 instead?
>
> Cheers,
> juan pablo
>
> El dom, 1 oct 2023, 18:58, Arturo Bernal 
> escribió:
>
>> @arturobernalg  pushed 1 commit.
>>
>>- 6bf3f32
>>
>> 
>>Add changelog
>>
>> —
>> View it on GitHub
>> 
>> or unsubscribe
>> 
>> .
>> You are receiving this because you are subscribed to this thread.Message
>> ID: 
>>
>

Re: [apache/jspwiki] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (PR #310)

2023-10-01 Thread Juan Pablo Santos Rodríguez 
Hi! Shouldn't this be part of 2.12.1-git-03 instead?

Cheers,
juan pablo

El dom, 1 oct 2023, 18:58, Arturo Bernal 
escribió:

> @arturobernalg  pushed 1 commit.
>
>- 6bf3f32
>
> 
>Add changelog
>
> —
> View it on GitHub
> 
> or unsubscribe
> 
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: 
>

[jira] [Updated] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-01 Thread Arturo Bernal (Jira) 


 [ 
https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arturo Bernal updated JSPWIKI-1181:
---
Fix Version/s: 2.12.2

> Search popup does not handle attachments correctly
> --
>
> Key: JSPWIKI-1181
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1181
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.12.1
>Reporter: Ulf Dittmer
>Assignee: Arturo Bernal
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 2.12.2
>
>
> If a search finds an attachment, that is not rendered correctly in the search 
> popup. A JavaScript error happens (see below), and the link to the attachment 
> is broken. This can be seen on [https://jspwiki-wiki.apache.org/] when 
> searching for 'pdf' for the result "Pic/pdf.png".
> {quote}XML Parsing Error: syntax error Location: 
> [https://jspwiki-wiki.apache.org/ajax/search/pages] Line Number 1, Column 1
> {quote}
> When bringing up the full search page, this is handled correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-01 Thread Arturo Bernal (Jira) 


 [ 
https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arturo Bernal updated JSPWIKI-1181:
---
Assignee: Arturo Bernal

> Search popup does not handle attachments correctly
> --
>
> Key: JSPWIKI-1181
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1181
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.12.1
>Reporter: Ulf Dittmer
>Assignee: Arturo Bernal
>Priority: Minor
>  Labels: pull-request-available
>
> If a search finds an attachment, that is not rendered correctly in the search 
> popup. A JavaScript error happens (see below), and the link to the attachment 
> is broken. This can be seen on [https://jspwiki-wiki.apache.org/] when 
> searching for 'pdf' for the result "Pic/pdf.png".
> {quote}XML Parsing Error: syntax error Location: 
> [https://jspwiki-wiki.apache.org/ajax/search/pages] Line Number 1, Column 1
> {quote}
> When bringing up the full search page, this is handled correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-01 Thread Arturo Bernal (Jira) 


[ 
https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770888#comment-17770888
 ] 

Arturo Bernal commented on JSPWIKI-1181:


[~brushed] 

done

> Search popup does not handle attachments correctly
> --
>
> Key: JSPWIKI-1181
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1181
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.12.1
>Reporter: Ulf Dittmer
>Priority: Minor
>  Labels: pull-request-available
>
> If a search finds an attachment, that is not rendered correctly in the search 
> popup. A JavaScript error happens (see below), and the link to the attachment 
> is broken. This can be seen on [https://jspwiki-wiki.apache.org/] when 
> searching for 'pdf' for the result "Pic/pdf.png".
> {quote}XML Parsing Error: syntax error Location: 
> [https://jspwiki-wiki.apache.org/ajax/search/pages] Line Number 1, Column 1
> {quote}
> When bringing up the full search page, this is handled correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-01 Thread Ulf Dittmer (Jira) 


[ 
https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770879#comment-17770879
 ] 

Ulf Dittmer commented on JSPWIKI-1181:
--

The fix works for my case, thank you!

> Search popup does not handle attachments correctly
> --
>
> Key: JSPWIKI-1181
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1181
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.12.1
>Reporter: Ulf Dittmer
>Priority: Minor
>  Labels: pull-request-available
>
> If a search finds an attachment, that is not rendered correctly in the search 
> popup. A JavaScript error happens (see below), and the link to the attachment 
> is broken. This can be seen on [https://jspwiki-wiki.apache.org/] when 
> searching for 'pdf' for the result "Pic/pdf.png".
> {quote}XML Parsing Error: syntax error Location: 
> [https://jspwiki-wiki.apache.org/ajax/search/pages] Line Number 1, Column 1
> {quote}
> When bringing up the full search page, this is handled correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-01 Thread Dirk Frederickx (Jira) 


[ 
https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770865#comment-17770865
 ] 

Dirk Frederickx commented on JSPWIKI-1181:
--

@Arthur,

Actually, it would be better to fix the cleanPageName() function. It 
incorrectly removes the "/" character.


dirk

> Search popup does not handle attachments correctly
> --
>
> Key: JSPWIKI-1181
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1181
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.12.1
>Reporter: Ulf Dittmer
>Priority: Minor
>  Labels: pull-request-available
>
> If a search finds an attachment, that is not rendered correctly in the search 
> popup. A JavaScript error happens (see below), and the link to the attachment 
> is broken. This can be seen on [https://jspwiki-wiki.apache.org/] when 
> searching for 'pdf' for the result "Pic/pdf.png".
> {quote}XML Parsing Error: syntax error Location: 
> [https://jspwiki-wiki.apache.org/ajax/search/pages] Line Number 1, Column 1
> {quote}
> When bringing up the full search page, this is handled correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-01 Thread Arturo Bernal (Jira) 


[ 
https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770858#comment-17770858
 ] 

Arturo Bernal commented on JSPWIKI-1181:


[~udittmer]  pelase take a look 

[https://github.com/apache/jspwiki/pull/310]

 

I've identified the issue with the URL generation for pages with special 
characters. The problem was in the `toUrl` function, which didn't account for 
special characters like '/'. I've updated this function to handle such cases 
correctly, ensuring that the generated URLs are both accurate and functional.

> Search popup does not handle attachments correctly
> --
>
> Key: JSPWIKI-1181
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1181
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.12.1
>Reporter: Ulf Dittmer
>Priority: Minor
>  Labels: pull-request-available
>
> If a search finds an attachment, that is not rendered correctly in the search 
> popup. A JavaScript error happens (see below), and the link to the attachment 
> is broken. This can be seen on [https://jspwiki-wiki.apache.org/] when 
> searching for 'pdf' for the result "Pic/pdf.png".
> {quote}XML Parsing Error: syntax error Location: 
> [https://jspwiki-wiki.apache.org/ajax/search/pages] Line Number 1, Column 1
> {quote}
> When bringing up the full search page, this is handled correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (JSPWIKI-1181) Search popup does not handle attachments correctly

2023-10-01 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/JSPWIKI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated JSPWIKI-1181:

Labels: pull-request-available  (was: )

> Search popup does not handle attachments correctly
> --
>
> Key: JSPWIKI-1181
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1181
> Project: JSPWiki
>  Issue Type: Bug
>  Components: Templates and UI
>Affects Versions: 2.12.1
>Reporter: Ulf Dittmer
>Priority: Minor
>  Labels: pull-request-available
>
> If a search finds an attachment, that is not rendered correctly in the search 
> popup. A JavaScript error happens (see below), and the link to the attachment 
> is broken. This can be seen on [https://jspwiki-wiki.apache.org/] when 
> searching for 'pdf' for the result "Pic/pdf.png".
> {quote}XML Parsing Error: syntax error Location: 
> [https://jspwiki-wiki.apache.org/ajax/search/pages] Line Number 1, Column 1
> {quote}
> When bringing up the full search page, this is handled correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (jspwiki)

2023-10-01 Thread via GitHub 


arturobernalg opened a new pull request, #310:
URL: https://github.com/apache/jspwiki/pull/310

   ### Summary
   This pull request addresses the issue of incorrect URL generation for pages 
with special characters like '/'. The `toUrl` function has been updated to 
handle these cases, ensuring that the generated URLs are accurate and 
functional.
   
   ### Changes
   - Updated the `toUrl` function to correctly handle page names with special 
characters.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org