Re: [PR] Bump com.google.code.gson:gson from 2.10.1 to 2.11.0 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #343: Bump com.google.code.gson:gson from 
2.10.1 to 2.11.0
URL: https://github.com/apache/jspwiki/pull/343


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump mockito.version from 5.11.0 to 5.12.0 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #341: Bump mockito.version from 5.11.0 to 
5.12.0
URL: https://github.com/apache/jspwiki/pull/341


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

arturobernalg commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-2130021691

   > hey @arturobernalg just found out about 
https://projectlombok.org/features/Locked on latest Lombok; same approach as 
your `Synchronizer` class, which seems definitely the way to go :-)
   
   Hey @juanpablo-santos  thanks for sharing! I'm continuing to check the 
issues.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-2117592639

   hey @arturobernalg just found out about 
https://projectlombok.org/features/Locked on latest Lombok; same approach as 
your `Synchronizer` class, which seems definitely the way to go :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1190 syntax converter command line util [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #336: JSPWIKI-1190 syntax converter 
command line util
URL: https://github.com/apache/jspwiki/pull/336


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1190 syntax converter command line util [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #336:
URL: https://github.com/apache/jspwiki/pull/336#issuecomment-2088524226

   As of 2.12.2-git-14, we generate markdown pages as part of the build, so 
there's no need to extract the syntax converter to its own module. In any case, 
thanks for both wanting to tackle this and the time you've invested in it :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.codehaus.cargo:cargo-maven3-plugin from 1.10.11 to 1.10.13 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #339: Bump 
org.codehaus.cargo:cargo-maven3-plugin from 1.10.11 to 1.10.13
URL: https://github.com/apache/jspwiki/pull/339


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump log4j2.version from 2.23.0 to 2.23.1 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #338: Bump log4j2.version from 2.23.0 to 
2.23.1
URL: https://github.com/apache/jspwiki/pull/338


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.awaitility:awaitility from 4.2.0 to 4.2.1 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #337: Bump org.awaitility:awaitility from 
4.2.0 to 4.2.1
URL: https://github.com/apache/jspwiki/pull/337


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]

[via GitHub]

spyhunter99 commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080934993

   could try dumpster. it's a pure java, unit test only, mail server setup. We 
used it on apache juddi for integration tests. works fairly well for plain text 
stuff. never tried it with ssl though


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JSPWIKI-1190 syntax converter command line util [jspwiki]

[via GitHub]

spyhunter99 opened a new pull request, #336:
URL: https://github.com/apache/jspwiki/pull/336

   initial cut at building a command line utility for the syntax converter. It 
still needs some packaging work to include this in the distributable. Pushing 
this for review. I'm not clear if markdown to jspwiki is a supported path or 
not. or jspwiki to any other format. also not clear if it's a good idea to 
clone the entire wiki storage directory during the conversion. Might be helpful 
for manual review, or for switching over, verifying, and rolling back in 
necessary etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080766504

   re. the build failure, MailUtilTest does send a mail to a local mailbox, and 
seems that up recently it doesn't allow mail sending if not using at least 
TLSv1.2. Currently running build at master should fix that issue, and I've also 
enabled console output on surefire on test failures/errors so hopefully 
debugging will be easier from now on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080726515

   this is now merged in 2.12.2-git-13, thanks! :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.sonarsource.scanner.maven:sonar-maven-plugin from 3.10.0.2594 to 3.11.0.3922 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #333: Bump 
org.sonarsource.scanner.maven:sonar-maven-plugin from 3.10.0.2594 to 3.11.0.3922
URL: https://github.com/apache/jspwiki/pull/333


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.eclipse.jetty.aggregate:jetty-all from 9.4.53.v20231009 to 9.4.54.v20240208 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #334: Bump 
org.eclipse.jetty.aggregate:jetty-all from 9.4.53.v20231009 to 9.4.54.v20240208
URL: https://github.com/apache/jspwiki/pull/334


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.codehaus.cargo:cargo-maven3-plugin from 1.10.11 to 1.10.12 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #331: Bump 
org.codehaus.cargo:cargo-maven3-plugin from 1.10.11 to 1.10.12
URL: https://github.com/apache/jspwiki/pull/331


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]

[via GitHub]

juanpablo-santos merged PR #330:
URL: https://github.com/apache/jspwiki/pull/330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080704623

   Hi, just added a commit on the PR to also allow system env variable 
expansion, with the tests also passing; let's merge this and get a look to ci 
build then


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]

[via GitHub]

spyhunter99 commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080687905

   cycling back around to this. looks like the last commit i made does it fact 
work.
   i'm not sure why the tests failed (works on my machine lol). test failure is 
related to email notifications...i didn't touch any of that. any guidance from 
the JSPWiki team?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump commons-io:commons-io from 2.15.0 to 2.15.1 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #327: Bump commons-io:commons-io from 
2.15.0 to 2.15.1
URL: https://github.com/apache/jspwiki/pull/327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump tomcat.version from 9.0.83 to 9.0.84 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #328: Bump tomcat.version from 9.0.83 to 
9.0.84
URL: https://github.com/apache/jspwiki/pull/328


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump log4j2.version from 2.20.0 to 2.22.0 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #326: Bump log4j2.version from 2.20.0 to 
2.22.0
URL: https://github.com/apache/jspwiki/pull/326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump plugin.surefire.version from 3.2.2 to 3.2.3 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #329: Bump plugin.surefire.version from 
3.2.2 to 3.2.3
URL: https://github.com/apache/jspwiki/pull/329


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

arturobernalg commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-2041526648

   > Hi @arturobernalg !
   > 
   > went ahead and pushed remaining requested changes, however I've got tests 
errors on `XMLUserDatabaseTest`. They aren't happening on the master branch, 
and were happening before applying my commits. Don't know if they're flaky 
tests which fail due to previous tests setting some unwanted state or if a bug 
was introduced with the refactor, would you mind taking a look at it?
   > 
   > thx + best regards
   
Hi @juanpablo-santos 
   
   I'll take a look.
   
   TY
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-2041067191

   Hi @arturobernalg !
   
   went ahead and pushed remaining requested changes, however I've got tests 
errors on `XMLUserDatabaseTest`. They aren't happening on the master branch, 
and were happening before applying my commits. Don't know if they're flaky 
tests which fail due to previous tests setting some unwanted state or if a bug 
was introduced with the refactor, would you mind taking a look at it?
   
   thx + best regards


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]

[via GitHub]

spyhunter99 commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2028797198

   this actually didn't work when i tested it in tomcat. investigating now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update URLConstructor.java [jspwiki]

[via GitHub]

udittmer commented on PR #322:
URL: https://github.com/apache/jspwiki/pull/322#issuecomment-1840465140

   Yes! Now saving umlauts works fine. Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update URLConstructor.java [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #322:
URL: https://github.com/apache/jspwiki/pull/322#issuecomment-1839540018

   Hi @udittmer ! would you mind trying 2.12.2-git-11 to see if the issue 
persists?
   
   The next filter on the filter chain after `WikiJSPFilter` is 
`WikiServletFilter`, which, early on, is doing this:
   
   ```java
   // Set the character encoding
   httpRequest.setCharacterEncoding( 
m_engine.getContentEncoding().displayName() );
   ```
   
   a quick peek at that javadoc method yields
   >Overrides the name of the character encoding used in the body of this 
request. This **method must be called prior to reading request parameters** or 
reading input using getReader(). **Otherwise, it has no effect**.
   
   So the initial fix was most probably rendering this call useless, hence the 
errors you were expecting. I've added that call prior to the `URLConstructor` 
call and now everything behaves as expected. I've left the 
`setCharacterEncoding` call also in `WikiServletFilter`, just in case a call 
goes through that filter without going through `WikiJSPFilter` first (like most 
probably on the preview pane).
   
   HTH!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump mockito.version from 5.7.0 to 5.8.0 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #325: Bump mockito.version from 5.7.0 to 
5.8.0
URL: https://github.com/apache/jspwiki/pull/325


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update URLConstructor.java [jspwiki]

[via GitHub]

udittmer commented on PR #322:
URL: https://github.com/apache/jspwiki/pull/322#issuecomment-1837465275

   No, that doesn't make a difference - any umlauts being saved are mangled. My 
encoding is UTF-8, in case that makes a difference, and useEncoding is true.
   
   I played around a bit encoding handling in WikiJSPFilter, but I'm confused 
with how useEncoding, m_wiki_encoding,  m_engine.getContentEncoding() and 
response.getCharacterEncoding() are supposed to work together. m_wiki_encoding 
gets initialized, but doesn't seem to be used.
   
   The strange thing is that umlauts are shown fine in the preview.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

juanpablo-santos commented on code in PR #307:
URL: https://github.com/apache/jspwiki/pull/307#discussion_r1412879450


##
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java:
##
@@ -406,15 +429,15 @@ public Set< WikiEventListener > getWikiEventListeners() {
  * @return true if the listener was added (i.e., it was not already in 
the list and was added)
  */
 public boolean addWikiEventListener( final WikiEventListener listener 
) {
-synchronized( m_listenerList ) {
+return Synchronizer.synchronize(wikiEventListenerLock, () -> {

Review Comment:
   shouldn't `m_listener` reuse the same `Lock` through the entire class? 
Different locks on different operations would imply they could execute 
operations on `m_listenerList` at the same time



##
jspwiki-main/src/main/java/org/apache/wiki/auth/authorize/DefaultGroupManager.java:
##
@@ -367,14 +395,18 @@ protected String[] extractMembers( final String 
memberLine ) {
 
 /** {@inheritDoc} */
 @Override
-public synchronized void addWikiEventListener( final WikiEventListener 
listener ) {
-WikiEventManager.addWikiEventListener( this, listener );
+public void addWikiEventListener( final WikiEventListener listener ) {

Review Comment:
   should use the same lock as `removeWikiEventListener`



##
jspwiki-main/src/main/java/org/apache/wiki/WatchDog.java:
##
@@ -136,26 +154,26 @@ private static void scrub() {
  *  Can be used to enable the WatchDog.  Will cause a new Thread to be 
created, if none was existing previously.
  */
 public void enable() {
-synchronized( WatchDog.class ) {
+Synchronizer.synchronize(enableLock, () -> {

Review Comment:
   same as before, same synchronized object should reuse the same Lock 
throughout the class.



##
jspwiki-main/src/main/java/org/apache/wiki/auth/authorize/DefaultGroupManager.java:
##
@@ -152,13 +180,13 @@ public void initialize( final Engine engine, final 
Properties props ) throws Wik
 
 // Load all groups from the database into the cache
 final Group[] groups = m_groupDatabase.groups();
-synchronized( m_groups ) {

Review Comment:
   converting `m_groups` to `ConcurrentHashMap` would avoid the use of 
`Synchronizer`



##
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java:
##
@@ -314,35 +337,35 @@ private Map< Object, WikiEventDelegate > getDelegates() {
  * @param client   the client Object, or alternately a Class reference
  * @return the WikiEventDelegate.
  */
-private WikiEventDelegate getDelegateFor( final Object client ) {
-synchronized( m_delegates ) {

Review Comment:
   again, converting to `ConcurrentHashMap` would avoid all the syncing..



##
jspwiki-main/src/main/java/org/apache/wiki/plugin/PageViewPlugin.java:
##
@@ -129,6 +134,20 @@ public class PageViewPlugin extends AbstractReferralPlugin 
implements Plugin, In
 /** Constant for storage interval in seconds. */
 private static final int STORAGE_INTERVAL = 60;
 
+/**
+ * A lock used to ensure thread safety when accessing shared resources.
+ * This lock provides more flexibility and capabilities than the intrinsic 
locking mechanism,
+ * such as the ability to attempt to acquire a lock with a timeout, or to 
interrupt a thread
+ * waiting to acquire a lock.
+ *
+ * @see java.util.concurrent.locks.ReentrantLock
+ */
+private final ReentrantLock lock;

Review Comment:
   better `private final ReentrantLock lock = new ReentrantLock();` to avoid to 
declare the constructor?



##
jspwiki-main/src/main/java/org/apache/wiki/search/LuceneSearchProvider.java:
##
@@ -389,9 +407,9 @@ protected Document luceneIndexPage( final Page page, final 
String text, final In
 field = new Field( LUCENE_PAGE_KEYWORDS, page.getAttribute( 
"keywords" ).toString(), TextField.TYPE_STORED );
 doc.add( field );
 }
-synchronized( writer ) {
+Synchronizer.synchronize(lock, () -> {

Review Comment:
   additional lock here?



##
jspwiki-main/src/main/java/org/apache/wiki/WatchDog.java:
##
@@ -186,10 +204,10 @@ public void enterState( final String state ) {
  */
 public void enterState( final String state, final int 
expectedCompletionTime ) {
 LOG.debug(  "{}: Entering state {}, expected completion in {} s", 
m_watchable.getName(), state, expectedCompletionTime );
-synchronized( m_stateStack ) {
+Synchronizer.synchronize(enterStateLock, () -> {

Review Comment:
   same as before..



##
jspwiki-main/src/main/java/org/apache/wiki/auth/SessionMonitor.java:
##
@@ -235,8 +260,10 @@ public final Principal[] userPrincipals() {
  * @param listener the event listener
  * @since 2.4.75
  */
-public final synchronized void 

Re: [PR] Update URLConstructor.java [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #322:
URL: https://github.com/apache/jspwiki/pull/322#issuecomment-1837241958

   Hi @udittmer, 
   
   I think that the problem comes from using `response.getEncoding()`, which 
causes the response to be committed, which in turn causes errors later on the 
filter chain, f.ex., when trying to create a session. 2.12.2-git-10 uses 
`engine.getEncoding()` instead, which is the parameter used elsewhere. This 
seems to fix the issue, would you mind verifying it with latest master?
   
   thx + best regards,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.codehaus.cargo:cargo-maven3-plugin from 1.10.10 to 1.10.11 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #324: Bump 
org.codehaus.cargo:cargo-maven3-plugin from 1.10.10 to 1.10.11
URL: https://github.com/apache/jspwiki/pull/324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update URLConstructor.java [jspwiki]

[via GitHub]

udittmer commented on PR #322:
URL: https://github.com/apache/jspwiki/pull/322#issuecomment-1833296214

   This patch actually causes problems: something is off with encoding, so that 
umlauts are mangled during saving. This happens because of the call to 
**getParameter**. If (in WikiJSPFIlter) the method is called before the 
super.doFilter call, the problem occurs. After doFilter, calling it causes no 
problem. Rewriting the method so it looks at the query string solves the 
problem:
   
   ```
  static String parsePageFromURL( final HttpServletRequest request, final 
Charset encoding ) {
   String name = request.getPathInfo();
   if( name == null || name.length() <= 1 ) {
   name = request.getQueryString();
if (StringUtils.isNotBlank(name) && name.contains("page="))
return name.substring(name.indexOf("page=")+5);
else
return null;
   } else if( name.charAt(0) == '/' ) {
   return name.substring(1);
   }
   
   //  This is required, because by default all URLs are handled as 
Latin1, even if they are really UTF-8.
   // name = TextUtil.urlDecode( name, encoding );
   
   return name;
   }
   }
   ```
   
   But I don't know enough of what is happening here to understand whether that 
is the right thing to do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JSPWIKI-1138 - Fix XSS vulnerability in property handling. [jspwiki]

[via GitHub]

arturobernalg opened a new pull request, #323:
URL: https://github.com/apache/jspwiki/pull/323

   Sanitize property values in the sanitizeInput method to prevent XSS attacks. 
Special characters in property values are now replaced with their corresponding 
HTML entities. This change enhances the security of the application by 
mitigating the risk of script injection through property values.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.codehaus.cargo:cargo-maven3-plugin from 1.10.9 to 1.10.10 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #320: Bump 
org.codehaus.cargo:cargo-maven3-plugin from 1.10.9 to 1.10.10
URL: https://github.com/apache/jspwiki/pull/320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump mockito.version from 5.5.0 to 5.7.0 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #319: Bump mockito.version from 5.5.0 to 
5.7.0
URL: https://github.com/apache/jspwiki/pull/319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update Viewer.js [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #321:
URL: https://github.com/apache/jspwiki/pull/321#issuecomment-1826345482

   Merged in 2.12.2-git-09, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update Viewer.js [jspwiki]

[via GitHub]

juanpablo-santos merged PR #321:
URL: https://github.com/apache/jspwiki/pull/321


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update URLConstructor.java [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #322:
URL: https://github.com/apache/jspwiki/pull/322#issuecomment-1826343572

   Added in 2.12.2-git-09, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update URLConstructor.java [jspwiki]

[via GitHub]

juanpablo-santos merged PR #322:
URL: https://github.com/apache/jspwiki/pull/322


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Update URLConstructor.java [jspwiki]

[via GitHub]

udittmer opened a new pull request, #322:
URL: https://github.com/apache/jspwiki/pull/322

   The method didn't work for the default URL style, causing PAGE_REQUESTED and 
PAGE_DELIVERED events to have a null page name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Update Viewer.js [jspwiki]

[via GitHub]

udittmer opened a new pull request, #321:
URL: https://github.com/apache/jspwiki/pull/321

   The Flash-based Vimeo player is obsolete, and HTML 5 works fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump com.codeborne:selenide from 6.19.0 to 7.0.2 [jspwiki]

[via GitHub]

juanpablo-santos commented on PR #318:
URL: https://github.com/apache/jspwiki/pull/318#issuecomment-1817982472

   @dependabot ignore this major version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.sonarsource.scanner.maven:sonar-maven-plugin from 3.9.1.2184 to 3.10.0.2594 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #308: Bump 
org.sonarsource.scanner.maven:sonar-maven-plugin from 3.9.1.2184 to 3.10.0.2594
URL: https://github.com/apache/jspwiki/pull/308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.eclipse.jetty.aggregate:jetty-all from 9.4.51.v20230217 to 9.4.53.v20231009 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #313: Bump 
org.eclipse.jetty.aggregate:jetty-all from 9.4.51.v20230217 to 9.4.53.v20231009
URL: https://github.com/apache/jspwiki/pull/313


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump com.github.jbellis:jamm from 0.3.3 to 0.4.0 [jspwiki]

[via GitHub]

juanpablo-santos closed pull request #296: Bump com.github.jbellis:jamm from 
0.3.3 to 0.4.0
URL: https://github.com/apache/jspwiki/pull/296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Avoid method that assume default platform encoding is suitable. [jspwiki]

[via GitHub]

arturobernalg commented on PR #232:
URL: https://github.com/apache/jspwiki/pull/232#issuecomment-1771658384

   Hi @juanpablo-santos,
   
   I've made changes to avoid reliance on default platform encoding,  I think 
this would be a nice addition to the 2.12.2 release. Please take a look.
   
   Best,
   Arturo 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Replace 'size() == 0' with 'isEmpty()' [jspwiki]

[via GitHub]

arturobernalg merged PR #314:
URL: https://github.com/apache/jspwiki/pull/314


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Simplify conditions. [jspwiki]

[via GitHub]

arturobernalg closed pull request #284: Simplify conditions.
URL: https://github.com/apache/jspwiki/pull/284


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Replace 'size() == 0' with 'isEmpty()' [jspwiki]

[via GitHub]

arturobernalg opened a new pull request, #314:
URL: https://github.com/apache/jspwiki/pull/314

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

arturobernalg commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1758434777

   HI @juanpablo-santos 
   I fix all the comment. Please do another pass.
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages [jspwiki]

[via GitHub]

arturobernalg merged PR #312:
URL: https://github.com/apache/jspwiki/pull/312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1056: Add Absolute URL Utility Methods [jspwiki]

[via GitHub]

arturobernalg merged PR #311:
URL: https://github.com/apache/jspwiki/pull/311


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

juanpablo-santos commented on code in PR #307:
URL: https://github.com/apache/jspwiki/pull/307#discussion_r1354460996


##
jspwiki-main/src/main/java/org/apache/wiki/WatchDog.java:
##
@@ -302,15 +315,15 @@ private void dumpStackTraceForWatchable() {
  */
 @Override
 public String toString() {
-synchronized( m_stateStack ) {
+return Synchronizer.synchronize(lock, () -> {

Review Comment:
   unrelated to the PR itself, but `java.util.Stack` is thread-safe (extends 
`Vector`) so not sure why this was synced on in the first place... Also, 
perhaps it could be substituted with a `ConcurrentLinkedDeque`. Anyway, out of 
PR's scope.



##
jspwiki-event/src/main/java/org/apache/wiki/event/WikiEventManager.java:
##
@@ -154,11 +168,13 @@ private WikiEventManager() {
  *  @return A shared instance of the WikiEventManager
  */
 public static WikiEventManager getInstance() {
-if( c_instance == null ) {
-synchronized( WikiEventManager.class ) {
-return new WikiEventManager();
-// start up any post-instantiation services here
-}
+if (c_instance == null) {
+Synchronizer.synchronize(lock, () -> {

Review Comment:
   seems that the `synchronized` blocks on this class do so against different 
objects: `WikiEventManager.class`, `m_delegates`, `m_preloadCache`, etc., so it 
would make more sense to use different locks on `Synchronizer.synchronize` 
calls?



##
jspwiki-main/src/main/java/org/apache/wiki/WikiEngine.java:
##
@@ -138,6 +141,16 @@ public class WikiEngine implements Engine {
 /** Stores WikiEngine's associated managers. */
 protected final Map< Class< ? >, Object > managers = new 
ConcurrentHashMap<>();
 
+/**
+ * A lock used to ensure thread safety when accessing shared resources.
+ * This lock provides more flexibility and capabilities than the intrinsic 
locking mechanism,
+ * such as the ability to attempt to acquire a lock with a timeout, or to 
interrupt a thread
+ * waiting to acquire a lock.
+ *
+ * @see java.util.concurrent.locks.ReentrantLock
+ */
+private static final ReentrantLock lock = new ReentrantLock();

Review Comment:
   again, perhaps several locks are needed



##
jspwiki-main/src/main/java/org/apache/wiki/auth/authorize/DefaultGroupManager.java:
##
@@ -75,6 +77,20 @@ public class DefaultGroupManager implements GroupManager, 
Authorizer, WikiEventL
 /** Map with GroupPrincipals as keys, and Groups as values */
 private final Map< Principal, Group > m_groups = new HashMap<>();
 
+/**
+ * A lock used to ensure thread safety when accessing shared resources.
+ * This lock provides more flexibility and capabilities than the intrinsic 
locking mechanism,
+ * such as the ability to attempt to acquire a lock with a timeout, or to 
interrupt a thread
+ * waiting to acquire a lock.
+ *
+ * @see java.util.concurrent.locks.ReentrantLock
+ */
+private final ReentrantLock lock;

Review Comment:
   same as before, better with a couple of locks?



##
jspwiki-event/pom.xml:
##
@@ -62,5 +62,10 @@
   junit-jupiter-engine
   test
 
+
+
+  org.apache.jspwiki
+  jspwiki-util

Review Comment:
   needs `${project.version}` and `groupId` can be replaced 
with `${project.groupId}` (see last comment on main pom.xml file)



##
pom.xml:
##
@@ -458,6 +458,13 @@
 javax.servlet-api
 ${javax-servlet-api.version}
   
+
+  
+org.apache.jspwiki
+jspwiki-util

Review Comment:
   this shouldn't be needed here, jspwiki modules should be referenced on other 
modules using `groupId:artifactId:version` where `groupId` is always 
`${project.groupId}` and version always is `${project.version}` (see 
[this](https://github.com/apache/jspwiki/blob/master/jspwiki-main/pom.xml#L34-L36)
 for an example)



##
jspwiki-main/src/main/java/org/apache/wiki/auth/user/XMLUserDatabase.java:
##
@@ -91,27 +95,59 @@ public class XMLUserDatabase extends AbstractUserDatabase {
 private Documentc_dom;
 private Filec_file;
 
+/**
+ * A lock used to ensure thread safety when accessing shared resources.
+ * This lock provides more flexibility and capabilities than the intrinsic 
locking mechanism,
+ * such as the ability to attempt to acquire a lock with a timeout, or to 
interrupt a thread
+ * waiting to acquire a lock.
+ *
+ * @see java.util.concurrent.locks.ReentrantLock
+ */
+private final ReentrantLock lock;
+
+public XMLUserDatabase() {
+lock = new ReentrantLock();
+}
+
 /** {@inheritDoc} */
-@Override
-public synchronized void deleteByLoginName( final String loginName ) 
throws WikiSecurityException {
-if( c_dom == null ) {
-throw new 

Re: [PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages [jspwiki]

[via GitHub]

arturobernalg commented on PR #312:
URL: https://github.com/apache/jspwiki/pull/312#issuecomment-1755833207

   @juanpablo-santos 
   I'm encountering the following error while when the CI is running: 
   ```[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-deploy-plugin:3.1.1:deploy (default-deploy) on 
project jspwiki-wikipages-en: Failed to update metadata 
org.apache.jspwiki.wikipages:jspwiki-wikipages-en/maven-metadata.xml: Could not 
parse metadata 
/home/jenkins/.m2/repository/org/apache/jspwiki/wikipages/jspwiki-wikipages-en/maven-metadata-apache.snapshots.https.xml:
 in epilog non whitespace content is not allowed but got t (position: END_TAG 
seen ...\nt... @12:2) -> [Help 1]
   ```
   This isn't the first time I've encountered this issue; I faced the same 
error in another PR as well. Do you have any insights into what might be 
causing it?"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages [jspwiki]

[via GitHub]

arturobernalg commented on PR #312:
URL: https://github.com/apache/jspwiki/pull/312#issuecomment-1755804657

   > Hi, lgtm!
   > 
   > agree on the ordering of the properties, should be done on a separate PR, 
probably renaming them according to where they are being used; right now they 
are ordered (more or less) following JSPs order.
   > 
   > cheers, juan pablo
   > 
   > p.s.: If it helps, we also have a 
[mini-guide](https://jspwiki-wiki.apache.org/Wiki.jsp?page=HowToI18n) stating 
the steps needed to locate missing i18n entries and the [translation 
status](https://jspwiki.apache.org/development/i18n.html) page, which is built 
with every commit.
   
   Hi @juanpablo-santos 
   
   Thank you for the tip. In this case i use a custom python 
   
   `def read_properties(file_path):
   properties = set()
   with open(file_path, 'r', encoding='ISO-8859-1') as f:
   for line in f:
   line = line.strip()
   if "=" not in line or line.startswith("#"):
   continue
   key = line.split("=", 1)[0].strip()
   properties.add(key)
   return properties
   
   
   file1_path = "PATH"  # Replace with your actual file path
   file2_path = "PATH2"  # Replace with your actual file path
   
   file1_properties = read_properties(file1_path)
   file2_properties = read_properties(file2_path)
   
   missing_in_file1 = file2_properties - file1_properties
   missing_in_file2 = file1_properties - file2_properties
   
   print("Properties missing in File 1:")
   for prop in missing_in_file1:
   print(prop)
   
   print("\nProperties missing in File 2:")
   for prop in missing_in_file2:
   print(prop)
   `
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

arturobernalg commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1754548191

   > The utility/class method focus should be more about synchronizing than 
locking (hence the names).
   
   
   
   > > Hi @arturobernalg !
   > > > However, this approach has limitations when it comes to working with 
condition variables and allowing for custom scenarios. Specifically, using a 
utility class for locking would make it challenging to implement more complex 
control flows that involve waiting for certain conditions to be met or 
signaling other threads to proceed.
   > > > In essence, while the utility class would make the code cleaner for 
basic locking and unlocking, it might not be flexible enough to handle advanced 
locking scenarios that require the use of conditions.
   > > 
   > > 
   > > I agree that more complex scenarios would **not** fit inside this 
utility class. However, the scope of the PR is to switch away from 
`synchronized` blocks, and for all them we have the same idiom all over the 
place:
   > > ```
   > > lock.lock();
   > > try {
   > > doSomething();
   > > } finally {
   > > lock.unlock();
   > > }
   > > ```
   > > 
   > > 
   > > 
   > >   
   > > 
   > > 
   > >   
   > > 
   > > 
   > > 
   > >   
   > > So abstracting it into a common method makes sense to me. If later on we 
want to refactor, or we want to capture more complex scenarios, we can always 
move away from the utility `synchronize` method. The utility/class method focus 
should be more about synchronizing than locking (hence the names).
   > > WDYT?
   > 
   > HI @juanpablo-santos It makes sense to start with this abstraction for the 
sake of code cleanliness and readability.
   > 
   > I'll go ahead and make the changes to incorporate the new method It might 
take me a couple of days to complete the update, but I'll keep you posted on 
the progress.
   > 
   > TY
   
   HI @juanpablo-santos 
   
   Implemented the custom Synchronizer class to manage ReentrantLock 
synchronization as planned. 
   The changes turned out to be more extensive than initially anticipated. 
   Looking forward to your feedback to determine if this approach works well 
for our use case.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

[via GitHub]

arturobernalg commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1753342760

   > Hi @arturobernalg !
   > 
   > > However, this approach has limitations when it comes to working with 
condition variables and allowing for custom scenarios. Specifically, using a 
utility class for locking would make it challenging to implement more complex 
control flows that involve waiting for certain conditions to be met or 
signaling other threads to proceed.
   > > In essence, while the utility class would make the code cleaner for 
basic locking and unlocking, it might not be flexible enough to handle advanced 
locking scenarios that require the use of conditions.
   > 
   > I agree that more complex scenarios would **not** fit inside this utility 
class. However, the scope of the PR is to switch away from `synchronized` 
blocks, and for all them we have the same idiom all over the place:
   > 
   > ```
   > lock.lock();
   > try {
   > doSomething();
   > } finally {
   > lock.unlock();
   > }
   > ```
   > 
   > So abstracting it into a common method makes sense to me. If later on we 
want to refactor, or we want to capture more complex scenarios, we can always 
move away from the utility `synchronize` method. The utility/class method focus 
should be more about synchronizing than locking (hence the names).
   > 
   > WDYT?
   
   HI @juanpablo-santos 
   It makes sense to start with this abstraction for the sake of code 
cleanliness and readability.
   
   I'll go ahead and make the changes to incorporate the Synchronizer utility 
class. It might take me a couple of days to complete the update, but I'll keep 
you posted on the progress.
   
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1752606848

   Hi @arturobernalg !
   
   > However, this approach has limitations when it comes to working with 
condition variables and allowing for custom scenarios. Specifically, using a 
utility class for locking would make it challenging to implement more complex 
control flows that involve waiting for certain conditions to be met or 
signaling other threads to proceed.
   >
   > In essence, while the utility class would make the code cleaner for basic 
locking and unlocking, it might not be flexible enough to handle advanced 
locking scenarios that require the use of conditions.
   
   I agree that more complex scenarios would fit inside this utility class. 
However, the scope of the PR is to switch away from `synchronized` blocks, and 
for all them we have the same idiom all over the place:
   
   ```
   lock.lock();
   try {
   doSomething();
   } finally {
   lock.unlock();
   }
   ```
   
   So abstracting it into a common method makes sense to me. If later on a we 
want to refactor or we want to capture more complex scenarios, we can move away 
from the utility `synchronize` method. The utility/class method focus should be 
more about synchronizing than locking (hence the names).
   
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JSPWIKI-925 - Add Missing i18n Literals for Multiple Languages (jspwiki)

[via GitHub]

arturobernalg opened a new pull request, #312:
URL: https://github.com/apache/jspwiki/pull/312

   Description:
   
   This pull request addresses the missing i18n literals as outlined in 
[JSPWIKI-925](https://issues.apache.org/jira/browse/JSPWIKI-925). Missing 
entries have been added for various languages to their respective properties 
files.
   Languages Updated:
   
   German (de)
   Finnish (fi)
   French (fr)
   Italian (it)
   Dutch (nl)
   Brazilian Portuguese (pt_BR)
   Russian (ru)
   Simplified Chinese (zh_CN)
   
   Note on Ordering:
   
   The added literals are not in alphabetical order within the properties 
files. If alphabetical ordering is desired, this can be addressed in a separate 
ticket. In my opinion, that would be the appropriate course of action.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1056: Add Absolute URL Utility Methods (jspwiki)

[via GitHub]

arturobernalg commented on PR #311:
URL: https://github.com/apache/jspwiki/pull/311#issuecomment-1747308089

   > Hi,
   > 
   > wiki installations behind an apache web server (or similar) would send 
their internal URL, which surely wouldn't be intended. We could also check for 
known headers with the "external" IP/domain, but again there're going to be 
corner cases.
   > 
   > We used to had a wiki property for that, but we moved away from it some 
time/years ago.. There's a JIRA for that IIRc.
   > 
   > So, I'm not really sure which would be the best way to tackle this.. 
Perhaps check for an specific header with the domain/IP and if not found revert 
to the proposed solution? That would allow moving the problem/customization to 
the web server configuration ([ex.](https://serverfault.com/a/716154)). Again, 
that would be very similar to reintroducing a wiki property so not really sure 
this is the best way..
   > 
   > @arturobernalg would you mind opening a thread with this at 
[dev@j.a.o](mailto:dev@j.a.o)? so it doesn't get clobbered up with all the GH 
mails
   > 
   > thx!
   
   Please @juanpablo-santos  do another pass.
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. (jspwiki)

[via GitHub]

arturobernalg commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1745343221

   > Hi,
   > 
   > interesting PR! :-) My only comment is that I'd extract the lock behaviour 
on a utility class something similar to (pseudocode, surely doesn't even 
compile):
   > 
   > ```java
   > public class Synchronizer {
   > 
   > public static < T > T synchronize( final ReentrantLock lock, final 
Supplier< T > supplier ) {
   > lock.lock();
   >try {
   >return supplier.get();
   >} finally {
   >lock.unlock();
   >}
   > }
   > 
   > }
   > ```
   > 
   > so code inside synchronized blocks can be passed as a lambda (also this 
method could be overloaded so it could also receive some Runnable, Function, 
etc.)
   > 
   > WDYT?
   > 
   > cheers, juan pablo
   
   HI @juanpablo-santos 
   
   I agree that encapsulating the lock behavior in a utility class like 
Synchronizer would offer several advantages, particularly in terms of code 
Readability and Reusability.
   
   However, this approach has limitations when it comes to working with 
condition variables and allowing for custom scenarios. Specifically, using a 
utility class for locking would make it challenging to implement more complex 
control flows that involve waiting for certain conditions to be met or 
signaling other threads to proceed.
   
   In essence, while the utility class would make the code cleaner for basic 
locking and unlocking, it might not be flexible enough to handle advanced 
locking scenarios that require the use of conditions.
   
   Best regards,


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #307:
URL: https://github.com/apache/jspwiki/pull/307#issuecomment-1743774024

   Hi,
   
   interesting PR! :-) My only comment is that I'd extract the lock behaviour 
on a utility class something similar to (pseudocode, surely doesn't even 
compile):
   
   ```java
   public class Synchronizer {
   
   public static < T > T synchronize( final ReentrantLock lock, final 
Supplier< T > supplier ) {
   lock.lock();
try {
return supplier.get();
} finally {
lock.unlock();
}
   }
   
   }
   ```
   so code inside synchronized blocks can be passed as a lambda (also this 
method could be overloaded so it could also receive some Runnable, Function, 
etc.)
   
   WDYT?
   
   
   cheers,
   juan pablo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1056: Add Absolute URL Utility Methods (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #311:
URL: https://github.com/apache/jspwiki/pull/311#issuecomment-1743694515

   Hi,
   
   wiki installations behind an apache web server (or similar) would send their 
internal URL, which surely wouldn't be intended. We could also check for known 
headers with the "external" IP/domain, but again there're going to be corner 
cases.
   
   We used to had a wiki property for that, but we moved away from it some 
time/years ago.. There's a JIRA for that IIRc.
   
   So, I'm not really sure which would be the best way to tackle this.. Perhaps 
check for an specific header with the domain/IP and if not found revert to the 
proposed solution? That would allow moving the problem/customization to the web 
server configuration ([ex.](https://serverfault.com/a/716154)). Again, that 
would be very similar to reintroducing a wiki property so not really sure this 
is the best way..
   
   @arturobernalg would you mind opening a thread with this at dev@j.a.o? so it 
doesn't get clobbered up with all the GH mails
   
   thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JSPWIKI-1056: Add Absolute URL Utility Methods (jspwiki)

[via GitHub]

arturobernalg opened a new pull request, #311:
URL: https://github.com/apache/jspwiki/pull/311

   
   ### Summary
   
   This PR addresses 
[JSPWIKI-1056](https://issues.apache.org/jira/browse/JSPWIKI-1056) by adding 
utility methods to generate absolute URLs. These methods are used to send 
absolute URLs in email notifications for the login page, replacing the previous 
relative URLs.
   
   ### Changes
   
   - Added `getAbsoluteUrl(HttpServletRequest request, String relativeUrl)` and 
`getAbsoluteUrl(HttpServletRequest request)` methods in `HttpUtil`.
   - Included JUnit 5 tests to validate these new methods.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (jspwiki)

[via GitHub]

arturobernalg merged PR #310:
URL: https://github.com/apache/jspwiki/pull/310


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (jspwiki)

[via GitHub]

arturobernalg commented on PR #310:
URL: https://github.com/apache/jspwiki/pull/310#issuecomment-1742174282

   You're absolutely correct, JP. The version has been updated to
   2.12.2-git-03.
   
   
   Arturo
   
   
   On Sun, Oct 1, 2023 at 8:09 PM Brushed ***@***.***> wrote:
   
   > Txs. Looks ok to me.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (jspwiki)

[via GitHub]

brushed commented on PR #310:
URL: https://github.com/apache/jspwiki/pull/310#issuecomment-1742156411

   Txs. Looks ok to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] JSPWIKI-1181 - Fix: Correct URL Generation for Pages with Special Characters (jspwiki)

[via GitHub]

arturobernalg opened a new pull request, #310:
URL: https://github.com/apache/jspwiki/pull/310

   ### Summary
   This pull request addresses the issue of incorrect URL generation for pages 
with special characters like '/'. The `toUrl` function has been updated to 
handle these cases, ensuring that the generated URLs are accurate and 
functional.
   
   ### Changes
   - Updated the `toUrl` function to correctly handle page names with special 
characters.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. (jspwiki)

[via GitHub]

arturobernalg opened a new pull request, #307:
URL: https://github.com/apache/jspwiki/pull/307

   Refactored synchronized blocks/methods containing blocking operations to 
prevent potential deadlocks introduced by the upcoming Virtual Threads feature 
in JDK 21.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-778 JSPWiki missing some translations in Finnish (jspwiki)

[via GitHub]

arturobernalg merged PR #305:
URL: https://github.com/apache/jspwiki/pull/305


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Add missing Finnish translations in properties file. (jspwiki)

[via GitHub]

arturobernalg opened a new pull request, #305:
URL: https://github.com/apache/jspwiki/pull/305

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] JSPWIKI-778 JSPWiki missing some translations in Finnish (jspwiki)

[via GitHub]

arturobernalg closed pull request #300: JSPWIKI-778  JSPWiki missing some 
translations in Finnish
URL: https://github.com/apache/jspwiki/pull/300


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.codehaus.cargo:cargo-maven3-plugin from 1.10.7 to 1.10.9 (jspwiki)

[via GitHub]

arturobernalg closed pull request #298: Bump 
org.codehaus.cargo:cargo-maven3-plugin from 1.10.7 to 1.10.9
URL: https://github.com/apache/jspwiki/pull/298


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump com.codeborne:selenide from 6.16.1 to 6.17.2 (jspwiki)

[via GitHub]

arturobernalg closed pull request #303: Bump com.codeborne:selenide from 6.16.1 
to 6.17.2
URL: https://github.com/apache/jspwiki/pull/303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump mockito.version from 5.4.0 to 5.5.0 (jspwiki)

[via GitHub]

arturobernalg closed pull request #302: Bump mockito.version from 5.4.0 to 5.5.0
URL: https://github.com/apache/jspwiki/pull/302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Add missing Finnish translations in properties file. (jspwiki)

[via GitHub]

arturobernalg opened a new pull request, #300:
URL: https://github.com/apache/jspwiki/pull/300

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump jdom2 from 2.0.6 to 2.0.6.1 (jspwiki)

[via GitHub]

arturobernalg commented on PR #159:
URL: https://github.com/apache/jspwiki/pull/159#issuecomment-1683669992

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump org.codehaus.cargo:cargo-maven3-plugin from 1.10.7 to 1.10.9 (jspwiki)

[via GitHub]

arturobernalg commented on PR #298:
URL: https://github.com/apache/jspwiki/pull/298#issuecomment-1682992686

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump com.codeborne:selenide from 6.16.1 to 6.17.0 (jspwiki)

[via GitHub]

arturobernalg commented on PR #297:
URL: https://github.com/apache/jspwiki/pull/297#issuecomment-1682992566

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump com.github.jbellis:jamm from 0.3.3 to 0.4.0 (jspwiki)

[via GitHub]

arturobernalg commented on PR #296:
URL: https://github.com/apache/jspwiki/pull/296#issuecomment-1682990132

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Add GitHub Actions workflows for Java CI and Dependency Review (jspwiki)

[via GitHub]

arturobernalg opened a new pull request, #299:
URL: https://github.com/apache/jspwiki/pull/299

   This pull request introduces two new GitHub Actions workflows:
   
   1. **Java CI Workflow**: 
  - Provides continuous integration support for multiple OS and Java 
versions.
  - Caches Maven dependencies for optimized build times.
  - Implements CodeQL analysis for enhanced code security.
   
   2. **Dependency Review Workflow**: 
  - Triggered on pull requests to ensure dependencies are reviewed and safe.
   
   These workflows aim to enhance the project's CI/CD pipeline, ensuring code 
quality and security with each pull request. Feedback and suggestions are 
welcome!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Use try-with-resources. (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #207:
URL: https://github.com/apache/jspwiki/pull/207#issuecomment-1656893050

   Hi! just've seen now a pending review here - there're still a bunch of `try 
(JspWriter out = pageContext.getOut()) {` that should be reverted?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Serializable class without serialVersionUID (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #292:
URL: https://github.com/apache/jspwiki/pull/292#issuecomment-1656891408

   merged in 2.12.1-git-02, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Serializable class without serialVersionUID (jspwiki)

[via GitHub]

juanpablo-santos merged PR #292:
URL: https://github.com/apache/jspwiki/pull/292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Constant charset String literal (for example, "UTF-8") can be replaced with the predefined StandardCharsets.UTF_8 code. (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #290:
URL: https://github.com/apache/jspwiki/pull/290#issuecomment-1656891269

   merged in 2.12.1-git-02, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Use placeholders in the logger message. (jspwiki)

[via GitHub]

juanpablo-santos merged PR #291:
URL: https://github.com/apache/jspwiki/pull/291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Constant charset String literal (for example, "UTF-8") can be replaced with the predefined StandardCharsets.UTF_8 code. (jspwiki)

[via GitHub]

juanpablo-santos merged PR #290:
URL: https://github.com/apache/jspwiki/pull/290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Use placeholders in the logger message. (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #291:
URL: https://github.com/apache/jspwiki/pull/291#issuecomment-1656891355

   merged in 2.12.1-git-02, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #282:
URL: https://github.com/apache/jspwiki/pull/282#issuecomment-1656890604

   merged in 2.12.1-git-02, would you mind resolving the associated jira issue? 
thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [JSPWIKI-1172] Set jspwiki.workDir default to servlet context temp directory (jspwiki)

[via GitHub]

juanpablo-santos merged PR #282:
URL: https://github.com/apache/jspwiki/pull/282


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] java 11 improvements. (jspwiki)

[via GitHub]

juanpablo-santos commented on PR #272:
URL: https://github.com/apache/jspwiki/pull/272#issuecomment-1656888291

   merged in 2.12.1-git-02, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] java 11 improvements. (jspwiki)

[via GitHub]

juanpablo-santos merged PR #272:
URL: https://github.com/apache/jspwiki/pull/272


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump flexmark.version from 0.64.6 to 0.64.8 (jspwiki)

[via GitHub]

juanpablo-santos closed pull request #286: Bump flexmark.version from 0.64.6 to 
0.64.8
URL: https://github.com/apache/jspwiki/pull/286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump com.codeborne:selenide from 6.15.0 to 6.16.1 (jspwiki)

[via GitHub]

juanpablo-santos closed pull request #294: Bump com.codeborne:selenide from 
6.15.0 to 6.16.1
URL: https://github.com/apache/jspwiki/pull/294


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump hsqldb.version from 2.7.1 to 2.7.2 (jspwiki)

[via GitHub]

juanpablo-santos closed pull request #287: Bump hsqldb.version from 2.7.1 to 
2.7.2
URL: https://github.com/apache/jspwiki/pull/287


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Bump mockito.version from 5.3.1 to 5.4.0 (jspwiki)

[via GitHub]

juanpablo-santos closed pull request #288: Bump mockito.version from 5.3.1 to 
5.4.0
URL: https://github.com/apache/jspwiki/pull/288


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [jspwiki-site] arturobernalg closed pull request #1: Add myself to committer and PMC list

[via GitHub]

arturobernalg closed pull request #1: Add myself to committer and PMC list
URL: https://github.com/apache/jspwiki-site/pull/1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] Serializable class without serialVersionUID (jspwiki)

[via GitHub]

arturobernalg opened a new pull request, #292:
URL: https://github.com/apache/jspwiki/pull/292

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jspwiki.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org