[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848861#comment-15848861 ] brushed commented on JSPWIKI-1035: -- Harry, The MooEditable javascript library is using by coincidence a variable with the name "baseURL". But this has nothing to do with the baseURL of JSPWiki. dirk > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: brushed > Attachments: DefaultURLConstructor.java.patch, > jspwiki.properties.patch, WikiEngine.java.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15789583#comment-15789583 ] Harry Metske commented on JSPWIKI-1035: --- I merged it back to master now. There is still some reference to baseURL in the javascripts: * jspwiki-war/src/main/webapp/scripts/mooeditable/Source/MooEditable/MooEditable.js * jspwiki-war/src/main/scripts/wiki-wysiwyg/Source/MooEditable/MooEditable.js > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[
https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15788204#comment-15788204
]
Jürgen Weber commented on JSPWIKI-1035:
---
Actually, getting JSPWiki up and running is now as easy as:
1: put the content of jspwiki-wikipages-de-2.10.3-SNAPSHOT.zip into
$\{user.home\}/jspwiki-files
2. drop JSPWiki.war into $\{catalina.home\}/webapps
> get rid of jspwiki.baseURL
> --
>
> Key: JSPWIKI-1035
> URL: https://issues.apache.org/jira/browse/JSPWIKI-1035
> Project: JSPWiki
> Issue Type: Improvement
> Components: Core & storage
>Affects Versions: 2.10.2
>Reporter: Jürgen Weber
>Assignee: Harry Metske
> Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch,
> jspwiki.properties.patch
>
>
> Could we get rid of jspwiki.baseURL and calculate it on
> HttpServletRequest#getContextPath() ?
> It's the only mandatory property you have to set for JSPWiki, so removing it
> would make installation much easier.
> And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e.
> you cannot use the same JSPWiki instance in an intranet and on the internet
> (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed
> Apache, neither SSL and non-SSL.
> If you look at the source of https://jspwiki-wiki.apache.org/
> there are not many places where the whole base url is used. So, I wonder, if
> context relative links could be sufficient.
> http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783640#comment-15783640 ] Jürgen Weber commented on JSPWIKI-1035: --- I guess until now the installer did not start until you had set jspwiki.baseURL so you'd have to have a means to edit jspwiki-custom.properties anyway. So no reason to keep installer, everything installer does should be possible with jspwiki-custom.properties, isn't it? > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783530#comment-15783530 ] Harry Metske commented on JSPWIKI-1035: --- nice, tx > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783527#comment-15783527 ] Siegfried Goeschl commented on JSPWIKI-1035: [~metskem] I played with JSPWiki portable from the JSPWIKI-1035 branch and it looks good :-) > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783500#comment-15783500 ] Harry Metske commented on JSPWIKI-1035: --- I also don't use it, I think one of the reasons for it's existence is that some users do not have console access to their servers (mostly hosted environments), and the Installer then offers (limited) configuration options. Anyway, I think we can just keep the Installer as it is now. If there are no objections I like to merge JSPWIKI-1035 back to the master branch, > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber >Assignee: Harry Metske > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15756915#comment-15756915 ] Harry Metske commented on JSPWIKI-1035: --- There were a lot of broken unit tests. I fixed a couple of them , still about 40 failing. I have created branch JSPWIKI-1035, see https://github.com/apache/jspwiki/tree/JSPWIKI-1035 . > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746530#comment-15746530 ] Jürgen Weber commented on JSPWIKI-1035: --- Isn't a branch a bit heavy? I tested with ShortViewURLConstructor and default template, looks good. Didn't test haddock. I ran JSPWiki on a machine reachable with two IP addresses, Firefox of course sees two separate web applications. > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15746174#comment-15746174 ] Harry Metske commented on JSPWIKI-1035: --- Jurgen, can you create the patch files with the -u option, so we can apply them with the patch cmd (or IDE of course) ? Then I suggest we create a separate (JSPWIKI-1035) branch for it, so we can continue testing and patching it. > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber > Attachments: DefaultURLConstructor.java.patch, WikiEngine.java.patch, > jspwiki.properties.patch > > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JSPWIKI-1035) get rid of jspwiki.baseURL
[ https://issues.apache.org/jira/browse/JSPWIKI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648016#comment-15648016 ] Siegfried Goeschl commented on JSPWIKI-1035: That would be awesome :-) > get rid of jspwiki.baseURL > -- > > Key: JSPWIKI-1035 > URL: https://issues.apache.org/jira/browse/JSPWIKI-1035 > Project: JSPWiki > Issue Type: Improvement > Components: Core & storage >Affects Versions: 2.10.2 >Reporter: Jürgen Weber > > Could we get rid of jspwiki.baseURL and calculate it on > HttpServletRequest#getContextPath() ? > It's the only mandatory property you have to set for JSPWiki, so removing it > would make installation much easier. > And, first and foremost, it makes JSPWiki only work on exactly this URL, i.e. > you cannot use the same JSPWiki instance in an intranet and on the internet > (e.g. wiki.firm.com and wiki.firm.private), neither with and without JK'ed > Apache, neither SSL and non-SSL. > If you look at the source of https://jspwiki-wiki.apache.org/ > there are not many places where the whole base url is used. So, I wonder, if > context relative links could be sufficient. > http://stackoverflow.com/questions/4764405/how-to-use-relative-paths-without-including-the-context-root-name -- This message was sent by Atlassian JIRA (v6.3.4#6332)
