[jira] [Updated] (KAFKA-684) ConsoleProducer does not have the queue-size option

2013-01-07 Thread Maxime Brugidou (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxime Brugidou updated KAFKA-684:
--

Fix Version/s: 0.8
Affects Version/s: 0.8
   Status: Patch Available  (was: Open)

 ConsoleProducer does not have the queue-size option
 ---

 Key: KAFKA-684
 URL: https://issues.apache.org/jira/browse/KAFKA-684
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou
 Fix For: 0.8


 When using the kafka ConsoleProducer (from script kafka-console-producer.sh), 
 you cannot set the queue.size, which gets very annoying when  you want to 
 produce quickly a lot of messages. You definitely need to increase the 
 queue.size (or decrease the send timeout).
 Here is a simple patch to add the option.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-684) ConsoleProducer does not have the queue-size option

2013-01-07 Thread Maxime Brugidou (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxime Brugidou updated KAFKA-684:
--

Attachment: KAFKA-684.patch

 ConsoleProducer does not have the queue-size option
 ---

 Key: KAFKA-684
 URL: https://issues.apache.org/jira/browse/KAFKA-684
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou
 Fix For: 0.8

 Attachments: KAFKA-684.patch


 When using the kafka ConsoleProducer (from script kafka-console-producer.sh), 
 you cannot set the queue.size, which gets very annoying when  you want to 
 produce quickly a lot of messages. You definitely need to increase the 
 queue.size (or decrease the send timeout).
 Here is a simple patch to add the option.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-685) ConsoleOffsetChecker does not work with 0.8

2013-01-07 Thread Maxime Brugidou (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxime Brugidou updated KAFKA-685:
--

Description: 
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{code:bash}
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
{code}


  was:
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{code}
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
{code}



 ConsoleOffsetChecker does not work with 0.8
 ---

 Key: KAFKA-685
 URL: https://issues.apache.org/jira/browse/KAFKA-685
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou

 The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
 useful when used with the MirrorMaker.
 Here is a patch to make it work with some cosmetic changes:
 * script-friendly formatting (one line per partition)
 * offsets do not correspond to bytes anymore (so the lag is in number of 
 messages, not GiB)
 * --broker-info optional option to print the broker list at the end (like the 
 previous version)
 Example: 
 {code:bash}
 bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
 --zkconnect zoo.example.org:2181
 Group   Topic   Pid Offset  logSize Lag   
   Owner
 KafkaMirror test   0  215385  215385  0   
 Some(KafkaMirror_broker01-1379350-71cf9117-0)
 KafkaMirror test   1  683564  683564  0   
 Some(KafkaMirror_broker03-1379351-71cf9117-0)
 KafkaMirror test2 0  176943  176943  0   
 Some(KafkaMirror_broker05-1379353-71cf91
 {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-685) ConsoleOffsetChecker does not work with 0.8

2013-01-07 Thread Maxime Brugidou (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxime Brugidou updated KAFKA-685:
--

Description: 
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{noformat}
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
{noformat}


  was:
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{code}
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
{code}



 ConsoleOffsetChecker does not work with 0.8
 ---

 Key: KAFKA-685
 URL: https://issues.apache.org/jira/browse/KAFKA-685
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou

 The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
 useful when used with the MirrorMaker.
 Here is a patch to make it work with some cosmetic changes:
 * script-friendly formatting (one line per partition)
 * offsets do not correspond to bytes anymore (so the lag is in number of 
 messages, not GiB)
 * --broker-info optional option to print the broker list at the end (like the 
 previous version)
 Example: 
 {noformat}
 bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
 --zkconnect zoo.example.org:2181
 Group   Topic   Pid Offset  logSize Lag   
   Owner
 KafkaMirror test   0  215385  215385  0   
 Some(KafkaMirror_broker01-1379350-71cf9117-0)
 KafkaMirror test   1  683564  683564  0   
 Some(KafkaMirror_broker03-1379351-71cf9117-0)
 KafkaMirror test2 0  176943  176943  0   
 Some(KafkaMirror_broker05-1379353-71cf91
 {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-685) ConsoleOffsetChecker does not work with 0.8

2013-01-07 Thread Maxime Brugidou (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxime Brugidou updated KAFKA-685:
--

Description: 
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{{
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
}}


  was:
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{noformat}
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
{noformat}



 ConsoleOffsetChecker does not work with 0.8
 ---

 Key: KAFKA-685
 URL: https://issues.apache.org/jira/browse/KAFKA-685
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou
 Attachments: KAFKA-685.patch


 The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
 useful when used with the MirrorMaker.
 Here is a patch to make it work with some cosmetic changes:
 * script-friendly formatting (one line per partition)
 * offsets do not correspond to bytes anymore (so the lag is in number of 
 messages, not GiB)
 * --broker-info optional option to print the broker list at the end (like the 
 previous version)
 Example: 
 {{
 bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
 --zkconnect zoo.example.org:2181
 Group   Topic   Pid Offset  logSize Lag   
   Owner
 KafkaMirror test   0  215385  215385  0   
 Some(KafkaMirror_broker01-1379350-71cf9117-0)
 KafkaMirror test   1  683564  683564  0   
 Some(KafkaMirror_broker03-1379351-71cf9117-0)
 KafkaMirror test2 0  176943  176943  0   
 Some(KafkaMirror_broker05-1379353-71cf91
 }}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-685) ConsoleOffsetChecker does not work with 0.8

2013-01-07 Thread Maxime Brugidou (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxime Brugidou updated KAFKA-685:
--

Description: 
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{{test}}
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
}}


  was:
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{{
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
}}



 ConsoleOffsetChecker does not work with 0.8
 ---

 Key: KAFKA-685
 URL: https://issues.apache.org/jira/browse/KAFKA-685
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou
 Attachments: KAFKA-685.patch


 The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
 useful when used with the MirrorMaker.
 Here is a patch to make it work with some cosmetic changes:
 * script-friendly formatting (one line per partition)
 * offsets do not correspond to bytes anymore (so the lag is in number of 
 messages, not GiB)
 * --broker-info optional option to print the broker list at the end (like the 
 previous version)
 Example: 
 {{test}}
 bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
 --zkconnect zoo.example.org:2181
 Group   Topic   Pid Offset  logSize Lag   
   Owner
 KafkaMirror test   0  215385  215385  0   
 Some(KafkaMirror_broker01-1379350-71cf9117-0)
 KafkaMirror test   1  683564  683564  0   
 Some(KafkaMirror_broker03-1379351-71cf9117-0)
 KafkaMirror test2 0  176943  176943  0   
 Some(KafkaMirror_broker05-1379353-71cf91
 }}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-685) ConsoleOffsetChecker does not work with 0.8

2013-01-07 Thread Maxime Brugidou (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxime Brugidou updated KAFKA-685:
--

Description: 
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91


  was:
The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
useful when used with the MirrorMaker.

Here is a patch to make it work with some cosmetic changes:

* script-friendly formatting (one line per partition)
* offsets do not correspond to bytes anymore (so the lag is in number of 
messages, not GiB)
* --broker-info optional option to print the broker list at the end (like the 
previous version)

Example: 

{{test}}
bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
--zkconnect zoo.example.org:2181
Group   Topic   Pid Offset  logSize Lag 
Owner
KafkaMirror test   0  215385  215385  0   
Some(KafkaMirror_broker01-1379350-71cf9117-0)
KafkaMirror test   1  683564  683564  0   
Some(KafkaMirror_broker03-1379351-71cf9117-0)
KafkaMirror test2 0  176943  176943  0   
Some(KafkaMirror_broker05-1379353-71cf91
}}



 ConsoleOffsetChecker does not work with 0.8
 ---

 Key: KAFKA-685
 URL: https://issues.apache.org/jira/browse/KAFKA-685
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou
 Attachments: KAFKA-685.patch


 The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
 useful when used with the MirrorMaker.
 Here is a patch to make it work with some cosmetic changes:
 * script-friendly formatting (one line per partition)
 * offsets do not correspond to bytes anymore (so the lag is in number of 
 messages, not GiB)
 * --broker-info optional option to print the broker list at the end (like the 
 previous version)
 Example: 
 bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
 --zkconnect zoo.example.org:2181
 Group   Topic   Pid Offset  logSize Lag   
   Owner
 KafkaMirror test   0  215385  215385  0   
 Some(KafkaMirror_broker01-1379350-71cf9117-0)
 KafkaMirror test   1  683564  683564  0   
 Some(KafkaMirror_broker03-1379351-71cf9117-0)
 KafkaMirror test2 0  176943  176943  0   
 Some(KafkaMirror_broker05-1379353-71cf91

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-685) ConsoleOffsetChecker does not work with 0.8

2013-01-07 Thread Maxime Brugidou (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxime Brugidou updated KAFKA-685:
--

Attachment: KAFKA-685.patch

 ConsoleOffsetChecker does not work with 0.8
 ---

 Key: KAFKA-685
 URL: https://issues.apache.org/jira/browse/KAFKA-685
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou
 Attachments: KAFKA-685.patch


 The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
 useful when used with the MirrorMaker.
 Here is a patch to make it work with some cosmetic changes:
 * script-friendly formatting (one line per partition)
 * offsets do not correspond to bytes anymore (so the lag is in number of 
 messages, not GiB)
 * --broker-info optional option to print the broker list at the end (like the 
 previous version)
 Example: 
 bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
 --zkconnect zoo.example.org:2181
 Group   Topic   Pid Offset  logSize Lag   
   Owner
 KafkaMirror test   0  215385  215385  0   
 Some(KafkaMirror_broker01-1379350-71cf9117-0)
 KafkaMirror test   1  683564  683564  0   
 Some(KafkaMirror_broker03-1379351-71cf9117-0)
 KafkaMirror test2 0  176943  176943  0   
 Some(KafkaMirror_broker05-1379353-71cf91

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: git workflow

2013-01-07 Thread David Arthur

Diff/patch makes it easy for non-committer to contribute.

On 1/7/13 12:52 AM, Derek Chen-Becker wrote:

Although I haven't contributed much here yet, I did want to ask: why
diff/patch and not pull/merge? I know my work on getting the SBT build
working with a modern SBT was quite a headache for everyone because the
diff format was unable to convey things like delete this binary file and
add this other one.

Derek


On Sat, Jan 5, 2013 at 10:35 PM, Joe Stein crypt...@gmail.com wrote:


ok with some more research today it seems the difference and issues I was
having was from the patch being made with

git diff vs git format-patch

with git diff (which is how the patch I was reviewing was made) you apply
doing patch -p1  patch

no commits messages are preserved with git diff.  I think there are pros
and cons to this.

If folks make good commit messages then this is great however I prefer the
git diff patch myself from contribs because then I can commit with a
message for the JIRA ticket and the reviewer

thoughts on git diff vs git format-patch ?

I updated the wiki to deal with the error i encountered since it already
references format-patch I but think we should have some consensus for
contributors and how they should proceed and how we should too.

On Sat, Jan 5, 2013 at 2:02 PM, Joe Stein crypt...@gmail.com wrote:


Ok, I figured out the problem.  The problem was with the patch format so

I

will take care of that ... the patch is minor enough I will take the code
changes and whip up a new patch and let Maxime know (assuming that patch

is

good) about how to make a Kafka patch moving forward).

I noticed the incubation URL was wrong on the README so I walked through
the contributor steps and everything worked just perfectly

the only thing I did notice is that the commit message I put in as a
contributor was part of the patch and everything so I think we should

call

out some guidelines for making commit messages, like always put the
KAFKA-XYZ in the message so when we review and push everything goes in

how

we expected if we made the change and committed ourselves.

I just could not let it go, now I am going to-do what I need to for work
before my daughter wakes up =8^)


On Sat, Jan 5, 2013 at 1:42 PM, Joe Stein crypt...@gmail.com wrote:


that did not work either

I can't even get the patch to apply from the latest trunk because of

this

message of patch without email

so the patch is here


https://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patch

I go through the steps on the git workflow

git clone https://git-wip-us.apache.org/repos/asf/kafka.git kafka
cd kafka
git fetch
git checkout trunk
//already on trunk
git apply --stat ../KAFKA-133.patch
//project/build.properties |2 +-
//project/build/KafkaProject.scala |   44
+-
//2 files changed, 25 insertions(+), 21 deletions(-)
git apply --check ../KAFKA-133.patch
git am --signoff  ../KAFKA-133.patch
//Patch does not have a valid e-mail address.

my git --version = 1.8.0.3

now what is interesting is when I grab the patch using wget


https://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patchinsteadof 
downloading it it through a browser I get Patch format

detection failed. instead of the error saying Patch does not have a

valid

e-mail address

I am guessing it is something I am doing wrong and could be doing
different but am interested to see where exactly the problem is.

any thoughts?  I gotta work on some code for work right will bang on

this

later tonight again but if anyone can reproduce this same thing or not

or

has an idea that would be great.

could just be the patch, but would prefer to fix the patch and review

the

code change for what it is and communicate moving forward how to make
patches differently (if that is in fact the problem)


On Sat, Jan 5, 2013 at 12:38 PM, David Arthur mum...@gmail.com wrote:


You can amend the previous commit (as long as you havent pushed) with

an

author like git --amend --author='...'

On Saturday, January 5, 2013, Joe Stein wrote:


I am getting the no email after doing

git am --signoff  xyz.patch

so nothing gets in to commit to set the author :(

On Sat, Jan 5, 2013 at 12:30 AM, Jay Kreps jay.kr...@gmail.com

javascript:;

wrote:


I have but I don't really know why. This format worked for me:
   git commit --author='Bertrand Russell bruss...@cambridge.edu

javascript:;

'


On Fri, Jan 4, 2013 at 8:35 PM, Joe Stein crypt...@gmail.com

javascript:;

wrote:

I started following this so far really helpful thanks!!

Running into some issues reviewing someone's patch getting Patch

does

not

have a valid e-mail address. googling to figure out what is

wrong

figure I

mention here if anyone bumped into this yet

thnx

On Thu, Jan 3, 2013 at 11:17 AM, Jun Rao jun...@gmail.com

javascript:;

wrote:

Thanks for documenting this. Could you also add how to resolve

conflicts

during rebase?

Jun

On Wed, Jan 2, 2013 at 

Re: git workflow

2013-01-07 Thread Derek Chen-Becker
It makes it easier for a non-committer to contribute via email, but with
publicly available repos (a la GitHub) it's just as easy to merge from a
remote (and doesn't require contorting through hoops for certain scenarios).
On Jan 7, 2013 7:45 AM, David Arthur mum...@gmail.com wrote:

 Diff/patch makes it easy for non-committer to contribute.

 On 1/7/13 12:52 AM, Derek Chen-Becker wrote:

 Although I haven't contributed much here yet, I did want to ask: why
 diff/patch and not pull/merge? I know my work on getting the SBT build
 working with a modern SBT was quite a headache for everyone because the
 diff format was unable to convey things like delete this binary file and
 add this other one.

 Derek


 On Sat, Jan 5, 2013 at 10:35 PM, Joe Stein crypt...@gmail.com wrote:

  ok with some more research today it seems the difference and issues I was
 having was from the patch being made with

 git diff vs git format-patch

 with git diff (which is how the patch I was reviewing was made) you apply
 doing patch -p1  patch

 no commits messages are preserved with git diff.  I think there are pros
 and cons to this.

 If folks make good commit messages then this is great however I prefer
 the
 git diff patch myself from contribs because then I can commit with a
 message for the JIRA ticket and the reviewer

 thoughts on git diff vs git format-patch ?

 I updated the wiki to deal with the error i encountered since it already
 references format-patch I but think we should have some consensus for
 contributors and how they should proceed and how we should too.

 On Sat, Jan 5, 2013 at 2:02 PM, Joe Stein crypt...@gmail.com wrote:

  Ok, I figured out the problem.  The problem was with the patch format so

 I

 will take care of that ... the patch is minor enough I will take the
 code
 changes and whip up a new patch and let Maxime know (assuming that patch

 is

 good) about how to make a Kafka patch moving forward).

 I noticed the incubation URL was wrong on the README so I walked through
 the contributor steps and everything worked just perfectly

 the only thing I did notice is that the commit message I put in as a
 contributor was part of the patch and everything so I think we should

 call

 out some guidelines for making commit messages, like always put the
 KAFKA-XYZ in the message so when we review and push everything goes in

 how

 we expected if we made the change and committed ourselves.

 I just could not let it go, now I am going to-do what I need to for work
 before my daughter wakes up =8^)


 On Sat, Jan 5, 2013 at 1:42 PM, Joe Stein crypt...@gmail.com wrote:

  that did not work either

 I can't even get the patch to apply from the latest trunk because of

 this

 message of patch without email

 so the patch is here

  https://issues.apache.org/**jira/secure/attachment/**
 12563266/KAFKA-133.patchhttps://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patch

 I go through the steps on the git workflow

 git clone 
 https://git-wip-us.apache.org/**repos/asf/kafka.githttps://git-wip-us.apache.org/repos/asf/kafka.gitkafka
 cd kafka
 git fetch
 git checkout trunk
 //already on trunk
 git apply --stat ../KAFKA-133.patch
 //project/build.properties |2 +-
 //project/build/KafkaProject.**scala |   44
 +-**
 //2 files changed, 25 insertions(+), 21 deletions(-)
 git apply --check ../KAFKA-133.patch
 git am --signoff  ../KAFKA-133.patch
 //Patch does not have a valid e-mail address.

 my git --version = 1.8.0.3

 now what is interesting is when I grab the patch using wget

  https://issues.apache.org/**jira/secure/attachment/**
 12563266/KAFKA-133.**patchinsteadofhttps://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patchinsteadofdownloading
  it it through a browser I get Patch format

 detection failed. instead of the error saying Patch does not have a

 valid

 e-mail address

 I am guessing it is something I am doing wrong and could be doing
 different but am interested to see where exactly the problem is.

 any thoughts?  I gotta work on some code for work right will bang on

 this

 later tonight again but if anyone can reproduce this same thing or not

 or

 has an idea that would be great.

 could just be the patch, but would prefer to fix the patch and review

 the

 code change for what it is and communicate moving forward how to make
 patches differently (if that is in fact the problem)


 On Sat, Jan 5, 2013 at 12:38 PM, David Arthur mum...@gmail.com
 wrote:

  You can amend the previous commit (as long as you havent pushed) with

 an

 author like git --amend --author='...'

 On Saturday, January 5, 2013, Joe Stein wrote:

  I am getting the no email after doing

 git am --signoff  xyz.patch

 so nothing gets in to commit to set the author :(

 On Sat, Jan 5, 2013 at 12:30 AM, Jay Kreps jay.kr...@gmail.com

 javascript:;

 wrote:

  I have but I don't really know why. This format worked for me:
git commit 

Re: git workflow

2013-01-07 Thread Jay Kreps
The reason we take diffs is because traditionally the mandatory Apache
toolchain is svn+jira+patch/diff. When we were on github of course we used
that.

I'm actually not sure of the Apache rules here. Can we just directly accept
github pull requests? I.e. you fork the apache mirror and send a pull
request? Github has lots of tools for seeing diffs, commenting on code, etc
so this would be fantastic. Is that considered bad form? We could just have
the JIRA point to the github url...

-Jay


On Mon, Jan 7, 2013 at 7:05 AM, Derek Chen-Becker de...@precog.com wrote:

 It makes it easier for a non-committer to contribute via email, but with
 publicly available repos (a la GitHub) it's just as easy to merge from a
 remote (and doesn't require contorting through hoops for certain
 scenarios).
 On Jan 7, 2013 7:45 AM, David Arthur mum...@gmail.com wrote:

  Diff/patch makes it easy for non-committer to contribute.
 
  On 1/7/13 12:52 AM, Derek Chen-Becker wrote:
 
  Although I haven't contributed much here yet, I did want to ask: why
  diff/patch and not pull/merge? I know my work on getting the SBT build
  working with a modern SBT was quite a headache for everyone because the
  diff format was unable to convey things like delete this binary file
 and
  add this other one.
 
  Derek
 
 
  On Sat, Jan 5, 2013 at 10:35 PM, Joe Stein crypt...@gmail.com wrote:
 
   ok with some more research today it seems the difference and issues I
 was
  having was from the patch being made with
 
  git diff vs git format-patch
 
  with git diff (which is how the patch I was reviewing was made) you
 apply
  doing patch -p1  patch
 
  no commits messages are preserved with git diff.  I think there are
 pros
  and cons to this.
 
  If folks make good commit messages then this is great however I prefer
  the
  git diff patch myself from contribs because then I can commit with a
  message for the JIRA ticket and the reviewer
 
  thoughts on git diff vs git format-patch ?
 
  I updated the wiki to deal with the error i encountered since it
 already
  references format-patch I but think we should have some consensus for
  contributors and how they should proceed and how we should too.
 
  On Sat, Jan 5, 2013 at 2:02 PM, Joe Stein crypt...@gmail.com wrote:
 
   Ok, I figured out the problem.  The problem was with the patch format
 so
 
  I
 
  will take care of that ... the patch is minor enough I will take the
  code
  changes and whip up a new patch and let Maxime know (assuming that
 patch
 
  is
 
  good) about how to make a Kafka patch moving forward).
 
  I noticed the incubation URL was wrong on the README so I walked
 through
  the contributor steps and everything worked just perfectly
 
  the only thing I did notice is that the commit message I put in as a
  contributor was part of the patch and everything so I think we should
 
  call
 
  out some guidelines for making commit messages, like always put the
  KAFKA-XYZ in the message so when we review and push everything goes in
 
  how
 
  we expected if we made the change and committed ourselves.
 
  I just could not let it go, now I am going to-do what I need to for
 work
  before my daughter wakes up =8^)
 
 
  On Sat, Jan 5, 2013 at 1:42 PM, Joe Stein crypt...@gmail.com wrote:
 
   that did not work either
 
  I can't even get the patch to apply from the latest trunk because of
 
  this
 
  message of patch without email
 
  so the patch is here
 
   https://issues.apache.org/**jira/secure/attachment/**
  12563266/KAFKA-133.patch
 https://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patch
 
  I go through the steps on the git workflow
 
  git clone https://git-wip-us.apache.org/**repos/asf/kafka.git
 https://git-wip-us.apache.org/repos/asf/kafka.gitkafka
  cd kafka
  git fetch
  git checkout trunk
  //already on trunk
  git apply --stat ../KAFKA-133.patch
  //project/build.properties |2 +-
  //project/build/KafkaProject.**scala |   44
  +-**
  //2 files changed, 25 insertions(+), 21 deletions(-)
  git apply --check ../KAFKA-133.patch
  git am --signoff  ../KAFKA-133.patch
  //Patch does not have a valid e-mail address.
 
  my git --version = 1.8.0.3
 
  now what is interesting is when I grab the patch using wget
 
   https://issues.apache.org/**jira/secure/attachment/**
  12563266/KAFKA-133.**patchinsteadof
 https://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patchinsteadofdownloading
 it it through a browser I get Patch format
 
  detection failed. instead of the error saying Patch does not have a
 
  valid
 
  e-mail address
 
  I am guessing it is something I am doing wrong and could be doing
  different but am interested to see where exactly the problem is.
 
  any thoughts?  I gotta work on some code for work right will bang on
 
  this
 
  later tonight again but if anyone can reproduce this same thing or not
 
  or
 
  has an idea that would be great.
 
  could just be the patch, but would 

Re: git workflow

2013-01-07 Thread Derek Chen-Becker
If it's mandated by Apache rules, I understand, but I do think that
GitHub/git provide improved workflow over SVN + patch. Apache appears to be
mirroring to GitHub anyway:

https://github.com/apache/kafka

You even have a pull request (5 months old) already. Things like pull
request review/commenting, as mentioned, are very nice, and it would be a
shame to not be able to use them.

Derek


On Mon, Jan 7, 2013 at 9:06 AM, Jay Kreps jay.kr...@gmail.com wrote:

 The reason we take diffs is because traditionally the mandatory Apache
 toolchain is svn+jira+patch/diff. When we were on github of course we used
 that.

 I'm actually not sure of the Apache rules here. Can we just directly accept
 github pull requests? I.e. you fork the apache mirror and send a pull
 request? Github has lots of tools for seeing diffs, commenting on code, etc
 so this would be fantastic. Is that considered bad form? We could just have
 the JIRA point to the github url...

 -Jay


 On Mon, Jan 7, 2013 at 7:05 AM, Derek Chen-Becker de...@precog.com
 wrote:

  It makes it easier for a non-committer to contribute via email, but with
  publicly available repos (a la GitHub) it's just as easy to merge from a
  remote (and doesn't require contorting through hoops for certain
  scenarios).
  On Jan 7, 2013 7:45 AM, David Arthur mum...@gmail.com wrote:
 
   Diff/patch makes it easy for non-committer to contribute.
  
   On 1/7/13 12:52 AM, Derek Chen-Becker wrote:
  
   Although I haven't contributed much here yet, I did want to ask: why
   diff/patch and not pull/merge? I know my work on getting the SBT build
   working with a modern SBT was quite a headache for everyone because
 the
   diff format was unable to convey things like delete this binary file
  and
   add this other one.
  
   Derek
  
  
   On Sat, Jan 5, 2013 at 10:35 PM, Joe Stein crypt...@gmail.com
 wrote:
  
ok with some more research today it seems the difference and issues I
  was
   having was from the patch being made with
  
   git diff vs git format-patch
  
   with git diff (which is how the patch I was reviewing was made) you
  apply
   doing patch -p1  patch
  
   no commits messages are preserved with git diff.  I think there are
  pros
   and cons to this.
  
   If folks make good commit messages then this is great however I
 prefer
   the
   git diff patch myself from contribs because then I can commit with a
   message for the JIRA ticket and the reviewer
  
   thoughts on git diff vs git format-patch ?
  
   I updated the wiki to deal with the error i encountered since it
  already
   references format-patch I but think we should have some consensus for
   contributors and how they should proceed and how we should too.
  
   On Sat, Jan 5, 2013 at 2:02 PM, Joe Stein crypt...@gmail.com
 wrote:
  
Ok, I figured out the problem.  The problem was with the patch
 format
  so
  
   I
  
   will take care of that ... the patch is minor enough I will take the
   code
   changes and whip up a new patch and let Maxime know (assuming that
  patch
  
   is
  
   good) about how to make a Kafka patch moving forward).
  
   I noticed the incubation URL was wrong on the README so I walked
  through
   the contributor steps and everything worked just perfectly
  
   the only thing I did notice is that the commit message I put in as
 a
   contributor was part of the patch and everything so I think we
 should
  
   call
  
   out some guidelines for making commit messages, like always put the
   KAFKA-XYZ in the message so when we review and push everything goes
 in
  
   how
  
   we expected if we made the change and committed ourselves.
  
   I just could not let it go, now I am going to-do what I need to for
  work
   before my daughter wakes up =8^)
  
  
   On Sat, Jan 5, 2013 at 1:42 PM, Joe Stein crypt...@gmail.com
 wrote:
  
that did not work either
  
   I can't even get the patch to apply from the latest trunk because
 of
  
   this
  
   message of patch without email
  
   so the patch is here
  
https://issues.apache.org/**jira/secure/attachment/**
   12563266/KAFKA-133.patch
 
 https://issues.apache.org/jira/secure/attachment/12563266/KAFKA-133.patch
  
   I go through the steps on the git workflow
  
   git clone https://git-wip-us.apache.org/**repos/asf/kafka.git
  https://git-wip-us.apache.org/repos/asf/kafka.gitkafka
   cd kafka
   git fetch
   git checkout trunk
   //already on trunk
   git apply --stat ../KAFKA-133.patch
   //project/build.properties |2 +-
   //project/build/KafkaProject.**scala |   44
   +-**
   //2 files changed, 25 insertions(+), 21 deletions(-)
   git apply --check ../KAFKA-133.patch
   git am --signoff  ../KAFKA-133.patch
   //Patch does not have a valid e-mail address.
  
   my git --version = 1.8.0.3
  
   now what is interesting is when I grab the patch using wget
  
https://issues.apache.org/**jira/secure/attachment/**
   12563266/KAFKA-133.**patchinsteadof
 
 

[jira] Subscription: outstanding kafka patches

2013-01-07 Thread jira
Issue Subscription
Filter: outstanding kafka patches (56 issues)
The list of outstanding kafka patches
Subscriber: kafka-mailing-list

Key Summary
KAFKA-685   ConsoleOffsetChecker does not work with 0.8
https://issues.apache.org/jira/browse/KAFKA-685
KAFKA-684   ConsoleProducer does not have the queue-size option
https://issues.apache.org/jira/browse/KAFKA-684
KAFKA-682   java.lang.OutOfMemoryError: Java heap space
https://issues.apache.org/jira/browse/KAFKA-682
KAFKA-677   Retention process gives exception if an empty segment is chosen for 
collection
https://issues.apache.org/jira/browse/KAFKA-677
KAFKA-674   Clean Shutdown Testing - Log segments checksums mismatch
https://issues.apache.org/jira/browse/KAFKA-674
KAFKA-651   Create testcases on auto create topics
https://issues.apache.org/jira/browse/KAFKA-651
KAFKA-648   Use uniform convention for naming properties keys 
https://issues.apache.org/jira/browse/KAFKA-648
KAFKA-645   Create a shell script to run System Test with DEBUG details and 
tee console output to a file
https://issues.apache.org/jira/browse/KAFKA-645
KAFKA-637   Separate log4j environment variable from KAFKA_OPTS in 
kafka-run-class.sh
https://issues.apache.org/jira/browse/KAFKA-637
KAFKA-621   System Test 9051 : ConsoleConsumer doesn't receives any data for 20 
topics but works for 10
https://issues.apache.org/jira/browse/KAFKA-621
KAFKA-607   System Test Transient Failure (case 4011 Log Retention) - 
ConsoleConsumer receives less data
https://issues.apache.org/jira/browse/KAFKA-607
KAFKA-606   System Test Transient Failure (case 0302 GC Pause) - Log segments 
mismatched across replicas
https://issues.apache.org/jira/browse/KAFKA-606
KAFKA-604   Add missing metrics in 0.8
https://issues.apache.org/jira/browse/KAFKA-604
KAFKA-598   decouple fetch size from max message size
https://issues.apache.org/jira/browse/KAFKA-598
KAFKA-583   SimpleConsumerShell may receive less data inconsistently
https://issues.apache.org/jira/browse/KAFKA-583
KAFKA-552   No error messages logged for those failing-to-send messages from 
Producer
https://issues.apache.org/jira/browse/KAFKA-552
KAFKA-547   The ConsumerStats MBean name should include the groupid
https://issues.apache.org/jira/browse/KAFKA-547
KAFKA-530   kafka.server.KafkaApis: kafka.common.OffsetOutOfRangeException
https://issues.apache.org/jira/browse/KAFKA-530
KAFKA-493   High CPU usage on inactive server
https://issues.apache.org/jira/browse/KAFKA-493
KAFKA-479   ZK EPoll taking 100% CPU usage with Kafka Client
https://issues.apache.org/jira/browse/KAFKA-479
KAFKA-465   Performance test scripts - refactoring leftovers from tools to perf 
package
https://issues.apache.org/jira/browse/KAFKA-465
KAFKA-438   Code cleanup in MessageTest
https://issues.apache.org/jira/browse/KAFKA-438
KAFKA-419   Updated PHP client library to support kafka 0.7+
https://issues.apache.org/jira/browse/KAFKA-419
KAFKA-414   Evaluate mmap-based writes for Log implementation
https://issues.apache.org/jira/browse/KAFKA-414
KAFKA-411   Message Error in high cocurrent environment
https://issues.apache.org/jira/browse/KAFKA-411
KAFKA-404   When using chroot path, create chroot on startup if it doesn't exist
https://issues.apache.org/jira/browse/KAFKA-404
KAFKA-399   0.7.1 seems to show less performance than 0.7.0
https://issues.apache.org/jira/browse/KAFKA-399
KAFKA-398   Enhance SocketServer to Enable Sending Requests
https://issues.apache.org/jira/browse/KAFKA-398
KAFKA-397   kafka.common.InvalidMessageSizeException: null
https://issues.apache.org/jira/browse/KAFKA-397
KAFKA-388   Add a highly available consumer co-ordinator to a Kafka cluster
https://issues.apache.org/jira/browse/KAFKA-388
KAFKA-346   Don't call commitOffsets() during rebalance
https://issues.apache.org/jira/browse/KAFKA-346
KAFKA-345   Add a listener to ZookeeperConsumerConnector to get notified on 
rebalance events
https://issues.apache.org/jira/browse/KAFKA-345
KAFKA-319   compression support added to php client does not pass unit tests
https://issues.apache.org/jira/browse/KAFKA-319
KAFKA-318   update zookeeper dependency to 3.3.5
https://issues.apache.org/jira/browse/KAFKA-318
KAFKA-314   Go Client Multi-produce
https://issues.apache.org/jira/browse/KAFKA-314
KAFKA-313   Add JSON output and looping options to ConsumerOffsetChecker
https://issues.apache.org/jira/browse/KAFKA-313
KAFKA-312   Add 'reset' operation for AsyncProducerDroppedEvents
https://issues.apache.org/jira/browse/KAFKA-312
KAFKA-298   Go Client support max message size

[jira] [Commented] (KAFKA-684) ConsoleProducer does not have the queue-size option

2013-01-07 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546291#comment-13546291
 ] 

Jun Rao commented on KAFKA-684:
---

Thanks for the patch. It looks good. While you are here, could you also expose 
the following properties (from SyncProducerConfig) in ConsoleProducer?
producer.request.timeout.ms
producer.request.required.acks

 ConsoleProducer does not have the queue-size option
 ---

 Key: KAFKA-684
 URL: https://issues.apache.org/jira/browse/KAFKA-684
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou
 Fix For: 0.8

 Attachments: KAFKA-684.patch


 When using the kafka ConsoleProducer (from script kafka-console-producer.sh), 
 you cannot set the queue.size, which gets very annoying when  you want to 
 produce quickly a lot of messages. You definitely need to increase the 
 queue.size (or decrease the send timeout).
 Here is a simple patch to add the option.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


LinkedIn's Kafka-Hadoop ETL pipeline is open source

2013-01-07 Thread Jay Kreps
Hey All,

There has been interesting in getting something a little more sophisticated
then the Input- and OutputFormat we include in contrib for reading Kafka
data into HDFS.

Internally at LinkedIn we have had a pretty sophisticated system that we
use for Kafka ETL. It automatically discovers topics, does date
partitioning, balances load for many topics, etc. We have wanted to open
source this for a while but haven't really had time to spend on it. This
code is now open source:
  https://github.com/linkedin/camus

Ken Goodhope is the lead for this system. If you have any questions there
is a mailing list here:
  camus_...@googlegroups.com

We haven't done a ton of packaging work on this yet so there isn't a ton of
documentation and it is a bit of work to get set up. So it is probably most
appropriate for people who would be taking a white box approach to the
code. We have had interest from a few groups in contributing and we are
definitely interested in recruiting this kind of help. All our own
development going forward will be done off the public github repo, as usual
with LinkedIn open source projects.

Until we get better docs up, you can get a pretty good high-level overview
of our setup from this paper:
  http://sites.computer.org/debull/A12june/pipeline.pdf

-Jay


[jira] [Commented] (KAFKA-685) ConsoleOffsetChecker does not work with 0.8

2013-01-07 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546397#comment-13546397
 ] 

Jun Rao commented on KAFKA-685:
---

Thanks for the patch.  The code looks good. Got the following error on latest 
0.8 branch. This is likely due to the recent change in KAFKA-668. So you need 
to change the regex a bit.

ERROR Could not parse broker info Some(jrao-ld.linkedin.biz:9092:) with 
regex ^([^:]+):(\d+)$ (kafka.tools.ConsumerOffsetChecker$)

 ConsoleOffsetChecker does not work with 0.8
 ---

 Key: KAFKA-685
 URL: https://issues.apache.org/jira/browse/KAFKA-685
 Project: Kafka
  Issue Type: Bug
  Components: core
Affects Versions: 0.8
Reporter: Maxime Brugidou
 Attachments: KAFKA-685.patch


 The ConsoleOffsetChecker does not work anymore with 0.8, this tool is very 
 useful when used with the MirrorMaker.
 Here is a patch to make it work with some cosmetic changes:
 * script-friendly formatting (one line per partition)
 * offsets do not correspond to bytes anymore (so the lag is in number of 
 messages, not GiB)
 * --broker-info optional option to print the broker list at the end (like the 
 previous version)
 Example: 
 bin/kafka-run-class.sh kafka.tools.ConsumerOffsetChecker --group KafkaMirror 
 --zkconnect zoo.example.org:2181
 Group   Topic   Pid Offset  logSize Lag   
   Owner
 KafkaMirror test   0  215385  215385  0   
 Some(KafkaMirror_broker01-1379350-71cf9117-0)
 KafkaMirror test   1  683564  683564  0   
 Some(KafkaMirror_broker03-1379351-71cf9117-0)
 KafkaMirror test2 0  176943  176943  0   
 Some(KafkaMirror_broker05-1379353-71cf91

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-07 Thread Sriram Subramanian (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sriram Subramanian updated KAFKA-648:
-

Attachment: configchanges-v2.patch

1. Standardized usage of enable
2. Fixed config names in SyncPRoducerConfigShared and AsyncProducerConfig
3. Made the property changes in system_tests, perf

 Use uniform convention for naming properties keys 
 --

 Key: KAFKA-648
 URL: https://issues.apache.org/jira/browse/KAFKA-648
 Project: Kafka
  Issue Type: Bug
Affects Versions: 0.8
Reporter: Swapnil Ghike
Assignee: Sriram Subramanian
Priority: Blocker
 Fix For: 0.8, 0.8.1

 Attachments: configchanges-1.patch, configchanges-v2.patch


 Currently, the convention that we seem to use to get a property value in 
 *Config is as follows:
 val configVal = property.getType(config.val, ...) // dot is used to 
 separate two words in the key and the first letter of second word is 
 capitalized in configVal.
 We should use similar convention for groupId, consumerId, clientId, 
 correlationId.
 This change will probably be backward non-compatible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Created] (KAFKA-686) 0.8 Kafka broker should give a better error message when running against 0.7 zookeeper

2013-01-07 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-686:
---

 Summary: 0.8 Kafka broker should give a better error message when 
running against 0.7 zookeeper
 Key: KAFKA-686
 URL: https://issues.apache.org/jira/browse/KAFKA-686
 Project: Kafka
  Issue Type: Bug
Reporter: Jay Kreps
 Fix For: 0.8


People will not know that the zookeeper paths are not compatible. When you try 
to start the 0.8 broker pointed at a 0.7 zookeeper you get a 
NullPointerException. We should detect this and give a more sane error.

Error:
kafka.common.KafkaException: Can't parse json string: null
at kafka.utils.Json$.liftedTree1$1(Json.scala:20)
at kafka.utils.Json$.parseFull(Json.scala:16)
at 
kafka.utils.ZkUtils$$anonfun$getReplicaAssignmentForTopics$2.apply(ZkUtils.scala:498)
at 
kafka.utils.ZkUtils$$anonfun$getReplicaAssignmentForTopics$2.apply(ZkUtils.scala:494)
at 
scala.collection.LinearSeqOptimized$class.foreach(LinearSeqOptimized.scala:61)
at scala.collection.immutable.List.foreach(List.scala:45)
at kafka.utils.ZkUtils$.getReplicaAssignmentForTopics(ZkUtils.scala:494)
at 
kafka.controller.KafkaController.initializeControllerContext(KafkaController.scala:446)
at 
kafka.controller.KafkaController.onControllerFailover(KafkaController.scala:220)
at 
kafka.controller.KafkaController$$anonfun$1.apply$mcV$sp(KafkaController.scala:85)
at 
kafka.server.ZookeeperLeaderElector.elect(ZookeeperLeaderElector.scala:53)
at 
kafka.server.ZookeeperLeaderElector.startup(ZookeeperLeaderElector.scala:43)
at kafka.controller.KafkaController.startup(KafkaController.scala:381)
at kafka.server.KafkaServer.startup(KafkaServer.scala:90)
at 
kafka.server.KafkaServerStartable.startup(KafkaServerStartable.scala:34)
at kafka.Kafka$.main(Kafka.scala:46)
at kafka.Kafka.main(Kafka.scala)
Caused by: java.lang.NullPointerException
at 
scala.util.parsing.combinator.lexical.Scanners$Scanner.init(Scanners.scala:52)
at scala.util.parsing.json.JSON$.parseRaw(JSON.scala:71)
at scala.util.parsing.json.JSON$.parseFull(JSON.scala:85)
at kafka.utils.Json$.liftedTree1$1(Json.scala:17)
... 16 more

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (KAFKA-133) Publish kafka jar to a public maven repository

2013-01-07 Thread Jun Rao (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546624#comment-13546624
 ] 

Jun Rao commented on KAFKA-133:
---

Joe, do you plan to merge the commit to the 0.8 branch?

 Publish kafka jar to a public maven repository
 --

 Key: KAFKA-133
 URL: https://issues.apache.org/jira/browse/KAFKA-133
 Project: Kafka
  Issue Type: Improvement
Affects Versions: 0.6, 0.8
Reporter: Neha Narkhede
  Labels: patch
 Fix For: 0.8

 Attachments: KAFKA-133.patch, pom.xml


 The released kafka jar must be download manually and then deploy to a private 
 repository before they can be used by a developer using maven2.
 Similar to other Apache projects, it will be nice to have a way to publish 
 Kafka releases to a public maven repo. 
 In the past, we gave it a try using sbt publish to Sonatype Nexus maven repo, 
 but ran into some authentication problems. It will be good to revisit this 
 and get it resolved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira