Re: [VOTE] KIP-238: Expose Kafka cluster ID in Connect REST API

2017-12-17 Thread Konstantine Karantasis
+1

Nice KIP. Thanks!

- Konstantine

On Sat, Dec 16, 2017 at 6:19 AM, Gwen Shapira  wrote:

> +1 (binding). Thanks!
> On Fri, Dec 15, 2017 at 10:55 AM Ted Yu  wrote:
>
> > +1
> >
> > On Fri, Dec 15, 2017 at 10:49 AM, Ewen Cheslack-Postava <
> e...@confluent.io
> > >
> > wrote:
> >
> > > Discussion seems to have tapered off, so I'd like to start the vote on
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 238%3A+Expose+Kafka+cluster+ID+in+Connect+REST+API
> > >
> > > Obviously +1 (binding) from me :)
> > >
> > > -Ewen
> > >
> >
>


[jira] [Resolved] (KAFKA-4767) KafkaProducer is not joining its IO thread properly

2017-12-17 Thread huxihx (JIRA)

 [ 
https://issues.apache.org/jira/browse/KAFKA-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

huxihx resolved KAFKA-4767.
---
Resolution: Fixed

already fixed in another jira.

> KafkaProducer is not joining its IO thread properly
> ---
>
> Key: KAFKA-4767
> URL: https://issues.apache.org/jira/browse/KAFKA-4767
> Project: Kafka
>  Issue Type: Bug
>  Components: producer 
>Affects Versions: 0.10.2.0
>Reporter: Buğra Gedik
>Assignee: huxihx
>Priority: Minor
> Fix For: 1.1.0, 1.0.1, 0.11.0.3
>
>
> The {{KafkaProducer}} is not properly joining the thread it creates. The code 
> is like this:
> {code}
> try {
> this.ioThread.join(timeUnit.toMillis(timeout));
> } catch (InterruptedException t) {
> firstException.compareAndSet(null, t);
> log.error("Interrupted while joining ioThread", t);
> }
> {code}
> If the code is interrupted while performing the join, it will end up leaving 
> the io thread running. The correct way of handling this is a follows:
> {code}
> try {
> this.ioThread.join(timeUnit.toMillis(timeout));
> } catch (InterruptedException t) {
> // propagate the interrupt
> this.ioThread.interrupt();
> try { 
>  this.ioThread.join();
> } catch (InterruptedException t) {
> firstException.compareAndSet(null, t);
> log.error("Interrupted while joining ioThread", t);
> } finally {
> // make sure we maintain the interrupted status
> Thread.currentThread.interrupt();
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (KAFKA-6378) NullPointerException on KStream-GlobalKTable leftJoin when KeyValueMapper returns null

2017-12-17 Thread Andy Bryant (JIRA)
Andy Bryant created KAFKA-6378:
--

 Summary: NullPointerException on KStream-GlobalKTable leftJoin 
when KeyValueMapper returns null
 Key: KAFKA-6378
 URL: https://issues.apache.org/jira/browse/KAFKA-6378
 Project: Kafka
  Issue Type: Bug
  Components: streams
Affects Versions: 1.0.0
Reporter: Andy Bryant


On a Stream->GlobalKTable leftJoin if the KeyValueMapper returns null, the 
stream fails with a NullPointerException (see stacktrace below). On Kafka 
0.11.0.0 the stream processes this successfully, calling the ValueJoiner with 
the table value set to null.

The use-case for this is joining a stream to a table containing reference data 
where the stream foreign key may be null. There is no straight-forward 
workaround in this case with Kafka 1.0.0 without having to resort to either 
generating a key that will never match or branching the stream for records that 
don't have the foreign key.


Exception in thread "workshop-simple-example-client-StreamThread-1" 
java.lang.NullPointerException
at java.base/java.util.Objects.requireNonNull(Objects.java:221)
at 
org.apache.kafka.streams.state.internals.CachingKeyValueStore.get(CachingKeyValueStore.java:136)
at 
org.apache.kafka.streams.state.internals.CachingKeyValueStore.get(CachingKeyValueStore.java:35)
at 
org.apache.kafka.streams.state.internals.InnerMeteredKeyValueStore.get(InnerMeteredKeyValueStore.java:184)
at 
org.apache.kafka.streams.state.internals.MeteredKeyValueBytesStore.get(MeteredKeyValueBytesStore.java:116)
at 
org.apache.kafka.streams.kstream.internals.KTableSourceValueGetterSupplier$KTableSourceValueGetter.get(KTableSourceValueGetterSupplier.java:49)
at 
org.apache.kafka.streams.kstream.internals.KStreamKTableJoinProcessor.process(KStreamKTableJoinProcessor.java:56)
at 
org.apache.kafka.streams.processor.internals.ProcessorNode$1.run(ProcessorNode.java:46)
at 
org.apache.kafka.streams.processor.internals.StreamsMetricsImpl.measureLatencyNs(StreamsMetricsImpl.java:208)
at 
org.apache.kafka.streams.processor.internals.ProcessorNode.process(ProcessorNode.java:124)
at 
org.apache.kafka.streams.processor.internals.ProcessorContextImpl.forward(ProcessorContextImpl.java:85)
at 
org.apache.kafka.streams.processor.internals.SourceNode.process(SourceNode.java:80)
at 
org.apache.kafka.streams.processor.internals.StreamTask.process(StreamTask.java:216)
at 
org.apache.kafka.streams.processor.internals.AssignedTasks.process(AssignedTasks.java:403)
at 
org.apache.kafka.streams.processor.internals.TaskManager.process(TaskManager.java:317)
at 
org.apache.kafka.streams.processor.internals.StreamThread.processAndMaybeCommit(StreamThread.java:942)
at 
org.apache.kafka.streams.processor.internals.StreamThread.runOnce(StreamThread.java:822)
at 
org.apache.kafka.streams.processor.internals.StreamThread.runLoop(StreamThread.java:774)
at 
org.apache.kafka.streams.processor.internals.StreamThread.run(StreamThread.java:744)




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)