Re: [VOTE] KIP-266: Add TimeoutException for KafkaConsumer#position

[Richard Yu]

Hi,

With 3 binding votes and 6 non-binding, this KIP would be accepted.

Thanks for participating.

On Thu, May 10, 2018 at 2:35 AM, Edoardo Comar  wrote:

> +1 (non-binding)
>
> On 10 May 2018 at 10:29, zhenya Sun  wrote:
>
> > +1 non-binding
> >
> > > 在 2018年5月10日，下午5:19，Manikumar  写道：
> > >
> > > +1 (non-binding).
> > > Thanks.
> > >
> > > On Thu, May 10, 2018 at 2:33 PM, Mickael Maison <
> > mickael.mai...@gmail.com>
> > > wrote:
> > >
> > >> +1 (non binding)
> > >> Thanks
> > >>
> > >> On Thu, May 10, 2018 at 9:39 AM, Rajini Sivaram <
> > rajinisiva...@gmail.com>
> > >> wrote:
> > >>> Hi Richard, Thanks for the KIP.
> > >>>
> > >>> +1 (binding)
> > >>>
> > >>> Regards,
> > >>>
> > >>> Rajini
> > >>>
> > >>> On Wed, May 9, 2018 at 10:54 PM, Guozhang Wang 
> > >> wrote:
> > >>>
> >  +1 from me, thanks!
> > 
> > 
> >  Guozhang
> > 
> >  On Wed, May 9, 2018 at 10:46 AM, Jason Gustafson <
> ja...@confluent.io>
> >  wrote:
> > 
> > > Thanks for the KIP, +1 (binding).
> > >
> > > One small correction: the KIP mentions that close() will be
> > >> deprecated,
> >  but
> > > we do not want to do this because it is needed by the Closeable
> >  interface.
> > > We only want to deprecate close(long, TimeUnit) in favor of
> > > close(Duration).
> > >
> > > -Jason
> > >
> > > On Tue, May 8, 2018 at 12:43 AM, khaireddine Rezgui <
> > > khaireddine...@gmail.com> wrote:
> > >
> > >> +1
> > >>
> > >> 2018-05-07 20:35 GMT+01:00 Bill Bejeck :
> > >>
> > >>> +1
> > >>>
> > >>> Thanks,
> > >>> Bill
> > >>>
> > >>> On Fri, May 4, 2018 at 7:21 PM, Richard Yu <
> >  yohan.richard...@gmail.com
> > >>
> > >>> wrote:
> > >>>
> >  Hi all, I would like to bump this thread since discussion in the
> >  KIP
> >  appears to be reaching its conclusion.
> > 
> > 
> > 
> >  On Thu, Mar 15, 2018 at 3:30 PM, Richard Yu <
> > >> yohan.richard...@gmail.com>
> >  wrote:
> > 
> > > Hi all,
> > >
> > > Since there does not seem to be too much discussion in
> > >> KIP-266, I
> > >> will
> > >>> be
> > > starting a voting thread.
> > > Here is the link to KIP-266 for reference:
> > >
> > > https://cwiki.apache.org/confluence/pages/viewpage.
> >  action?pageId=75974886
> > >
> > > Recently, I have made some updates to the KIP. To reiterate, I
> >  have
> > > included KafkaConsumer's commitSync,
> > > poll, and committed in the KIP. (we will be adding to a
> > >>> TimeoutException
> > > to them as well, in a similar manner
> > > to what we will be doing for position())
> > >
> > > Thanks,
> > > Richard Yu
> > >
> > >
> > 
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >> Ingénieur en informatique
> > >>
> > >
> > 
> > 
> > 
> >  --
> >  -- Guozhang
> > 
> > >>
> >
> >
>
>
> --
> "When the people fear their government, there is tyranny; when the
> government fears the people, there is liberty." [Thomas Jefferson]
>

[jira] [Created] (KAFKA-6899) An Potential NPE

[lujie (JIRA)]

lujie created KAFKA-6899:


 Summary: An Potential NPE
 Key: KAFKA-6899
 URL: https://issues.apache.org/jira/browse/KAFKA-6899
 Project: Kafka
  Issue Type: Bug
Reporter: lujie


We have developed a static analysis tool 
[NPEDetector|https://github.com/lujiefsi/NPEDetector] to find some potential 
NPE. Our analysis shows that some callees may return null in corner case(e.g. 
node crash , IO exception), some of their callers have  _!=null_ check but some 
do not have. 

*Bug:*

callee JaasConfig#getAppConfigurationEntry  can return null, it has 13 callers, 
11 of the callers have the null checker while using the return value, 2 of them 
have no checker :
{code:java}
//caller1:KerberosLogin#login(Stirng, callback)
AppConfigurationEntry entries[] = 
Configuration.getConfiguration().getAppConfigurationEntry(loginContextName);
for (AppConfigurationEntry entry: entries) {}//may NPE

//caller2:KerberosLogin#login()
AppConfigurationEntry[] entries = 
configuration().getAppConfigurationEntry(contextName());
if (entries.length == 0)/may NPE
{code}
I am not sure these two are bug o or not, please correct me without any without 
any hesitation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)