Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #1161

2022-08-20 Thread Apache Jenkins Server
See 




[jira] [Resolved] (KAFKA-13914) Implement kafka-metadata-quorum.sh

2022-08-20 Thread Jason Gustafson (Jira)


 [ 
https://issues.apache.org/jira/browse/KAFKA-13914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Gustafson resolved KAFKA-13914.
-
Fix Version/s: 3.3.0
   Resolution: Fixed

> Implement kafka-metadata-quorum.sh
> --
>
> Key: KAFKA-13914
> URL: https://issues.apache.org/jira/browse/KAFKA-13914
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Jason Gustafson
>Assignee: dengziming
>Priority: Major
> Fix For: 3.3.0
>
>
> KIP-595 documents a tool for describing quorum status 
> `kafka-metadata-quorum.sh`: 
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-595%3A+A+Raft+Protocol+for+the+Metadata+Quorum#KIP595:ARaftProtocolfortheMetadataQuorum-ToolingSupport.]
>   We need to implement this.
> Note that this depends on the Admin API for `DescribeQuorum`, which is 
> proposed in KIP-836: 
> [https://cwiki.apache.org/confluence/display/KAFKA/KIP-836%3A+Addition+of+Information+in+DescribeQuorumResponse+about+Voter+Lag.]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [DISCUSS] KIP-854 Separate configuration for producer ID expiry

2022-08-20 Thread Luke Chen
+1 for internal configuration to reduce the complexity.
We can externalize it if we have some requirements in the future.

Thanks.
Luke

On Sat, Aug 20, 2022 at 2:13 AM David Jacot  wrote:

> Sounds good. Thanks, Justine.
>
> Le ven. 19 août 2022 à 19:38, Justine Olshan  >
> a écrit :
>
> > Hi all,
> >
> > Followed up with David and Ismael offline.
> > Ismael explained that we probably don't want to increase complexity and
> > didn't think the value needed to be modified beyond tests. I agree with
> > this so I've decided to go with an internal configuration (with the same
> > default as mentioned above).
> >
> > From a user's perspective, there will be no change. Because this is
> > internal, we decided to keep the name the internal variable used.
> >
> > Let me know if anyone has any further concerns.
> > Thanks,
> > Justine
> >
>


[jira] [Resolved] (KAFKA-14007) Connect header converters are never closed

2022-08-20 Thread Sagar Rao (Jira)


 [ 
https://issues.apache.org/jira/browse/KAFKA-14007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sagar Rao resolved KAFKA-14007.
---
Resolution: Fixed

> Connect header converters are never closed
> --
>
> Key: KAFKA-14007
> URL: https://issues.apache.org/jira/browse/KAFKA-14007
> Project: Kafka
>  Issue Type: Bug
>  Components: KafkaConnect
>Reporter: Chris Egerton
>Assignee: Sagar Rao
>Priority: Major
>
> The [HeaderConverter 
> interface|https://github.com/apache/kafka/blob/1e21201ea24389bdaccb8a462f3a53e356b58a58/connect/api/src/main/java/org/apache/kafka/connect/storage/HeaderConverter.java#L27]
>  extends {{Closeable}}, but {{HeaderConverter::close}} is never actually 
> invoked anywhere. We can and should start invoking it, probably wrapped in 
> [Utils::closeQuietly|https://github.com/apache/kafka/blob/1e21201ea24389bdaccb8a462f3a53e356b58a58/clients/src/main/java/org/apache/kafka/common/utils/Utils.java#L999-L1010]
>  so that any invalid logic in that method for custom header converters that 
> has to date gone undetected will not cause new task failures.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (KAFKA-14012) passing a "method" into the `Utils.closeQuietly` method cause NPE

2022-08-20 Thread Sagar Rao (Jira)


 [ 
https://issues.apache.org/jira/browse/KAFKA-14012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sagar Rao resolved KAFKA-14012.
---
Resolution: Fixed

> passing a "method" into the `Utils.closeQuietly` method cause NPE
> -
>
> Key: KAFKA-14012
> URL: https://issues.apache.org/jira/browse/KAFKA-14012
> Project: Kafka
>  Issue Type: Bug
>  Components: KafkaConnect
>Affects Versions: 3.2.0
>Reporter: Luke Chen
>Assignee: Sagar Rao
>Priority: Major
>
> Utils.closeQuietly method accepts `AutoCloseable` object, and close it. But 
> there are some places we passed "method" into Utils.closeQuietly, which 
> causes the object doesn't get closed as expected. 
> I found it appeared in:
> - WorkerConnector
> - AbstractWorkerSourceTask
> - KafkaConfigBackingStore
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)