Re: [VOTE] 0.10.1.1 RC0

[Bernard Leach]

I found those ones but was hoping to see them in 
https://repository.apache.org/content/groups/staging/org/apache/kafka/ 
 so we 
can just point the maven build there for testing.

> On 13 Dec 2016, at 11:38, Guozhang Wang  wrote:
> 
> @Bernard
> 
> You should be able to find the artifacts in the staging RC repository I
> listed above, named as "kafka_2.12-0.10.1.1.tgz
> 
> ".
> 
> @Everyone
> 
> Since KAFKA-4497 is a critical issue, that anyone using compaction with
> compressed message on server logs can possibly hit it, I'm going to create
> a new RC after it is merged (presumably soon).
> 
> If you discover any new problems in the meantime, let me know on this
> thread.
> 
> 
> Guozhang
> 
> 
> On Mon, Dec 12, 2016 at 2:51 PM, Ismael Juma  wrote:
> 
>> Yes, it would be good to include that (that's why I set the fix version to
>> 0.10.1.1 a couple of days ago).
>> 
>> Ismael
>> 
>> On Mon, Dec 12, 2016 at 3:47 PM, Moczarski, Swen <
>> smoczar...@ebay-kleinanzeigen.de> wrote:
>> 
>>> -0 (non-binding)
>>> 
>>> Would it make sense to include https://issues.apache.org/
>>> jira/browse/KAFKA-4497 ? The issue sounds quite critical and a patch for
>>> 0.10.1.1 seems to be available.
>>> 
>>> On 2016-12-07 23:46 (+0100), Guozhang Wang >> gmail.com>> wrote:
 Hello Kafka users, developers and client-developers,>
 
 This is the first candidate for the release of Apache Kafka 0.10.1.1.
>>> This is>
 a bug fix release and it includes fixes and improvements from 27 JIRAs.
>>> See>
 the release notes for more details:>
 
 http://home.apache.org/~guozhang/kafka-0.10.1.1-rc0/RELEASE_NOTES.html
>>> 
 
 *** Please download, test and vote by Monday, 13 December, 8am PT ***>
 
 Kafka's KEYS file containing PGP keys we use to sign the release:>
 http://kafka.apache.org/KEYS>
 
 * Release artifacts to be voted upon (source and binary):>
 http://home.apache.org/~guozhang/kafka-0.10.1.1-rc0/>
 
 * Maven artifacts to be voted upon:>
 https://repository.apache.org/content/groups/staging/org/apache/kafka/
>>> 
 
 * Javadoc:>
 http://home.apache.org/~guozhang/kafka-0.10.1.1-rc0/javadoc/>
 
 * Tag to be voted upon (off 0.10.0 branch) is the 0.10.0.1-rc0 tag:>
 https://git-wip-us.apache.org/repos/asf?p=kafka.git;a=tag;h=
>>> 8b77507083fdd427ce81021228e7e346da0d814c>
 
 
 Thanks,>
 Guozhang>
 
>>> 
>> 
> 
> 
> 
> -- 
> -- Guozhang

Re: [VOTE] 0.10.1.1 RC0

[Bernard Leach]

The scala 2.12 artifacts aren’t showing up, any chance of publishing them?

> On 9 Dec 2016, at 07:57, Vahid S Hashemian  wrote:
> 
> +1
> 
> Build and quickstart worked fine on Ubuntu, Mac, Windows 32 and 64 bit.
> 
> Thanks for running the release.
> 
> Regards,
> --Vahid 
> 
> 
> 
> 
> From:   Guozhang Wang 
> To: "us...@kafka.apache.org" , 
> "dev@kafka.apache.org" , 
> kafka-clie...@googlegroups.com
> Date:   12/07/2016 02:47 PM
> Subject:[VOTE] 0.10.1.1 RC0
> 
> 
> 
> Hello Kafka users, developers and client-developers,
> 
> This is the first candidate for the release of Apache Kafka 0.10.1.1. This 
> is
> a bug fix release and it includes fixes and improvements from 27 JIRAs. 
> See
> the release notes for more details:
> 
> http://home.apache.org/~guozhang/kafka-0.10.1.1-rc0/RELEASE_NOTES.html
> 
> *** Please download, test and vote by Monday, 13 December, 8am PT ***
> 
> Kafka's KEYS file containing PGP keys we use to sign the release:
> http://kafka.apache.org/KEYS
> 
> * Release artifacts to be voted upon (source and binary):
> http://home.apache.org/~guozhang/kafka-0.10.1.1-rc0/
> 
> * Maven artifacts to be voted upon:
> https://repository.apache.org/content/groups/staging/org/apache/kafka/
> 
> * Javadoc:
> http://home.apache.org/~guozhang/kafka-0.10.1.1-rc0/javadoc/
> 
> * Tag to be voted upon (off 0.10.0 branch) is the 0.10.0.1-rc0 tag:
> https://git-wip-us.apache.org/repos/asf?p=kafka.git;a=tag;h=8b77507083fdd427ce81021228e7e346da0d814c
> 
> 
> 
> Thanks,
> Guozhang
> 
> 
> 
> 

Re: [DISCUSS] 0.10.1.1 Plan

[Bernard Leach]

Hi Guozhang,

My suggestion was to not add kafka_2.12-0.10.1.0.tgz to downloads.html but to 
still run the build to generate the maven artefacts for 2.12 and still publish 
those to maven central.  That would allow projects with binary dependencies on 
kafka to obtain the required jars but hide away the tgz so as not to imply that 
it is suitable for production use.  Alternatively just do the regular release 
process and mark it as beta on the downloads page.  Either way you’ll get more 
exposure and testing of the 2.12 version which you won’t get via SNAPSHOTs from 
the trunk.,

cheers,
bern

> On 30 Nov 2016, at 16:52, Guozhang Wang <wangg...@gmail.com> wrote:
> 
> @Ignacio Solis
> 
> The commit you mentioned was not intended for 0.10.1 but only for trunk
> (and there is a related KIP for this API change), but mistakenly gets
> leaked in and was already reverted.
> 
> @Bernard Leach
> 
> Could you elaborate on "instead simply publish the artifacts to maven
> central"? Currently the Kafka release is already through maven and we do
> not yet have kafka_2.12-0.10.1.0.tgz for binary.
> 
> https://kafka.apache.org/downloads.html
> 
> On Tue, Nov 29, 2016 at 5:40 PM, Gwen Shapira <g...@confluent.io> wrote:
> 
>> Sorry for my misunderstanding, I assumed the request to include the
>> keyword removal came from you.
>> 
>> And it is always good to know what versions LinkedIn are running, you
>> guys always serve as somewhat of a gold standard to the community :)
>> 
>> On Tue, Nov 29, 2016 at 5:32 PM, Ignacio Solis <iso...@igso.net> wrote:
>>> I don't think anybody from LinkedIn asked for features on this release.
>> We
>>> just jumped in at the discussion of including a patch which was not a bug
>>> fix and whether it mattered.
>>> 
>>> Having said that, the internal release we're working on came off the
>> 0.10.1
>>> branch with a few internal hotfix patches and a few cherry picked
>> fixes...
>>> Including the final keyword removal patch.
>>> 
>>> Nacho
>>> 
>>> 
>>> On Tue, Nov 29, 2016, 5:15 PM Gwen Shapira <g...@confluent.io> wrote:
>>>> 
>>>> btw. is LinkedIn no longer running from trunk? I'm not used to
>>>> LinkedIn employees requesting specific patches to be included in a
>>>> bugfix release.
>>>> 
>>>> Any discussion on the content of any release is obviously welcome, I'm
>>>> just wondering if there was a change in policy.
>>>> 
>>>> On Tue, Nov 29, 2016 at 2:17 PM, Ismael Juma <ism...@juma.me.uk> wrote:
>>>>> OK, so it seems like there are no changes that break compatibility in
>>>>> the
>>>>> 0.10.1 branch since we offer no compatibility guarantees for logging
>>>>> output. That's good. :)
>>>>> 
>>>>> About the removal of final, it happened in trunk and it doesn't seem
>>>>> like
>>>>> anyone is still asking for it to be included in the 0.10.1 branch so
>> it
>>>>> is
>>>>> indeed not important for this bug fix release (I thought we had
>>>>> established
>>>>> that quite a while ago).
>>>>> 
>>>>> Ismael
>>>>> 
>>>>> On Tue, Nov 29, 2016 at 9:35 PM, Ignacio Solis <iso...@igso.net>
>> wrote:
>>>>> 
>>>>>> Sorry, that was a hasty reply.  There are also various logging things
>>>>>> that
>>>>>> change format. This could break parsers.
>>>>>> 
>>>>>> None of them are important, my only argument is that the final
>> keyword
>>>>>> removal is not important either.
>>>>>> 
>>>>>> Nacho
>>>>>> 
>>>>>> 
>>>>>> On Tue, Nov 29, 2016 at 1:25 PM, Ignacio Solis <iso...@igso.net>
>> wrote:
>>>>>> 
>>>>>>> https://git-wip-us.apache.org/repos/asf?p=kafka.git;a=commit;h=
>>>>>>> 10cfc1628df024f7596d3af5c168fa90f59035ca
>>>>>>> 
>>>>>>> On Tue, Nov 29, 2016 at 1:24 PM, Ismael Juma <ism...@juma.me.uk>
>>>>>>> wrote:
>>>>>>> 
>>>>>>>> Which changes break compatibility in the 0.10.1 branch? It would
>> be
>>>>>>>> good
>>>>>>>> to
>>>>>>>> fix before the release goes out.
>>>>>>>> 
>>>>>&

Re: [DISCUSS] 0.10.1.1 Plan

[Bernard Leach]

Getting out 0.10.1.1 quickly makes a lot of sense so perhaps the answer to the 
quality concern is to not publish the 2.12 tgz and instead simply publish the 
artifacts to maven central allowing the scala community to become a part of 
that quality process.  That way when the 0.10.2.0 release swings around there 
will already be a level of maturity with 2.12.

On 29 Nov 2016, at 06:17, Guozhang Wang <wangg...@gmail.com> wrote:
> 
> @Radai
> 
> I think Ismael's point is that people who coded their applications against
> 0.10.1.1 should be able to swipe in the 0.10.1.0 jar without breaking the
> code (in practice maybe it is more likely the reverse scenario, that people
> coded against 0.10.1.0 and trying to swipe in a newer 0.10.1.1).
> 
> @Bernard Leach
> 
> I agree that having Scala 2.12 support as early as possible than next Feb
> can help the Scala community who's using Kafka. However, the downside is
> that it may increase our release cycles for this bug-fix release as we need
> to add more validation process to make sure that builds with Scala12 works
> perfectly, while we are trying to make 0.10.1.1 out asap.
> 
> 
> Guozhang
> 
> 
> On Sun, Nov 27, 2016 at 5:16 PM, Bernard Leach <leac...@bouncycastle.org>
> wrote:
> 
>> I guess bugs are in the eye of the beholder; I’d really like to see
>> KAFKA-4438 addressed as a patch release - the bug being "I can’t currently
>> build any scala 2.12 projects with Kafka as a dependency".  There’s a PR
>> ready to go for the branch that has already been accepted to trunk and this
>> Ismael has addressed the risk issue by making the 2.12 not part of the
>> default build.
>> 
>> There are a number of downstream projects awaiting kafka scala 2.12
>> binaries so they can publish their own so getting this addressed before
>> February would really help push along the availability of 2.12 compatible
>> libraries.
>> 
>> cheers,
>> bern.
>> 
>>> On 27 Nov 2016, at 10:08, radai <radai.rosenbl...@gmail.com> wrote:
>>> 
>>> "compatibility guarantees that are expected by people who subclass these
>>> classes"
>>> 
>>> sorry if this is not the best thread for this discussion, but I just
>> wanted
>>> to pop in and say that since any subclassing of these will obviously not
>> be
>>> done within the kafka codebase - what guarantees are needed?
>>> 
>>> On Fri, Nov 25, 2016 at 11:13 PM, Michael Pearce <michael.pea...@ig.com>
>>> wrote:
>>> 
>>>> As agreed that this should be purely a bug fix release for stability.
>>>> 
>>>> 
>>>> I'd like to flag then we shouldn't be adding / merging in any Jira's
>> that
>>>> are not bugs.
>>>> 
>>>> e.g. KAFKA-4438
>>>> 
>>>> 
>>>> 
>>>> From: isma...@gmail.com <isma...@gmail.com> on behalf of Ismael Juma <
>>>> ism...@juma.me.uk>
>>>> Sent: Friday, November 25, 2016 11:43 AM
>>>> To: dev@kafka.apache.org
>>>> Subject: Re: [DISCUSS] 0.10.1.1 Plan
>>>> 
>>>> Good, seems like we are in agreement about sticking to bug fixes for
>>>> 0.10.1.1.
>>>> 
>>>> Regarding the removal of final, I understand that it doesn't break
>>>> backwards binary compatibility (it does break forwards compatibility and
>>>> hence why it's more suited for feature releases; these are the same
>> rules
>>>> followed by the JDK and Scala).
>>>> 
>>>> It's probably best to discuss this in another thread, but to clarify:
>> the
>>>> point I was making is that once you make a class non final, maintaining
>>>> compatibility becomes more complex. You have to take into account that
>>>> methods could have been overridden, for example. As such, some thought
>>>> should be given to the scenarios under which classes can be extended,
>> how
>>>> we will ensure that we can evolve the class without breaking users,
>> whether
>>>> we want to make some methods final, whether we should add some
>>>> documentation guiding users regarding good/bad examples of inheritance
>>>> versus composition for these classes and so on. This is particularly
>>>> important for core client classes exposed by the consumer and producer
>> and
>>>> it is the approach taken by projects that have a good track record with
>>>> regards to maintaining compatibility for long periods of

Re: [DISCUSS] 0.10.1.1 Plan

[Bernard Leach]

;>>> 
>>>> I think we should avoid making changes like that in patch releases as
>> it
>>>> means that code that compiles with 0.10.1.1 may not compile with
>>> 0.10.1.0.
>>>> Since we now have frequent time based releases, I think it makes sense
>>> for
>>>> patch releases to only include bug fixes and test stability fixes.
>>>> 
>>>> About the specific changes that you mention, I didn't see a discussion
>>>> about compatibility guarantees that are expected by people who subclass
>>>> these classes so I think it was a bit premature to merge the
>>> ProducerRecord
>>>> and ConsumerRecord final removal change.
>>>> 
>>>> Ismael
>>>> 
>>>> On 24 Nov 2016 10:26 am, "Rajini Sivaram" <
>> rajinisiva...@googlemail.com>
>>>> wrote:
>>>> 
>>>>> Can we add KAFKA-4440 and KAFKA-4250 to the the list? They make
>>>>> ProducerRecord/ConsumerRecord/RecordMetadata non-final so that they
>>> can
>>>> be
>>>>> extended. The changes have minimal impact on the codebase, but will
>>>> really
>>>>> help when implementing other producers/consumers. It is not a
>> bug-fix,
>>>> but
>>>>> if we are going to make the change, it will be good to have it in a
>>>> release
>>>>> soon.
>>>>> 
>>>>> Thank you,
>>>>> 
>>>>> Rajini
>>>>> 
>>>>> 
>>>>> On Thu, Nov 24, 2016 at 4:36 AM, Bernard Leach <
>>> leac...@bouncycastle.org
>>>>> 
>>>>> wrote:
>>>>> 
>>>>>> Hi Guozhang,
>>>>>> 
>>>>>> I have added KAFKA-4438 to that list as that would enable
>> publishing
>>>> the
>>>>>> scala 2.12 builds of 0.10.1.1.  There are other tasks in order to
>>>>> actually
>>>>>> publish a 2.12 but merging that change would enable that process.
>>>>> There’s
>>>>>> a corresponding PR on github that consists of a cherry-pick of the
>>>>>> corresponding change from trunk.
>>>>>> 
>>>>>> cheers,
>>>>>> bern
>>>>>> 
>>>>>>> On 24 Nov 2016, at 06:58, Guozhang Wang <wangg...@gmail.com>
>>> wrote:
>>>>>>> 
>>>>>>> Hi everyone,
>>>>>>> 
>>>>>>> We have resolved 15 JIRAs including a few critical bugs in the
>>> 0.10.1
>>>>>>> branch since 0.10.1.0 was released so I'd like to propose to
>>> release
>>>>>>> 0.10.1.1 soon:
>>>>>>> 
>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%
>>>>>> 3D%20KAFKA%20AND%20resolution%20%3D%20Fixed%20AND%
>>>>>> 20fixVersion%20%3D%200.10.1.1%20ORDER%20BY%20priority%
>>>>>> 20DESC%2C%20key%20DESC
>>>>>>> 
>>>>>>> There are still a few outstanding issues that are not unresolved
>>> and
>>>>> have
>>>>>>> 0.10.1.1 as the target version:
>>>>>>> 
>>>>>>> https://issues.apache.org/jira/issues/?jql=project%20%
>>>>>> 3D%20KAFKA%20AND%20resolution%20%3D%20Unresolved%20AND%
>>>>>> 20fixVersion%20%3D%200.10.1.1%20ORDER%20BY%20priority%
>>>>>> 20DESC%2C%20key%20DESC
>>>>>>> 
>>>>>>> Once we have resolved these issues I will start the release
>>> process.
>>>>>>> 
>>>>>>> --
>>>>>>> -- Guozhang
>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>>> --
>>>>> Regards,
>>>>> 
>>>>> Rajini
>>>>> 
>>>> 
>>> 
>>> 
>>> 
>>> --
>>> Regards,
>>> 
>>> Rajini
>>> The information contained in this email is strictly confidential and for
>>> the use of the addressee only, unless otherwise indicated. If you are not
>>> the intended recipient, please do not read, copy, use or disclose to
>> others
>>> this message or any attachment. Please also notify the sender by replying
>>> to this email or by telephone (+44(020 7896 0011) and then delete the
>>> email and any copies of it. Opinions, conclusion (etc) that do not relate
>>> to the official business of this company shall be understood as neither
>>> given nor endorsed by it. IG is a trading name of IG Markets Limited (a
>>> company registered in England and Wales, company number 04008957) and IG
>>> Index Limited (a company registered in England and Wales, company number
>>> 01190902). Registered address at Cannon Bridge House, 25 Dowgate Hill,
>>> London EC4R 2YA. Both IG Markets Limited (register number 195355) and IG
>>> Index Limited (register number 114059) are authorised and regulated by
>> the
>>> Financial Conduct Authority.
>>> 
>> The information contained in this email is strictly confidential and for
>> the use of the addressee only, unless otherwise indicated. If you are not
>> the intended recipient, please do not read, copy, use or disclose to others
>> this message or any attachment. Please also notify the sender by replying
>> to this email or by telephone (+44(020 7896 0011) and then delete the email
>> and any copies of it. Opinions, conclusion (etc) that do not relate to the
>> official business of this company shall be understood as neither given nor
>> endorsed by it. IG is a trading name of IG Markets Limited (a company
>> registered in England and Wales, company number 04008957) and IG Index
>> Limited (a company registered in England and Wales, company number
>> 01190902). Registered address at Cannon Bridge House, 25 Dowgate Hill,
>> London EC4R 2YA. Both IG Markets Limited (register number 195355) and IG
>> Index Limited (register number 114059) are authorised and regulated by the
>> Financial Conduct Authority.
>> 

[jira] [Updated] (KAFKA-4438) BACKPORT - Add scala 2.12 support

[Bernard Leach (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bernard Leach updated KAFKA-4438:
-
Issue Type: Bug  (was: Improvement)

> BACKPORT - Add scala 2.12 support
> -
>
> Key: KAFKA-4438
> URL: https://issues.apache.org/jira/browse/KAFKA-4438
> Project: Kafka
>  Issue Type: Bug
>  Components: build
>Affects Versions: 0.10.1.0, 0.10.0.1
>    Reporter: Bernard Leach
>    Assignee: Bernard Leach
> Fix For: 0.10.1.1
>
>
> Now that Scala 2.12 has now been officially released releasing 2.12 builds of 
> the kafka artifacts will allow downstream projects such as reactive-kafka via 
> scalatest-embedded-kafka to release 2.12 builds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSS] 0.10.1.1 Plan

[Bernard Leach]

Hi Guozhang,

I have added KAFKA-4438 to that list as that would enable publishing the scala 
2.12 builds of 0.10.1.1.  There are other tasks in order to actually publish a 
2.12 but merging that change would enable that process.  There’s a 
corresponding PR on github that consists of a cherry-pick of the corresponding 
change from trunk.

cheers,
bern

> On 24 Nov 2016, at 06:58, Guozhang Wang  wrote:
> 
> Hi everyone,
> 
> We have resolved 15 JIRAs including a few critical bugs in the 0.10.1
> branch since 0.10.1.0 was released so I'd like to propose to release
> 0.10.1.1 soon:
> 
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20KAFKA%20AND%20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%200.10.1.1%20ORDER%20BY%20priority%20DESC%2C%20key%20DESC
> 
> There are still a few outstanding issues that are not unresolved and have
> 0.10.1.1 as the target version:
> 
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20KAFKA%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%200.10.1.1%20ORDER%20BY%20priority%20DESC%2C%20key%20DESC
> 
> Once we have resolved these issues I will start the release process.
> 
> -- 
> -- Guozhang

[jira] [Updated] (KAFKA-4438) BACKPORT - Add scala 2.12 support

[Bernard Leach (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bernard Leach updated KAFKA-4438:
-
Fix Version/s: (was: 0.10.2.0)
   0.10.1.1

> BACKPORT - Add scala 2.12 support
> -
>
> Key: KAFKA-4438
> URL: https://issues.apache.org/jira/browse/KAFKA-4438
> Project: Kafka
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 0.10.1.0, 0.10.0.1
>    Reporter: Bernard Leach
>    Assignee: Bernard Leach
> Fix For: 0.10.1.1
>
>
> Now that Scala 2.12 has now been officially released releasing 2.12 builds of 
> the kafka artifacts will allow downstream projects such as reactive-kafka via 
> scalatest-embedded-kafka to release 2.12 builds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (KAFKA-4438) BACKPORT - Add scala 2.12 support

[Bernard Leach (JIRA)]

Bernard Leach created KAFKA-4438:


 Summary: BACKPORT - Add scala 2.12 support
 Key: KAFKA-4438
 URL: https://issues.apache.org/jira/browse/KAFKA-4438
 Project: Kafka
  Issue Type: Improvement
  Components: build
Affects Versions: 0.10.1.0, 0.10.0.1
Reporter: Bernard Leach
Assignee: Bernard Leach
 Fix For: 0.10.2.0


Now that Scala 2.12 has now been officially released releasing 2.12 builds of 
the kafka artifacts will allow downstream projects such as reactive-kafka via 
scalatest-embedded-kafka to release 2.12 builds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

scala 2.12 artifacts

[Bernard Leach]

Hi all,

With the recent release of scala 2.12 the community has been working toward 
getting libraries released as 2.12 compiled binaries.  Although Kafka isn’t a 
typical development library the scalatest-embedded-kafka project 
(https://github.com/manub/scalatest-embedded-kafka 
) has a dependency on the 
scala kafka module in order to stand up a Kafka instance for testing.  This 
test library is used by reactive-kafka (https://github.com/akka/reactive-kafka 
) to allow testing of the client 
library against the kafka server.  As a result to publish reactive-kafka built 
with 2.12 we need a release of both kafka and scalatest-embedded-kafka built 
with 2.12.

The necessary changes have now been merged to the kafka repo on trunk (commit 
f3aad3b54b7cbc5109d8398829a31100fd82b3e0) so the build with 
'-PscalaVersion=2.12’ with JDK8 will now build with scala 2.12.

However as I understand it the next release from trunk for Kafka (0.10.2.0) 
will be a time based release around the end of January so it would be great if 
we could get this change back ported to the 0.10.1 branch and released as a 
patch version so as to get the downstream projects migrated before then.  
Building the original 0.10.1.0 artifacts with this change would be fine but it 
may be easier to release a 0.10.1.1 version.

cheers,
bern

[jira] [Assigned] (KAFKA-4378) Address 2.12 eta-expansion warnings

[Bernard Leach (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bernard Leach reassigned KAFKA-4378:


Assignee: Bernard Leach

> Address 2.12 eta-expansion warnings
> ---
>
> Key: KAFKA-4378
> URL: https://issues.apache.org/jira/browse/KAFKA-4378
> Project: Kafka
>  Issue Type: Sub-task
>  Components: core
>    Reporter: Bernard Leach
>    Assignee: Bernard Leach
>
> The 2.12 compiler generates warnings about zero-argument eta-expansion.  
> Update the code to make the expansion explicit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2284) ConsumerRebalanceListener receives wrong type in partitionOwnership values

[Bernard Leach (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634855#comment-15634855
 ] 

Bernard Leach commented on KAFKA-2284:
--

Just came across this as a failing test in 
https://github.com/apache/kafka/pull/2101 where I had fixed the underlying bug. 
 I've separated the fix out to a separate PR 
https://github.com/apache/kafka/pull/2102.

> ConsumerRebalanceListener receives wrong type in partitionOwnership values
> --
>
> Key: KAFKA-2284
> URL: https://issues.apache.org/jira/browse/KAFKA-2284
> Project: Kafka
>  Issue Type: Bug
>  Components: consumer
>Affects Versions: 0.8.2.0
>Reporter: E. Sammer
>Assignee: Neha Narkhede
>
> The ConsumerRebalanceListener's beforeReleasingPartitions() method is 
> supposed to receive an arg of Map<String, Set> (topic -> 
> Set(partitions)). Even though the type of the map value is specified as a 
> java.util.Set, a scala.collection.convert.Wrappers$JSetWrapper is passed 
> instead which does not implement Set causing a class cast exception as 
> soon as one attempts to access any value of the map. It looks as if this 
> method was never tested against the actual types specified by the interface.
> Here's what happens if you call {{Set foo = 
> partitionOwnership.get(topic)}}:
> {code}
> 2015-06-18 07:28:43,776 
> (search-consumer_esammer-mbp.local-1434637723383-12126c1b_watcher_executor) 
> [WARN - 
> com.rocana.search.consumer.ConsumerService$1.beforeReleasingPartitions(ConsumerService.java:246)]
>  Exception while rebalancing!
> java.lang.ClassCastException: scala.collection.convert.Wrappers$JSetWrapper 
> cannot be cast to java.util.Set
>   at 
> com.rocana.search.consumer.IndexConsumerWorker.onRebalance(IndexConsumerWorker.java:80)
>   at 
> com.rocana.search.consumer.ConsumerService$1.beforeReleasingPartitions(ConsumerService.java:244)
>   at 
> kafka.consumer.ZookeeperConsumerConnector$ZKRebalancerListener.kafka$consumer$ZookeeperConsumerConnector$ZKRebalancerListener$$rebalance(ZookeeperConsumerConnector.scala:675)
>   at 
> kafka.consumer.ZookeeperConsumerConnector$ZKRebalancerListener$$anonfun$syncedRebalance$1$$anonfun$apply$mcV$sp$1.apply$mcVI$sp(ZookeeperConsumerConnector.scala:625)
>   at scala.collection.immutable.Range.foreach$mVc$sp(Range.scala:142)
>   at 
> kafka.consumer.ZookeeperConsumerConnector$ZKRebalancerListener$$anonfun$syncedRebalance$1.apply$mcV$sp(ZookeeperConsumerConnector.scala:619)
>   at 
> kafka.consumer.ZookeeperConsumerConnector$ZKRebalancerListener$$anonfun$syncedRebalance$1.apply(ZookeeperConsumerConnector.scala:616)
>   at 
> kafka.consumer.ZookeeperConsumerConnector$ZKRebalancerListener$$anonfun$syncedRebalance$1.apply(ZookeeperConsumerConnector.scala:616)
>   at kafka.metrics.KafkaTimer.time(KafkaTimer.scala:33)
>   at 
> kafka.consumer.ZookeeperConsumerConnector$ZKRebalancerListener.syncedRebalance(ZookeeperConsumerConnector.scala:615)
>   at 
> kafka.consumer.ZookeeperConsumerConnector$ZKRebalancerListener$$anon$1.run(ZookeeperConsumerConnector.scala:568)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-4376) Add scala 2.12 support

[Bernard Leach (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634454#comment-15634454
 ] 

Bernard Leach commented on KAFKA-4376:
--

2.12 will need to be built using java8, currently the jenkins builds are java7 
only.

> Add scala 2.12 support
> --
>
> Key: KAFKA-4376
> URL: https://issues.apache.org/jira/browse/KAFKA-4376
> Project: Kafka
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 0.10.1.0, 0.10.0.1
>    Reporter: Bernard Leach
>
> Now that Scala 2.12 has now been officially released releasing 2.12 builds of 
> the kafka artifacts will allow downstream projects such as reactive-kafka via 
> scalatest-embedded-kafka to release 2.12 builds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (KAFKA-4378) Address 2.12 eta-expansion warnings

[Bernard Leach (JIRA)]

Bernard Leach created KAFKA-4378:


 Summary: Address 2.12 eta-expansion warnings
 Key: KAFKA-4378
 URL: https://issues.apache.org/jira/browse/KAFKA-4378
 Project: Kafka
  Issue Type: Sub-task
  Components: core
Reporter: Bernard Leach


The 2.12 compiler generates warnings about zero-argument eta-expansion.  Update 
the code to make the expansion explicit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (KAFKA-4377) Address 2.12 deprecations

[Bernard Leach (JIRA)]

Bernard Leach created KAFKA-4377:


 Summary: Address 2.12 deprecations
 Key: KAFKA-4377
 URL: https://issues.apache.org/jira/browse/KAFKA-4377
 Project: Kafka
  Issue Type: Sub-task
  Components: core
Reporter: Bernard Leach


The 2.12 compiler is generating a large number of deprecation warnings, those 
that can be resolved in a 2.10 compatible way should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (KAFKA-4376) Add scala 2.12 support

[Bernard Leach (JIRA)]

Bernard Leach created KAFKA-4376:


 Summary: Add scala 2.12 support
 Key: KAFKA-4376
 URL: https://issues.apache.org/jira/browse/KAFKA-4376
 Project: Kafka
  Issue Type: Improvement
  Components: build
Affects Versions: 0.10.0.1, 0.10.1.0
Reporter: Bernard Leach


Now that Scala 2.12 has now been officially released releasing 2.12 builds of 
the kafka artifacts will allow downstream projects such as reactive-kafka via 
scalatest-embedded-kafka to release 2.12 builds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)