[jira] [Commented] (KAFKA-4617) gradle-generated core eclipse project has incorrect source folder structure
[
https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827453#comment-15827453
]
Dhwani Katagade commented on KAFKA-4617:
[~ecomar] Thanks for the review and LGTM :-)
> gradle-generated core eclipse project has incorrect source folder structure
> ---
>
> Key: KAFKA-4617
> URL: https://issues.apache.org/jira/browse/KAFKA-4617
> Project: Kafka
> Issue Type: Bug
> Components: build
>Reporter: Edoardo Comar
>Assignee: Dhwani Katagade
>Priority: Minor
> Labels: build
>
> The gradle-generated Eclipse Scala project for Kafka core has a
> classpath defined as :
> {code:xml}
>
>
>
> {code}
> because of how the source files are for tests are structured, code navigation
> / running unit tests fails. The correct structure should be instead :
> {code:xml}
>
>path="src/test/scala"/>
>
>
>
>
> {code}
> Moreover, the classpath included as libraries core/build/test and
> core/build/resources
> which should not be there as the eclipse classes are not generated under build
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-4617) gradle-generated core eclipse project has incorrect source folder structure
[
https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826017#comment-15826017
]
Dhwani Katagade commented on KAFKA-4617:
[~ecomar] thanks for your comments.
I tried to remove the following explicit dependency from build.gradle but it is
required by the scala plugin for building test classes. Without it the
:core:compileTestScala task fails.
testCompile project(':clients').sourceSets.test.output
I had to fix the generated .classpath file in the whenMerged closure itself. I
have pushed an additional commit with changes to handle this.
Please review.
> gradle-generated core eclipse project has incorrect source folder structure
> ---
>
> Key: KAFKA-4617
> URL: https://issues.apache.org/jira/browse/KAFKA-4617
> Project: Kafka
> Issue Type: Bug
> Components: build
>Reporter: Edoardo Comar
>Assignee: Dhwani Katagade
>Priority: Minor
> Labels: build
>
> The gradle-generated Eclipse Scala project for Kafka core has a
> classpath defined as :
> {code:xml}
>
>
>
> {code}
> because of how the source files are for tests are structured, code navigation
> / running unit tests fails. The correct structure should be instead :
> {code:xml}
>
>path="src/test/scala"/>
>
>
>
>
> {code}
> Moreover, the classpath included as libraries core/build/test and
> core/build/resources
> which should not be there as the eclipse classes are not generated under build
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work stopped] (KAFKA-4604) Gradle Eclipse plugin creates projects for non project subfolders
[ https://issues.apache.org/jira/browse/KAFKA-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-4604 stopped by Dhwani Katagade. -- > Gradle Eclipse plugin creates projects for non project subfolders > - > > Key: KAFKA-4604 > URL: https://issues.apache.org/jira/browse/KAFKA-4604 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.11.0.0 > Environment: Tried with Gradle 3.2.1 and Eclipse Neon >Reporter: Dhwani Katagade >Assignee: Dhwani Katagade >Priority: Minor > Labels: build, easyfix, patch > > Running the command *./gradlew eclipse* generates .project and .classpath > files for all projects. But it also generates these files for the root > project folder and the connect subfolder that holds the 4 connector projects > even though these folders are not actual project folders. > The unnecessary connect project is benign, but the unnecessary kafka project > created for the root folder has a side effect. The root folder has a bin > directory that holds some scripts. When a _Clean all projects_ is done in > Eclipse, it cleans up the scripts in the bin directory. These have to be > restored by running *git checkout \-\- *. This same could become a > problem for the connect project as well if tomorrow we place some files under > connect/bin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-4617) gradle-generated core eclipse project has incorrect source folder structure
[
https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dhwani Katagade updated KAFKA-4617:
---
Labels: build (was: )
Reviewer: Edoardo Comar
Status: Patch Available (was: In Progress)
Please review the linked PR.
The core project .classpath file gets generated properly. The 6 folders are
listed properly under Project Properties-> Java Build Path -> Source.
But on my eclipse 4.6.1 it does not render all 6 source folders in Package
Explorer view. I have to remove the core project and re-import it, and then it
renders the src folders properly under Package Explorer view as well.
> gradle-generated core eclipse project has incorrect source folder structure
> ---
>
> Key: KAFKA-4617
> URL: https://issues.apache.org/jira/browse/KAFKA-4617
> Project: Kafka
> Issue Type: Bug
> Components: build
>Reporter: Edoardo Comar
>Assignee: Dhwani Katagade
>Priority: Minor
> Labels: build
>
> The gradle-generated Eclipse Scala project for Kafka core has a
> classpath defined as :
> {code:xml}
>
>
>
> {code}
> because of how the source files are for tests are structured, code navigation
> / running unit tests fails. The correct structure should be instead :
> {code:xml}
>
>path="src/test/scala"/>
>
>
>
>
> {code}
> Moreover, the classpath included as libraries core/build/test and
> core/build/resources
> which should not be there as the eclipse classes are not generated under build
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work started] (KAFKA-4617) gradle-generated core eclipse project has incorrect source folder structure
[
https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-4617 started by Dhwani Katagade.
--
> gradle-generated core eclipse project has incorrect source folder structure
> ---
>
> Key: KAFKA-4617
> URL: https://issues.apache.org/jira/browse/KAFKA-4617
> Project: Kafka
> Issue Type: Bug
> Components: build
>Reporter: Edoardo Comar
>Assignee: Dhwani Katagade
>Priority: Minor
>
> The gradle-generated Eclipse Scala project for Kafka core has a
> classpath defined as :
> {code:xml}
>
>
>
> {code}
> because of how the source files are for tests are structured, code navigation
> / running unit tests fails. The correct structure should be instead :
> {code:xml}
>
>path="src/test/scala"/>
>
>
>
>
> {code}
> Moreover, the classpath included as libraries core/build/test and
> core/build/resources
> which should not be there as the eclipse classes are not generated under build
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (KAFKA-4617) gradle-generated core eclipse project has incorrect source folder structure
[
https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dhwani Katagade reassigned KAFKA-4617:
--
Assignee: Dhwani Katagade
> gradle-generated core eclipse project has incorrect source folder structure
> ---
>
> Key: KAFKA-4617
> URL: https://issues.apache.org/jira/browse/KAFKA-4617
> Project: Kafka
> Issue Type: Bug
> Components: build
>Reporter: Edoardo Comar
>Assignee: Dhwani Katagade
>Priority: Minor
>
> The gradle-generated Eclipse Scala project for Kafka core has a
> classpath defined as :
> {code:xml}
>
>
>
> {code}
> because of how the source files are for tests are structured, code navigation
> / running unit tests fails. The correct structure should be instead :
> {code:xml}
>
>path="src/test/scala"/>
>
>
>
>
> {code}
> Moreover, the classpath included as libraries core/build/test and
> core/build/resources
> which should not be there as the eclipse classes are not generated under build
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work started] (KAFKA-4604) Gradle Eclipse plugin creates projects for non project subfolders
[ https://issues.apache.org/jira/browse/KAFKA-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-4604 started by Dhwani Katagade. -- > Gradle Eclipse plugin creates projects for non project subfolders > - > > Key: KAFKA-4604 > URL: https://issues.apache.org/jira/browse/KAFKA-4604 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.11.0.0 > Environment: Tried with Gradle 3.2.1 and Eclipse Neon >Reporter: Dhwani Katagade >Assignee: Dhwani Katagade >Priority: Minor > Labels: build, easyfix, patch > > Running the command *./gradlew eclipse* generates .project and .classpath > files for all projects. But it also generates these files for the root > project folder and the connect subfolder that holds the 4 connector projects > even though these folders are not actual project folders. > The unnecessary connect project is benign, but the unnecessary kafka project > created for the root folder has a side effect. The root folder has a bin > directory that holds some scripts. When a _Clean all projects_ is done in > Eclipse, it cleans up the scripts in the bin directory. These have to be > restored by running *git checkout \-\- *. This same could become a > problem for the connect project as well if tomorrow we place some files under > connect/bin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-4617) gradle-generated core eclipse project has incorrect source folder structure
[
https://issues.apache.org/jira/browse/KAFKA-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818024#comment-15818024
]
Dhwani Katagade commented on KAFKA-4617:
The gradle eclipse plugin seem to have other problems as well, like the output
folders for src and test class files and resources. More details discussed here
http://mail-archives.apache.org/mod_mbox/kafka-dev/201701.mbox/%3Cd98febbd-ceb8-a995-56bb-2294d60beb5b%40persistent.co.in%3E
> gradle-generated core eclipse project has incorrect source folder structure
> ---
>
> Key: KAFKA-4617
> URL: https://issues.apache.org/jira/browse/KAFKA-4617
> Project: Kafka
> Issue Type: Bug
> Components: build
>Reporter: Edoardo Comar
>Priority: Minor
>
> The gradle-generated Eclipse Scala project for Kafka core has a
> classpath defined as :
> {code:xml}
>
>
>
> {code}
> because of how the source files are for tests are structured, code navigation
> / running unit tests fails. The correct structure should be instead :
> {code:xml}
>
>path="src/test/scala"/>
>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-4604) Gradle Eclipse plugin creates projects for non project subfolders
[ https://issues.apache.org/jira/browse/KAFKA-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816852#comment-15816852 ] Dhwani Katagade commented on KAFKA-4604: Hi I have tried it with Eclipse since I use Eclipse for an IDE. On a dev list thread Ismael had confirmed that the Intellij setup works just fine. I can believe that since the Intellij model is slightly different. http://mail-archives.apache.org/mod_mbox/kafka-dev/201701.mbox/%3CCAD5tkZa12yGShXbbDXGUgMK7Upo-qQQx4tMn88xjYP%2B5nMfMnA%40mail.gmail.com%3E > Gradle Eclipse plugin creates projects for non project subfolders > - > > Key: KAFKA-4604 > URL: https://issues.apache.org/jira/browse/KAFKA-4604 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.11.0.0 > Environment: Tried with Gradle 3.2.1 and Eclipse Neon >Reporter: Dhwani Katagade >Assignee: Dhwani Katagade >Priority: Minor > Labels: build, easyfix, patch > > Running the command *./gradlew eclipse* generates .project and .classpath > files for all projects. But it also generates these files for the root > project folder and the connect subfolder that holds the 4 connector projects > even though these folders are not actual project folders. > The unnecessary connect project is benign, but the unnecessary kafka project > created for the root folder has a side effect. The root folder has a bin > directory that holds some scripts. When a _Clean all projects_ is done in > Eclipse, it cleans up the scripts in the bin directory. These have to be > restored by running *git checkout \-\- *. This same could become a > problem for the connect project as well if tomorrow we place some files under > connect/bin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-4604) Gradle Eclipse plugin creates projects for non project subfolders
[ https://issues.apache.org/jira/browse/KAFKA-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15804227#comment-15804227 ] Dhwani Katagade commented on KAFKA-4604: I would like to assign this to myself. I am not able to find a way. > Gradle Eclipse plugin creates projects for non project subfolders > - > > Key: KAFKA-4604 > URL: https://issues.apache.org/jira/browse/KAFKA-4604 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.11.0.0 > Environment: Tried with Gradle 3.2.1 and Eclipse Neon >Reporter: Dhwani Katagade >Priority: Minor > Labels: build, easyfix, patch > > Running the command *./gradlew eclipse* generates .project and .classpath > files for all projects. But it also generates these files for the root > project folder and the connect subfolder that holds the 4 connector projects > even though these folders are not actual project folders. > The unnecessary connect project is benign, but the unnecessary kafka project > created for the root folder has a side effect. The root folder has a bin > directory that holds some scripts. When a _Clean all projects_ is done in > Eclipse, it cleans up the scripts in the bin directory. These have to be > restored by running *git checkout \-\- *. This same could become a > problem for the connect project as well if tomorrow we place some files under > connect/bin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-4604) Gradle Eclipse plugin creates projects for non project subfolders
[ https://issues.apache.org/jira/browse/KAFKA-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhwani Katagade updated KAFKA-4604: --- Summary: Gradle Eclipse plugin creates projects for non project subfolders (was: Gradle Eclipse plugin creates blank projects for subfolders) > Gradle Eclipse plugin creates projects for non project subfolders > - > > Key: KAFKA-4604 > URL: https://issues.apache.org/jira/browse/KAFKA-4604 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.11.0.0 > Environment: Tried with Gradle 3.2.1 and Eclipse Neon >Reporter: Dhwani Katagade >Priority: Minor > Labels: build, easyfix, patch > > Running the command *./gradlew eclipse* generates .project and .classpath > files for all projects. But it also generates these files for the root > project folder and the connect subfolder that holds the 4 connector projects > even though these folders are not actual project folders. > The unnecessary connect project is benign, but the unnecessary kafka project > created for the root folder has a side effect. The root folder has a bin > directory that holds some scripts. When a _Clean all projects_ is done in > Eclipse, it cleans up the scripts in the bin directory. These have to be > restored by running *git checkout \-\- *. This same could become a > problem for the connect project as well if tomorrow we place some files under > connect/bin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-4604) Gradle Eclipse plugin creates blank projects for subfolders
[ https://issues.apache.org/jira/browse/KAFKA-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhwani Katagade updated KAFKA-4604: --- Summary: Gradle Eclipse plugin creates blank projects for subfolders (was: Gradle Eclipse plugins creates blank projects for subfolders) > Gradle Eclipse plugin creates blank projects for subfolders > --- > > Key: KAFKA-4604 > URL: https://issues.apache.org/jira/browse/KAFKA-4604 > Project: Kafka > Issue Type: Bug > Components: build >Affects Versions: 0.11.0.0 > Environment: Tried with Gradle 3.2.1 and Eclipse Neon >Reporter: Dhwani Katagade >Priority: Minor > Labels: build, easyfix, patch > > Running the command *./gradlew eclipse* generates .project and .classpath > files for all projects. But it also generates these files for the root > project folder and the connect subfolder that holds the 4 connector projects > even though these folders are not actual project folders. > The unnecessary connect project is benign, but the unnecessary kafka project > created for the root folder has a side effect. The root folder has a bin > directory that holds some scripts. When a _Clean all projects_ is done in > Eclipse, it cleans up the scripts in the bin directory. These have to be > restored by running *git checkout \-\- *. This same could become a > problem for the connect project as well if tomorrow we place some files under > connect/bin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KAFKA-4604) Gradle Eclipse plugins creates blank projects for subfolders
Dhwani Katagade created KAFKA-4604: -- Summary: Gradle Eclipse plugins creates blank projects for subfolders Key: KAFKA-4604 URL: https://issues.apache.org/jira/browse/KAFKA-4604 Project: Kafka Issue Type: Bug Components: build Affects Versions: 0.11.0.0 Environment: Tried with Gradle 3.2.1 and Eclipse Neon Reporter: Dhwani Katagade Priority: Minor Running the command *./gradlew eclipse* generates .project and .classpath files for all projects. But it also generates these files for the root project folder and the connect subfolder that holds the 4 connector projects even though these folders are not actual project folders. The unnecessary connect project is benign, but the unnecessary kafka project created for the root folder has a side effect. The root folder has a bin directory that holds some scripts. When a _Clean all projects_ is done in Eclipse, it cleans up the scripts in the bin directory. These have to be restored by running *git checkout \-\- *. This same could become a problem for the connect project as well if tomorrow we place some files under connect/bin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
