[jira] [Resolved] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Vereshchagin resolved KAFKA-1528. Resolution: Not a Problem No. You can close this ticket. Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch, KAFKA-1528_2014-07-06_16:20:28.patch, KAFKA-1528_2014-07-06_16:23:21.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14395979#comment-14395979 ] Evgeny Vereshchagin edited comment on KAFKA-1528 at 4/4/15 10:41 PM: - No. was (Author: evvers): No. You can close this ticket. Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch, KAFKA-1528_2014-07-06_16:20:28.patch, KAFKA-1528_2014-07-06_16:23:21.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056521#comment-14056521 ] Evgeny Vereshchagin commented on KAFKA-1528: [~junrao], what command do you run to apply patch? git apply --stat xyz-v1.patch ? I want to reproduce it. Looks like I send invalid patch. Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch, KAFKA-1528_2014-07-06_16:20:28.patch, KAFKA-1528_2014-07-06_16:23:21.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14056720#comment-14056720 ] Evgeny Vereshchagin commented on KAFKA-1528: kafka-patch-review.py squashes two commits to one giant diff. It's wrong for these changes. Maybe, format-patch and apply-patch would be better? Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch, KAFKA-1528_2014-07-06_16:20:28.patch, KAFKA-1528_2014-07-06_16:23:21.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)
Review Request 23291: Patch for KAFKA-1528
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/ --- Review request for kafka. Bugs: KAFKA-1528 https://issues.apache.org/jira/browse/KAFKA-1528 Repository: kafka Description --- See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ See https://help.github.com/articles/dealing-with-line-endings Normalize line endings. Contents the same. Diffs - .gitattributes PRE-CREATION bin/windows/kafka-run-class.bat f4d2904a3320ae756ed4171f6e99566f1f0cf963 bin/windows/kafka-server-stop.bat b9496ce0fe7438b9df1bbdb10bd86ddefab27ff4 bin/windows/zookeeper-server-stop.bat 29bdee81ac3ac4a96b081ac369d8f6d85c237747 Diff: https://reviews.apache.org/r/23291/diff/ Testing --- Thanks, Evgeny Vereshchagin
[jira] [Updated] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Vereshchagin updated KAFKA-1528: --- Attachment: KAFKA-1528.patch Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (KAFKA-1528) Normalize all the line endings
Evgeny Vereshchagin created KAFKA-1528: -- Summary: Normalize all the line endings Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053142#comment-14053142 ] Evgeny Vereshchagin commented on KAFKA-1528: Created reviewboard https://reviews.apache.org/r/23291/diff/ against branch trunk Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053146#comment-14053146 ] Evgeny Vereshchagin commented on KAFKA-1528: Updated reviewboard against branch trunk Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch, KAFKA-1528_2014-07-06_16:20:28.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Vereshchagin updated KAFKA-1528: --- Attachment: KAFKA-1528_2014-07-06_16:20:28.patch Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch, KAFKA-1528_2014-07-06_16:20:28.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Review Request 23291: Patch for KAFKA-1528
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/ --- (Updated July 6, 2014, 4:23 p.m.) Review request for kafka. Bugs: KAFKA-1528 https://issues.apache.org/jira/browse/KAFKA-1528 Repository: kafka Description (updated) --- See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ See https://help.github.com/articles/dealing-with-line-endings Normalize line endings. Contents the same. Add text attribute to *.md files Diffs (updated) - .gitattributes PRE-CREATION bin/windows/kafka-run-class.bat f4d2904a3320ae756ed4171f6e99566f1f0cf963 bin/windows/kafka-server-stop.bat b9496ce0fe7438b9df1bbdb10bd86ddefab27ff4 bin/windows/zookeeper-server-stop.bat 29bdee81ac3ac4a96b081ac369d8f6d85c237747 Diff: https://reviews.apache.org/r/23291/diff/ Testing --- Thanks, Evgeny Vereshchagin
[jira] [Updated] (KAFKA-1528) Normalize all the line endings
[ https://issues.apache.org/jira/browse/KAFKA-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Vereshchagin updated KAFKA-1528: --- Attachment: KAFKA-1528_2014-07-06_16:23:21.patch Normalize all the line endings -- Key: KAFKA-1528 URL: https://issues.apache.org/jira/browse/KAFKA-1528 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Trivial Attachments: KAFKA-1528.patch, KAFKA-1528_2014-07-06_16:20:28.patch, KAFKA-1528_2014-07-06_16:23:21.patch Hi! I add .gitattributes file and remove all '\r' from some .bat files See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ and https://help.github.com/articles/dealing-with-line-endings for explanation. Maybe, add https://help.github.com/articles/dealing-with-line-endings to contributing/commiting guide? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053167#comment-14053167
]
Evgeny Vereshchagin commented on KAFKA-1414:
Changelog: [2.9.0|http://www.scala-lang.org/download/changelog.html#2.9.0].
Speedup broker startup after hard reset
---
Key: KAFKA-1414
URL: https://issues.apache.org/jira/browse/KAFKA-1414
Project: Kafka
Issue Type: Improvement
Components: log
Affects Versions: 0.8.2, 0.9.0, 0.8.1.1
Reporter: Dmitry Bugaychenko
Assignee: Jay Kreps
Attachments: parallel-dir-loading-0.8.patch,
parallel-dir-loading-trunk.patch
After hard reset due to power failure broker takes way too much time
recovering unflushed segments in a single thread. This could be easiliy
improved launching multiple threads (one per data dirrectory, assuming that
typically each data directory is on a dedicated drive). Localy we trie this
simple patch to LogManager.loadLogs and it seems to work, however I'm too new
to scala, so do not take it literally:
{code}
/**
* Recover and load all logs in the given data directories
*/
private def loadLogs(dirs: Seq[File]) {
val threads : Array[Thread] = new Array[Thread](dirs.size)
var i: Int = 0
val me = this
for(dir - dirs) {
val thread = new Thread( new Runnable {
def run()
{
val recoveryPoints = me.recoveryPointCheckpoints(dir).read
/* load the logs */
val subDirs = dir.listFiles()
if(subDirs != null) {
val cleanShutDownFile = new File(dir, Log.CleanShutdownFile)
if(cleanShutDownFile.exists())
info(Found clean shutdown file. Skipping recovery for all logs
in data directory '%s'.format(dir.getAbsolutePath))
for(dir - subDirs) {
if(dir.isDirectory) {
info(Loading log ' + dir.getName + ')
val topicPartition = Log.parseTopicPartitionName(dir.getName)
val config = topicConfigs.getOrElse(topicPartition.topic,
defaultConfig)
val log = new Log(dir,
config,
recoveryPoints.getOrElse(topicPartition, 0L),
scheduler,
time)
val previous = addLogWithLock(topicPartition, log)
if(previous != null)
throw new IllegalArgumentException(Duplicate log
directories found: %s, %s!.format(log.dir.getAbsolutePath,
previous.dir.getAbsolutePath))
}
}
cleanShutDownFile.delete()
}
}
})
thread.start()
threads(i) = thread
i = i + 1
}
for(thread - threads) {
thread.join()
}
}
def addLogWithLock(topicPartition: TopicAndPartition, log: Log): Log = {
logCreationOrDeletionLock synchronized {
this.logs.put(topicPartition, log)
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset
[
https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14053203#comment-14053203
]
Evgeny Vereshchagin commented on KAFKA-1414:
{quote}
scala 2.8 is really old and we could drop the 2.8 support.
{quote}
+1 for this
{quote}
It seems that the application doesn't have control on the degree of parallelism
{quote}
Since
[2.10.0|http://www.scala-lang.org/download/changelog.html#parallel_collections_are_now_configurable_with_custom_thread_pools]
Parallel Collections
[configurable|http://docs.scala-lang.org/overviews/parallel-collections/configuration.html]
with custom thread pools.
Speedup broker startup after hard reset
---
Key: KAFKA-1414
URL: https://issues.apache.org/jira/browse/KAFKA-1414
Project: Kafka
Issue Type: Improvement
Components: log
Affects Versions: 0.8.2, 0.9.0, 0.8.1.1
Reporter: Dmitry Bugaychenko
Assignee: Jay Kreps
Attachments: parallel-dir-loading-0.8.patch,
parallel-dir-loading-trunk.patch
After hard reset due to power failure broker takes way too much time
recovering unflushed segments in a single thread. This could be easiliy
improved launching multiple threads (one per data dirrectory, assuming that
typically each data directory is on a dedicated drive). Localy we trie this
simple patch to LogManager.loadLogs and it seems to work, however I'm too new
to scala, so do not take it literally:
{code}
/**
* Recover and load all logs in the given data directories
*/
private def loadLogs(dirs: Seq[File]) {
val threads : Array[Thread] = new Array[Thread](dirs.size)
var i: Int = 0
val me = this
for(dir - dirs) {
val thread = new Thread( new Runnable {
def run()
{
val recoveryPoints = me.recoveryPointCheckpoints(dir).read
/* load the logs */
val subDirs = dir.listFiles()
if(subDirs != null) {
val cleanShutDownFile = new File(dir, Log.CleanShutdownFile)
if(cleanShutDownFile.exists())
info(Found clean shutdown file. Skipping recovery for all logs
in data directory '%s'.format(dir.getAbsolutePath))
for(dir - subDirs) {
if(dir.isDirectory) {
info(Loading log ' + dir.getName + ')
val topicPartition = Log.parseTopicPartitionName(dir.getName)
val config = topicConfigs.getOrElse(topicPartition.topic,
defaultConfig)
val log = new Log(dir,
config,
recoveryPoints.getOrElse(topicPartition, 0L),
scheduler,
time)
val previous = addLogWithLock(topicPartition, log)
if(previous != null)
throw new IllegalArgumentException(Duplicate log
directories found: %s, %s!.format(log.dir.getAbsolutePath,
previous.dir.getAbsolutePath))
}
}
cleanShutDownFile.delete()
}
}
})
thread.start()
threads(i) = thread
i = i + 1
}
for(thread - threads) {
thread.join()
}
}
def addLogWithLock(topicPartition: TopicAndPartition, log: Log): Log = {
logCreationOrDeletionLock synchronized {
this.logs.put(topicPartition, log)
}
}
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Re: Review Request 23291: Patch for KAFKA-1528
On July 6, 2014, 5:01 p.m., Jun Rao wrote: .gitattributes, lines 1-2 https://reviews.apache.org/r/23291/diff/2/?file=624384#file624384line1 Thanks for the patch. Since we explicitly specify the text types, do we still need this line? * text=auto set the default behavior, in case people don't have core.autocrlf set. But it means that you really trust Git to do binary detection properly Yes, you're right. I will drop this line and add other text files names (for example, HEADER, LICENCE, NOTICE etc) if you approve. - Evgeny --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/#review47357 --- On July 6, 2014, 4:23 p.m., Evgeny Vereshchagin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23291/ --- (Updated July 6, 2014, 4:23 p.m.) Review request for kafka. Bugs: KAFKA-1528 https://issues.apache.org/jira/browse/KAFKA-1528 Repository: kafka Description --- See http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/ See https://help.github.com/articles/dealing-with-line-endings Normalize line endings. Contents the same. Add text attribute to *.md files Diffs - .gitattributes PRE-CREATION bin/windows/kafka-run-class.bat f4d2904a3320ae756ed4171f6e99566f1f0cf963 bin/windows/kafka-server-stop.bat b9496ce0fe7438b9df1bbdb10bd86ddefab27ff4 bin/windows/zookeeper-server-stop.bat 29bdee81ac3ac4a96b081ac369d8f6d85c237747 Diff: https://reviews.apache.org/r/23291/diff/ Testing --- Thanks, Evgeny Vereshchagin
[jira] [Created] (KAFKA-1520) Tools for contributors
Evgeny Vereshchagin created KAFKA-1520: -- Summary: Tools for contributors Key: KAFKA-1520 URL: https://issues.apache.org/jira/browse/KAFKA-1520 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Minor Hi! It' s too hard to contribute. I spend two days for configuring jira, reviewboard and jenkins. Manual installation of jira-python and RBTools with these [instructions|https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review] was awful. I create [package|https://pypi.python.org/pypi/kafka-dev-tools/] with kafka-patch-review script. Now all dependencies installs automatically and script installs to required place. Is there any tools for automating developers tasks? I can add it to package. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1520) Tools for contributors
[ https://issues.apache.org/jira/browse/KAFKA-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051917#comment-14051917 ] Evgeny Vereshchagin commented on KAFKA-1520: It's demo version and too early to document this:) And maybe it's wrong way. Theoretically you can install it on any platform that supports Python2.7. Installation instruction same as [here|https://www.reviewboard.org/docs/rbtools/0.6/#installation] That package depends on tools required for kafka-patch-review script: RBTools and jira-python. I want add features to automate, for example, these [steps|https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review#Patchsubmissionandreview-Simplecontributorworkflow], because manual branch managment and rebasing too magically for most people. But I don't understand workflow very well, yet. And maybe some Kafka developers has useful Python/Bash/Ruby helper scripts or [Vagrant|http://www.vagrantup.com/] files for creating development environment. Tools for contributors -- Key: KAFKA-1520 URL: https://issues.apache.org/jira/browse/KAFKA-1520 Project: Kafka Issue Type: Improvement Reporter: Evgeny Vereshchagin Priority: Minor Hi! It' s too hard to contribute. I spend two days for configuring jira, reviewboard and jenkins. Manual installation of jira-python and RBTools with these [instructions|https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review] was awful. I create [package|https://pypi.python.org/pypi/kafka-dev-tools/] with kafka-patch-review script. Now all dependencies installs automatically and script installs to required place. Is there any tools for automating developers tasks? I can add it to package. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1520) Tools for contributors
[
https://issues.apache.org/jira/browse/KAFKA-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051960#comment-14051960
]
Evgeny Vereshchagin commented on KAFKA-1520:
{quote}
Do we have instructions somewhere that seem to imply you need the review tools
all set up to send us a patch?
{quote}
[~jkreps], [here|http://kafka.apache.org/contributing.html]:
{quote}
You can find some help using git to contribute, rebase, and create patches here.
{quote}
And link to [Kafka patch review
tool|https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review]
Tools for contributors
--
Key: KAFKA-1520
URL: https://issues.apache.org/jira/browse/KAFKA-1520
Project: Kafka
Issue Type: Improvement
Reporter: Evgeny Vereshchagin
Priority: Minor
Hi!
It' s too hard to contribute.
I spend two days for configuring jira, reviewboard and jenkins.
Manual installation of jira-python and RBTools with these
[instructions|https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review]
was awful.
I create [package|https://pypi.python.org/pypi/kafka-dev-tools/] with
kafka-patch-review script. Now all dependencies installs automatically and
script installs to required place.
Is there any tools for automating developers tasks? I can add it to package.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050261#comment-14050261 ] Evgeny Vereshchagin commented on KAFKA-1513: Looks like server could be just val. I changed var to val and run tests. It's ok. But I'm not sure that this change don't break something. I'm reading dependent code. I'll update patch if can understand that change safety. Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050303#comment-14050303 ] Evgeny Vereshchagin commented on KAFKA-1513: Yes, It's ok. I want to remove type declaration (: KafkaServer) because type it's obvious by constructor name. I can't find in guide recommends about type inference usage. Drop it or explicit better than implicit? Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050303#comment-14050303 ] Evgeny Vereshchagin edited comment on KAFKA-1513 at 7/2/14 4:41 PM: Yes, It's ok. I want to remove type declaration (server: *KafkaServer* = new KafkaServer) because it's type obvious by constructor name. I can't find in guide recommends about type inference usage. Drop it or explicit better than implicit? was (Author: evvers): Yes, It's ok. I want to remove type declaration (: KafkaServer) because type it's obvious by constructor name. I can't find in guide recommends about type inference usage. Drop it or explicit better than implicit? Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Vereshchagin updated KAFKA-1513: --- Attachment: cleanup-kafkaserverstartable-code-v2.patch Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch, cleanup-kafkaserverstartable-code-v2.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050623#comment-14050623 ] Evgeny Vereshchagin commented on KAFKA-1513: Submit new [patch|https://issues.apache.org/jira/secure/attachment/12653670/cleanup-kafkaserverstartable-code-v2.patch] Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch, cleanup-kafkaserverstartable-code-v2.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
Review Request 23255: Patch for KAFKA-1513
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23255/ --- Review request for kafka. Bugs: KAFKA-1513 https://issues.apache.org/jira/browse/KAFKA-1513 Repository: kafka Description --- Cleanup KafkaServerStartable code Diffs - core/src/main/scala/kafka/server/KafkaServerStartable.scala cef3b84bcf5fda968550b1dc1c0fd6d790eae6e6 Diff: https://reviews.apache.org/r/23255/diff/ Testing --- Thanks, Evgeny Vereshchagin
[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051001#comment-14051001 ] Evgeny Vereshchagin commented on KAFKA-1513: Created reviewboard https://reviews.apache.org/r/23255/diff/ against branch origin/trunk Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: KAFKA-1513.patch, cleanup-kafkaserverstartable-code-v1.patch, cleanup-kafkaserverstartable-code-v2.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Vereshchagin updated KAFKA-1513: --- Attachment: KAFKA-1513.patch Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: KAFKA-1513.patch, cleanup-kafkaserverstartable-code-v1.patch, cleanup-kafkaserverstartable-code-v2.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Consistent logIdent
Sorry, I was wrong. It's different parts of one log message. -- Best regards, Evgeny Vereshchagin
[jira] [Created] (KAFKA-1513) Cleanup KafkaServerStartable code
Evgeny Vereshchagin created KAFKA-1513: -- Summary: Cleanup KafkaServerStartable code Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evgeny Vereshchagin updated KAFKA-1513: --- Attachment: cleanup-kafkaserverstartable-code-v1.patch Submit patch. Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
