[jira] [Assigned] (KAFKA-4917) Our built-in file connector can't work with our built-in SMT
[ https://issues.apache.org/jira/browse/KAFKA-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasvi Gupta reassigned KAFKA-4917: Assignee: Manasvi Gupta > Our built-in file connector can't work with our built-in SMT > > > Key: KAFKA-4917 > URL: https://issues.apache.org/jira/browse/KAFKA-4917 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > > Our built-in file connector always returns STRING schema. > All our transformations expect either STRUCT (if connectors return schema) or > a MAP (schemaless). > I understand why (how do you add a field to a STRING?), but it also means > that you can't have an example for SMT that works with Apache Kafka out of > the box. Which makes documentation kind of painful. > Either we modify the file connector or we modify the SMTs to deal with STRING > better, but something gotta change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (KAFKA-4594) Annotate integration tests and provide gradle build targets to run subsets of tests
[
https://issues.apache.org/jira/browse/KAFKA-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manasvi Gupta reassigned KAFKA-4594:
Assignee: Manasvi Gupta
> Annotate integration tests and provide gradle build targets to run subsets of
> tests
> ---
>
> Key: KAFKA-4594
> URL: https://issues.apache.org/jira/browse/KAFKA-4594
> Project: Kafka
> Issue Type: Bug
> Components: unit tests
>Reporter: Ewen Cheslack-Postava
>Assignee: Manasvi Gupta
>Priority: Minor
> Labels: newbie
>
> It's possible to annotate unit tests and control which ones run based on
> these annotations. Our tests have grown to take quite a long time because
> we've added a lot of relatively expensive integration tests. Because these
> tests are all interleaved with the true unit tests and block things like
> checkstyle from running, we've ended up with pretty bad turn around time on
> feedback on simple PR issues.
> We could make this a lot nicer, and encourage users to actually run some
> tests before submitting PRs with problems, by making it easier to get
> lightweight feedback based only on unit tests. We'd want to annotate
> integration tests (which can probably mostly be accomplished by annotating
> just a few shared {{*TestHarness}} classes and then setting up the build
> tasks and dependencies to run things in fast-fail, more user-friendly order.
> In particular, it'd be nice to:
> a) Have gradle tasks that can run just the unit tests + checkstyle. This
> provides devs a *much* faster way to get at least basic feedback about
> whether there are problems with their PR. PR Jenkins builds will also give
> much faster feedback (and avoid clogging up the Jenkins slaves with lots of
> unnecessary work that will ultimately just fail on a unit test anyway).
> b) Have the order of tests be 1) build everything and run their unit tests,
> 2) run checkstyle against all components, then 3) run integration tests. This
> could help address one of the frustrating things about checkstyle tests
> today, which are put after all tests to avoid annoying failures during
> development, but also results in a lot of folks missing simple checkstyle
> issues before submitting PRs.
> The two obvious options I see for this are:
> 1. In JUnit4 (which we currently use), use Categories. These seem to
> unfortunately still be under an experimental package. We pin to a specific
> version of JUnit, so this may not be a huge issue. But it does mean any
> future migration would be more painful as the annotations & integration with
> the test runner would need to change in the future.
> 2. Wait for JUnit5 with its built-in Tag support. This would be tied to
> making JDK8 the minimum supported Java version. Given current plans that
> would mean we couldn't do this until at least 0.11.0.0.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (KAFKA-4307) Inconsistent parameters between console producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626544#comment-15626544 ] Manasvi Gupta commented on KAFKA-4307: -- Yes. Sorry, I was on holiday for Diwali. Will have patch by tomorrow. > Inconsistent parameters between console producer and consumer > - > > Key: KAFKA-4307 > URL: https://issues.apache.org/jira/browse/KAFKA-4307 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.10.1.0 >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > > kafka-console-producer uses --broker-list while kafka-console-consumer uses > --bootstrap-server. > Let's add --bootstrap-server to the producer for some consistency? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-4308) Inconsistent parameters between console producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15582890#comment-15582890 ] Manasvi Gupta commented on KAFKA-4308: -- I think this one is duplicate of KAFKA-4307 > Inconsistent parameters between console producer and consumer > - > > Key: KAFKA-4308 > URL: https://issues.apache.org/jira/browse/KAFKA-4308 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.10.1.0 >Reporter: Gwen Shapira > Labels: newbie > > kafka-console-producer uses --broker-list while kafka-console-consumer uses > --bootstrap-server. > Let's add --bootstrap-server to the producer for some consistency? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (KAFKA-4307) Inconsistent parameters between console producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-4307 started by Manasvi Gupta. > Inconsistent parameters between console producer and consumer > - > > Key: KAFKA-4307 > URL: https://issues.apache.org/jira/browse/KAFKA-4307 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.10.1.0 >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > > kafka-console-producer uses --broker-list while kafka-console-consumer uses > --bootstrap-server. > Let's add --bootstrap-server to the producer for some consistency? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-4307) Inconsistent parameters between console producer and consumer
[ https://issues.apache.org/jira/browse/KAFKA-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasvi Gupta reassigned KAFKA-4307: Assignee: Manasvi Gupta > Inconsistent parameters between console producer and consumer > - > > Key: KAFKA-4307 > URL: https://issues.apache.org/jira/browse/KAFKA-4307 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.10.1.0 >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > > kafka-console-producer uses --broker-list while kafka-console-consumer uses > --bootstrap-server. > Let's add --bootstrap-server to the producer for some consistency? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3827) log.message.format.version should default to inter.broker.protocol.version
[ https://issues.apache.org/jira/browse/KAFKA-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339043#comment-15339043 ] Manasvi Gupta commented on KAFKA-3827: -- I will wait for more clarification from [~junrao] before starting to work on this issue. Thanks! > log.message.format.version should default to inter.broker.protocol.version > -- > > Key: KAFKA-3827 > URL: https://issues.apache.org/jira/browse/KAFKA-3827 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.10.0.0 >Reporter: Jun Rao >Assignee: Manasvi Gupta > Labels: newbie > > Currently, if one sets inter.broker.protocol.version to 0.9.0 and restarts > the broker, one will get the following exception since > log.message.format.version defaults to 0.10.0. It will be more intuitive if > log.message.format.version defaults to the value of > inter.broker.protocol.version. > java.lang.IllegalArgumentException: requirement failed: > log.message.format.version 0.10.0-IV1 cannot be used when > inter.broker.protocol.version is set to 0.9.0.1 > at scala.Predef$.require(Predef.scala:233) > at kafka.server.KafkaConfig.validateValues(KafkaConfig.scala:1023) > at kafka.server.KafkaConfig.(KafkaConfig.scala:994) > at kafka.server.KafkaConfig$.fromProps(KafkaConfig.scala:743) > at kafka.server.KafkaConfig$.fromProps(KafkaConfig.scala:740) > at > kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:28) > at kafka.Kafka$.main(Kafka.scala:58) > at kafka.Kafka.main(Kafka.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-3827) log.message.format.version should default to inter.broker.protocol.version
[ https://issues.apache.org/jira/browse/KAFKA-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasvi Gupta reassigned KAFKA-3827: Assignee: Manasvi Gupta > log.message.format.version should default to inter.broker.protocol.version > -- > > Key: KAFKA-3827 > URL: https://issues.apache.org/jira/browse/KAFKA-3827 > Project: Kafka > Issue Type: Improvement >Affects Versions: 0.10.0.0 >Reporter: Jun Rao >Assignee: Manasvi Gupta > Labels: newbie > > Currently, if one sets inter.broker.protocol.version to 0.9.0 and restarts > the broker, one will get the following exception since > log.message.format.version defaults to 0.10.0. It will be more intuitive if > log.message.format.version defaults to the value of > inter.broker.protocol.version. > java.lang.IllegalArgumentException: requirement failed: > log.message.format.version 0.10.0-IV1 cannot be used when > inter.broker.protocol.version is set to 0.9.0.1 > at scala.Predef$.require(Predef.scala:233) > at kafka.server.KafkaConfig.validateValues(KafkaConfig.scala:1023) > at kafka.server.KafkaConfig.(KafkaConfig.scala:994) > at kafka.server.KafkaConfig$.fromProps(KafkaConfig.scala:743) > at kafka.server.KafkaConfig$.fromProps(KafkaConfig.scala:740) > at > kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:28) > at kafka.Kafka$.main(Kafka.scala:58) > at kafka.Kafka.main(Kafka.scala) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work stopped] (KAFKA-3009) Disallow star imports
[ https://issues.apache.org/jira/browse/KAFKA-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-3009 stopped by Manasvi Gupta. > Disallow star imports > - > > Key: KAFKA-3009 > URL: https://issues.apache.org/jira/browse/KAFKA-3009 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > Attachments: main.xml > > > Looks like we don't want star imports in our code (java.utils.*) > So, lets add this rule to checkstyle and fix existing violations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3009) Disallow star imports
[ https://issues.apache.org/jira/browse/KAFKA-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasvi Gupta updated KAFKA-3009: - Status: Patch Available (was: Open) > Disallow star imports > - > > Key: KAFKA-3009 > URL: https://issues.apache.org/jira/browse/KAFKA-3009 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > Attachments: main.xml > > > Looks like we don't want star imports in our code (java.utils.*) > So, lets add this rule to checkstyle and fix existing violations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (KAFKA-3009) Disallow star imports
[ https://issues.apache.org/jira/browse/KAFKA-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-3009 started by Manasvi Gupta. > Disallow star imports > - > > Key: KAFKA-3009 > URL: https://issues.apache.org/jira/browse/KAFKA-3009 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > > Looks like we don't want star imports in our code (java.utils.*) > So, lets add this rule to checkstyle and fix existing violations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3009) Disallow star imports
[ https://issues.apache.org/jira/browse/KAFKA-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasvi Gupta updated KAFKA-3009: - Attachment: main.xml Checkstyle errors on core module > Disallow star imports > - > > Key: KAFKA-3009 > URL: https://issues.apache.org/jira/browse/KAFKA-3009 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > Attachments: main.xml > > > Looks like we don't want star imports in our code (java.utils.*) > So, lets add this rule to checkstyle and fix existing violations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work stopped] (KAFKA-3009) Disallow star imports
[ https://issues.apache.org/jira/browse/KAFKA-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-3009 stopped by Manasvi Gupta. > Disallow star imports > - > > Key: KAFKA-3009 > URL: https://issues.apache.org/jira/browse/KAFKA-3009 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > > Looks like we don't want star imports in our code (java.utils.*) > So, lets add this rule to checkstyle and fix existing violations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work started] (KAFKA-3009) Disallow star imports
[ https://issues.apache.org/jira/browse/KAFKA-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-3009 started by Manasvi Gupta. > Disallow star imports > - > > Key: KAFKA-3009 > URL: https://issues.apache.org/jira/browse/KAFKA-3009 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > > Looks like we don't want star imports in our code (java.utils.*) > So, lets add this rule to checkstyle and fix existing violations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (KAFKA-3009) Disallow star imports
[ https://issues.apache.org/jira/browse/KAFKA-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manasvi Gupta reassigned KAFKA-3009: Assignee: Manasvi Gupta > Disallow star imports > - > > Key: KAFKA-3009 > URL: https://issues.apache.org/jira/browse/KAFKA-3009 > Project: Kafka > Issue Type: Bug >Reporter: Gwen Shapira >Assignee: Manasvi Gupta > Labels: newbie > > Looks like we don't want star imports in our code (java.utils.*) > So, lets add this rule to checkstyle and fix existing violations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
