[jira] [Created] (KAFKA-1727) Fix comment about message format

2014-10-23 Thread Muneyuki Noguchi (JIRA) 
Muneyuki Noguchi created KAFKA-1727:
---

 Summary: Fix comment about message format
 Key: KAFKA-1727
 URL: https://issues.apache.org/jira/browse/KAFKA-1727
 Project: Kafka
  Issue Type: Bug
Reporter: Muneyuki Noguchi
Priority: Trivial


The comment in Message.scala says the value of magic identifier is 2,

 bq. 2. 1 byte magic identifier to allow format changes, value is 2 currently

but the actual current magic value is 0.

{code}
  /**
   * The current magic value
   */
  val CurrentMagicValue: Byte = 0
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-1727) Fix comment about message format

2014-10-23 Thread Muneyuki Noguchi (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14181308#comment-14181308
 ] 

Muneyuki Noguchi commented on KAFKA-1727:
-

Created reviewboard https://reviews.apache.org/r/27075/diff/
 against branch origin/trunk

 Fix comment about message format
 

 Key: KAFKA-1727
 URL: https://issues.apache.org/jira/browse/KAFKA-1727
 Project: Kafka
  Issue Type: Bug
Reporter: Muneyuki Noguchi
Priority: Trivial
 Attachments: KAFKA-1727.patch


 The comment in Message.scala says the value of magic identifier is 2,
  bq. 2. 1 byte magic identifier to allow format changes, value is 2 
 currently
 but the actual current magic value is 0.
 {code}
   /**
* The current magic value
*/
   val CurrentMagicValue: Byte = 0
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 27075: Patch for KAFKA-1727

2014-10-23 Thread Muneyuki Noguchi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27075/
---

Review request for kafka.


Bugs: KAFKA-1727
https://issues.apache.org/jira/browse/KAFKA-1727


Repository: kafka


Description
---

The value of magic identifier is 0 because CurrentMagicValue is 0.


Diffs
-

  core/src/main/scala/kafka/message/Message.scala 
d2a7293c7be4022af30884330924791340acc5c1 

Diff: https://reviews.apache.org/r/27075/diff/


Testing
---


Thanks,

Muneyuki Noguchi

[jira] [Updated] (KAFKA-1727) Fix comment about message format

2014-10-23 Thread Muneyuki Noguchi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/KAFKA-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Muneyuki Noguchi updated KAFKA-1727:

Attachment: KAFKA-1727.patch

 Fix comment about message format
 

 Key: KAFKA-1727
 URL: https://issues.apache.org/jira/browse/KAFKA-1727
 Project: Kafka
  Issue Type: Bug
Reporter: Muneyuki Noguchi
Priority: Trivial
 Attachments: KAFKA-1727.patch


 The comment in Message.scala says the value of magic identifier is 2,
  bq. 2. 1 byte magic identifier to allow format changes, value is 2 
 currently
 but the actual current magic value is 0.
 {code}
   /**
* The current magic value
*/
   val CurrentMagicValue: Byte = 0
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)