[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15119739#comment-15119739
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~ijuma] [~gwenshap] Can I rely on you to tell me when I should move from 
DISCUSS to VOTE for the KIP?

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116960#comment-15116960
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~gwenshap] - thanks! the KIP is up: 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61337336

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15116177#comment-15116177
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

Can anyone help with the confluence issue I'm having to create the KIP, or are 
edit rights to the wiki reserved to project members? (In which case, I couldn't 
help for the KIP).

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15112115#comment-15112115
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

Hi [~gwenshap], I'm happy to go through the process. I don't seem to have 
authorization to create pages in the Kafka space on confluence though. My 
user-id there is "pyr" 

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110597#comment-15110597
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~granthenke] It's ready to be committed, but I do think there needs to be a 
final resolution from project members to move forwards.

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096960#comment-15096960
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~hachikuji]  [~ewencp] [~ijuma] Can I be of any additional help moving this 
forward?

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (KAFKA-1377) transient unit test failure in LogOffsetTest

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067053#comment-15067053
 ] 

Pierre-Yves Ritschard edited comment on KAFKA-1377 at 12/21/15 9:03 PM:


[~guozhang] I'm testing against trunk.
The failure to propagater results is confined to the Sasl tests.


was (Author: pyritschard):
[~guozhang] I'm testing against trunk.

> transient unit test failure in LogOffsetTest
> 
>
> Key: KAFKA-1377
> URL: https://issues.apache.org/jira/browse/KAFKA-1377
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Jun Rao
>Assignee: Jun Rao
>  Labels: newbie
> Fix For: 0.10.0.0
>
> Attachments: KAFKA-1377.patch, KAFKA-1377_2014-04-11_17:42:13.patch, 
> KAFKA-1377_2014-04-11_18:14:45.patch
>
>
> Saw the following transient unit test failure.
> kafka.server.LogOffsetTest > testGetOffsetsBeforeEarliestTime FAILED
> junit.framework.AssertionFailedError: expected: but 
> was:
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:277)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:71)
> at 
> kafka.server.LogOffsetTest.testGetOffsetsBeforeEarliestTime(LogOffsetTest.scala:198)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-1377) transient unit test failure in LogOffsetTest

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067053#comment-15067053
 ] 

Pierre-Yves Ritschard commented on KAFKA-1377:
--

[~guozhang] I'm testing against trunk.

> transient unit test failure in LogOffsetTest
> 
>
> Key: KAFKA-1377
> URL: https://issues.apache.org/jira/browse/KAFKA-1377
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Jun Rao
>Assignee: Jun Rao
>  Labels: newbie
> Fix For: 0.10.0.0
>
> Attachments: KAFKA-1377.patch, KAFKA-1377_2014-04-11_17:42:13.patch, 
> KAFKA-1377_2014-04-11_18:14:45.patch
>
>
> Saw the following transient unit test failure.
> kafka.server.LogOffsetTest > testGetOffsetsBeforeEarliestTime FAILED
> junit.framework.AssertionFailedError: expected: but 
> was:
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:277)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:71)
> at 
> kafka.server.LogOffsetTest.testGetOffsetsBeforeEarliestTime(LogOffsetTest.scala:198)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-1377) transient unit test failure in LogOffsetTest

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067138#comment-15067138
 ] 

Pierre-Yves Ritschard commented on KAFKA-1377:
--

[~ijuma] will do. it looked to me as a generalization of the previous problem.

> transient unit test failure in LogOffsetTest
> 
>
> Key: KAFKA-1377
> URL: https://issues.apache.org/jira/browse/KAFKA-1377
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Jun Rao
>Assignee: Jun Rao
>  Labels: newbie
> Fix For: 0.10.0.0
>
> Attachments: KAFKA-1377.patch, KAFKA-1377_2014-04-11_17:42:13.patch, 
> KAFKA-1377_2014-04-11_18:14:45.patch
>
>
> Saw the following transient unit test failure.
> kafka.server.LogOffsetTest > testGetOffsetsBeforeEarliestTime FAILED
> junit.framework.AssertionFailedError: expected: but 
> was:
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:277)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:71)
> at 
> kafka.server.LogOffsetTest.testGetOffsetsBeforeEarliestTime(LogOffsetTest.scala:198)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067633#comment-15067633
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~hachikuji] [~ijuma] I went through the re-factor. I had to fight gradle and 
some unrelated tests which fail for me (on both trunk and this branch), which 
explains the many commits. As it stands the branch builds and passes all tests.

Along the way I discovered that a SinkTask uses similar signatures, I propose 
converging to the same signatures in a separate patch, to get this under way.

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Reopened] (KAFKA-1377) transient unit test failure in LogOffsetTest

[Pierre-Yves Ritschard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre-Yves Ritschard reopened KAFKA-1377:
--

I am getting these errors consistently.
This is against trunk on Linux. 64 bit, i7 processor 16G. JDK version:

java version "1.8.0_60"
Java(TM) SE Runtime Environment (build 1.8.0_60-b27)
Java HotSpot(TM) 64-Bit Server VM (build 25.60-b23, mixed mode)


> transient unit test failure in LogOffsetTest
> 
>
> Key: KAFKA-1377
> URL: https://issues.apache.org/jira/browse/KAFKA-1377
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Jun Rao
>Assignee: Jun Rao
>  Labels: newbie
> Fix For: 0.10.0.0
>
> Attachments: KAFKA-1377.patch, KAFKA-1377_2014-04-11_17:42:13.patch, 
> KAFKA-1377_2014-04-11_18:14:45.patch
>
>
> Saw the following transient unit test failure.
> kafka.server.LogOffsetTest > testGetOffsetsBeforeEarliestTime FAILED
> junit.framework.AssertionFailedError: expected: but 
> was:
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:277)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:71)
> at 
> kafka.server.LogOffsetTest.testGetOffsetsBeforeEarliestTime(LogOffsetTest.scala:198)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-1377) transient unit test failure in LogOffsetTest

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066345#comment-15066345
 ] 

Pierre-Yves Ritschard commented on KAFKA-1377:
--

FWIW, bumping the waitTime parameter in TestUtils.scala does not change the 
behavior, so this is not timing related (waiting for 15s instead of 5s still 
exhibits the same behavior).

> transient unit test failure in LogOffsetTest
> 
>
> Key: KAFKA-1377
> URL: https://issues.apache.org/jira/browse/KAFKA-1377
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Reporter: Jun Rao
>Assignee: Jun Rao
>  Labels: newbie
> Fix For: 0.10.0.0
>
> Attachments: KAFKA-1377.patch, KAFKA-1377_2014-04-11_17:42:13.patch, 
> KAFKA-1377_2014-04-11_18:14:45.patch
>
>
> Saw the following transient unit test failure.
> kafka.server.LogOffsetTest > testGetOffsetsBeforeEarliestTime FAILED
> junit.framework.AssertionFailedError: expected: but 
> was:
> at junit.framework.Assert.fail(Assert.java:47)
> at junit.framework.Assert.failNotEquals(Assert.java:277)
> at junit.framework.Assert.assertEquals(Assert.java:64)
> at junit.framework.Assert.assertEquals(Assert.java:71)
> at 
> kafka.server.LogOffsetTest.testGetOffsetsBeforeEarliestTime(LogOffsetTest.scala:198)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064119#comment-15064119
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~granthenke] I am not going to argue with this, given the language I mostly 
consume the API from. I will wait for feedback from Jenkins and then push a 
clean-up which removes the superfluous signatures.

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064182#comment-15064182
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~granthenke] ok, i'll wait for more opinions on the matter. Now that 
regressions tests have passed on the PR, except for the final decision on this 
aspect and pushing a single cleaned-up commit the PR should be ready.

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064819#comment-15064819
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

Hi,

I just wanted to clarify something. The switch is transparent and uneventful 
from List types to Collection, and it makes perfect sense to remove the List 
signatures.
I would just like a confirmation that Array signatures should go as well since 
if they do, the refactor is going to be much bigger.

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064879#comment-15064879
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

I pushed a version with the superfluous signatures removed for comparison

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (KAFKA-3006) kafka client should offer Collection alternative to Array call signatures

[Pierre-Yves Ritschard (JIRA)]

Pierre-Yves Ritschard created KAFKA-3006:


 Summary: kafka client should offer Collection alternative to Array 
call signatures
 Key: KAFKA-3006
 URL: https://issues.apache.org/jira/browse/KAFKA-3006
 Project: Kafka
  Issue Type: Improvement
  Components: clients
Affects Versions: 0.9.0.0
Reporter: Pierre-Yves Ritschard


Some languages (in my case, clojure) make it a bit cumbersome to deal with java 
arrays. 

In the consumer, these four signatures only accepts arrays:

seekToBeginning, seekToEnd, pause, resume.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (KAFKA-3006) kafka client should offer Collection alternative to Array call signatures

[Pierre-Yves Ritschard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre-Yves Ritschard updated KAFKA-3006:
-
Status: Patch Available  (was: Open)

> kafka client should offer Collection alternative to Array call signatures
> -
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> Some languages (in my case, clojure) make it a bit cumbersome to deal with 
> java arrays. 
> In the consumer, these four signatures only accepts arrays:
> seekToBeginning, seekToEnd, pause, resume.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre-Yves Ritschard updated KAFKA-3006:
-
Description: 
The KafkaConsumer API has some annoying inconsistencies in the usage of 
collection types. For example, subscribe() takes a list, but subscription() 
returns a set. Similarly for assign() and assignment(). We also have pause() , 
seekToBeginning(), seekToEnd(), and resume() which annoyingly use a variable 
argument array, which means you have to copy the result of assignment() to an 
array if you want to pause all assigned partitions. We can solve these issues 
by adding the following variants:


{code}
void subscribe(Collection topics);
void subscribe(Collection topics, ConsumerRebalanceListener);
void assign(Collection partitions);
void pause(Collection partitions);
void resume(Collection partitions);
void seekToBeginning(Collection);
void seekToEnd(Collection);
{code}

This issues supersedes KAFKA-2991

  was:
The KafkaConsumer API has some annoying inconsistencies in the usage of 
collection types. For example, subscribe() takes a list, but subscription() 
returns a set. Similarly for assign() and assignment(). We also have pause() , 
seekToBeginning(), seekToEnd(), and resume() which annoyingly use a variable 
argument array, which means you have to copy the result of assignment() to an 
array if you want to pause all assigned partitions. We can solve these issues 
by adding the following variants:


{code}
void subscribe(Collection topics);
void subscribe(Collection topics, ConsumerRebalanceListener);
void assign(Collection partitions);
void pause(Collection partitions);
void resume(Collection partitions);
void seekToBeginning(Collection);
void seekToEnd(Collection);
{code}



> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) kafka client should offer Collection alternative to Array call signatures

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062799#comment-15062799
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~hachikuji] I added the necessary changes for KAFKA-2991 (still waiting for 
Jenkins to run through the whole test-suite) and incorporated your comments.
To better address the concerns [~jkreps] had in KAFKA-2991, should I mark the 
List and Array signatures as deprecated?

> kafka client should offer Collection alternative to Array call signatures
> -
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> Some languages (in my case, clojure) make it a bit cumbersome to deal with 
> java arrays. 
> In the consumer, these four signatures only accepts arrays:
> seekToBeginning, seekToEnd, pause, resume.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (KAFKA-3006) make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre-Yves Ritschard updated KAFKA-3006:
-
Summary: make collection default container type for sequences in the 
consumer API  (was: kafka client should offer Collection alternative to Array 
call signatures)

> make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) Make collection default container type for sequences in the consumer API

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063589#comment-15063589
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

I'm open to fixing the PR both ways. The consensus seems to go towards having a 
single signature for each call which would be collections, right?

> Make collection default container type for sequences in the consumer API
> 
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> The KafkaConsumer API has some annoying inconsistencies in the usage of 
> collection types. For example, subscribe() takes a list, but subscription() 
> returns a set. Similarly for assign() and assignment(). We also have pause() 
> , seekToBeginning(), seekToEnd(), and resume() which annoyingly use a 
> variable argument array, which means you have to copy the result of 
> assignment() to an array if you want to pause all assigned partitions. We can 
> solve these issues by adding the following variants:
> {code}
> void subscribe(Collection topics);
> void subscribe(Collection topics, ConsumerRebalanceListener);
> void assign(Collection partitions);
> void pause(Collection partitions);
> void resume(Collection partitions);
> void seekToBeginning(Collection);
> void seekToEnd(Collection);
> {code}
> This issues supersedes KAFKA-2991



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) kafka client should offer Collection alternative to Array call signatures

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062613#comment-15062613
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~hachikuji] Yes will do so in a couple of hours, thanks for the quick feedback.

> kafka client should offer Collection alternative to Array call signatures
> -
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> Some languages (in my case, clojure) make it a bit cumbersome to deal with 
> java arrays. 
> In the consumer, these four signatures only accepts arrays:
> seekToBeginning, seekToEnd, pause, resume.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3006) kafka client should offer Collection alternative to Array call signatures

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062599#comment-15062599
 ] 

Pierre-Yves Ritschard commented on KAFKA-3006:
--

[~hachikuji] Hi Jason, I'm happy to cover KAFKA-2991 in the patch as well.

> kafka client should offer Collection alternative to Array call signatures
> -
>
> Key: KAFKA-3006
> URL: https://issues.apache.org/jira/browse/KAFKA-3006
> Project: Kafka
>  Issue Type: Improvement
>  Components: clients
>Affects Versions: 0.9.0.0
>Reporter: Pierre-Yves Ritschard
>  Labels: patch
>
> Some languages (in my case, clojure) make it a bit cumbersome to deal with 
> java arrays. 
> In the consumer, these four signatures only accepts arrays:
> seekToBeginning, seekToEnd, pause, resume.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2033) Small typo in documentation

[Pierre-Yves Ritschard (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370917#comment-14370917
 ] 

Pierre-Yves Ritschard commented on KAFKA-2033:
--

Created reviewboard https://reviews.apache.org/r/32290/diff/
 against branch origin/trunk

 Small typo in documentation
 ---

 Key: KAFKA-2033
 URL: https://issues.apache.org/jira/browse/KAFKA-2033
 Project: Kafka
  Issue Type: Bug
  Components: consumer
Affects Versions: 0.8.3, 0.9.0
Reporter: Pierre-Yves Ritschard
Assignee: Neha Narkhede
 Attachments: KAFKA-2033.patch


 The javadoc still mentions metadata.broker.list in the consumer config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (KAFKA-2033) Small typo in documentation

[Pierre-Yves Ritschard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre-Yves Ritschard updated KAFKA-2033:
-
Assignee: Pierre-Yves Ritschard  (was: Neha Narkhede)
  Status: Patch Available  (was: Open)

 Small typo in documentation
 ---

 Key: KAFKA-2033
 URL: https://issues.apache.org/jira/browse/KAFKA-2033
 Project: Kafka
  Issue Type: Bug
  Components: consumer
Affects Versions: 0.8.3, 0.9.0
Reporter: Pierre-Yves Ritschard
Assignee: Pierre-Yves Ritschard
 Attachments: KAFKA-2033.patch


 The javadoc still mentions metadata.broker.list in the consumer config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (KAFKA-2033) Small typo in documentation

[Pierre-Yves Ritschard (JIRA)]

Pierre-Yves Ritschard created KAFKA-2033:


 Summary: Small typo in documentation
 Key: KAFKA-2033
 URL: https://issues.apache.org/jira/browse/KAFKA-2033
 Project: Kafka
  Issue Type: Bug
  Components: consumer
Affects Versions: 0.8.3, 0.9.0
Reporter: Pierre-Yves Ritschard
Assignee: Neha Narkhede
 Attachments: KAFKA-2033.patch

The javadoc still mentions metadata.broker.list in the consumer config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (KAFKA-2033) Small typo in documentation

[Pierre-Yves Ritschard (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre-Yves Ritschard updated KAFKA-2033:
-
Attachment: KAFKA-2033.patch

 Small typo in documentation
 ---

 Key: KAFKA-2033
 URL: https://issues.apache.org/jira/browse/KAFKA-2033
 Project: Kafka
  Issue Type: Bug
  Components: consumer
Affects Versions: 0.8.3, 0.9.0
Reporter: Pierre-Yves Ritschard
Assignee: Neha Narkhede
 Attachments: KAFKA-2033.patch


 The javadoc still mentions metadata.broker.list in the consumer config.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)