[jira] [Updated] (KAFKA-4284) Partitioner never closed by producer
[ https://issues.apache.org/jira/browse/KAFKA-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theo Hultberg updated KAFKA-4284: - External issue URL: https://github.com/apache/kafka/pull/2000 > Partitioner never closed by producer > > > Key: KAFKA-4284 > URL: https://issues.apache.org/jira/browse/KAFKA-4284 > Project: Kafka > Issue Type: Bug > Components: producer >Affects Versions: 0.10.0.1 >Reporter: Theo Hultberg >Priority: Minor > > Partitioners are never closed by the producer, even though the Partitioner > interface has a close method. > I looked at KAFKA-2091 and it seems like the close method has been there from > the beginning, but never been used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-4284) Partitioner never closed by producer
[ https://issues.apache.org/jira/browse/KAFKA-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theo Hultberg updated KAFKA-4284: - Description: Partitioners are never closed by the producer, even though the Partitioner interface has a close method. I looked at KAFKA-2091 and it seems like the close method has been there from the beginning, but never been used. was: Partitioners are never closed by the producer, even though the Partitioner interface has a close method. I looked at KAFKA-2091 and it seems like the close method has been there from the beginning, but never been used. I've made a pull request with a fix, it can be found here: https://github.com/apache/kafka/pull/2000 > Partitioner never closed by producer > > > Key: KAFKA-4284 > URL: https://issues.apache.org/jira/browse/KAFKA-4284 > Project: Kafka > Issue Type: Bug > Components: producer >Affects Versions: 0.10.0.1 >Reporter: Theo Hultberg >Priority: Minor > > Partitioners are never closed by the producer, even though the Partitioner > interface has a close method. > I looked at KAFKA-2091 and it seems like the close method has been there from > the beginning, but never been used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-4284) Partitioner never closed by producer
[ https://issues.apache.org/jira/browse/KAFKA-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theo Hultberg updated KAFKA-4284: - Status: Patch Available (was: Open) Patch available here: https://github.com/apache/kafka/pull/2000 > Partitioner never closed by producer > > > Key: KAFKA-4284 > URL: https://issues.apache.org/jira/browse/KAFKA-4284 > Project: Kafka > Issue Type: Bug > Components: producer >Affects Versions: 0.10.0.1 >Reporter: Theo Hultberg >Priority: Minor > > Partitioners are never closed by the producer, even though the Partitioner > interface has a close method. > I looked at KAFKA-2091 and it seems like the close method has been there from > the beginning, but never been used. > I've made a pull request with a fix, it can be found here: > https://github.com/apache/kafka/pull/2000 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-4284) Partitioner never closed by producer
[ https://issues.apache.org/jira/browse/KAFKA-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theo Hultberg updated KAFKA-4284: - Description: Partitioners are never closed by the producer, even though the Partitioner interface has a close method. I looked at KAFKA-2091 and it seems like the close method has been there from the beginning, but never been used. I've made a pull request with a fix, it can be found here: https://github.com/apache/kafka/pull/2000 was: Partitioners are never closed by the producer, even though the Partitioner interface has a close method. I looked at KAFKA-2091 and it seems like the close method has been there from the beginning, but never been used. There's > Partitioner never closed by producer > > > Key: KAFKA-4284 > URL: https://issues.apache.org/jira/browse/KAFKA-4284 > Project: Kafka > Issue Type: Bug > Components: producer >Affects Versions: 0.10.0.1 >Reporter: Theo Hultberg >Priority: Minor > > Partitioners are never closed by the producer, even though the Partitioner > interface has a close method. > I looked at KAFKA-2091 and it seems like the close method has been there from > the beginning, but never been used. > I've made a pull request with a fix, it can be found here: > https://github.com/apache/kafka/pull/2000 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-4284) Partitioner never closed by producer
[ https://issues.apache.org/jira/browse/KAFKA-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Theo Hultberg updated KAFKA-4284: - Description: Partitioners are never closed by the producer, even though the Partitioner interface has a close method. I looked at KAFKA-2091 and it seems like the close method has been there from the beginning, but never been used. There's was: Partitioners are never closed by the producer, even though the Partitioner interface has a close method. I looked at KAFKA-2091 and it seems like the close method has been there from the beginning, but never been used. I will push up a pull request for this shortly. > Partitioner never closed by producer > > > Key: KAFKA-4284 > URL: https://issues.apache.org/jira/browse/KAFKA-4284 > Project: Kafka > Issue Type: Bug > Components: producer >Affects Versions: 0.10.0.1 >Reporter: Theo Hultberg >Priority: Minor > > Partitioners are never closed by the producer, even though the Partitioner > interface has a close method. > I looked at KAFKA-2091 and it seems like the close method has been there from > the beginning, but never been used. > There's -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KAFKA-4284) Partitioner never closed by producer
Theo Hultberg created KAFKA-4284: Summary: Partitioner never closed by producer Key: KAFKA-4284 URL: https://issues.apache.org/jira/browse/KAFKA-4284 Project: Kafka Issue Type: Bug Components: producer Affects Versions: 0.10.0.1 Reporter: Theo Hultberg Priority: Minor Partitioners are never closed by the producer, even though the Partitioner interface has a close method. I looked at KAFKA-2091 and it seems like the close method has been there from the beginning, but never been used. I will push up a pull request for this shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (KAFKA-2225) Allow fetching from ISR
Theo Hultberg created KAFKA-2225: Summary: Allow fetching from ISR Key: KAFKA-2225 URL: https://issues.apache.org/jira/browse/KAFKA-2225 Project: Kafka Issue Type: Improvement Reporter: Theo Hultberg Currently clients are not allowed to fetch from replicas, even if they are in sync with the master. If I'm not missing anything significant it shouldn't be any difference fetching from the leader or an ISR, besides maybe some extra latency. For our use case it would be very beneficial to be able to fetch from replicas instead of just the leader. We run Kafka clusters that replicate across EC2 availability zones, and each byte sent between zones costs money. This bandwith usage costs us about the same as it costs to run the instances. If we could fetch from a replica in the same zone as the client we could avoid some of this cost. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1493) Use a well-documented LZ4 compression format and remove redundant LZ4HC option
[ https://issues.apache.org/jira/browse/KAFKA-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158408#comment-14158408 ] Theo Hultberg commented on KAFKA-1493: -- If you're looking for a standard way to handle LZ4 there doesn't seem to be any, but Cassandra uses a 4 byte field for the uncompressed length and no checksum (https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/compress/LZ4Compressor.java). I've seen varint used too in other projects, but in my opinion it's a pain to implement compared to just using an int, and for very little benefit. The drawbacks are that small messages will use one or two bytes more, and that you can't handle compressed chunks of over a couple of gigabyte. Sorry for jumping into the discussion out of the blue, I just stumbled upon this while looking through the issues for 0.8.2. I've got very little experience with the Kafka codebase, but I'm the author of the Ruby driver for Cassandra and I recognized the issue. Hope this was helpful and I didn't completely miss the point. Use a well-documented LZ4 compression format and remove redundant LZ4HC option -- Key: KAFKA-1493 URL: https://issues.apache.org/jira/browse/KAFKA-1493 Project: Kafka Issue Type: Improvement Affects Versions: 0.8.2 Reporter: James Oliver Assignee: James Oliver Priority: Blocker Fix For: 0.8.2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
