[GitHub] kafka pull request #4348: MINOR: Fix race condition in Streams EOS system te...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4348 MINOR: Fix race condition in Streams EOS system test We should start the process only within the `with` block, otherwise the bytes parameter would cause a race condition that result in false alarms of system test failures. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-fix-eos-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4348.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4348 commit 628b345c61017abaf3e51c3a753a0c2b3418a0ce Author: Guozhang Wang <wangguoz@...> Date: 2017-12-21T01:56:29Z Fix race condition ---
[GitHub] kafka-site issue #113: HOTFIX: broken /10 docs
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/113 Merged to asf-site. ---
[GitHub] kafka-site issue #112: Migrate Streams Dev Guide content to AK
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/112 LGTM. Merged to asf-site. ---
[GitHub] kafka pull request #4338: [WIP] MINOR: web docs for KIP-220
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4338 [WIP] MINOR: web docs for KIP-220 1. added functions for KafkaStreams and KafkaClientSupplier. 2. added prefix for admin client in StreamsConfig. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K6150-doc-changes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4338 commit ea22d410f9b9b1c28c6c3a30486f0a4f9b5a07d7 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-12-18T20:08:39Z docs for KIP-220 ---
[GitHub] kafka pull request #4331: [WIP] MINOR: Improve Join integration test coverag...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4331 [WIP] MINOR: Improve Join integration test coverage, PART I 1. Merge `KStreamRepartitionJoinTest.java` into `JoinIntegrationTest.java` with augmented stream-stream join. 2. Make the JoinIntegrationTest `Parameterized` with and without caching. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-join-integration-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4331.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4331 commit c1e00d0c5717a23cdf7252e48dcd6e49dd0ad810 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-30T01:01:17Z ingested stream stream join commit 71f2625746d4ce9d6297b8adc84d3df4eac435fb Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-12-15T22:22:07Z Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into KMinor-join-integration-tests ---
[GitHub] kafka-site issue #111: KAFKA-6334: fix typo in backwards compatibility note
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/111 LGTM. Merged to asf-site. ---
[GitHub] kafka pull request #4315: KAFKA-6150: KIP-204 part III; Change repartition t...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4315 KAFKA-6150: KIP-204 part III; Change repartition topic segment size and ms 1. Create default internal topic configs in StreamsConfig, especially for repartition topics change the segment size and time to smaller value. 2. Consolidate the default internal topic settings to InternalTopicManager and simplify InternalTopicConfig correspondingly. 3. Add an integration test for purging data. 4. MINOR: change TopologyBuilderException to IllegalStateException in StreamPartitionAssignor (part of https://issues.apache.org/jira/browse/KAFKA-5660). Here are a few public facing APIs that get added: 1. AbstractConfig#originalsWithPrefix(String prefix, boolean strip). 2. KafkaStreams constructor with Time object for convienent mocking in tests. Will update KIP-204 accordingly if people re-votes these changes. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K6150-segment-size Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4315.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4315 commit 7f394817cc0a7a5606ee2cc1bae0d3e271c307b9 Author: Matthias J. Sax <matth...@confluent.io> Date: 2017-11-21T02:17:57Z KAFKA-4857: Replace StreamsKafkaClient with AdminClient in Kafka Streams commit 49e832c297b93c432cdbffddca5635dbdecfc565 Author: Matthias J. Sax <matth...@confluent.io> Date: 2017-12-04T19:36:29Z Github comments - fixed parameter passing for `retries` - added couple of tests commit ad7ccde56910a0b52825470fdd6a54339358445d Author: Matthias J. Sax <matth...@confluent.io> Date: 2017-12-04T21:01:46Z rebased commit bfd3937666ecc82e7584083fd1f17d0bacba8962 Author: Matthias J. Sax <matth...@confluent.io> Date: 2017-12-05T05:38:36Z fixed system test error message commit 81b17ba0b60e9d11cd6a23d4f91786d499869393 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-12-07T02:53:33Z Merge branch 'kafka-4857-admit-client' of https://github.com/mjsax/kafka into K6150-segment-size commit 3c286b94e2d698ab41c90668b2b9ada8212ab2d8 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-12-08T00:14:04Z add internal topic types commit 6c223b89c0b81769930c86390de7a8f745e71780 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-12-08T02:30:12Z use default props for internal topics commit 177d11a400f1574f7c1fbac1e233493e3d43b944 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-12-11T17:36:11Z Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into K6150-segment-size commit ef57e80633bd39335bc184bed59d55179d18b69b Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-12-12T01:20:55Z add integration test for purging repartition topic ---
[GitHub] kafka pull request #4270: [WIP] KAFKA-6150: Purge repartition topics
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4270 [WIP] KAFKA-6150: Purge repartition topics *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K6150-purge-repartition-topics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4270.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4270 ---
[GitHub] kafka pull request #4268: KAFKA-6274: Use topic plus dash as prefix of auto-...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4268 KAFKA-6274: Use topic plus dash as prefix of auto-generated state store names Use `topic-` as the prefix of the auto-generated state store name. Also add a unit test for this functionality. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K6274-table-source-store-name Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4268.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4268 ---
[GitHub] kafka-site issue #109: Added secondary nav to streams sub-page
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/109 LGTM. Merged to asf-site. ---
[GitHub] kafka pull request #4224: [WIP] KAFKA-6170; KIP-220 Part 2: Break dependency...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4224 [WIP] KAFKA-6170; KIP-220 Part 2: Break dependency of Assignor on StreamThread This refactoring is discussed in https://github.com/apache/kafka/pull/3624#discussion_r132614639. More specifically: 1. Moved the access of `StreamThread` in `StreamPartitionAssignor` to `TaskManager`, removed any fields stored in `StreamThread` such as `processId` and `clientId` that are only to be used in `StreamPartitionAssignor`, and pass them to `TaskManager` if necessary. 2. Moved any in-memory states, `metadataWithInternalTopics`, `partitionsByHostState`, `standbyTasks`, `activeTasks` to `TaskManager` so that `StreamPartitionAssignor` becomes a stateless thin layer that access TaskManager directly. 3. Remove the reference of `StreamPartitionAssignor` in `StreamThread`, instead consolidate all related functionalities such as `cachedTasksIds ` in `TaskManager` which could be retrieved by the `StreamThread` and the `StreamPartitionAssignor` directly. 4. Finally, removed the two interfaces used for `StreamThread` and `StreamPartitionAssignor`. 5. Some minor fixes on logPrefixes, etc. Future work: when replacing the StreamsKafkaClient, we would let `StreamPartitionAssignor` to retrieve it from `TaskManager` directly, and also its closing call do not need to be called (`KafkaStreams` will be responsible for closing it). ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K6170-refactor-assignor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4224.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4224 commit 6c5b20ea34323a101118286e9282568f428b8e34 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-07T00:14:53Z add AdminClient commit fc908e06d80816db1e28e0f1d05e1d10fa1d0379 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-13T22:13:37Z Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into K6170-admin-client commit d1be566efe65c71c068a6e948c59f7bd980d6bd8 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-14T21:41:20Z refactor thread / assignor dependency commit d1a778fff0cbaeb8ea00421d89fcd50552b93eba Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-14T21:44:09Z revert TaskManager APIs commit f9e5fbff4c18764bc64793dc9b5c376d956cd67c Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-15T02:04:55Z move logic of assignor to task manager commit bfd08c45cab067035d4980d85d6e7ff9cd5a6e36 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-15T02:16:37Z minor fix commit f95dc0bb9849356ab721c4f7e042a813fcb34330 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-15T02:22:34Z extract delegating restore listener commit 10ceff07c23ea555bd25ea74baa4b995ea0f3a83 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-15T02:26:59Z add admin configs in streams config commit 41dc2b0790866bb5f8325191102622bdbd5fbe23 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-15T19:39:29Z add AdminClient to stream thread commit 3592206eb7c06313a7f553242329f6eb578b4cbd Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-15T22:49:39Z Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into K6170-admin-client commit 03e64d0bb4a6581d4105f9faa4d95cd6e20f45f3 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-15T23:49:16Z add admin prefix commit 035b3a6a04025d397fec8abb535d9b148f722792 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-16T00:07:19Z merge from K6170-admin-client ---
[GitHub] kafka pull request #4211: [WIP] KAFKA-6170: Add AdminClient to Streams
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4211 [WIP] KAFKA-6170: Add AdminClient to Streams 1. Add The AdminClient into Kafka Streams, which is shared among all the threads. 2. Refactored mutual dependency between StreamPartitionAssignor / StreamTread to TaskManager as discussed in https://github.com/apache/kafka/pull/3624#discussion_r132614639. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K6170-admin-client Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4211 commit 6c5b20ea34323a101118286e9282568f428b8e34 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-07T00:14:53Z add AdminClient commit fc908e06d80816db1e28e0f1d05e1d10fa1d0379 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-13T22:13:37Z Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into K6170-admin-client commit d1be566efe65c71c068a6e948c59f7bd980d6bd8 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-14T21:41:20Z refactor thread / assignor dependency commit d1a778fff0cbaeb8ea00421d89fcd50552b93eba Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-14T21:44:09Z revert TaskManager APIs ---
[GitHub] kafka pull request #4208: MINOR: Not enough replica exception should never h...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4208 MINOR: Not enough replica exception should never happen for delete records When reviewing https://github.com/apache/kafka/pull/4132, I felt that NOT_ENOUGH_REPLICAS should never happen actually. Hence proposing to remove it from the listed error code as well in the broker-side capture clause. Testing added in 4132 should have been sufficient. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-delete-records-error-code Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4208 commit 86b8fe19fe551962bf5cf54c8c98b623972d6242 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-13T19:00:08Z Not enough replica exception should never happen for delete records ---
[GitHub] kafka pull request #4186: [WIP] KAFKA-6179: Clear min timestamp tracker upon...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4186 [WIP] KAFKA-6179: Clear min timestamp tracker upon partition queue cleanup You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K6179-cleanup-timestamp-tracker-on-clear Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4186.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4186 commit c92eaa566334e8fe6f20a37f7196db807c4b01b2 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-07T01:46:14Z clear min timestamp tracker upon partition queue cleanup ---
[GitHub] kafka pull request #4085: HOTFIX: poll with zero millis during restoration
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/4085 ---
[GitHub] kafka pull request #4130: HOTFIX: Remove sysout logging
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/4130 ---
[GitHub] kafka pull request #4184: MINOR: Remove FanoutIntegrationTest.java
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4184 MINOR: Remove FanoutIntegrationTest.java This test has been completely subsumed by the coverage of reset integration test, and hence can be removed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-remove-fanout-integration Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4184.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4184 commit 9e189664fb9c1ab882403f4174393e8f2aa66047 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-06T22:40:13Z Remove FanoutIntegrationTest.java ---
[GitHub] kafka pull request #4171: MINOR: Change version format in release notes pyth...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4171 MINOR: Change version format in release notes python code @ijuma @ewencp You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-update-releasepy Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4171 commit 93e8e4abdf0f98db4d05fd623d3a47ed2dbbb7ff Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-02T19:22:23Z Change minor version format ---
[GitHub] kafka pull request #4169: MINOR: Update docs for new version
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4169 MINOR: Update docs for new version 1. Update the Streams hello world examples with the new API. 2. Update the version references in various places. 3. Update version templates to 1.1.x. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMINOR-streams-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4169.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4169 commit 39f61834b442593806b9be674952d9129d727fe9 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-01T23:24:18Z use template version data ---
[GitHub] kafka-site issue #107: MINOR: Follow-up Update on 1.0.0 release
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/107 Merged to asf-site ---
[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/107#discussion_r148394602 --- Diff: 10/documentation.html --- @@ -69,15 +69,15 @@ 8. Kafka Connect -9. Kafka Streams +9. Kafka Streams Kafka Streams is a client library for processing and analyzing data stored in Kafka. It builds upon important stream processing concepts such as properly distinguishing between event time and processing time, windowing support, exactly-once processing semantics and simple yet efficient management of application state. Kafka Streams has a low barrier to entry: You can quickly write and run a small-scale proof-of-concept on a single machine; and you only need to run additional instances of your application on multiple machines to scale up to high-volume production workloads. Kafka Streams transparently handles the load balancing of multiple instances of the same application by leveraging Kafka's parallelism model. -Learn More about Kafka Streams read this Section. +Learn More about Kafka Streams read this Section. --- End diff -- Just updated that part while looking on diff files :) ---
[GitHub] kafka-site issue #107: MINOR: Follow-up Update on 1.0.0 release
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/107 @ijuma addressed your comments. Will submit another PR for kafka repo for the same necessary changes. ---
[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/107#discussion_r148321476 --- Diff: downloads.html --- @@ -9,48 +9,75 @@ You can verify your download by following these http://www.apache.org/info/verification.html;>procedures and using these http://kafka.apache.org/KEYS;>KEYS. +1.0.0 - 1.0.0 - - - Released November 1, 2017 - - - https://dist.apache.org/repos/dist/release/kafka/1.0.0/RELEASE_NOTES.html;>Release Notes - - - Source download: https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka-1.0.0-src.tgz;>kafka-1.0.0-src.tgz (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.asc;>asc, https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.sha512;>sha512) - - - Binary downloads: - - Scala 2.11 - https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka_2.11-1.0.0.tgz;>kafka_2.11-1.0.0.tgz (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.11-1.0.0.tgz.asc;>asc, https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.11-1.0.0.tgz.sha512;>sha512) - Scala 2.12 - https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka_2.12-1.0.0.tgz;>kafka_2.12-1.0.0.tgz (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.12-1.0.0.tgz.asc;>asc, https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka_2.12-1.0.0.tgz.sha512;>sha512) - - We build for multiple versions of Scala. This only matters if you are using Scala and you want a version built for the same Scala version you use. Otherwise any version should work (2.11 is recommended). - - + + +Released November 1, 2017 + + +Source download: https://www.apache.org/dyn/closer.cgi?path=/kafka/1.0.0/kafka-1.0.0-src.tgz;>kafka-1.0.0-src.tgz (https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.asc;>asc, https://dist.apache.org/repos/dist/release/kafka/1.0.0/kafka-1.0.0-src.tgz.md5;>md5) --- End diff -- ack. ---
[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/107#discussion_r148321409 --- Diff: 10/documentation.html --- @@ -0,0 +1,83 @@ + + +<!--#include virtual="js/templateData.js" --> + + + + + + + + + +Documentation +Kafka 0.11.0 Documentation +Prior releases: 0.7.x, 0.8.0, 0.8.1.X, 0.8.2.X, 0.9.0.X, 0.10.0.X, 0.10.1.X, 0.10.2.X. --- End diff -- ack. ---
[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka-site/pull/107 MINOR: Follow-up Update on 1.0.0 release 1. Replaced 100 folder with 10 folder. 2. Update Streams/index.html file with a couple follow-up PRs that went in post RC4. 3. Add the paragraph that Sally and Jun suggested in release notes. @ijuma @rajinisivaram You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka-site KMinor-1.0-release-update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/107.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #107 commit 89a75e4c3067b72e6868128568a259162c8b2197 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-01T15:48:48Z update pages commit 17b4e1947c78af7b1eee57a66a8c7de5b394d11e Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-01T15:59:44Z add 10 folder commit fd40020e32c3899f32824e366a2942e54abd7132 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-11-01T16:00:13Z remove 100 folder ---
[GitHub] kafka-site issue #105: Adding Trivago logo to streams page
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/105 LGTM. Merged to asf-site. ---
[GitHub] kafka-site pull request #105: Adding Trivago logo to streams page
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/105#discussion_r147801292 --- Diff: 0110/streams/index.html --- @@ -17,20 +17,20 @@
[GitHub] kafka-site issue #104: Replace link
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/104 Merged to asf-site. ---
[GitHub] kafka-site issue #104: Replace link
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/104 LGTM. Could you submit a PR for changes in ` 0110/streams` as well in `kafka` repo? ---
[GitHub] kafka-site pull request #104: Replace link
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/104#discussion_r147261460 --- Diff: powered-by.html --- @@ -2,453 +2,452 @@
[GitHub] kafka pull request #4136: KAFKA-6100: Down-grade RocksDB to 5.7.3
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4136 KAFKA-6100: Down-grade RocksDB to 5.7.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K6100-rocksdb-580-regression Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4136.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4136 commit 92b5797bbbe0cec7faddd000a8bfee715a3f0df7 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-26T00:16:08Z Downgrade rocksDB 5.8.0 to 5.7.3 ---
[GitHub] kafka pull request #4130: HOTFIX: Remove sysout logging
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4130 HOTFIX: Remove sysout logging You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-0110-remove-logging Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4130.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4130 ---
[GitHub] kafka-site issue #103: MINOR: Fix typo in title
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/103 LGTM. Merged to `asf-site`. ---
[GitHub] kafka-site issue #103: MINOR: Fix typo in title
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/103 Could you submit a patch to `kafka` repo under `docs/streams/index.html` as well? ---
[GitHub] kafka pull request #4085: HOTFIX: poll with zero millis during restoration
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/4085 ---
[GitHub] kafka pull request #4085: HOTFIX: poll with zero millis during restoration
GitHub user guozhangwang reopened a pull request: https://github.com/apache/kafka/pull/4085 HOTFIX: poll with zero millis during restoration Mirror of #4096 for 0.11.01. During the restoration phase, when thread state is still in PARTITION_ASSIGNED not RUNNING yet, call poll() on the normal consumer with 0 millisecond timeout, to unblock the restoration of other tasks as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-0110-restore-only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4085.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4085 commit 941a567f0388b4c74d095c444165e4315ff5b9df Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-17T20:29:15Z poll with zero millis during restoration commit 01af809ba31857f6f68e19821d25d3cef5dd62c0 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-12T21:18:46Z dummy commit 6c7b512cf8fe93661aea55c2c0622b2064be5beb Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-19T05:19:02Z github comments; fixes for double check commit 2d26b4d64f6dce0f01a06c379af8c5823a8ed5b6 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-23T19:49:22Z rebase from 0.11.0 commit 9b41200e6565af233389d2d7172348a881912cd3 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-23T19:53:01Z github comments commit c00143a42ae7cd0f460bd1254b7b65105c221e77 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-23T20:32:00Z minor fixes post rebasing commit d11b0373a8663705979d2e58681a81777657d90a Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-23T21:28:24Z one minor fix commit 379a727509a08ab0bf69e36af432c664acd355ca Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-23T21:30:12Z cherry-pick fix from trunk ---
[GitHub] kafka-site issue #100: MINOR: Pinterest link correction
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/100 LGTM. Merged to asf-site. ---
[GitHub] kafka pull request #4096: HOTFIX: Poll with zero milliseconds during restora...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4096 HOTFIX: Poll with zero milliseconds during restoration phase 1. After the poll call, re-check if the state has been changed or not; if yes, initialize the tasks again. 2. Cherry-pick the flaky test fix from #4095 3. Minor log4j improvements. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-restore-only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4096.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4096 ---
[GitHub] kafka pull request #4086: [WIP] KAFKA-6085: Pause all partitions before task...
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/4086 ---
[GitHub] kafka pull request #4086: [WIP] KAFKA-6085: Pause all partitions before task...
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/4086 ---
[GitHub] kafka pull request #4086: [WIP] KAFKA-6085: Pause all partitions before task...
GitHub user guozhangwang reopened a pull request: https://github.com/apache/kafka/pull/4086 [WIP] KAFKA-6085: Pause all partitions before tasks are initialized Mirror of #4085 against trunk. This PR contains two fixes (one major and one minor): Major: on rebalance, pause all partitions instead of the partitions for tasks with state stores only, so that no records will be returned in the same `pollRecords()` call. Minor: during the restoration phase, when thread state is still PARTITION_ASSIGNED, call consumer.poll with hard-coded pollMs = 0. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-restore-only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4086.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4086 commit 62bf4784779f7379e849289c4456363f352cb850 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-12T21:18:46Z dummy commit 5726e39cba8a79e6858e8b932c5116b60f2ae314 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-12T21:18:46Z dummy fix issues Remove debugging information commit 8214a3ee340791eb18f7e5fa77f2510470cf977a Author: Matthias J. Sax <matth...@confluent.io> Date: 2017-10-17T00:38:31Z MINOR: update exception message for KIP-120 Author: Matthias J. Sax <matth...@confluent.io> Reviewers: Guozhang Wang <wangg...@gmail.com> Closes #4078 from mjsax/hotfix-streams commit 637b76342801cf4a32c9e65aa89bfe0bf76c24a7 Author: Jason Gustafson <ja...@confluent.io> Date: 2017-10-17T00:49:35Z MINOR: A few javadoc fixes Author: Jason Gustafson <ja...@confluent.io> Reviewers: Guozhang Wang <wangg...@gmail.com> Closes #4076 from hachikuji/javadoc-fixes commit f57c505f6e714b891a6d30e5501b463f14316708 Author: Damian Guy <damian@gmail.com> Date: 2017-10-17T01:01:32Z MINOR: add equals to SessionWindows Author: Damian Guy <damian@gmail.com> Reviewers: Guozhang Wang <wangg...@gmail.com>, Matthias J. Sax<matth...@confluent.io>, Bill Bejeck <b...@confluent.io> Closes #4074 from dguy/minor-session-window-equals commit 2f1dd0d4da24eee352f20436902d825d7851c45b Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-18T01:27:35Z normal poll with zero during restoration commit 043f28ac89b50f9145ac719449f03a427376dcde Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-19T04:58:36Z recheck state change ---
[GitHub] kafka pull request #4095: KAFKA-5140: Fix reset integration test
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4095 KAFKA-5140: Fix reset integration test The MockTime was incorrectly used across multiple test methods within the class, as a class rule. Instead we set it on each test case; also remove the scala MockTime dependency. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-reset-integration-test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4095.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4095 commit 1aac7bec94de5b2d26d72bade9e654192f18d576 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-12T21:18:46Z dummy commit 83f176c26dd092f924e2d273a4fa763ce5d7cdcf Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-19T04:44:18Z fix issues ---
[GitHub] kafka-site pull request #100: MINOR: Pinterest link correction
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/100#discussion_r145530925 --- Diff: 0110/streams/index.html --- @@ -82,26 +82,8 @@ The easiest way to write mission-critical real-time ap Streams API use cases - - https://linecorp.com/; target="_blank" class="grid__logo__link"> - - - https://engineering.linecorp.com/en/blog/detail/80; target="_blank">LINE uses Apache Kafka as a central datahub for our services to communicate to one another. Hundreds of billions of messages are produced daily and are used to execute various business logic, threat detection, search indexing and data analysis. LINE leverages Kafka Streams to reliably transform and filter topics enabling sub topics consumers can efficiently consume, meanwhile retaining easy maintainability thanks to its sophisticated yet minimal code base. - - - - - http://www.zalando.com; target="_blank" class="grid__logo__link"> - - - As the leading online fashion retailer in Europe, Zalando uses Kafka as an ESB (Enterprise Service Bus), which helps us in transitioning from a monolithic to a micro services architecture. Using Kafka for processing - https://kafka-summit.org/sessions/using-kstreams-ktables-calculate-real-time-domain-rankings/; target='blank'> event streams enables our technical team to do near-real time business intelligence. - - - - - https://www.nytimes.com; target="_blank" class="grid__logo__link"> + https://www.confluent.io/blog/publishing-apache-kafka-new-york-times/; target="_blank" class="grid__logo__link"> --- End diff -- Maybe better to use this url instead as it is from the original nyt website? https://open.nytimes.com/publishing-with-apache-kafka-at-the-new-york-times-7f0e3b7d2077 ---
[GitHub] kafka-site pull request #100: MINOR: Pinterest link correction
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/100#discussion_r145531542 --- Diff: 0110/streams/index.html --- @@ -111,23 +93,41 @@ Streams API use cases - https://www.nytimes.com; target="_blank" class="grid__logo__link"> + https://medium.com/@Pinterest_Engineering/using-kafka-streams-api-for-predictive-budgeting-9f58d206c996; target="_blank" class="grid__logo__link"> --- End diff -- Hmm.. why we need to ref links for pinterest, with one for its logo and the content as well while for others we just use one ref link for the logo only? ---
[GitHub] kafka pull request #4086: HOTFIX: Normal poll with zero during restoration
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4086 HOTFIX: Normal poll with zero during restoration Mirror of #4085 against trunk. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-restore-only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4086.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4086 commit 9f4a0e9e4b88929901b26d8599b6f5fbecac Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-18T01:27:35Z normal poll with zero during restoration ---
[GitHub] kafka pull request #4085: HOTFIX: poll with zero millis during restoration
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4085 HOTFIX: poll with zero millis during restoration You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-0110-restore-only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4085.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4085 commit 941a567f0388b4c74d095c444165e4315ff5b9df Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-17T20:29:15Z poll with zero millis during restoration ---
[GitHub] kafka-site issue #98: Added Pinterest logo to streams page
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/98 LGTM. Merged to asf-site. ---
[GitHub] kafka pull request #4071: MINOR: a few web doc and javadoc fixes
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4071 MINOR: a few web doc and javadoc fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-javadoc-gaps Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4071.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4071 commit 8a962a25dff7d6388d64174c23e190c157ace199 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-13T05:47:18Z made a first pass ---
[GitHub] kafka-site issue #96: Fixed video paramas
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/96 LGTM. Merged to `asf-site`. ---
[GitHub] kafka-site pull request #96: Fixed video paramas
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/96#discussion_r144150407 --- Diff: css/styles.css --- @@ -1074,7 +1074,6 @@ nav .btn { .sticky-top { white-space: nowrap; overflow-y: hidden; -overflow-x: scroll; --- End diff -- Are these changes on this file intentional? I'm asking because we already have lots of edits on this commit: https://github.com/apache/kafka-site/pull/92/files And I'm just double checking to see if any of them were unintentionally reverted in this PR. ---
[GitHub] kafka pull request #4054: HOTFIX: Updates on release.py before 1.0.0
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4054 HOTFIX: Updates on release.py before 1.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-pre-1.0-release Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4054.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4054 commit d4198caea7806b5866a56e75b613569e0fabfb4f Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-10T22:27:40Z minor edits ---
[GitHub] kafka-site issue #95: Change apache-kafka image permission as image not appe...
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/95 LGTM. Merged to asf-site. ---
[GitHub] kafka-site issue #95: Change apache-kafka image permission as image not appe...
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/95 @manjuapu I cannot tell what's changed in the image, could you point it out for me? ---
[GitHub] kafka-site issue #92: Redesign of Streams page - includes video & customer l...
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/92 Merged to asf-site. ---
[GitHub] kafka-site pull request #92: Redesign of Streams page - includes video & cus...
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/92#discussion_r143525624 --- Diff: 0110/streams/index.html --- @@ -1,275 +1,311 @@ - -<!--#include virtual="../js/templateData.js" --> - + Licensed to the Apache Software Foundation (ASF) under one or more --- End diff -- I need to point out that if we made a new release from 0.11.0 and do the copy-paste from `kafka` repo these changes will be auto-reverted as well. Do you want to submit a corresponding PR for `kafka` against 0.11.0 branch to keep the docs in-sync? ---
[GitHub] kafka pull request #4036: MINOR: KIP-161 upgrade docs change
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4036 MINOR: KIP-161 upgrade docs change You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-kip-161-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4036.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4036 commit 12712180da63faf11d74ecd7a90977519bbbedb8 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-06T23:24:57Z kip-161 docs change ---
[GitHub] kafka pull request #4031: MINOR: log4j improvements on assigned tasks and st...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/4031 MINOR: log4j improvements on assigned tasks and store changelog reader You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-assigned-task-log4j Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4031.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4031 commit 6e29bc79de539163858c6594c6d3fae35f80d7be Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-10-05T23:49:27Z log4j improvements ---
[GitHub] kafka pull request #3607: [DO NOT MERGE] Existing StreamThread exception han...
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/3607 ---
[GitHub] kafka-site issue #77: MINOR: Update verbiage on landing page https://kafka.a...
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/77 LGTM. Merged to asf-site. ---
[GitHub] kafka-site issue #85: Adding New York logo to powered-by and Streams page
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/85 Merged to trunk with some minor tweaks. ---
[GitHub] kafka-site pull request #85: Adding New York logo to powered-by and Streams ...
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/85#discussion_r140623361 --- Diff: 0110/streams/index.html --- @@ -201,39 +201,41 @@ The easiest way to write mission-critical real-tim -See how Kafka Streams is being used + See how Kafka Streams is being used --- End diff -- This indentation seems unintentional. ---
[GitHub] kafka-site pull request #85: Adding New York logo to powered-by and Streams ...
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/85#discussion_r140623385 --- Diff: 0110/streams/index.html --- @@ -201,39 +201,41 @@ The easiest way to write mission-critical real-tim -See how Kafka Streams is being used + See how Kafka Streams is being used + + + The New York Times uses Kafka and the Kafka Streams API to store and distribute, in real-time, published content to the various applications and systems that make it available to the readers. --- End diff -- nit: ..Apache Kafka and Kafka Streams... ---
[GitHub] kafka-site issue #84: Adding LINE logo to Streams page
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/84 LGTM Merged to trunk. ---
[GitHub] kafka-site issue #83: Line logo to Powered-by page + minor edits to styles +...
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/83 LGTM. Merged to asf-site. ---
[GitHub] kafka-site issue #82: Adding minor style changes
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/82 @manjuapu Only the PR submitter can close her own PRs unfortunately. ---
[GitHub] kafka-site issue #79: Adding Customer section to Streams page
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/79 Some meta comments: 1. The `.DS_Store` should not be included. 2. As @ewencp mentioned, these files under `0110/` should be in `kafka` repo as well. You would need to file a separate PR for `kafka` repo adding these files, against trunk. The committer who merges this PR will also cherry-pick it to `0.11.0` branch. So that when 1.0.0 web docs are up these files will be reflected as well. 3. For `css/styles.css` it is only in `kafka-site` repo, so it is good as is. ---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/77#discussion_r139275915 --- Diff: index.html --- @@ -7,17 +7,17 @@ Publish subscribe to streams of data like a messaging system - Learn more + Learn about APIs --- End diff -- `Learn about producer and consumer`? ---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/77#discussion_r139275946 --- Diff: index.html --- @@ -7,17 +7,17 @@ Publish subscribe to streams of data like a messaging system - Learn more + Learn about APIs Process streams of data efficiently and in real time - Learn more + Learn about Streams --- End diff -- `Learn about Streams API`? ---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/77#discussion_r139275996 --- Diff: index.html --- @@ -7,17 +7,17 @@ Publish subscribe to streams of data like a messaging system - Learn more + Learn about APIs Process streams of data efficiently and in real time - Learn more + Learn about Streams Store streams of data safely in a distributed replicated cluster - Learn more + Learn about Storage --- End diff -- `Learn about storage architecture design`? ---
[GitHub] kafka-site pull request #77: MINOR: Add streams child topics to left-hand na...
Github user guozhangwang commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/77#discussion_r139275998 --- Diff: includes/_nav.htm --- @@ -11,6 +11,12 @@ getting started APIs kafka streams + --- End diff -- Could you paste a screenshot of this change? ---
[GitHub] kafka pull request #3850: MINOR: Un-hide the tutorial buttons on web docs
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3850 MINOR: Un-hide the tutorial buttons on web docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-unhide-button Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3850.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3850 commit 0f0ed8659039dbd2a02e70a182b17e22d739c7d4 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-09-13T17:52:03Z unhide the tutorial buttons ---
[GitHub] kafka pull request #3819: [DO NOT MERGE] KAFKA-5576: RocksDB upgrade to 5.7....
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3819 [DO NOT MERGE] KAFKA-5576: RocksDB upgrade to 5.7.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-rocksDB-573 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3819.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3819 commit 8ea15b07b47758bda16af343ba13555c6c5642b4 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-09-08T21:09:06Z upgrade to 5.7.3 ---
[GitHub] kafka pull request #3806: KAFKA-5797: Handle metadata not available in store...
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/3806 ---
[GitHub] kafka pull request #3796: MINOR: KIP-138 renaming of string names
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3796 MINOR: KIP-138 renaming of string names You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka kip-138-minor-renames Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3796.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3796 commit 947ea33f11ec5b40b2f9669570c76310e2c00fbd Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-30T18:17:11Z rename system-time to wall-clock-time commit 87b4e7b4345f647bd8562e9552ba192ee3744c47 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-09-05T23:56:42Z Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into kip-138-minor-renames ---
[GitHub] kafka pull request #3771: MINOR: logging improvements
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/3771 ---
[GitHub] kafka-site issue #73: Add coding guidelines for Streams API
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/73 LGTM. Merged to `asf-site`. ---
[GitHub] kafka pull request #3771: MINOR: logging improvements
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3771 MINOR: logging improvements This is a manual cherry-pick of https://github.com/apache/kafka/pull/3769 for 0.11.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-logging-improvements Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3771.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3771 commit cb208f653c24fb270caff13b0f242b26d92765e1 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-31T17:45:10Z logging improvements commit 4607e2235d65208ca0ea829a113ca358e7531a41 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-31T17:47:16Z unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3769: MINOR: Log encountered exception during rebalance
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3769 MINOR: Log encountered exception during rebalance Some other minor changes: 1. Do not throw the exception form callback as it would only be swallowed by consumer coordinator; remembering it and re-throw in the next loop is good enough. 2. Change Creating to Defining in Stores to avoid confusions that the stores have already been successfully created at that time. 3. Do not need unAssignChangeLogPartitions as the restore consumer will be unassigned already inside changelog reader. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-logging-before-throwing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3769.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3769 commit 2a83edbfd14cce427a79f94924b56e54cd97c03d Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-31T03:17:28Z minor fixes commit b302ab47911822bd3e3056254caade73057896d5 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-31T17:02:32Z unit test fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site issue #72: Jason and Becket are PMC members
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/72 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3757: KAFKA-5379 follow up: reduce redundant mock proces...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3757 KAFKA-5379 follow up: reduce redundant mock processor context You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K5379-follow-up Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3757.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3757 commit c750932d05559c3e7d28c64a1a334db680cfe77f Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-29T20:59:44Z remove two test processor context into mock processor context commit d2fc3853ff3caa6f10e9932e90b995ff5a4807ea Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-29T21:27:28Z some reverts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3748: KAFKA-5797: Delay checking of partition existence ...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3748 KAFKA-5797: Delay checking of partition existence in StoreChangelogReader 1. Remove timeout-based validatePartitionExists from StoreChangelogReader; instead only try to refresh metadata once after all tasks have been created and their topology initialized (hence all stores have been registered). 2. Add the logic to refresh partition metadata at the end of initialization if some restorers needing initialization cannot find their changelogs, hoping that in the next run loop these stores can find their changelogs. As a result, we would not ever call `consumer#partitionsFor` any more, but only `consumer#listTopics`; so the only blocking calls left are `listTopics` and `endOffsets, and we always capture timeout exceptions around these two calls, and delay to retry in the next run loop after refreshing the metadata. By doing this we can also reduce the number of request round trips between consumer and brokers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K5797-handle-metadata-available Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3748.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3748 commit a1cbd208007a0a5e73ff917987a457662554c04c Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-27T03:47:01Z handlg timeout exception commit 2348799f54722c67f9837133a939e3f982b543d9 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-27T05:25:21Z fix unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3746: MINOR: Fix doc typos and grammar
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3746 MINOR: Fix doc typos and grammar This is contributed by mihbor on various doc fixes including: https://github.com/apache/kafka/pull/3224 https://github.com/apache/kafka/pull/3226 https://github.com/apache/kafka/pull/3229 You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-doc-typos Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3746.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3746 commit 0afd8f01e33c7d5454582d5aeb0224cf456d0175 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-26T23:29:55Z fix doc typos and grammar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site issue #63: Do not use hyphens in wrapping property names in table...
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/63 Merged to asf-site. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site issue #56: Update commiter page to indicate that Gwen is a PMC me...
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/56 @wushujames This is already resolved, could you close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3733: [WIP] MINOR: KIP-160 docs
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3733 [WIP] MINOR: KIP-160 docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-kip160-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3733.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3733 commit c13b3161cee31da24e301fe5399eaf79a01a924e Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-24T23:54:06Z doc changes for KIP-138 commit 265a82fe5fd1f7f26f7e5e012dd9dacb61aaea5d Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-25T00:16:41Z kip 160 docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3732: MINOR: doc changes for KIP-138
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3732 MINOR: doc changes for KIP-138 1. Core concepts (added the stream time definition), upgrade guide and developer guide. 2. Related Java docs changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-kip138-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3732.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3732 commit c13b3161cee31da24e301fe5399eaf79a01a924e Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-24T23:54:06Z doc changes for KIP-138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3720: [DO NOT MERGE] KAFKA-3705: non-key joins
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3720 [DO NOT MERGE] KAFKA-3705: non-key joins This is just for reviewing the diff easily to see how it is done by @jfillipiak. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Kaiserchen/kafka KAFKA3705 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3720.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3720 commit 3da2b8f787a5d30dee2de71cf0f125ab3e57d89b Author: jfilipiak <jan.filip...@trivago.com> Date: 2017-06-30T09:00:39Z onetomany join signature to show on mailing list commit cc9c6f4a68170fb829adb46a6de40ec0fc75716f Author: jfilipiak <jan.filip...@trivago.com> Date: 2017-07-12T14:49:43Z stores commit 807e90aac82d7659310ce92066ac1df6e339068a Author: jfilipiak <jan.filip...@trivago.com> Date: 2017-07-26T06:06:58Z just throw in most of the processors, wont build commit 1a6ff7b01ad35dd7eedf4c69aa534043ab1a8eb8 Author: jfilipiak <jan.filip...@trivago.com> Date: 2017-08-18T10:07:34Z random clean up commit ffe9b9496afbdad73bfcb9c014b6045b8ca95e79 Author: jfilipiak <jan.filip...@trivago.com> Date: 2017-08-19T19:22:02Z clean up as much as possible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3713: MINOR: simplify state transition for Kafka Streams...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3713 MINOR: simplify state transition for Kafka Streams and stream threads You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-set-state Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3713.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3713 commit 4da235927f9eebf2442533b44bf017454d372747 Author: Damian Guy <damian@gmail.com> Date: 2017-08-14T17:23:53Z perform state restoration in poll loop commit a7d6f54079ce61ec75bebbae74a2fd55701e9d53 Author: Damian Guy <damian@gmail.com> Date: 2017-08-16T14:18:25Z move commitAll out of StreamThread commit b35f1c7688a88ddadbf8a3e94e6c6132a4b827de Author: Damian Guy <damian@gmail.com> Date: 2017-08-16T14:29:29Z add test for AssignedTasks#commit commit 4e2bf7e0829db11d34e0e8d2df27e21813e3ddcd Author: Damian Guy <damian@gmail.com> Date: 2017-08-16T16:31:08Z move more task oriented code out of stream thread commit e9dae9f386a6b2c415cd2ab16cb012a8884ef320 Author: Damian Guy <damian@gmail.com> Date: 2017-08-17T11:09:07Z address some of guozhang's comments commit 3dbed27e661562e1af78941903f3f443ff1785a2 Author: Damian Guy <damian@gmail.com> Date: 2017-08-17T13:44:42Z move all metric calculations back to StreamThread commit cd3c8a6876cd535da7e33758351094213860952a Author: Damian Guy <damian@gmail.com> Date: 2017-08-17T13:56:37Z move printing of active tasks into TaskManager commit 42785e92cafb792e01cfb91673bb8011fbff4224 Author: Damian Guy <damian@gmail.com> Date: 2017-08-18T08:44:24Z address comments commit 61f984d625562407b1034e284a017c26d4407963 Author: Damian Guy <damian@gmail.com> Date: 2017-08-18T09:19:57Z add state restore integration test commit 34142cf5afbb0bc842f9cd870cb5494e4011d48f Author: Damian Guy <damian@gmail.com> Date: 2017-08-18T13:22:35Z fix checkstyle commit ec177b0c4464830fd9838214852887849aa24b2e Author: Damian Guy <damian@gmail.com> Date: 2017-08-18T08:10:50Z Add MeteredWindowStore and refactor store hierarchy such that Metered is always the outer store. commit 72a510c2e56489d8a843110b9371210edadbdd89 Author: Damian Guy <damian@gmail.com> Date: 2017-08-18T16:58:40Z address comments commit 247f9ab5167bf751be03621facdcefdccf394eca Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-19T17:38:55Z Merge branch 'kafka-5689' of https://github.com/dguy/kafka into KMinor-set-state commit a1858243b9e12085be98f95254bc727fe4b85a8f Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-19T17:44:25Z collapse setState functions commit 6d32a9f7300dd26a2f6cf484e53eabaeb047b5a7 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-21T05:18:47Z cherry-pick state diagrams into trunk commit f4c6fa81701f8a6714b9e0f604afa30cc5808b0b Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-21T17:22:45Z minor fix commit d488b9c35121d7b321937c2e5d9831491b2eb8a2 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-22T18:52:12Z rebase from trunk commit 1570586342afe62a4891ee319e8d4b5b22919bfb Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-22T19:30:32Z minor fix on unit tests commit a5703325d9b711eedf814d0c84c45d6fc6c82781 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-22T20:04:01Z minor fix commit fb5461fd16aa8ca4ca11689ea9f3d03cdc3d8479 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-22T20:25:58Z add log4j entries --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3660: KAFKA-5727: Archetype project for Streams quicksta...
Github user guozhangwang closed the pull request at: https://github.com/apache/kafka/pull/3660 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3687: MINOR: add upgrade section for 1.0.0
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3687 MINOR: add upgrade section for 1.0.0 1. Add upgrade section for 1.0.0, including Streams API changes section. 2. Add metrics name changes section. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-metrics-upgrade-guide Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3687.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3687 commit a2551f463a91fb8688f44cb966177a51a2c88efa Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-17T17:42:29Z add upgrade section for 1.0.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3681: KAFKA-5733: RocksDB bulk load with lower number of...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3681 KAFKA-5733: RocksDB bulk load with lower number of levels. This is to complete Bill's PR on KAFKA-5733, incorporating the suggestion in https://github.com/facebook/rocksdb/issues/2734. Some minor changes: move `open = true` in `openDB`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K5733-rocksdb-bulk-load Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3681.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3681 commit 2cfc54c8e77b840acc0d176cea8eabda4d1c4b03 Author: Bill Bejeck <b...@confluent.io> Date: 2017-08-14T14:46:08Z KAFKA-5733: ensure clean RocksDB directory before setting prepareForBulkload settings commit f468147455c9f8eaf640f2821b7849b7b370968d Author: Bill Bejeck <b...@confluent.io> Date: 2017-08-14T16:57:29Z KAFKA-5733: address comments commit 149634b405cd5d73ec0e27c9a55b16f9971abf1f Author: Bill Bejeck <b...@confluent.io> Date: 2017-08-14T18:20:05Z KAFKA-5733: address additional comments, enforce not opening and closing if not a clean RocksDB dir on restore commit b4cd505b5c5cb9e57df4728414b5194a65d14b1c Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-16T22:17:17Z Merge branch 'KAFKA-5733_rocks_db_throws_more_than_num_levels_on_restore' of https://github.com/bbejeck/kafka into K5733-rocksdb-bulk-load commit d0ada11eb8e97fbd5efdfb4c66160a81970575e4 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-16T22:45:16Z use compactRange to still enable bulk loading commit 08da1f16c8aeb587dd8b1ac7b5192f1ab3395cd7 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-16T23:53:02Z minor fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3660: KAFKA-5727: Archetype project for Streams quicksta...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3660 KAFKA-5727: Archetype project for Streams quickstart and tutorial web docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K5727-archetype-project-0110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3660.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3660 commit b42d0399acef7eb437101c2aef4e6dbd4288f06c Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-11T19:19:28Z KAFKA-5727: Add Streams quickstart tutorial as an archetype project 0. Minor fixes on the existing examples to merge all on a single input topic; also do not use `common.utils.Exit` as it is for internal usage only. 1. Add the archetype project for the quickstart. Steps to try it out: a. `mvn install` on the quickstart directory. b. `mvn archetype:generate \ -DarchetypeGroupId=org.apache.kafka \ -DarchetypeArtifactId=streams-quickstart-java \ -DarchetypeVersion=1.0.0-SNAPSHOT \ -DgroupId=streams-quickstart \ -DartifactId=streams-quickstart \ -Dversion=0.1 \ -Dpackage=StreamsQuickstart \ -DinteractiveMode=false` at any directory to create the project. c. build the streams jar with version `1.0.0-SNAPSHOT` to local maven repository with `./gradlew installAll`; `cd streams-quickstart; mvn clean package` d. create the input / output topics, start the console producer and consumer. e. start the program: `mvn exec:java -Dexec.mainClass=StreamsQuickstart.Pipe/LineSplit/WordCount`. f. type data on console producer and observe data on console consumer. Author: Guozhang Wang <wangg...@gmail.com> Reviewers: Damian Guy <damian@gmail.com>, Bill Bejeck <bbej...@gmail.com>, Ewen Cheslack-Postava <m...@ewencp.org>, Eno Thereska <eno.there...@gmail.com> Closes #3630 from guozhangwang/KMinor-streams-quickstart-tutorial commit 794b844956f52cbda92352bd4c0befcf909af2f2 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-11T19:39:46Z rebase on 0.11.0 branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site issue #70: Add learn more verbiage on ctas
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/70 LGTM. Merged to `asf-site`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3630: MINOR: Add Streams quickstart tutorial as an arche...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3630 MINOR: Add Streams quickstart tutorial as an archetype project 0. Minor fixes on the existing examples to merge all on a single input topic; also do not use `common.utils.Exit` as it is for internal usage only. 1. Add the archetype project for the quickstart. Steps to try it out: a. `mvn install` on the quickstart directory. b. `mvn archetype:generate \ -DarchetypeGroupId=org.apache.kafka \ -DarchetypeArtifactId=streams-quickstart-java \ -DarchetypeVersion=1.0.0-SNAPSHOT \ -DgroupId=streams-quickstart \ -DartifactId=streams-quickstart \ -Dversion=0.1 \ -Dpackage=StreamsQuickstart \ -DinteractiveMode=false` at any directory to create the project. c. `cd streams-quickstart; mvn clean package` d. create the input / output topics, start the console producer and consumer. e. start the program: `mvn exec:java -Dexec.mainClass=StreamsQuickstart.Pipe/LineSplit/WordCount`. f. type data on console producer and observe data on console consumer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-streams-quickstart-tutorial Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3630.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3630 commit 879ba88841e65671116186f9de259b7aea9ad4d1 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-10T01:43:51Z fix a few typos on streams quickstart commit 4dd0c22373adf72798aaecf882e0918e30f65ddb Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-10T16:39:58Z make quickstart more interactive commit a21eecce9a169d0d1580133147339b4396882451 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-17T04:56:37Z Github comments commit 2ac01b11cfff581f71dc29acbf57c2816d27bda4 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-17T16:22:52Z remove extra quote commit bf16c0aea03a5dd166498a2f6984daa3548c75c3 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-20T14:26:40Z add the first example code commit c7da966cf7d08fa029156e025d903ae34c36fb54 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-22T05:58:41Z rebase from trunk commit 64c60bfd77fe700a7456dff959cbcfd2dc4a70c6 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-03T01:32:04Z rebase from trunk commit 010c76fd93cdb29a8ff83c6fb5511e1f20287e59 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-04T18:07:30Z Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into KMinor-streams-quickstart-tutorial commit 1d6b641c3239cd72674a4c21fe44a30289d37d3e Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-04T23:21:18Z add quickstart archetype for streams commit b1371749d3fd8b8fa462a239836a21d45aa91963 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-04T23:23:08Z Merge branch 'trunk' of https://git-wip-us.apache.org/repos/asf/kafka into KMinor-streams-quickstart-tutorial --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3618: KAFKA-5698: Sort processor nodes based on its sub-...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3618 KAFKA-5698: Sort processor nodes based on its sub-tree size 1. Sort processor nodes within a sub-topology by its sub-tree size: nodes with largest sizes are source nodes and hence printed earlier. 2. Minor: start newlines for predecessor and successor. 3. Minor: space between processor nodes and stores / topics; maintain `[]` for the topic names. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K5698-topology-description-sorting Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3618.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3618 commit bce7ea7d448fe15bebc45e4a12de5831c3f727db Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-04T00:43:30Z sort processor nodes based on its sub-tree size --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3617: HOTFIX add the hyper link for storage
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3617 HOTFIX add the hyper link for storage You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-introduction-hyperlink Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3617.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3617 commit beaf37926853e136a9dac0370609ffadefe28586 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-03T21:53:25Z add the hyper link for storage, also a ref link to storage design sections --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site issue #69: Hyperlink 3 callouts on the homepage
Github user guozhangwang commented on the issue: https://github.com/apache/kafka-site/pull/69 LGTM. Merged to asf-site. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3607: [DO NOT MERGE] Existing StreamThread exception han...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3607 [DO NOT MERGE] Existing StreamThread exception handling issues This is for @dguy as a reference while working on the first step of KAFKA-5152, as a list of existing issues that need to be address at stream thread layer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KMinor-stream-thread-exception-handling Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3607.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3607 commit 2d45430191c3dc417992c08454f9c550c1e6bb93 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-25T22:43:18Z handle commit failed exception on stream thread commit 9655791794dfa2623ba9f109676b112779fdceca Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-26T00:39:07Z minor fixes commit 26226d61529007acc0ccc151e6f6675fc9757d34 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-26T01:01:57Z add a bunch of TODOs for exception handling commit 3b054f556364be04d7f83a40b212e0c7facc4a23 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-27T22:09:43Z rebase from trunk commit 4b0f4f9cb30537fd0b45b192e2a5d81005ffa3c5 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-27T22:26:46Z minor fixes commit 5d2dffa72443139909d3e28f1684363a6e6f5585 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-27T22:29:39Z github comments commit 41ba5721ec9fe88b91416621a6236794d37a74de Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-02T00:08:13Z rebase from trunk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3603: KAFKA-5671 Followup: Remove reflections in unit te...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3603 KAFKA-5671 Followup: Remove reflections in unit test classes 1. Remove rest deprecation warnings in streams:jar. 2. Consolidate all unit test classes' reflections to access internal topology builder from packages other than `o.a.k.streams`. We need to refactor the hierarchies of StreamTask, StreamThread and KafkaStreams to remove these hacky reflections. 3. Minor fixes such as reference path, etc You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K5671-followup-comments Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3603.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3603 commit 86e1c22a223c12180ff192befe76c91f9618435c Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-08-01T00:31:58Z Remove reflections in unit test classes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3574: HOTFIX: handle commit failed exception on stream t...
GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/3574 HOTFIX: handle commit failed exception on stream thread's suspend task 1. Capture `CommitFailedException` in `StreamThread#suspendTasksAndState`; also fix log4j outputs for error and warn. 2. Minor fixes on StreamTask class for comments alignment etc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka KHotfix-handle-commit-failed-exception-in-suspend Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3574 commit 2d45430191c3dc417992c08454f9c550c1e6bb93 Author: Guozhang Wang <wangg...@gmail.com> Date: 2017-07-25T22:43:18Z handle commit failed exception on stream thread --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---