[GitHub] kafka pull request #4237: KAFKA-6207 : Include start of record when RecordIs...
GitHub user jawalesumit opened a pull request: https://github.com/apache/kafka/pull/4237 KAFKA-6207 : Include start of record when RecordIsTooLarge When a message is too large to be sent (at org.apache.kafka.clients.producer.KafkaProducer#doSend), the RecordTooLargeException should carry the start of the record (for example, the first 1KB) so that the calling application can debug which message caused the error. To resolve this, added functionality to log the first 1Kb of message, if RecordIsTooLarge exception is thrown. Thanks, Sumit Jawale ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jawalesumit/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4237.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4237 commit f2fbecfa87ac8152d5ae5d2c73fff3fcdc20e861 Author: jawalesumit <jawalesu...@gmail.com> Date: 2017-11-19T21:19:56Z KAFKA-6207 : Include start of record when RecordIsTooLarge ---
[GitHub] kafka pull request #4236: testing...
Github user jawalesumit closed the pull request at: https://github.com/apache/kafka/pull/4236 ---
[GitHub] kafka pull request #4236: testing...
GitHub user jawalesumit opened a pull request: https://github.com/apache/kafka/pull/4236 testing... *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jawalesumit/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4236.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4236 commit b9a862445f01dba1e47edb9350057c2a5d40d90e Author: jawalesumit <jawalesu...@gmail.com> Date: 2017-11-19T10:28:39Z testing... ---
[GitHub] kafka pull request #4235: KAFKA-6207 : Include start of record when RecordIs...
Github user jawalesumit closed the pull request at: https://github.com/apache/kafka/pull/4235 ---
[GitHub] kafka pull request #4235: KAFKA-6207 : Include start of record when RecordIs...
GitHub user jawalesumit opened a pull request: https://github.com/apache/kafka/pull/4235 KAFKA-6207 : Include start of record when RecordIsTooLarge When a message is too large to be sent (at org.apache.kafka.clients.producer.KafkaProducer#doSend), the RecordTooLargeException should carry the start of the record (for example, the first 1KB) so that the calling application can debug which message caused the error. To resolve this, added functionality to log the first 1Kb of message, if RecordIsTooLarge exception is thrown. Thanks, Sumit Jawale ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jawalesumit/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4235.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4235 commit 6236c3f10076ab6a8e576f9de9caf8cb2ad3200b Author: jawalesumit <jawalesu...@gmail.com> Date: 2017-11-19T09:57:41Z KAFKA-6207 : Include start of record when RecordIsTooLarge ---
[GitHub] kafka pull request #4234: KAFKA-6207 : Include start of record when RecordIs...
Github user jawalesumit closed the pull request at: https://github.com/apache/kafka/pull/4234 ---
[GitHub] kafka pull request #4234: KAFKA-6207 : Include start of record when RecordIs...
GitHub user jawalesumit opened a pull request: https://github.com/apache/kafka/pull/4234 KAFKA-6207 : Include start of record when RecordIsTooLarge When a message is too large to be sent (at org.apache.kafka.clients.producer.KafkaProducer#doSend), the RecordTooLargeException should carry the start of the record (for example, the first 1KB) so that the calling application can debug which message caused the error. To resolve this, I created a new function which will get the first 1KB of the message (if the RecordTooLargeException is occurring), and the same will be logged... Thanks, Sumit Jawale ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jawalesumit/kafka trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4234.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4234 commit 686a3ff711018b4e80e622240cc250e6735d24c7 Author: jawalesumit <jawalesu...@gmail.com> Date: 2017-11-19T07:24:53Z KAFKA-6207 : Include start of record when RecordIsTooLarge ---
