[GitHub] kafka pull request #4351: kafka-6320: move ZK metrics in KafkaHealthCheck to...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/4351 kafka-6320: move ZK metrics in KafkaHealthCheck to ZookeeperClient * Moved metrics in KafkaHealthCheck to ZookeeperClient. * Converted remaining ZkUtils usage in KafkaServer to ZookeeperClient and removed ZkUtils from KafkaServer. * Made the re-creation of ZooKeeper during ZK session expiration with infinite retries. * Added unit tests for all new methods in KafkaZkClient. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka kafka-6320 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/4351.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4351 commit 68937522ada25ed1efdda0f51919375d997e596e Author: Jun Rao <junrao@...> Date: 2017-12-21T22:09:17Z kafka-6320: move ZK metrics in KafkaHealthCheck to ZookeeperClient ---
[GitHub] kafka-site issue #90: Kafka registered trademark
Github user junrao commented on the issue: https://github.com/apache/kafka-site/pull/90 @derrickdoo : Thanks for the patch. LGTM ---
[GitHub] kafka pull request #3929: Minor: tighten up the check of partition states in...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/3929 Minor: tighten up the check of partition states in AbstractFetcherThread You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka minor-change-abstractfetcherthread Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3929.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3929 commit 73c3232c981f7608e9b1ef8f084c6c43b4389dfd Author: Jun Rao <jun...@gmail.com> Date: 2017-09-21T01:20:26Z Minor: tighten up the check of partition states in AbstractFetcherThread ---
[GitHub] kafka pull request #3074: KAFKA-5036: hold onto the leader lock in Partition...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/3074 KAFKA-5036: hold onto the leader lock in Partition while serving an O⦠â¦ffsetForLeaderEpoch request You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka kafka-5036 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3074.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3074 commit 8aa552372b4bae0cdf381d0ceeff829ea14119ee Author: Jun Rao <jun...@gmail.com> Date: 2017-05-16T22:56:34Z KAFKA-5036: hold onto the leader lock in Partition while serving an OffsetForLeaderEpoch request --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2896: Minor: Make sure ProducerPerformance can bind with...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/2896 Minor: Make sure ProducerPerformance can bind with older client jar You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka minor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2896.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2896 commit 2a0d3ea43e8fb7d953f80c330c27efe2e7f81b1f Author: Jun Rao <jun...@gmail.com> Date: 2017-04-22T16:38:58Z Minor: Make sure ProducerPerformance can bind with older client jar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2890: KAFKA-5100: ProducerPerformanceService failing due...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/2890 KAFKA-5100: ProducerPerformanceService failing due to parsing error You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka kafka-5100 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2890.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2890 commit c01c992644907582cb338fe3c1b3601b25b3e495 Author: Jun Rao <jun...@gmail.com> Date: 2017-04-21T16:00:54Z KAFKA-5100: ProducerPerformanceService failing due to parsing error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site issue #47: More edits on 0.10.2 web docs after the release
Github user junrao commented on the issue: https://github.com/apache/kafka-site/pull/47 @guozhangwang : Thanks for the patch. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site issue #26: add trademark symbol on all pages plus longer footer m...
Github user junrao commented on the issue: https://github.com/apache/kafka-site/pull/26 Merged into kafka-site. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site issue #26: add trademark symbol on all pages plus longer footer m...
Github user junrao commented on the issue: https://github.com/apache/kafka-site/pull/26 Thanks for the patch. LGTM. Will remove the duplicated "are" in includes/_footer.htm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2043: KAFKA-4313: ISRs may thrash when replication quota...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/2043 KAFKA-4313: ISRs may thrash when replication quota is enabled You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka kafka-4313 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2043.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2043 commit 4fd876cc82b8ff5b455ecde8cb4a97fc3cf18c75 Author: Jun Rao <jun...@gmail.com> Date: 2016-10-19T02:07:16Z KAFKA-4313: ISRs may thrash when replication quota is enabled --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1703: KAFKA-3875: Transient test failure: kafka.api.SslP...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/1703 KAFKA-3875: Transient test failure: kafka.api.SslProducerSendTest.testSendNonCompressedMessageWithCreateTime 1. The IllegalStateException is actually thrown from testCloseWithZeroTimeoutFromSenderThread() due to a bug. We call producer.close() in the callback. Once the first callback is called, producing records in the callback will hit the IllegalStateException. This only pollutes the output, but doesn't fail the test. I fixed this by only calling producer.send() in the first callback. 2. It's not clear which test throws TimeoutException and it's not reproducible locally. One thing is that the error message in TimeoutException is mis-leading since the timeout is not necessarily due to metadata. Improved this by making the error message in TimeoutException clearer. 3. It's not clear what actually failed testSendNonCompressedMessageWithCreateTime(). One thing I found is that since we set the linger time to MAX_LONG and are sending small messages, those produced messages won't be drained until we call producer.close(1L, TimeUnit.MILLISECONDS). Normally, 10 secs should be enough for the records to be sent. My only hypothesis is that since SSL is more expensive, occasionally, 10 secs is still not enough. So, I bumped up the timeout from 10 secs to 20 secs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka kafka-3875 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1703.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1703 commit c67640e7a45f95ff68cd140795fb9058c11f3dcb Author: Jun Rao <jun...@gmail.com> Date: 2016-08-03T22:29:25Z KAFKA-3875: Transient test failure: kafka.api.SslProducerSendTest.testSendNonCompressedMessageWithCreateTime --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site pull request: KAFKA-3709: Create a project security pag...
Github user junrao commented on the pull request: https://github.com/apache/kafka-site/pull/12#issuecomment-220784809 The mailing list has been created. We can invite all committers/contributors who are interested in security to join the list. secur...@kafka.apache.org Moderators: jun...@gmail.com,ism...@juma.me.uk,csh...@gmail.com This list is private. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site pull request: KAFKA-3709: Create a project security pag...
Github user junrao commented on the pull request: https://github.com/apache/kafka-site/pull/12#issuecomment-219094883 Thanks for the patch. LGTM. I initiated the request to create the security mailing list for Kafka. Will update the PR when it's created. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3474: add metrics to track replica fetch...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/1150 KAFKA-3474: add metrics to track replica fetcher timeouts You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka kafka-3474 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1150.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1150 commit 9a960a3b7e31d75d5ce47e26c375777329174494 Author: Jun Rao <jun...@gmail.com> Date: 2016-03-28T03:15:22Z add timeout metrics --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3427: broker can return incorrect versio...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/1101 KAFKA-3427: broker can return incorrect version of fetch response when the broker hits an unknown exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka kafka-3427 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1101 commit d0a0c11a7704d1d5237204051187f36f6ca6b750 Author: Jun Rao <jun...@gmail.com> Date: 2016-03-19T01:21:29Z add versionId in FetchResponse --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3314: Add CDDL license to LICENSE and NO...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/997 KAFKA-3314: Add CDDL license to LICENSE and NOTICE file You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka kafka-3314 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/997.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #997 commit ef72005da661872c3e5dd2efb358649de1a13fdf Author: Jun Rao <jun...@gmail.com> Date: 2016-03-02T18:17:07Z add CDDL license --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2813: selector doesn't close socket conn...
GitHub user junrao opened a pull request: https://github.com/apache/kafka/pull/501 KAFKA-2813: selector doesn't close socket connection on non-IOExceptions Patched Selector.poll() to close the connection on any exception. You can merge this pull request into a Git repository by running: $ git pull https://github.com/junrao/kafka KAFKA-2813 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/501.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #501 commit 2a4dfd4d63f3b3383d9ce01fce7c2be151ef9f78 Author: Jun Rao <jun...@gmail.com> Date: 2015-11-12T01:11:49Z KAFKA-2813: selector doesn't close socket connection on non-IOExceptions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
