[GitHub] kafka pull request #3968: KAFKA-5952 Refactor Consumer Fetcher metrics
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/3968 KAFKA-5952 Refactor Consumer Fetcher metrics This is ready for review. This does not have to be merged into 1.0.0, it can simply go to trunk. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka refactor_consumer_fetcher_metrics Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3968.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3968 commit be9f0f17ca4285f893d154f8ccc8a79634549e00 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-27T02:32:21Z Update the consumer metrics registry stuff to match the producer metrics refactoring. commit 8bba351987577a29426b6412f9f21b8a5249a282 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-27T02:38:01Z Change "metricTags" to just tags. Get rid of the "get" prefixes. Make instance variables final. ---
[GitHub] kafka pull request #3967: KAFKA-5951: Autogenerate Producer RecordAccumulato...
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/3967 KAFKA-5951: Autogenerate Producer RecordAccumulator metrics Don't review this until https://github.com/apache/kafka/pull/3799/files is merged. This PR layers on top of https://github.com/apache/kafka/pull/3799/files. This will have to be rebased, once https://github.com/apache/kafka/pull/3799/files is merged into trunk and 1.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka producer_record_accumulator_bufferpool Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3967.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3967 commit 7b48ab7030c58879103bccf8c3f7dff59444a6a6 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-06T07:23:23Z Instead of having the metrics registry and the org.apache.kafka.common.metrics.Metrics object be separate things, have the metrics registry hold a copy of the Metrics object. That way, all the metricInstance stuff is hidden, and we don't have to make sure they are configured identicailly (with the same tags). commit f8cd817fa3faefb4cf0bd482dce9d6627ee5b84e Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-17T07:40:25Z Merge remote-tracking branch 'origin/trunk' into producer_sender_metrics_docs_different Conflicts: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java clients/src/main/java/org/apache/kafka/clients/producer/internals/SenderMetricsRegistry.java clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java commit 3a11a7bfc2d2e37b769019326555a42051b554ad Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-17T08:22:08Z Fix merge errors. Change public metrics to private, since they all have getters now. Simplify the Sender.throttleTimeSensor() static method to just use the metrics registry. commit b3e739f87a74f1d10c9bdfd712d2506848dd69dd Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-17T08:24:39Z Missed this change, when I switched metrics accces to private. commit 9893002e9d4f95ebcbf94922b5b0897b79d582d2 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-19T05:24:23Z Merge remote-tracking branch 'origin/trunk' into producer_sender_metrics_docs_different commit 9014654f1b74f8e19365e1478fb92b13cfe2abd6 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-19T05:33:42Z Update test case to accomodate new registry design. commit 4adc64e8fb48866cbb9fc8a9ba4a3304968b844e Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-19T05:49:32Z Automatically put all the MetricNameTemplates into a list, which is used for documentation. commit f9fb34586955d98e30e37b8fc79fb0433319ef51 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-21T05:38:11Z Get rid of the getters, for all the metrics without additional tags. Precompute the MetricNames in advance. Expose those MetricNames as public variables to all the people who need it. commit a6ee2efac0ed7ce8d5d9b1f0e04058855aaaff25 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-21T05:48:27Z Inline access to the metrics, where possible and readable. commit d40ffc1c54b2cd303a318587cb93f5d3000e8309 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-21T05:51:49Z Make instance variables final. commit 763035ad3120232140f8861038b56de108a75b49 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-21T06:01:57Z Change another variable to final commit c4e87e757b9f64fa28afcbe08190739fc3ff80b4 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-21T06:04:51Z Merge remote-tracking branch 'origin/trunk' into producer_sender_metrics_docs_different_2 commit d4542de643123a9fe734b2e0cc5cac11dfce7ec5 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-21T07:42:31Z Merge remote-tracking branch 'origin/trunk' into producer_sender_metrics_docs_different commit 3f306488a4101f63da5587655e332332c952e30c Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-22T06:10:04Z Add empty RecordAccumulatorMetricsRegistry commit 4447f53babf67f6e51a3f908107f509fb085fecf Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-22T06:34:40Z RecordAccumulator now takes a metrics registry commit 49ba8c6c52b0a34008f513e9af7867d09d3d53d2 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-22T06:54:02Z Switch RecordAccumulator to use the metrics registry. commit 0ce13cbae54587878cbf473f67cad21a528ec6ff Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-22T06:57:01Z Removed unused parameters commit 76b7c85c5d45911e01e684098dc73acc524eb2c2 Author
[GitHub] kafka pull request #3931: Minor: Fix testUniqueErrorCodes unit test failure
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/3931 Minor: Fix testUniqueErrorCodes unit test failure I'm not really sure if I'm doing the right thing here, but I thought I'd give it a shot and try to fix the unit test breakage. Running ```./gradlew :clients:unitTest``` now passes. Fix error code collision accidentally introduced when merging in https://github.com/apache/kafka/commit/5f6393f9b17cce17ded7a00e439599dfa77deb2d#diff-b119227df7efa3ffeb7fe69e49ff1afeR541 There were two Error 59's Requesting review by @tombentley You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka KAFKA-5856.buildfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3931.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3931 commit b3c738ba1dd8771c1e6a088222e3e9d850758aa1 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-21T07:14:47Z Fix error code collision accidentally introduced when merging in https://github.com/apache/kafka/commit/5f6393f9b17cce17ded7a00e439599dfa77deb2d#diff-b119227df7efa3ffeb7fe69e49ff1afeR541 ---
[GitHub] kafka pull request #3799: KAFKA-5597 [WIP] Alternate way to do Metrics docs ...
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/3799 KAFKA-5597 [WIP] Alternate way to do Metrics docs generation I was about to start on the next round of autogeneration of metrics docs, but I wanted to @guozhangwang 's opinion on this first. This is a possible alternate way to do autogeneration of metrics docs, that possibly looks a little nicer for the developer. Posting this to get some feedback on if the original way looks better, or if this new way looks better. Instead of having the metrics registry and the org.apache.kafka.common.metrics.Metrics object be separate things, have the metrics registry hold a copy of the Metrics object. That way, all the metricInstance stuff is hidden, and we don't have to make sure that the metrics registry and the Metrics object are configured identicailly (with the same tags). I personally think this looks a little better. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka producer_sender_metrics_docs_different Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3799.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3799 commit 7b48ab7030c58879103bccf8c3f7dff59444a6a6 Author: James Cheng <jylch...@yahoo.com> Date: 2017-09-06T07:23:23Z Instead of having the metrics registry and the org.apache.kafka.common.metrics.Metrics object be separate things, have the metrics registry hold a copy of the Metrics object. That way, all the metricInstance stuff is hidden, and we don't have to make sure they are configured identicailly (with the same tags). ---
[GitHub] kafka-site pull request #56: Update commiter page to indicate that Gwen is a...
Github user wushujames closed the pull request at: https://github.com/apache/kafka-site/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #3535: KAFKA-5597: Autogenerate producer sender metrics.
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/3535 KAFKA-5597: Autogenerate producer sender metrics. Subtask of https://issues.apache.org/jira/browse/KAFKA-3480 The changes are very similar to what was done for the consumer in https://issues.apache.org/jira/browse/KAFKA-5191 (pull request https://github.com/apache/kafka/pull/2993) A screenshot of the docs are here:  You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka producer_sender_metrics_docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3535.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3535 commit 33f876fa471048ec6ddd7c05dbd5935d0157eca3 Author: James Cheng <jylch...@yahoo.com> Date: 2017-07-16T08:29:30Z Autogenerate producer sender metrics. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka-site pull request #56: Update commiter page to indicate that Gwen is a...
GitHub user wushujames opened a pull request: https://github.com/apache/kafka-site/pull/56 Update commiter page to indicate that Gwen is a PMC member. Would it be a conflict of interest for @gwenshap to approve this PR? :) You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka-site gwen_pmc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka-site/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit ddbb5917b1cdc8e233ae5265c8f3276518276cb6 Author: James Cheng <jylch...@yahoo.com> Date: 2017-05-26T19:40:46Z Update commiter page to indicate that Gwen is a PMC member. commit a4bdb1fb0a225c30352ad5bef573a000e3c8482a Author: James Cheng <jylch...@yahoo.com> Date: 2017-05-26T19:42:44Z Spaces instead of tabs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #2993: KAFKA-5191: Autogenerate Consumer Fetcher metrics
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/2993 KAFKA-5191: Autogenerate Consumer Fetcher metrics Autogenerate docs for the Consumer Fetcher's metrics. This is a smaller subset of the original PR https://github.com/apache/kafka/pull/1202. CC @ijuma @benstopford @hachikuji You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka fetcher_metrics_docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2993.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2993 commit edcfde98d50b6cb46a0eaf19d61ad5f19dd8fd8b Author: James Cheng <jylch...@yahoo.com> Date: 2017-05-07T05:33:48Z Base files, to support auto-generating metrics documentation. commit 9c0becef44e36f69dd3a141e4d2bce4694eb29b7 Author: James Cheng <jylch...@yahoo.com> Date: 2017-05-07T06:46:54Z Autogenerate metrics docs for the Fetcher --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1202: KAFKA-3480: Autogenerate metrics documentation
Github user wushujames closed the pull request at: https://github.com/apache/kafka/pull/1202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1527: KAFKA-3809: Auto-generate documentation for topic-...
GitHub user wushujames reopened a pull request: https://github.com/apache/kafka/pull/1527 KAFKA-3809: Auto-generate documentation for topic-level configuration @ijuma said that it would make sense to split out this work from KAFKA-3234, since KAFKA-3234 had both a mechanical change (generating docs) as well as a change requiring discussion (deprecating/renaming config options). @jjkoshy, I hope you don't mind that I took over this work. It's been 3 months since the last activity on KAFKA-3234, so I thought it would be okay to take over. This work is essentially is the first 5-6 commits from Joel's https://github.com/apache/kafka/pull/907. However, since I'm not very experienced with git, I didn't do a direct merge/rebase, but instead largely hand-merged it. I did some minor cleanup. All credit goes to Joel, all blame goes to me. :) For reference, I attached the auto-generated configuration.html file (as a PDF, because github won't let me attache html). [configuration.pdf](https://github.com/apache/kafka/files/323901/configuration.pdf) This is my first time writing Scala, so let me know if there are any changes needed. I don't know who is the right person to review this. @ijuma, can you help me redirect this to the appropriate person? Thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka generate_topic_docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1527.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1527 commit 91aa7ff404ba0cdb3d1004591a7e96b5cab98319 Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-17T23:02:53Z Generate docs. Include them in the configuration.html file. commit 49eb27bdc3c496ec9f3aec34b7570562abb81435 Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T00:11:27Z Copy the descriptions from the previous hand-maintained webpage into the code. commit 596915de11e0d4fea9f30a47dc6eda154959faf3 Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T00:17:31Z Update some more descriptions, based on of Joel Koshy's changes. commit 4aad500a09cbd5b80794cc47868dbc43e7e4be4e Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T00:34:14Z For each topic-level config, add a column that points to the server-level config value that it inherits from. commit 82aa887486392a606f87f941d1e9b7eee88c Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T00:59:34Z Fix compile errors. Centralize the descriptions of message.format.version, min.insync.replicas, and message.timestamp.type commit e5f05009e34e0a5208ad9a3da8f4bb972e6af85a Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T01:51:23Z Add a column to the config table that shows the server property that each topic-level config inherits from. commit aff49e012d03f64af7ca7e70430fd92159471654 Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-20T16:41:26Z segment.ms should inherit from log.roll.ms commit 7bef85f6047b7d50b543ca7e2ec3ce2199370fec Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-20T16:41:59Z Subclasses just need "protected" access, not full public. commit fd53519b7e82733698e61b024ada2395e308831f Author: James Cheng <jylch...@yahoo.com> Date: 2016-08-04T18:57:48Z Remove unnecessary semicolons. commit c7db281e7a11a0ea5f70d4f40614a35ad565a11e Author: James Cheng <jylch...@yahoo.com> Date: 2016-08-04T20:00:09Z Add return value to definition of public methods. commit b923778a8d593c41a84824b1010a0a6fbdedf488 Author: James Cheng <jylch...@yahoo.com> Date: 2016-08-04T20:10:42Z No need for boxing. commit 8843ef09e161c6e95e2241ef708e4ce4e6bf66c8 Author: James Cheng <jylch...@yahoo.com> Date: 2016-08-04T20:23:13Z Switch this back. The topic-level description now references the server level description, not the other way around. commit d2e4342119927652c2d9de66712b681821ba1411 Author: James Cheng <jylch...@yahoo.com> Date: 2016-08-04T23:45:48Z Move the headers and column values into data callbacks, so allow subclasses to override. Make LogConfig use that functionality to include additional columns. commit e2dae9a122a67e03094fe41e5379ba232c47575b Author: James Cheng <jylch...@yahoo.com> Date: 2016-08-05T16:05:30Z Merge branch 'trunk' into generate_topic_docs commit bad1627b47fc0f2d7b92fd84e0d4d0991695b3b7 Author: James Cheng <jylch...@yahoo.com> Date: 2016-08-05T16:45:40Z Fix indentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w
[GitHub] kafka pull request #1527: KAFKA-3809: Auto-generate documentation for topic-...
Github user wushujames closed the pull request at: https://github.com/apache/kafka/pull/1527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request #1527: KAFKA-3809: Auto-generate documentation for topic-...
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/1527 KAFKA-3809: Auto-generate documentation for topic-level configuration @ijuma said that it would make sense to split out this work from KAFKA-3234, since KAFKA-3234 had both a mechanical change (generating docs) as well as a change requiring discussion (deprecating/renaming config options). @jjkoshy, I hope you don't mind that I took over this work. It's been 3 months since the last activity on KAFKA-3234, so I thought it would be okay to take over. This work is essentially is the first 5-6 commits from Joel's https://github.com/apache/kafka/pull/907. However, since I'm not very experienced with git, I didn't do a direct merge/rebase, but instead largely hand-merged it. I did some minor cleanup. All credit goes to Joel, all blame goes to me. :) For reference, I attached the auto-generated configuration.html file (as a PDF, because github won't let me attached html). [configuration.pdf](https://github.com/apache/kafka/files/323901/configuration.pdf) This is my first time writing Scala, so let me know if there are any changes needed. I don't know who is the right person to review this. @ijuma, can you help me redirect this to the appropriate person? Thanks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka generate_topic_docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1527.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1527 commit 91aa7ff404ba0cdb3d1004591a7e96b5cab98319 Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-17T23:02:53Z Generate docs. Include them in the configuration.html file. commit 49eb27bdc3c496ec9f3aec34b7570562abb81435 Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T00:11:27Z Copy the descriptions from the previous hand-maintained webpage into the code. commit 596915de11e0d4fea9f30a47dc6eda154959faf3 Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T00:17:31Z Update some more descriptions, based on of Joel Koshy's changes. commit 4aad500a09cbd5b80794cc47868dbc43e7e4be4e Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T00:34:14Z For each topic-level config, add a column that points to the server-level config value that it inherits from. commit 82aa887486392a606f87f941d1e9b7eee88c Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T00:59:34Z Fix compile errors. Centralize the descriptions of message.format.version, min.insync.replicas, and message.timestamp.type commit e5f05009e34e0a5208ad9a3da8f4bb972e6af85a Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-18T01:51:23Z Add a column to the config table that shows the server property that each topic-level config inherits from. commit aff49e012d03f64af7ca7e70430fd92159471654 Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-20T16:41:26Z segment.ms should inherit from log.roll.ms commit 7bef85f6047b7d50b543ca7e2ec3ce2199370fec Author: James Cheng <jylch...@yahoo.com> Date: 2016-06-20T16:41:59Z Subclasses just need "protected" access, not full public. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: [WIP] KAFKA-3480: Autogenerate metrics documen...
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/1202 [WIP] KAFKA-3480: Autogenerate metrics documentation This is a proof of concept for autogenerating documentation for metrics, to see whether this approach is feasible. I applied it to the metrics in the TestMetrics.java file. I will attach the generated file to the JIRA, for reference. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka metrics_docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/1202.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1202 commit af70dc2f62897745d86169d900df4b6fe39c9d6b Author: James Cheng <jylch...@yahoo.com> Date: 2016-04-08T01:35:10Z Proof of concept for auto generating metrics documentation. commit d01b49894f82c90de41fa5992b50c71b8b1ed717 Author: James Cheng <jylch...@yahoo.com> Date: 2016-04-08T01:36:52Z Merge remote-tracking branch 'origin/trunk' into metrics_docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3216: "Modifying topics" section incorre...
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/881 KAFKA-3216: "Modifying topics" section incorrectly says you can't change replication factor. Correct the text that said that you can't change the replication factor of a topic. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka KAFKA-3216 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/881.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #881 commit f6b2e73a0295bff0cb8a9108b4b3a1db29077526 Author: James Cheng <jylch...@yahoo.com> Date: 2016-02-07T05:40:30Z Correct the text that said that you can't change the replication factor of a topic. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-3138: 0.9.0 docs still say that log comp...
GitHub user wushujames opened a pull request: https://github.com/apache/kafka/pull/807 KAFKA-3138: 0.9.0 docs still say that log compaction doesn't work on compressed topics. Log compaction is supported on compressed topics as of 0.9.0, so update the docs to reflect that. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wushujames/kafka KAFKA-3138 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/807.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #807 commit 3ef3ef157544474c6c37e0453b8e362cd936f02e Author: James Cheng <jylch...@yahoo.com> Date: 2016-01-24T06:48:21Z Log compaction is supported on compressed topics as of 0.9.0, so update the docs to reflect that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
