Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

[Guozhang Wang]

Sounds great, thanks!

On Wed, May 10, 2017 at 10:43 AM, Xavier Léauté  wrote:

> I'll be driving the implementation as well. Unless there are specific
> concerns about the implementation, I mainly wrote the KIP to agree on the
> additional public interfaces.
>
> Current window store fetch operations already rely on range scanning
> & filtering the relevant keys in the underlying state store, and
> implementing key range fetch would follow a similar approach.
>
> On Tue, May 9, 2017 at 9:21 PM Guozhang Wang  wrote:
>
> > Thanks, the KIP sounds good to me. There is no implementation proposal in
> > the JIRA / KIP yet, would you like you drive the implementation also?
> >
> >
> > Guozhang
> >
>



-- 
-- Guozhang

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

[Xavier Léauté]

I'll be driving the implementation as well. Unless there are specific
concerns about the implementation, I mainly wrote the KIP to agree on the
additional public interfaces.

Current window store fetch operations already rely on range scanning
& filtering the relevant keys in the underlying state store, and
implementing key range fetch would follow a similar approach.

On Tue, May 9, 2017 at 9:21 PM Guozhang Wang  wrote:

> Thanks, the KIP sounds good to me. There is no implementation proposal in
> the JIRA / KIP yet, would you like you drive the implementation also?
>
>
> Guozhang
>

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

[Guozhang Wang]

Thanks, the KIP sounds good to me. There is no implementation proposal in
the JIRA / KIP yet, would you like you drive the implementation also?


Guozhang

On Tue, May 9, 2017 at 8:29 AM, Xavier Léauté  wrote:

> I updated the KIP to reflect Michal's comment. Unless there are any further
> comments, I will initiate a vote this evening.
>
> On Mon, May 8, 2017 at 11:01 AM Xavier Léauté  wrote:
>
> > That sounds reasonable, Michal. Given the underlying implementation uses
> > the same segmented bytes store I don't think it should be too difficult
> to
> > add.
> >
> > On Mon, May 8, 2017 at 2:04 AM Michal Borowiecki <
> > michal.borowie...@openbet.com> wrote:
> >
> >> Hi Xavier,
> >>
> >> I like your KIP. Do you think the same should apply to session stores?
> >>
> >> IMHO, all three should be on par wrt the ability to query key ranges
> >> (although I understand the implementation concerns for windowed stores
> are
> >> more involved than for normal key value stores).
> >>
> >> Thanks,
> >>
> >> Michal
> >>
> >> On 08/05/17 08:18, Xavier Léauté wrote:
> >>
> >> Hi everyone,
> >>
> >> I am proposing to add the ability to range scan windowed state stores in
> >> Kafka Streams. The required interface changes are relatively minimal and
> >> follow our existing conventions for state stores. Let me know if that
> >> sounds reasonable.
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP+
> 155+-+Add+range+scan+for+windowed+state+stores
> >> https://issues.apache.org/jira/browse/KAFKA-5192
> >>
> >> Thank you,
> >> Xavier
> >>
> >>
> >>
> >> --
> >>  Michal Borowiecki
> >> Senior Software Engineer L4
> >> T: +44 208 742 1600 <+44%2020%208742%201600>
> >>
> >>
> >> +44 203 249 8448 <+44%2020%203249%208448>
> >>
> >>
> >>
> >> E: michal.borowie...@openbet.com
> >> W: www.openbet.com
> >> OpenBet Ltd
> >>
> >> Chiswick Park Building 9
> >>
> >> 566 Chiswick High Rd
> >>
> >> London
> >>
> >> W4 5XT
> >>
> >> UK
> >> 
> >> This message is confidential and intended only for the addressee. If you
> >> have received this message in error, please immediately notify the
> >> postmas...@openbet.com and delete it from your system as well as any
> >> copies. The content of e-mails as well as traffic data may be monitored
> by
> >> OpenBet for employment and security purposes. To protect the environment
> >> please do not print this e-mail unless necessary. OpenBet Ltd.
> Registered
> >> Office: Chiswick Park Building 9, 566 Chiswick High Road, London, W4
> 5XT,
> >> United Kingdom. A company registered in England and Wales. Registered
> no.
> >> 3134634. VAT no. GB927523612
> >>
> >
>



-- 
-- Guozhang

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

[Xavier Léauté]

I updated the KIP to reflect Michal's comment. Unless there are any further
comments, I will initiate a vote this evening.

On Mon, May 8, 2017 at 11:01 AM Xavier Léauté  wrote:

> That sounds reasonable, Michal. Given the underlying implementation uses
> the same segmented bytes store I don't think it should be too difficult to
> add.
>
> On Mon, May 8, 2017 at 2:04 AM Michal Borowiecki <
> michal.borowie...@openbet.com> wrote:
>
>> Hi Xavier,
>>
>> I like your KIP. Do you think the same should apply to session stores?
>>
>> IMHO, all three should be on par wrt the ability to query key ranges
>> (although I understand the implementation concerns for windowed stores are
>> more involved than for normal key value stores).
>>
>> Thanks,
>>
>> Michal
>>
>> On 08/05/17 08:18, Xavier Léauté wrote:
>>
>> Hi everyone,
>>
>> I am proposing to add the ability to range scan windowed state stores in
>> Kafka Streams. The required interface changes are relatively minimal and
>> follow our existing conventions for state stores. Let me know if that
>> sounds reasonable.
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP+155+-+Add+range+scan+for+windowed+state+stores
>> https://issues.apache.org/jira/browse/KAFKA-5192
>>
>> Thank you,
>> Xavier
>>
>>
>>
>> --
>>  Michal Borowiecki
>> Senior Software Engineer L4
>> T: +44 208 742 1600 <+44%2020%208742%201600>
>>
>>
>> +44 203 249 8448 <+44%2020%203249%208448>
>>
>>
>>
>> E: michal.borowie...@openbet.com
>> W: www.openbet.com
>> OpenBet Ltd
>>
>> Chiswick Park Building 9
>>
>> 566 Chiswick High Rd
>>
>> London
>>
>> W4 5XT
>>
>> UK
>> 
>> This message is confidential and intended only for the addressee. If you
>> have received this message in error, please immediately notify the
>> postmas...@openbet.com and delete it from your system as well as any
>> copies. The content of e-mails as well as traffic data may be monitored by
>> OpenBet for employment and security purposes. To protect the environment
>> please do not print this e-mail unless necessary. OpenBet Ltd. Registered
>> Office: Chiswick Park Building 9, 566 Chiswick High Road, London, W4 5XT,
>> United Kingdom. A company registered in England and Wales. Registered no.
>> 3134634. VAT no. GB927523612
>>
>

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

[Xavier Léauté]

That sounds reasonable, Michal. Given the underlying implementation uses
the same segmented bytes store I don't think it should be too difficult to
add.

On Mon, May 8, 2017 at 2:04 AM Michal Borowiecki <
michal.borowie...@openbet.com> wrote:

> Hi Xavier,
>
> I like your KIP. Do you think the same should apply to session stores?
>
> IMHO, all three should be on par wrt the ability to query key ranges
> (although I understand the implementation concerns for windowed stores are
> more involved than for normal key value stores).
>
> Thanks,
>
> Michal
>
> On 08/05/17 08:18, Xavier Léauté wrote:
>
> Hi everyone,
>
> I am proposing to add the ability to range scan windowed state stores in
> Kafka Streams. The required interface changes are relatively minimal and
> follow our existing conventions for state stores. Let me know if that
> sounds reasonable.
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+155+-+Add+range+scan+for+windowed+state+stores
> https://issues.apache.org/jira/browse/KAFKA-5192
>
> Thank you,
> Xavier
>
>
>
> --
>  Michal Borowiecki
> Senior Software Engineer L4
> T: +44 208 742 1600 <+44%2020%208742%201600>
>
>
> +44 203 249 8448 <+44%2020%203249%208448>
>
>
>
> E: michal.borowie...@openbet.com
> W: www.openbet.com
> OpenBet Ltd
>
> Chiswick Park Building 9
>
> 566 Chiswick High Rd
>
> London
>
> W4 5XT
>
> UK
> 
> This message is confidential and intended only for the addressee. If you
> have received this message in error, please immediately notify the
> postmas...@openbet.com and delete it from your system as well as any
> copies. The content of e-mails as well as traffic data may be monitored by
> OpenBet for employment and security purposes. To protect the environment
> please do not print this e-mail unless necessary. OpenBet Ltd. Registered
> Office: Chiswick Park Building 9, 566 Chiswick High Road, London, W4 5XT,
> United Kingdom. A company registered in England and Wales. Registered no.
> 3134634. VAT no. GB927523612
>

Re: [DISCUSS] KIP-155 Add range scan for windowed state stores

[Michal Borowiecki]

Hi Xavier,

I like your KIP. Do you think the same should apply to session stores?

IMHO, all three should be on par wrt the ability to query key ranges 
(although I understand the implementation concerns for windowed stores 
are more involved than for normal key value stores).


Thanks,

Michal


On 08/05/17 08:18, Xavier Léauté wrote:

Hi everyone,

I am proposing to add the ability to range scan windowed state stores in
Kafka Streams. The required interface changes are relatively minimal and
follow our existing conventions for state stores. Let me know if that
sounds reasonable.

https://cwiki.apache.org/confluence/display/KAFKA/KIP+155+-+Add+range+scan+for+windowed+state+stores

https://issues.apache.org/jira/browse/KAFKA-5192

Thank you,
Xavier



--
Signature
 Michal Borowiecki
Senior Software Engineer L4
T:  +44 208 742 1600


+44 203 249 8448



E:  michal.borowie...@openbet.com
W:  www.openbet.com 


OpenBet Ltd

Chiswick Park Building 9

566 Chiswick High Rd

London

W4 5XT

UK




This message is confidential and intended only for the addressee. If you 
have received this message in error, please immediately notify the 
postmas...@openbet.com  and delete it 
from your system as well as any copies. The content of e-mails as well 
as traffic data may be monitored by OpenBet for employment and security 
purposes. To protect the environment please do not print this e-mail 
unless necessary. OpenBet Ltd. Registered Office: Chiswick Park Building 
9, 566 Chiswick High Road, London, W4 5XT, United Kingdom. A company 
registered in England and Wales. Registered no. 3134634. VAT no. 
GB927523612

[DISCUSS] KIP-155 Add range scan for windowed state stores

[Xavier Léauté]

Hi everyone,

I am proposing to add the ability to range scan windowed state stores in
Kafka Streams. The required interface changes are relatively minimal and
follow our existing conventions for state stores. Let me know if that
sounds reasonable.

https://cwiki.apache.org/confluence/display/KAFKA/KIP+155+-+Add+range+scan+for+windowed+state+stores

https://issues.apache.org/jira/browse/KAFKA-5192

Thank you,
Xavier