[GitHub] kafka pull request: HOTFIX: open window segments in order, add seg...

2016-02-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/891


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request: HOTFIX: open window segments in order, add seg...

2016-02-09 Thread ymatsuda
GitHub user ymatsuda opened a pull request:

https://github.com/apache/kafka/pull/891

HOTFIX: open window segments in order, add segment id check in getSegment

* During window store initialization, we have to open segments in the 
segment id order and update ```currentSegmentId```, otherwise cleanup won't 
work.
* ```getSegment()``` should not create a segment and clean up old segments 
if the segment id is greater than ```currentSegmentId```. Segment maintenance 
should be driven not by query but only by data insertion.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ymatsuda/kafka hotfix2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/891.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #891


commit b64b84cdeeda65284e3d99ab8278383d1a2aec72
Author: Yasuhiro Matsuda 
Date:   2016-02-09T18:05:38Z

HOTFIX: open window segments in order




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---