[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
GitHub user benstopford reopened a pull request: https://github.com/apache/kafka/pull/158 KAFKA-2453: Enable new consumer in EndToEndLatency You can merge this pull request into a Git repository by running: $ git pull https://github.com/benstopford/kafka KAFKA-2453b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 71b11fac33a67ef9f0ac8ac09bcbb5305a56047f Author: Ben StopfordDate: 2015-08-21T16:44:48Z KAFKA-2453: migrated EndToEndLatencyTest to new consumer API. Added feature for configuring message size. Added inline assertion. commit 43d6a0678fd37d7f382d5f89c898571ae4e3cfbb Author: Ben Stopford Date: 2015-08-21T16:45:19Z KAFKA-2453: small change which prevents the ConsoleConsumer from throwing an exception when the Finalizer thread tries to close it. commit cac85029c7d802da29d68073545c118804bd41cb Author: Ben Stopford Date: 2015-08-21T17:08:29Z KAFKA-2453: Added additional arguments to call to EndToEndLatency from Performance tests commit 119a6fa545bcaf586c9cb110f0e13c1cfee1f56c Author: Ben Stopford Date: 2015-09-01T10:20:14Z KAFKA-2453: Rebased to trunk KAFKA-2453: removed whitespace KAFKA-2453: Formatting only commit 954f076701dd8961e3f835b08a022fc31ae74943 Author: Ben Stopford Date: 2015-09-01T15:30:17Z KAFKA-2453: Incorporate changes from KAFKA-2486 Previous version used an optional busy loop to get better performance by avoiding sleeps inside the API. These turned out to be a bug fixed in KAFKA-2486 so the optional busy loop has been removed. commit 4b96fab3037e6ed2ee00a0ff370168000fddcd09 Author: Ben Stopford Date: 2015-09-01T18:17:29Z KAFKA-2453: removed sleep which I believe is not longer needed now we have consumer.seekToEnd() commit 3e52bca1f0f711b7abdee680253f808bb871057e Author: Ben Stopford Date: 2015-09-01T22:04:17Z KAFKA-2453: Producer acks can be a string commit 29ce7cd9c95980f391bf3315099d285c120ace6e Author: Ben Stopford Date: 2015-09-02T13:13:06Z KAFKA-2453: Feedback from Gwen + fix to seek problem - Fixed issue with seekToEnd evaluating lazily (i.e. when poll is called) meaning messages can be missed in slower environments (discovered when I ran this on EC2). Detailed in comments. - Removed redundant retry backoff override (this was an artifact of KAFKA-2486) - Forced producer acks to be 1 or all (i.e. synchronous) - Reduced poll to a reasonable timeout to avoid hangs in erroneous situations - Added check for results being non zero - Added check that there is only a single message returned commit d2d7378c7fdaf0a095141ece1dff8c52aa72a9ac Author: Ben Stopford Date: 2015-09-02T14:09:33Z KAFKA-2453: downgrade duplicate message exception to warning commit a6544d19cb8d1da58a67f878d8204c10a3c42c1a Author: Ben Stopford Date: 2015-09-02T16:05:12Z KAFKA-2453: Added in support for ssl properties file. Ismael's changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
Github user benstopford closed the pull request at: https://github.com/apache/kafka/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
GitHub user benstopford reopened a pull request: https://github.com/apache/kafka/pull/158 KAFKA-2453: Enable new consumer in EndToEndLatency You can merge this pull request into a Git repository by running: $ git pull https://github.com/benstopford/kafka KAFKA-2453b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 71b11fac33a67ef9f0ac8ac09bcbb5305a56047f Author: Ben StopfordDate: 2015-08-21T16:44:48Z KAFKA-2453: migrated EndToEndLatencyTest to new consumer API. Added feature for configuring message size. Added inline assertion. commit 43d6a0678fd37d7f382d5f89c898571ae4e3cfbb Author: Ben Stopford Date: 2015-08-21T16:45:19Z KAFKA-2453: small change which prevents the ConsoleConsumer from throwing an exception when the Finalizer thread tries to close it. commit cac85029c7d802da29d68073545c118804bd41cb Author: Ben Stopford Date: 2015-08-21T17:08:29Z KAFKA-2453: Added additional arguments to call to EndToEndLatency from Performance tests commit 119a6fa545bcaf586c9cb110f0e13c1cfee1f56c Author: Ben Stopford Date: 2015-09-01T10:20:14Z KAFKA-2453: Rebased to trunk KAFKA-2453: removed whitespace KAFKA-2453: Formatting only commit 954f076701dd8961e3f835b08a022fc31ae74943 Author: Ben Stopford Date: 2015-09-01T15:30:17Z KAFKA-2453: Incorporate changes from KAFKA-2486 Previous version used an optional busy loop to get better performance by avoiding sleeps inside the API. These turned out to be a bug fixed in KAFKA-2486 so the optional busy loop has been removed. commit 4b96fab3037e6ed2ee00a0ff370168000fddcd09 Author: Ben Stopford Date: 2015-09-01T18:17:29Z KAFKA-2453: removed sleep which I believe is not longer needed now we have consumer.seekToEnd() commit 3e52bca1f0f711b7abdee680253f808bb871057e Author: Ben Stopford Date: 2015-09-01T22:04:17Z KAFKA-2453: Producer acks can be a string commit 29ce7cd9c95980f391bf3315099d285c120ace6e Author: Ben Stopford Date: 2015-09-02T13:13:06Z KAFKA-2453: Feedback from Gwen + fix to seek problem - Fixed issue with seekToEnd evaluating lazily (i.e. when poll is called) meaning messages can be missed in slower environments (discovered when I ran this on EC2). Detailed in comments. - Removed redundant retry backoff override (this was an artifact of KAFKA-2486) - Forced producer acks to be 1 or all (i.e. synchronous) - Reduced poll to a reasonable timeout to avoid hangs in erroneous situations - Added check for results being non zero - Added check that there is only a single message returned --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
Github user benstopford closed the pull request at: https://github.com/apache/kafka/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
GitHub user benstopford reopened a pull request: https://github.com/apache/kafka/pull/158 KAFKA-2453: Enable new consumer in EndToEndLatency You can merge this pull request into a Git repository by running: $ git pull https://github.com/benstopford/kafka KAFKA-2453b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 71b11fac33a67ef9f0ac8ac09bcbb5305a56047f Author: Ben StopfordDate: 2015-08-21T16:44:48Z KAFKA-2453: migrated EndToEndLatencyTest to new consumer API. Added feature for configuring message size. Added inline assertion. commit 43d6a0678fd37d7f382d5f89c898571ae4e3cfbb Author: Ben Stopford Date: 2015-08-21T16:45:19Z KAFKA-2453: small change which prevents the ConsoleConsumer from throwing an exception when the Finalizer thread tries to close it. commit cac85029c7d802da29d68073545c118804bd41cb Author: Ben Stopford Date: 2015-08-21T17:08:29Z KAFKA-2453: Added additional arguments to call to EndToEndLatency from Performance tests commit 119a6fa545bcaf586c9cb110f0e13c1cfee1f56c Author: Ben Stopford Date: 2015-09-01T10:20:14Z KAFKA-2453: Rebased to trunk KAFKA-2453: removed whitespace KAFKA-2453: Formatting only commit 954f076701dd8961e3f835b08a022fc31ae74943 Author: Ben Stopford Date: 2015-09-01T15:30:17Z KAFKA-2453: Incorporate changes from KAFKA-2486 Previous version used an optional busy loop to get better performance by avoiding sleeps inside the API. These turned out to be a bug fixed in KAFKA-2486 so the optional busy loop has been removed. commit 4b96fab3037e6ed2ee00a0ff370168000fddcd09 Author: Ben Stopford Date: 2015-09-01T18:17:29Z KAFKA-2453: removed sleep which I believe is not longer needed now we have consumer.seekToEnd() commit 3e52bca1f0f711b7abdee680253f808bb871057e Author: Ben Stopford Date: 2015-09-01T22:04:17Z KAFKA-2453: Producer acks can be a string commit 29ce7cd9c95980f391bf3315099d285c120ace6e Author: Ben Stopford Date: 2015-09-02T13:13:06Z KAFKA-2453: Feedback from Gwen + fix to seek problem - Fixed issue with seekToEnd evaluating lazily (i.e. when poll is called) meaning messages can be missed in slower environments (discovered when I ran this on EC2). Detailed in comments. - Removed redundant retry backoff override (this was an artifact of KAFKA-2486) - Forced producer acks to be 1 or all (i.e. synchronous) - Reduced poll to a reasonable timeout to avoid hangs in erroneous situations - Added check for results being non zero - Added check that there is only a single message returned commit d2d7378c7fdaf0a095141ece1dff8c52aa72a9ac Author: Ben Stopford Date: 2015-09-02T14:09:33Z KAFKA-2453: downgrade duplicate message exception to warning --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
GitHub user benstopford reopened a pull request: https://github.com/apache/kafka/pull/158 KAFKA-2453: Enable new consumer in EndToEndLatency You can merge this pull request into a Git repository by running: $ git pull https://github.com/benstopford/kafka KAFKA-2453b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 71b11fac33a67ef9f0ac8ac09bcbb5305a56047f Author: Ben StopfordDate: 2015-08-21T16:44:48Z KAFKA-2453: migrated EndToEndLatencyTest to new consumer API. Added feature for configuring message size. Added inline assertion. commit 43d6a0678fd37d7f382d5f89c898571ae4e3cfbb Author: Ben Stopford Date: 2015-08-21T16:45:19Z KAFKA-2453: small change which prevents the ConsoleConsumer from throwing an exception when the Finalizer thread tries to close it. commit cac85029c7d802da29d68073545c118804bd41cb Author: Ben Stopford Date: 2015-08-21T17:08:29Z KAFKA-2453: Added additional arguments to call to EndToEndLatency from Performance tests commit 119a6fa545bcaf586c9cb110f0e13c1cfee1f56c Author: Ben Stopford Date: 2015-09-01T10:20:14Z KAFKA-2453: Rebased to trunk KAFKA-2453: removed whitespace KAFKA-2453: Formatting only --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
Github user benstopford closed the pull request at: https://github.com/apache/kafka/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
GitHub user benstopford reopened a pull request: https://github.com/apache/kafka/pull/158 KAFKA-2453: Enable new consumer in EndToEndLatency You can merge this pull request into a Git repository by running: $ git pull https://github.com/benstopford/kafka KAFKA-2453b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 71b11fac33a67ef9f0ac8ac09bcbb5305a56047f Author: Ben StopfordDate: 2015-08-21T16:44:48Z KAFKA-2453: migrated EndToEndLatencyTest to new consumer API. Added feature for configuring message size. Added inline assertion. commit 43d6a0678fd37d7f382d5f89c898571ae4e3cfbb Author: Ben Stopford Date: 2015-08-21T16:45:19Z KAFKA-2453: small change which prevents the ConsoleConsumer from throwing an exception when the Finalizer thread tries to close it. commit cac85029c7d802da29d68073545c118804bd41cb Author: Ben Stopford Date: 2015-08-21T17:08:29Z KAFKA-2453: Added additional arguments to call to EndToEndLatency from Performance tests commit 119a6fa545bcaf586c9cb110f0e13c1cfee1f56c Author: Ben Stopford Date: 2015-09-01T10:20:14Z KAFKA-2453: Rebased to trunk KAFKA-2453: removed whitespace KAFKA-2453: Formatting only --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
Github user benstopford closed the pull request at: https://github.com/apache/kafka/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] kafka pull request: KAFKA-2453: Enable new consumer in EndToEndLat...
GitHub user benstopford opened a pull request: https://github.com/apache/kafka/pull/158 KAFKA-2453: Enable new consumer in EndToEndLatency You can merge this pull request into a Git repository by running: $ git pull https://github.com/benstopford/kafka KAFKA-2453b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/158.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #158 commit 9088400f4a1cf0eea4a94e2ce8773ccdb23edb21 Author: Ben Stopford benstopf...@gmail.com Date: 2015-08-21T16:44:48Z KAFKA-2453: migrated EndToEndLatencyTest to new consumer API. Added feature for configuring message size. Added inline assertion. commit 614102350c1553086f7fcedb3db42e1114e0f4d7 Author: Ben Stopford benstopf...@gmail.com Date: 2015-08-21T16:45:19Z KAFKA-2453: small change which prevents the ConsoleConsumer from throwing an exception when the Finalizer thread tries to close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---