[GitHub] kafka pull request: KAFKA-2455: Test Failure: kafka.consumer.Metri...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/694


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request: KAFKA-2455: Test Failure: kafka.consumer.Metri...

[ZoneMayor]

GitHub user ZoneMayor opened a pull request:

https://github.com/apache/kafka/pull/694

KAFKA-2455: Test Failure: kafka.consumer.MetricsTest > testMetricsLeak

@guozhangwang 
I reproduced this;
Every time this test failed, I found extra "type=DelayedFetchMetrics, 
name=ExpiresperSec, fetcherType=consumer/follower" inside 
Metrics.defaultRegistry().allMetrics().keySet();
that is because for "DelayedFetch", object DelayedFetchMetrics are loaded 
dynamically in function "onExpiration";
To fix, I explicitly load this object;
Is it appropriate?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ZoneMayor/kafka trunk-KAFKA-2455

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/694.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #694


commit 34240b52e1b70aa172b65155f6042243d838b420
Author: ZoneMayor 
Date:   2015-12-18T07:22:20Z

Merge pull request #12 from apache/trunk

2015-12-18

commit 5e6284e034fc8e92745f1ebdda2fa228b8beaf4f
Author: jinxing 
Date:   2015-12-18T11:17:17Z

KAFKA-2455: Test Failure: kafka.consumer.MetricsTest > testMetricsLeak




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---