[GitHub] kafka pull request: Kafka 1595 remove deprecated json parser

2015-04-26 Thread ijuma
Github user ijuma closed the pull request at:

https://github.com/apache/kafka/pull/55


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request: Kafka 1595 remove deprecated json parser

2015-04-20 Thread ijuma
GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/55

Kafka 1595 remove deprecated json parser



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
kafka-1595-remove-deprecated-json-parser

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #55


commit 31ac16dbd9d657fbb9a8a63153361ec543aabb7b
Author: Ismael Juma ism...@juma.me.uk
Date:   2015-04-17T23:26:28Z

Drop support for Scala 2.9.1 and 2.9.2

Use the same `scalatest` version for all Scala
versions and remove unused code.

commit ab71458018dc2c5b05a981da1a73aea08a0163cd
Author: Ismael Juma ism...@juma.me.uk
Date:   2015-04-20T20:53:54Z

Introduce `testJsonParse`

Simple test that shows existing behaviour.

commit bda759a01cf244d0786830a7e9540b2e84a620c2
Author: Ismael Juma ism...@juma.me.uk
Date:   2015-04-21T00:15:02Z

KAFKA-1595; Remove deprecated and slower scala JSON parser from 
kafka.consumer.TopicCount

A combination of spray-json's AST combined with jawn's parser are used as 
the replacement.
Note that both libraries have no dependencies and are relatively simple. We 
use `jawn` for
its performance, but it could be dropped by changing one line in 
`Json.parseFull`.

An attempt has been made to maintain the existing behaviour regarding when 
exceptions
are thrown. There are a number of cases where `DeserializationException` 
will be thrown
instead of `ClassCastException`, however. It is expected that users would 
not try to catch
`ClassCastException`.

commit d1adee404e6d9a7f7b07da4d7ab2ed8e2087ccdf
Author: Ismael Juma ism...@juma.me.uk
Date:   2015-04-21T00:23:39Z

Minor clean-ups in `Json.encode`




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---