[GitHub] kafka pull request #2901: KAFKA-5018: LogCleaner tests to verify behaviour o...

[original-brownbear]

Github user original-brownbear closed the pull request at:

https://github.com/apache/kafka/pull/2901


---

[GitHub] kafka pull request #2901: KAFKA-5018: LogCleaner tests to verify behaviour o...

[original-brownbear]

GitHub user original-brownbear opened a pull request:

https://github.com/apache/kafka/pull/2901

KAFKA-5018: LogCleaner tests to verify behaviour of message format v2

For https://issues.apache.org/jira/browse/KAFKA-5018:

* Added test for `baseOffset` behaviour after compaction
  * Added helper method for writing a multi-record batch
* Dried up handling of `LogConfig.SegmentIndexBytesProp` and added comments 
on the chosen magic values

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/original-brownbear/kafka KAFKA-5018

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2901.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2901


commit 9a036b934feec7c81ca34b49dfd58df680a2bb97
Author: Armin Braun 
Date:   2017-04-23T13:45:11Z

KAFKA-5018: LogCleaner tests to verify behaviour of message format v2

commit 959b5193e11ab87ca8a17eaff594408a57f44204
Author: Armin Braun 
Date:   2017-04-23T20:20:18Z

KAFKA-5018: LogCleaner tests to verify behaviour of message format v2




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---